180697 2017-12-12 09:03:46 -0800 Make ServiceWorkers follow the DEFAULT_EXPERIMENTAL_FEATURES_ENABLED flag on Mac 2017-12-12 15:11:40 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180700 InRadar P2 Normal --- 1 youennf youennf beidson cdumez commit-queue ggaren jlewis3 webkit-bug-importer oldest_to_newest 1380671 0 youennf 2017-12-12 09:03:46 -0800 As a first step towards activating service worker everywhere, make Service Worker experimental flag on by default. 1380672 1 329115 youennf 2017-12-12 09:04:26 -0800 Created attachment 329115 Patch 1380677 2 329115 cdumez 2017-12-12 09:11:26 -0800 Comment on attachment 329115 Patch I am unclear if this enables the feature on iOS or not. I think we'd want to hold off on iOS a bit until we do some basic testing. 1380684 3 beidson 2017-12-12 09:28:45 -0800 (In reply to Chris Dumez from comment #2) > Comment on attachment 329115 [details] > Patch > > I am unclear if this enables the feature on iOS or not. I think we'd want to > hold off on iOS a bit until we do some basic testing. Right. That's the reason why I hadn't done this yet (e.g resolve the radar) because I'm waiting on input on how to use the yaml to be Mac only. 1380685 4 329115 beidson 2017-12-12 09:29:05 -0800 Comment on attachment 329115 Patch Gotta do this differently 1380688 5 beidson 2017-12-12 09:29:43 -0800 *** Bug 180700 has been marked as a duplicate of this bug. *** 1380690 6 329118 beidson 2017-12-12 09:48:47 -0800 Created attachment 329118 Patch 1380691 7 329118 cdumez 2017-12-12 09:50:24 -0800 Comment on attachment 329118 Patch r=me assuming iOS EWS is happy. 1380704 8 beidson 2017-12-12 10:16:57 -0800 It's no good, but I have a good fix. 1380706 9 329123 beidson 2017-12-12 10:23:37 -0800 Created attachment 329123 Patch 1380714 10 329123 commit-queue 2017-12-12 10:48:17 -0800 Comment on attachment 329123 Patch Clearing flags on attachment: 329123 Committed r225789: <https://trac.webkit.org/changeset/225789> 1380715 11 commit-queue 2017-12-12 10:48:19 -0800 All reviewed patches have been landed. Closing bug. 1380717 12 beidson 2017-12-12 10:53:21 -0800 <rdar://problem/35978311> 1380828 13 jlewis3 2017-12-12 14:04:43 -0800 This caused multiple API failures on all macOS platforms: https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/6953/steps/run-api-tests/logs/stdio Build: https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/6953/steps/run-api-tests/logs/stdio The failing tests: WKProcessPool.InitialWarmedProcessUsed Failure: FAIL WKProcessPool.InitialWarmedProcessUsed /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:51 Value of: static_cast<size_t>(1) Actual: 1 Expected: [pool _webProcessCount] Which is: 2 WebKit.WebsiteDataStoreCustomPaths FAIL WebKit.WebsiteDataStoreCustomPaths /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:219 Value of: [WKWebsiteDataStore _defaultDataStoreExists] Actual: true Expected: false The test passed before this patch and now fail consistently 1380879 14 jlewis3 2017-12-12 15:11:40 -0800 New bug for the failures and the fix: https://bugs.webkit.org/show_bug.cgi?id=180722 329115 2017-12-12 09:04:26 -0800 2017-12-12 09:48:46 -0800 Patch bug-180697-20171212090426.patch text/plain 1224 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NzUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiYjNlZDc0MGE5MjljZmVm ZWE2MWExODgxZjg4NTgwNTllYjQ0MzMuLjU5Yjk5MTk1YjllNTlhMGQzNDFlNDNlOTE0ZGY5ZjRh MjFlMzM2ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMTItMTIgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgU2VydmljZSBXb3JrZXIg ZXhwZXJpbWVudGFsIGZsYWcgb24gYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbDoKKwog MjAxNy0xMi0xMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAg ICAgICBbV1RGXSBBZGQgQ29udmVydGVyIHRyYWl0cyB0byBTdHJpbmdIYXNoZXIgaW5zdGVhZCBv ZiBmdW5jdGlvbiBwb2ludGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQ cmVmZXJlbmNlcy55YW1sIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFt bAppbmRleCBiNGU3OGVkYzIzNTNiNmFjZmY4YTk4NWFkNzcwMjYzNjVhZjFiNmE3Li44MjBiNWVj NmQxODI5ZWNlMGFhYTEwOGFhMTc4OGJkMTQ3NjczMmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVk L1dlYlByZWZlcmVuY2VzLnlhbWwKQEAgLTExMTIsNyArMTExMiw3IEBAIElzU2VjdXJlQ29udGV4 dEF0dHJpYnV0ZUVuYWJsZWQ6CiAKIFNlcnZpY2VXb3JrZXJzRW5hYmxlZDoKICAgdHlwZTogYm9v bAotICBkZWZhdWx0VmFsdWU6IGZhbHNlCisgIGRlZmF1bHRWYWx1ZTogREVGQVVMVF9FWFBFUklN RU5UQUxfRkVBVFVSRVNfRU5BQkxFRAogICBodW1hblJlYWRhYmxlTmFtZTogIlNlcnZpY2VXb3Jr ZXJzIgogICBodW1hblJlYWRhYmxlRGVzY3JpcHRpb246ICJFbmFibGUgU2VydmljZVdvcmtlcnMi CiAgIGNhdGVnb3J5OiBleHBlcmltZW50YWwK 329118 2017-12-12 09:48:47 -0800 2017-12-12 10:23:36 -0800 Patch bug-180697-20171212094847.patch text/plain 1700 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRmMDU4Nzg5ZmUyNGY5ODM1 OGYwN2RjOTY1MmE3OWMyODQ2NGQ1N2UuLjhhMWM3YTU3NTU3MWFkZWY3ODhmYTFmMjViM2Q2MGYz MTk2MTg4NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMTItMTIgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgU2VydmljZVdvcmtlcnMg Zm9sbG93IHRoZSBERUZBVUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVEIGZsYWcgb24g TWFjLgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU5NzgzMTE+IGFuZCBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbDog Rm9sbG93IERFRkFVTFRfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTX0VOQUJMRUQgb24gTWFjLgorICAg ICAgICAgIE5vdGUgdGhhdCBob3cgd2UgaGFkIHRvIGRvIHRoaXMgbWVhbnMgdGhlIGV4cGVyaW1l bnRhbCBmZWF0dXJlIGlzbid0IGV2ZW4gZXhwb3NlZAorICAgICAgICAgIG9uIGlPUyBhbnltb3Jl LCBzbyBpdCBkZWZhdWx0cyB0byBvZmYuIFdlJ2xsIHJlc29sdmUgdGhpcyBsYXRlci4KKwogMjAx Ny0xMi0xMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAg ICBbV1RGXSBUaHJlYWQ6OmNyZWF0ZSBzaG91bGQgaGF2ZSBUaHJlYWQ6OnRyeUNyZWF0ZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbCBiL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKaW5kZXggYjRlNzhlZGMyMzUzYjZh Y2ZmOGE5ODVhZDc3MDI2MzY1YWYxYjZhNy4uNGZkOWJiMmYxYTdmODhjYWI2OTg5OGE2NjA1ZDE3 MGM3YzRiNDc3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5j ZXMueWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCkBA IC0xMTEyLDEzICsxMTEyLDEzIEBAIElzU2VjdXJlQ29udGV4dEF0dHJpYnV0ZUVuYWJsZWQ6CiAK IFNlcnZpY2VXb3JrZXJzRW5hYmxlZDoKICAgdHlwZTogYm9vbAotICBkZWZhdWx0VmFsdWU6IGZh bHNlCisgIGRlZmF1bHRWYWx1ZTogREVGQVVMVF9FWFBFUklNRU5UQUxfRkVBVFVSRVNfRU5BQkxF RAogICBodW1hblJlYWRhYmxlTmFtZTogIlNlcnZpY2VXb3JrZXJzIgogICBodW1hblJlYWRhYmxl RGVzY3JpcHRpb246ICJFbmFibGUgU2VydmljZVdvcmtlcnMiCiAgIGNhdGVnb3J5OiBleHBlcmlt ZW50YWwKICAgd2ViY29yZUJpbmRpbmc6IFJ1bnRpbWVFbmFibGVkRmVhdHVyZXMKICAgd2ViY29y ZU5hbWU6IHNlcnZpY2VXb3JrZXJFbmFibGVkCi0gIGNvbmRpdGlvbjogRU5BQkxFKFNFUlZJQ0Vf V09SS0VSKQorICBjb25kaXRpb246IEVOQUJMRShTRVJWSUNFX1dPUktFUikgJiYgUExBVEZPUk0o TUFDKQogCiBTdG9yYWdlQWNjZXNzQVBJRW5hYmxlZDoKICAgdHlwZTogYm9vbAo= 329123 2017-12-12 10:23:37 -0800 2017-12-12 10:48:17 -0800 Patch bug-180697-20171212102336.patch text/plain 1884 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRmMDU4Nzg5ZmUyNGY5ODM1 OGYwN2RjOTY1MmE3OWMyODQ2NGQ1N2UuLjgyMmRlYmE2M2U2MWY0YmM5YjU4NWI4ZmExMGQ3Njdj ZjVhZDU3YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTItMTIgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgU2VydmljZVdvcmtlcnMg Zm9sbG93IHRoZSBERUZBVUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVEIGZsYWcgb24g TWFjLgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU5NzgzMTE+IGFuZCBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbDoK KyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmg6CisKIDIwMTct MTItMTIgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAg W1dURl0gVGhyZWFkOjpjcmVhdGUgc2hvdWxkIGhhdmUgVGhyZWFkOjp0cnlDcmVhdGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwgYi9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCmluZGV4IGI0ZTc4ZWRjMjM1M2I2YWNm ZjhhOTg1YWQ3NzAyNjM2NWFmMWI2YTcuLjFmNGI5ZDk1NWRhY2ZhNThhYjM3MmNmZjc2MDU0Mzc5 ZThiNjM3OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2Vz LnlhbWwKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbApAQCAt MTExMiw3ICsxMTEyLDcgQEAgSXNTZWN1cmVDb250ZXh0QXR0cmlidXRlRW5hYmxlZDoKIAogU2Vy dmljZVdvcmtlcnNFbmFibGVkOgogICB0eXBlOiBib29sCi0gIGRlZmF1bHRWYWx1ZTogZmFsc2UK KyAgZGVmYXVsdFZhbHVlOiBERUZBVUxUX1NFUlZJQ0VfV09SS0VSU19FTkFCTEVECiAgIGh1bWFu UmVhZGFibGVOYW1lOiAiU2VydmljZVdvcmtlcnMiCiAgIGh1bWFuUmVhZGFibGVEZXNjcmlwdGlv bjogIkVuYWJsZSBTZXJ2aWNlV29ya2VycyIKICAgY2F0ZWdvcnk6IGV4cGVyaW1lbnRhbApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVz LmggYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaApp bmRleCA0N2JmZmI2ZTQxNDFlZWEzODJhYmEyM2Y1ZDRhZDQ5NjNhY2U4MWI2Li4xMDNjZDU2Yzdi ZDk4YjgwNzc1YjBjMjM0Mzg0MDVhMDYzZmZhNmVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaApAQCAtMTc4LDMgKzE3OCw5IEBA CiAjZWxzZQogI2RlZmluZSBERUZBVUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVEIGZh bHNlCiAjZW5kaWYKKworI2lmIEVOQUJMRShFWFBFUklNRU5UQUxfRkVBVFVSRVMpIHx8IFBMQVRG T1JNKE1BQykKKyNkZWZpbmUgREVGQVVMVF9TRVJWSUNFX1dPUktFUlNfRU5BQkxFRCB0cnVlCisj ZWxzZQorI2RlZmluZSBERUZBVUxUX1NFUlZJQ0VfV09SS0VSU19FTkFCTEVEIGZhbHNlCisjZW5k aWYK