180691 2017-12-11 23:39:18 -0800 Symbol not found: __ZN3WTF8LockBase10unlockSlowEv 2017-12-12 12:33:13 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180495 InRadar P2 Normal --- 1 hi webkit-unassigned benjamin cdumez cmarcelo dbates ews-watchlist joepeck mitz webkit-bug-importer ysuzuki oldest_to_newest 1380592 0 hi 2017-12-11 23:39:18 -0800 I just tried running my local build via `Tools/Scripts/run-safari --release` and got this error: Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in WebKitBuild/Release. dyld: Symbol not found: __ZN3WTF8LockBase10unlockSlowEv Referenced from: /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari Expected in: WebKitBuild/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore in /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari I'm guessing that this is related to <https://webkit.org/b/180495>, as it removed LockBase. * Info: ProductName: Mac OS X ProductVersion: 10.13.2 BuildVersion: 17C88 1380593 1 joepeck 2017-12-12 00:00:55 -0800 Looks like system macOS 10.13.2 Safari needs this symbol: $ c++filt __ZN3WTF8LockBase10unlockSlowEv WTF::LockBase::unlockSlow() Typically we add back something like this into: WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm I don't know the full list of symbols we need to add back. Probably a few of these, which just moved from WTF::LockBase to WTF::Lock. WTF_EXPORT_PRIVATE void lockSlow(); WTF_EXPORT_PRIVATE void unlockSlow(); WTF_EXPORT_PRIVATE void unlockFairlySlow(); WTF_EXPORT_PRIVATE void safepointSlow(); 1380598 2 329096 joepeck 2017-12-12 00:35:43 -0800 Created attachment 329096 [PATCH] Proposed Fix 1380599 3 329096 joepeck 2017-12-12 00:37:47 -0800 Comment on attachment 329096 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=329096&action=review > Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:132 > +#if PLATFORM(MAC) Not sure if it is worth adding a restriction here, such as: && __MAC_OS_X_VERSION_MIN_REQUIRED < 101340 But reviewers let me know if you think that would be worth doing. 1380609 4 329096 ysuzuki 2017-12-12 02:24:38 -0800 Comment on attachment 329096 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=329096&action=review >> Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:132 >> +#if PLATFORM(MAC) > > Not sure if it is worth adding a restriction here, such as: > > && __MAC_OS_X_VERSION_MIN_REQUIRED < 101340 > > But reviewers let me know if you think that would be worth doing. I think this restriction is useful since it can be a marker for dropping this in the future. Adding `FIXME` comment is also nice. 1380739 5 joepeck 2017-12-12 11:19:50 -0800 <https://trac.webkit.org/r225792> 1380774 6 webkit-bug-importer 2017-12-12 12:33:13 -0800 <rdar://problem/36001432> 329096 2017-12-12 00:35:43 -0800 2017-12-12 11:19:56 -0800 [PATCH] Proposed Fix safari-1.patch text/plain 1458 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMTg4MGQ4NjZjYjQuLmVkZTYyZWE5MjIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3 LTEyLTEyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAg U3ltYm9sIG5vdCBmb3VuZDogX19aTjNXVEY4TG9ja0Jhc2UxMHVubG9ja1Nsb3dFdgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNjkxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvbWFjL0RlcHJl Y2F0ZWRTeW1ib2xzVXNlZEJ5U2FmYXJpLm1tOgorICAgICAgICAoV1RGOjpMb2NrQmFzZTo6bG9j a1Nsb3cpOgorICAgICAgICAoV1RGOjpMb2NrQmFzZTo6dW5sb2NrU2xvdyk6CisgICAgICAgIEFk ZCBiYWNrIExvY2tCYXNlIFN5bWJvbHMgdXNlZCBieSBTeXN0ZW0gU2FmYXJpIG9uIDEwLjEzLgor CiAyMDE3LTEyLTExICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IE9wdGlvbmFsbHkgbG9nIFdlYktpdCBsb2cgcGFyYW1ldGVy cyBhcyBKU09OCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9tYWMvRGVwcmVjYXRlZFN5bWJv bHNVc2VkQnlTYWZhcmkubW0gYi9Tb3VyY2UvV1RGL3d0Zi9tYWMvRGVwcmVjYXRlZFN5bWJvbHNV c2VkQnlTYWZhcmkubW0KaW5kZXggY2Y1NzhmYjQzYjIuLjYwNzI5YmZmNThjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9tYWMvRGVwcmVjYXRlZFN5bWJvbHNVc2VkQnlTYWZhcmkubW0KKysr IGIvU291cmNlL1dURi93dGYvbWFjL0RlcHJlY2F0ZWRTeW1ib2xzVXNlZEJ5U2FmYXJpLm1tCkBA IC0xMjksNCArMTI5LDIzIEBAIHZvaWQgY2FuY2VsQ2FsbE9uTWFpblRocmVhZCh2b2lkICgqZnVu Y3Rpb24pKHZvaWQqKSwgdm9pZCogY29udGV4dCkKIH0KICNlbmRpZgogCisjaWYgUExBVEZPUk0o TUFDKQorc3RydWN0IExvY2tCYXNlIHsKK3ByaXZhdGU6CisgICAgV1RGX0VYUE9SVF9QUklWQVRF IHZvaWQgbG9ja1Nsb3coKTsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCB1bmxvY2tTbG93 KCk7CisgICAgQXRvbWljPHVpbnQ4X3Q+IG1fYnl0ZTsKK307CisKK3ZvaWQgTG9ja0Jhc2U6Omxv Y2tTbG93KCkKK3sKKyAgICBEZWZhdWx0TG9ja0FsZ29yaXRobTo6bG9ja1Nsb3cobV9ieXRlKTsK K30KKwordm9pZCBMb2NrQmFzZTo6dW5sb2NrU2xvdygpCit7CisgICAgRGVmYXVsdExvY2tBbGdv cml0aG06OnVubG9ja1Nsb3cobV9ieXRlLCBEZWZhdWx0TG9ja0FsZ29yaXRobTo6VW5mYWlyKTsK K30KKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXVEYK