180644 2017-12-11 06:04:06 -0800 [JSC] Optimize Object.assign by single transition acceleration 2018-05-05 06:19:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 185350 1 ysuzuki ysuzuki fpizlo jfbastien keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1380174 0 ysuzuki 2017-12-11 06:04:06 -0800 [JSC] Optimize Object.assign by single transition acceleration and reify shortcut 1380175 1 328962 ysuzuki 2017-12-11 06:07:05 -0800 Created attachment 328962 Patch 1380311 2 328962 saam 2017-12-11 11:34:07 -0800 Comment on attachment 328962 Patch I’m r- because I don’t want to add more code for this reification method table. I’ve already spoken to JF and other folks offline about removing this call from this code path. I think the right answer is to either: - Call defineOwnProperty for static getter/setters on classes. We can probably keep calling putDirect when defining it on an object literal since plain objects don’t have lazy properties. - move this reification call into define_getter_setter_by_id 1380998 3 ysuzuki 2017-12-12 18:11:43 -0800 (In reply to Saam Barati from comment #2) > Comment on attachment 328962 [details] > Patch > > I’m r- because I don’t want to add more code for this reification method > table. I’ve already spoken to JF and other folks offline about removing this > call from this code path. I think the right answer is to either: > - Call defineOwnProperty for static getter/setters on classes. We can > probably keep calling putDirect when defining it on an object literal since > plain objects don’t have lazy properties. > - move this reification call into define_getter_setter_by_id Hm, ok, I'll drop this part from my patch. Yeah, this reification method is called in putDirect path, so everytime we put non-indexed property, this function is called. We should remove or alleviate this. 1381066 4 329210 ysuzuki 2017-12-12 23:44:12 -0800 Created attachment 329210 Patch 1381068 5 ysuzuki 2017-12-12 23:51:22 -0800 Committed r225840: <https://trac.webkit.org/changeset/225840> 1381069 6 webkit-bug-importer 2017-12-12 23:52:15 -0800 <rdar://problem/36015370> 328962 2017-12-11 06:07:05 -0800 2017-12-12 23:44:10 -0800 Patch bug-180644-20171211230704.patch text/plain 3542 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MGM2MmFkY2E2ZmI3YjA5YmZmNWMyMTY0NzQyYWUzYTdiMTM5NTNhLi42ODljMTgxM2JiNjhjNTBi MWZiYTkyZWYwNDk2M2ExNTdhNDEyN2IzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNy0xMi0xMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBPcHRpbWl6ZSBPYmplY3QuYXNzaWduIGJ5IHNpbmdsZSB0 cmFuc2l0aW9uIGFjY2VsZXJhdGlvbiBhbmQgcmVpZnkgc2hvcnRjdXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDY0NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxvd2luZyAyIG9wdGltaXphdGlv biBpbXByb3ZlcyBTaXhTcGVlZC9vYmplY3QtYXNzaWduLmVzNiBieSA0LjclLgorCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmFzZWxpbmUgICAgICAgICAgICAgICAg ICBwYXRjaGVkCisKKyAgICAgICAgICAgIG9iamVjdC1hc3NpZ24uZXM2ICAgICAgMzkwLjkzNjcr LTEyLjcyODAgICAgXiAgICAzNzMuMjkzNCstNC44ODQzICAgICAgICBeIGRlZmluaXRlbHkgMS4w NDczeCBmYXN0ZXIKKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3RJbmxpbmVzLmg6CisgICAg ICAgIChKU0M6OkpTT2JqZWN0OjpwdXREaXJlY3RJbnRlcm5hbCk6CisgICAgICAgIFJlaWZ5aW5n IGlzIG5vdCB1c2VkIGZvciBwbGFpbiBvYmplY3QuV2UgY2FuIHNraXAgaWYgbWV0aG9kIHRhYmxl J3MgcG9pbnRlciBpcworICAgICAgICBwb2ludGluZyB0byBKU0NlbGw6OnJlaWZ5UHJvcGVydHlO YW1lSWZOZWVkZWQuCisKKyAgICAgICAgKiBydW50aW1lL1N0cnVjdHVyZS5jcHA6CisgICAgICAg IChKU0M6OlN0cnVjdHVyZVRyYW5zaXRpb25UYWJsZTo6Z2V0IGNvbnN0KToKKyAgICAgICAgSGFu ZGxpbmcgc2luZ2xlIHRyYW5zaXRpb24gaXMgY3JpdGljYWwuIFNpbmNlIHRoaXMgZ2V0KCkgZnVu Y3Rpb24gaXMgb25seSB1c2VkCisgICAgICAgIGluIFN0cnVjdHVyZS5jcHAncyAyIGZ1bmN0aW9u cyBhbmQgaXQgaXMgcXVpdGUgc21hbGwsIHdlIGNhbiBhbm5vdGF0ZSBgaW5saW5lYAorICAgICAg ICB0byBhY2NlbGVyYXRlIGl0LgorCiAyMDE3LTEyLTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgSGFyZGVuIGEgZmV3IGFzc2VydGlvbnMgaW4gR0Mgc3dlZXAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0SW5saW5l cy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3RJbmxpbmVzLmgKaW5k ZXggMjljYjk0MWJmMGUyODRmNzdhMzZhMTI5OTBmN2M2MmUxZWU3MTRiYS4uMmJkMDIzMmJkNjU1 ZmQ2YjAxZWQyMGZhNTA2ZmI2ZjllNDg3MTc4YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNPYmplY3RJbmxpbmVzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNPYmplY3RJbmxpbmVzLmgKQEAgLTI2MCwxMCArMjYwLDEzIEBAIEFMV0FZ U19JTkxJTkUgYm9vbCBKU09iamVjdDo6cHV0RGlyZWN0SW50ZXJuYWwoVk0mIHZtLCBQcm9wZXJ0 eU5hbWUgcHJvcGVydHlOYW1lCiAgICAgQVNTRVJUKCFIZWFwOjpoZWFwKHZhbHVlKSB8fCBIZWFw OjpoZWFwKHZhbHVlKSA9PSBIZWFwOjpoZWFwKHRoaXMpKTsKICAgICBBU1NFUlQoIXBhcnNlSW5k ZXgocHJvcGVydHlOYW1lKSk7CiAKLSAgICBzd2l0Y2ggKG1ldGhvZFRhYmxlKHZtKS0+cmVpZnlQ cm9wZXJ0eU5hbWVJZk5lZWRlZCh0aGlzLCBnbG9iYWxPYmplY3Qodm0pLT5nbG9iYWxFeGVjKCks IHByb3BlcnR5TmFtZSkpIHsKLSAgICBjYXNlIFByb3BlcnR5UmVpZmljYXRpb25SZXN1bHQ6Ok5v dGhpbmc6IGJyZWFrOwotICAgIGNhc2UgUHJvcGVydHlSZWlmaWNhdGlvblJlc3VsdDo6U29tZXRo aW5nOiBicmVhazsKLSAgICBjYXNlIFByb3BlcnR5UmVpZmljYXRpb25SZXN1bHQ6OlRyaWVkQnV0 RmFpbGVkOiBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIGF1dG8gcmVpZnlQcm9w ZXJ0eU5hbWVJZk5lZWRlZCA9IG1ldGhvZFRhYmxlKHZtKS0+cmVpZnlQcm9wZXJ0eU5hbWVJZk5l ZWRlZDsKKyAgICBpZiAoVU5MSUtFTFkocmVpZnlQcm9wZXJ0eU5hbWVJZk5lZWRlZCAhPSBKU0Nl bGw6OnJlaWZ5UHJvcGVydHlOYW1lSWZOZWVkZWQpKSB7CisgICAgICAgIHN3aXRjaCAocmVpZnlQ cm9wZXJ0eU5hbWVJZk5lZWRlZCh0aGlzLCBnbG9iYWxPYmplY3Qodm0pLT5nbG9iYWxFeGVjKCks IHByb3BlcnR5TmFtZSkpIHsKKyAgICAgICAgY2FzZSBQcm9wZXJ0eVJlaWZpY2F0aW9uUmVzdWx0 OjpOb3RoaW5nOiBicmVhazsKKyAgICAgICAgY2FzZSBQcm9wZXJ0eVJlaWZpY2F0aW9uUmVzdWx0 OjpTb21ldGhpbmc6IGJyZWFrOworICAgICAgICBjYXNlIFByb3BlcnR5UmVpZmljYXRpb25SZXN1 bHQ6OlRyaWVkQnV0RmFpbGVkOiBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAg ICB9CiAgICAgfQogCiAgICAgU3RydWN0dXJlSUQgc3RydWN0dXJlSUQgPSB0aGlzLT5zdHJ1Y3R1 cmVJRCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0 dXJlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAKaW5k ZXggYjNjZTAyOTFiOGRiZTgzNDkzYTEyM2UzOTI3NGNlZGQ1N2U2MThjYi4uNGI2MGE4NTYyMGM2 MGI4ZWM3NjU3MWJhMDU5ODczMDYyNzU1ZTQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9TdHJ1Y3R1cmUuY3BwCkBAIC05OCw3ICs5OCw3IEBAIGJvb2wgU3RydWN0dXJlVHJh bnNpdGlvblRhYmxlOjpjb250YWlucyhVbmlxdWVkU3RyaW5nSW1wbCogcmVwLCB1bnNpZ25lZCBh dHRyaWJ1CiAgICAgcmV0dXJuIG1hcCgpLT5nZXQoc3RkOjptYWtlX3BhaXIocmVwLCBhdHRyaWJ1 dGVzKSk7CiB9CiAKLVN0cnVjdHVyZSogU3RydWN0dXJlVHJhbnNpdGlvblRhYmxlOjpnZXQoVW5p cXVlZFN0cmluZ0ltcGwqIHJlcCwgdW5zaWduZWQgYXR0cmlidXRlcykgY29uc3QKK2lubGluZSBT dHJ1Y3R1cmUqIFN0cnVjdHVyZVRyYW5zaXRpb25UYWJsZTo6Z2V0KFVuaXF1ZWRTdHJpbmdJbXBs KiByZXAsIHVuc2lnbmVkIGF0dHJpYnV0ZXMpIGNvbnN0CiB7CiAgICAgaWYgKGlzVXNpbmdTaW5n bGVTbG90KCkpIHsKICAgICAgICAgU3RydWN0dXJlKiB0cmFuc2l0aW9uID0gc2luZ2xlVHJhbnNp dGlvbigpOwo= 329210 2017-12-12 23:44:12 -0800 2017-12-12 23:45:33 -0800 Patch bug-180644-20171213164411.patch text/plain 1928 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1ODM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm N2MzZWJmYzA0ODYzZTIwYTdlODM5YzRkYmMxZDE5MWJhMzM4N2Y3Li4xZmZkOTg2N2ZkOTA4MGRl MDg1NDg4MTQ1NzFkZDc1N2UyOTIyNGEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNy0xMi0xMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBPcHRpbWl6ZSBPYmplY3QuYXNzaWduIGJ5IHNpbmdsZSB0 cmFuc2l0aW9uIGFjY2VsZXJhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgwNjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSGFuZGxpbmcgc2luZ2xlIHRyYW5zaXRpb24gaXMgY3JpdGljYWwuIFNp bmNlIHRoaXMgZ2V0KCkgZnVuY3Rpb24gaXMgb25seSB1c2VkCisgICAgICAgIGluIFN0cnVjdHVy ZS5jcHAncyAyIGZ1bmN0aW9ucyBhbmQgaXQgaXMgcXVpdGUgc21hbGwsIHdlIGNhbiBhbm5vdGF0 ZSBgaW5saW5lYAorICAgICAgICB0byBhY2NlbGVyYXRlIGl0LgorCisgICAgICAgIFRoaXMgaW1w cm92ZXMgU2l4U3BlZWQvb2JqZWN0LWFzc2lnbi5lczYgYnkgMi44JS4KKworICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgYmFzZWxpbmUgICAgICAgICAgICAgICAgICBwYXRjaGVk CisKKyAgICAgICAgb2JqZWN0LWFzc2lnbi5lczYgICAgICAzODIuMzU0OCstOC4wNDYxICAgICAg ICAgIDM3MS42NDk2Ky01Ljc0MzkgICAgICAgICAgbWlnaHQgYmUgMS4wMjg4eCBmYXN0ZXIKKwor ICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlLmNwcDoKKyAgICAgICAgKEpTQzo6U3RydWN0dXJl VHJhbnNpdGlvblRhYmxlOjpnZXQgY29uc3QpOgorCiAyMDE3LTEyLTEyICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgU3RydWN0dXJlLCBTdHJ1Y3R1cmVSYXJlRGF0 YSwgYW5kIFByb3BlcnR5VGFibGUgc2hvdWxkIGJlIGluIElzb1N1YnNwYWNlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAKaW5kZXggN2Q0NWM0OWM5ZGQyYzgx OTVlMGU4NjAwNDUzYzM4ZGJjOWMwNWNiNi4uMGE4NTcyYWM1MjhmZjIwMDA1ZGQ5MGIxODEyNTcw MGY1NWIwNGExNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3Ry dWN0dXJlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUu Y3BwCkBAIC05OSw3ICs5OSw3IEBAIGJvb2wgU3RydWN0dXJlVHJhbnNpdGlvblRhYmxlOjpjb250 YWlucyhVbmlxdWVkU3RyaW5nSW1wbCogcmVwLCB1bnNpZ25lZCBhdHRyaWJ1CiAgICAgcmV0dXJu IG1hcCgpLT5nZXQoc3RkOjptYWtlX3BhaXIocmVwLCBhdHRyaWJ1dGVzKSk7CiB9CiAKLVN0cnVj dHVyZSogU3RydWN0dXJlVHJhbnNpdGlvblRhYmxlOjpnZXQoVW5pcXVlZFN0cmluZ0ltcGwqIHJl cCwgdW5zaWduZWQgYXR0cmlidXRlcykgY29uc3QKK2lubGluZSBTdHJ1Y3R1cmUqIFN0cnVjdHVy ZVRyYW5zaXRpb25UYWJsZTo6Z2V0KFVuaXF1ZWRTdHJpbmdJbXBsKiByZXAsIHVuc2lnbmVkIGF0 dHJpYnV0ZXMpIGNvbnN0CiB7CiAgICAgaWYgKGlzVXNpbmdTaW5nbGVTbG90KCkpIHsKICAgICAg ICAgU3RydWN0dXJlKiB0cmFuc2l0aW9uID0gc2luZ2xlVHJhbnNpdGlvbigpOwo=