180624 2017-12-09 12:26:13 -0800 [WTF] Remove RELAXED_CONSTEXPR 2017-12-09 13:43:36 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki benjamin cdumez cmarcelo commit-queue dbates ews-watchlist jfbastien webkit-bug-importer oldest_to_newest 1379992 0 ysuzuki 2017-12-09 12:26:13 -0800 [WTF] Remove RELAXED_CONSTEXPR 1379993 1 328913 ysuzuki 2017-12-09 12:27:42 -0800 Created attachment 328913 Patch 1379994 2 ysuzuki 2017-12-09 12:28:28 -0800 I believe it works in VC++ 2017. Watching on EWS. 1379995 3 ews-watchlist 2017-12-09 12:29:34 -0800 Attachment 328913 did not pass style-queue: ERROR: Source/WTF/wtf/Expected.h:485: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:491: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:494: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:554: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1380001 4 328913 jfbastien 2017-12-09 13:00:23 -0800 Comment on attachment 328913 Patch 🎉 =me r=me 1380002 5 328913 ysuzuki 2017-12-09 13:21:53 -0800 Comment on attachment 328913 Patch Yay, EWS becomes green. I'll land this :) 1380005 6 328913 commit-queue 2017-12-09 13:42:06 -0800 Comment on attachment 328913 Patch Clearing flags on attachment: 328913 Committed r225728: <https://trac.webkit.org/changeset/225728> 1380006 7 commit-queue 2017-12-09 13:42:07 -0800 All reviewed patches have been landed. Closing bug. 1380007 8 webkit-bug-importer 2017-12-09 13:43:36 -0800 <rdar://problem/35953465> 328913 2017-12-09 12:27:42 -0800 2017-12-09 13:42:06 -0800 Patch bug-180624-20171210052741.patch text/plain 6503 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDM0ZWE3NDhlYTA5NjNhYzIyODk5Njk4 ODA3NjdmY2UyODJkMDdjNzcuLjI3NTE3ZmNjNWJmNjMxYTQxZTBiZGVjNzhkN2Y1ODRjZjM3M2Qz NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMTctMTItMDkgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CiAKKyAgICAgICAgW1dURl0gUmVtb3ZlIFJFTEFYRURfQ09OU1RF WFBSCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA2 MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGwg b2Ygb3VyIHJlcXVpcmVkIGNvbXBpbGVycyBzdXBwb3J0IHJlbGF4ZWQgY29uc3RleHByIGluIEMr KzE0LgorICAgICAgICBXZSBjYW4gZHJvcCBSRUxBWEVEX0NPTlNURVhQUiBtYWNybyBpbiBvdXIg dHJlZS4KKworICAgICAgICAqIHd0Zi9Db21waWxlci5oOgorICAgICAgICAqIHd0Zi9FeHBlY3Rl ZC5oOgorICAgICAgICAoc3RkOjpleHBlcmltZW50YWw6OmZ1bmRhbWVudGFsc192Mzo6ZXhwZWN0 ZWQ6Om9wZXJhdG9yKik6CisgICAgICAgIChzdGQ6OmV4cGVyaW1lbnRhbDo6ZnVuZGFtZW50YWxz X3YzOjpleHBlY3RlZDo6dmFsdWUpOgorICAgICAgICAoc3RkOjpleHBlcmltZW50YWw6OmZ1bmRh bWVudGFsc192Mzo6ZXhwZWN0ZWQ6OmVycm9yKToKKyAgICAgICAgKiB3dGYvVW5leHBlY3RlZC5o OgorICAgICAgICAoc3RkOjpleHBlcmltZW50YWw6OmZ1bmRhbWVudGFsc192Mzo6dW5leHBlY3Rl ZDo6dmFsdWUpOgorICAgICAgICAoc3RkOjpleHBlcmltZW50YWw6OmZ1bmRhbWVudGFsc192Mzo6 dW5leHBlY3RlZDo6dmFsdWUgY29uc3QpOgorCisyMDE3LTEyLTA5ICBZdXN1a2UgU3V6dWtpICA8 dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCiAgICAgICAgIFVzZSByZWxheGVkIGNvbnN0ZXhwciBm b3IgU3RyaW5nSGFzaGVyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODA2MjIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaCBi L1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKaW5kZXggY2ViMzVkYjU2ZWNjODgwNmRhNDA2MDI2 YTc0YTI1NWM2MWFjYTI1Ny4uYzEwZDc5YzU3Y2U2YmNiMjg2MTZkNzM4NjI0YzRmMzkxZmU4Mjdk MyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaAorKysgYi9Tb3VyY2UvV1RG L3d0Zi9Db21waWxlci5oCkBAIC0xNTQsMjAgKzE1NCw2IEBACiAjZGVmaW5lIFdURl9DT01QSUxF Ul9TVVBQT1JUU19OU0RNSV9GT1JfQUdHUkVHQVRFUyAxCiAjZW5kaWYKIAotLyogUkVMQVhFRF9D T05TVEVYUFIgKi8KLQotI2lmIGRlZmluZWQoX19jcHBfY29uc3RleHByKSAmJiBfX2NwcF9jb25z dGV4cHIgPj0gMjAxMzA0Ci0jZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JUU19SRUxBWEVEX0NP TlNURVhQUiAxCi0jZW5kaWYKLQotI2lmICFkZWZpbmVkKFJFTEFYRURfQ09OU1RFWFBSKQotI2lm IENPTVBJTEVSX1NVUFBPUlRTKFJFTEFYRURfQ09OU1RFWFBSKQotI2RlZmluZSBSRUxBWEVEX0NP TlNURVhQUiBjb25zdGV4cHIKLSNlbHNlCi0jZGVmaW5lIFJFTEFYRURfQ09OU1RFWFBSCi0jZW5k aWYKLSNlbmRpZgotCiAjZGVmaW5lIEFTQU5fRU5BQkxFRCBDT01QSUxFUl9IQVNfQ0xBTkdfRkVB VFVSRShhZGRyZXNzX3Nhbml0aXplcikKIAogI2lmIEFTQU5fRU5BQkxFRApkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvRXhwZWN0ZWQuaCBiL1NvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmgKaW5k ZXggNzBhMjJhY2M4ZWVhZjIxMTljOGU0OTVhNDYzNzFkZWY4MWYyNWRjYi4uZGQwNDVlNTk4NzVl NGY0NzY3ZWIyZWIxNzljMWMyNzE5ZTBhZjJlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv RXhwZWN0ZWQuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9FeHBlY3RlZC5oCkBAIC00ODIsMTYgKzQ4 MiwxNiBAQCBjbGFzcyBleHBlY3RlZCA6IHByaXZhdGUgX19leHBlY3RlZF9kZXRhaWw6OmJhc2Vf c2VsZWN0PFQsIEU+IHsKICAgICBjb25zdGV4cHIgY29uc3QgdmFsdWVfdHlwZSYgb3BlcmF0b3Iq KCkgY29uc3QgJiB7IHJldHVybiBiYXNlOjpzLnZhbDsgfQogICAgIHZhbHVlX3R5cGUmIG9wZXJh dG9yKigpICYgeyByZXR1cm4gYmFzZTo6cy52YWw7IH0KICAgICBjb25zdGV4cHIgY29uc3QgdmFs dWVfdHlwZSYmIG9wZXJhdG9yKigpIGNvbnN0ICYmIHsgcmV0dXJuIHN0ZDo6bW92ZShiYXNlOjpz LnZhbCk7IH0KLSAgICBSRUxBWEVEX0NPTlNURVhQUiB2YWx1ZV90eXBlJiYgb3BlcmF0b3IqKCkg JiYgeyByZXR1cm4gc3RkOjptb3ZlKGJhc2U6OnMudmFsKTsgfQorICAgIGNvbnN0ZXhwciB2YWx1 ZV90eXBlJiYgb3BlcmF0b3IqKCkgJiYgeyByZXR1cm4gc3RkOjptb3ZlKGJhc2U6OnMudmFsKTsg fQogICAgIGNvbnN0ZXhwciBleHBsaWNpdCBvcGVyYXRvciBib29sKCkgY29uc3QgeyByZXR1cm4g YmFzZTo6aGFzOyB9CiAgICAgY29uc3RleHByIGJvb2wgaGFzX3ZhbHVlKCkgY29uc3QgeyByZXR1 cm4gYmFzZTo6aGFzOyB9CiAgICAgY29uc3RleHByIGNvbnN0IHZhbHVlX3R5cGUmIHZhbHVlKCkg Y29uc3QgJiB7IHJldHVybiBiYXNlOjpoYXMgPyBiYXNlOjpzLnZhbCA6IChfX0VYUEVDVEVEX1RI Uk9XKGJhZF9leHBlY3RlZF9hY2Nlc3M8ZXJyb3JfdHlwZT4oYmFzZTo6cy5lcnIpKSwgYmFzZTo6 cy52YWwpOyB9Ci0gICAgUkVMQVhFRF9DT05TVEVYUFIgdmFsdWVfdHlwZSYgdmFsdWUoKSAmIHsg cmV0dXJuIGJhc2U6OmhhcyA/IGJhc2U6OnMudmFsIDogKF9fRVhQRUNURURfVEhST1coYmFkX2V4 cGVjdGVkX2FjY2VzczxlcnJvcl90eXBlPihiYXNlOjpzLmVycikpLCBiYXNlOjpzLnZhbCk7IH0K KyAgICBjb25zdGV4cHIgdmFsdWVfdHlwZSYgdmFsdWUoKSAmIHsgcmV0dXJuIGJhc2U6OmhhcyA/ IGJhc2U6OnMudmFsIDogKF9fRVhQRUNURURfVEhST1coYmFkX2V4cGVjdGVkX2FjY2VzczxlcnJv cl90eXBlPihiYXNlOjpzLmVycikpLCBiYXNlOjpzLnZhbCk7IH0KICAgICBjb25zdGV4cHIgY29u c3QgdmFsdWVfdHlwZSYmIHZhbHVlKCkgY29uc3QgJiYgeyByZXR1cm4gc3RkOjptb3ZlKGJhc2U6 OmhhcyA/IGJhc2U6OnMudmFsIDogKF9fRVhQRUNURURfVEhST1coYmFkX2V4cGVjdGVkX2FjY2Vz czxlcnJvcl90eXBlPihiYXNlOjpzLmVycikpLCBiYXNlOjpzLnZhbCkpOyB9Ci0gICAgUkVMQVhF RF9DT05TVEVYUFIgdmFsdWVfdHlwZSYmIHZhbHVlKCkgJiYgeyByZXR1cm4gc3RkOjptb3ZlKGJh c2U6OmhhcyA/IGJhc2U6OnMudmFsIDogKF9fRVhQRUNURURfVEhST1coYmFkX2V4cGVjdGVkX2Fj Y2VzczxlcnJvcl90eXBlPihiYXNlOjpzLmVycikpLCBiYXNlOjpzLnZhbCkpOyB9CisgICAgY29u c3RleHByIHZhbHVlX3R5cGUmJiB2YWx1ZSgpICYmIHsgcmV0dXJuIHN0ZDo6bW92ZShiYXNlOjpo YXMgPyBiYXNlOjpzLnZhbCA6IChfX0VYUEVDVEVEX1RIUk9XKGJhZF9leHBlY3RlZF9hY2Nlc3M8 ZXJyb3JfdHlwZT4oYmFzZTo6cy5lcnIpKSwgYmFzZTo6cy52YWwpKTsgfQogICAgIGNvbnN0ZXhw ciBjb25zdCBlcnJvcl90eXBlJiBlcnJvcigpIGNvbnN0ICYgeyByZXR1cm4gIWJhc2U6OmhhcyA/ IGJhc2U6OnMuZXJyIDogKF9fRVhQRUNURURfVEhST1coYmFkX2V4cGVjdGVkX2FjY2Vzczx2b2lk PigpKSwgYmFzZTo6cy5lcnIpOyB9CiAgICAgZXJyb3JfdHlwZSYgZXJyb3IoKSAmIHsgcmV0dXJu ICFiYXNlOjpoYXMgPyBiYXNlOjpzLmVyciA6IChfX0VYUEVDVEVEX1RIUk9XKGJhZF9leHBlY3Rl ZF9hY2Nlc3M8dm9pZD4oKSksIGJhc2U6OnMuZXJyKTsgfQotICAgIFJFTEFYRURfQ09OU1RFWFBS IGVycm9yX3R5cGUmJiBlcnJvcigpICYmIHsgcmV0dXJuIHN0ZDo6bW92ZSghYmFzZTo6aGFzID8g YmFzZTo6cy5lcnIgOiAoX19FWFBFQ1RFRF9USFJPVyhiYWRfZXhwZWN0ZWRfYWNjZXNzPHZvaWQ+ KCkpLCBiYXNlOjpzLmVycikpOyB9CisgICAgY29uc3RleHByIGVycm9yX3R5cGUmJiBlcnJvcigp ICYmIHsgcmV0dXJuIHN0ZDo6bW92ZSghYmFzZTo6aGFzID8gYmFzZTo6cy5lcnIgOiAoX19FWFBF Q1RFRF9USFJPVyhiYWRfZXhwZWN0ZWRfYWNjZXNzPHZvaWQ+KCkpLCBiYXNlOjpzLmVycikpOyB9 CiAgICAgY29uc3RleHByIGNvbnN0IGVycm9yX3R5cGUmJiBlcnJvcigpIGNvbnN0ICYmIHsgcmV0 dXJuIHN0ZDo6bW92ZSghYmFzZTo6aGFzID8gYmFzZTo6cy5lcnIgOiAoX19FWFBFQ1RFRF9USFJP VyhiYWRfZXhwZWN0ZWRfYWNjZXNzPHZvaWQ+KCkpLCBiYXNlOjpzLmVycikpOyB9CiAgICAgdGVt cGxhdGU8Y2xhc3MgVT4gY29uc3RleHByIHZhbHVlX3R5cGUgdmFsdWVfb3IoVSYmIHUpIGNvbnN0 ICYgeyByZXR1cm4gYmFzZTo6aGFzID8gKip0aGlzIDogc3RhdGljX2Nhc3Q8dmFsdWVfdHlwZT4o c3RkOjpmb3J3YXJkPFU+KHUpKTsgfQogICAgIHRlbXBsYXRlPGNsYXNzIFU+IHZhbHVlX3R5cGUg dmFsdWVfb3IoVSYmIHUpICYmIHsgcmV0dXJuIGJhc2U6OmhhcyA/IHN0ZDo6bW92ZSgqKnRoaXMp IDogc3RhdGljX2Nhc3Q8dmFsdWVfdHlwZT4oc3RkOjpmb3J3YXJkPFU+KHUpKTsgfQpAQCAtNTUx LDcgKzU1MSw3IEBAIGNsYXNzIGV4cGVjdGVkPHZvaWQsIEU+IDogcHJpdmF0ZSBfX2V4cGVjdGVk X2RldGFpbDo6YmFzZV9zZWxlY3Q8dm9pZCwgRT4gewogICAgIHZvaWQgdmFsdWUoKSBjb25zdCB7 ICFiYXNlOjpoYXMgPyBfX0VYUEVDVEVEX1RIUk9XKGJhZF9leHBlY3RlZF9hY2Nlc3M8dm9pZD4o KSkgOiB2b2lkKCk7IH0KICAgICBjb25zdGV4cHIgY29uc3QgRSYgZXJyb3IoKSBjb25zdCAmIHsg cmV0dXJuICFiYXNlOjpoYXMgPyBiYXNlOjpzLmVyciA6IChfX0VYUEVDVEVEX1RIUk9XKGJhZF9l eHBlY3RlZF9hY2Nlc3M8dm9pZD4oKSksIGJhc2U6OnMuZXJyKTsgfQogICAgIEUmIGVycm9yKCkg JiB7IHJldHVybiAhYmFzZTo6aGFzID8gYmFzZTo6cy5lcnIgOiAoX19FWFBFQ1RFRF9USFJPVyhi YWRfZXhwZWN0ZWRfYWNjZXNzPHZvaWQ+KCkpLCBiYXNlOjpzLmVycik7IH0KLSAgICBSRUxBWEVE X0NPTlNURVhQUiBFJiYgZXJyb3IoKSAmJiB7IHJldHVybiBzdGQ6Om1vdmUoIWJhc2U6OmhhcyA/ IGJhc2U6OnMuZXJyIDogKF9fRVhQRUNURURfVEhST1coYmFkX2V4cGVjdGVkX2FjY2Vzczx2b2lk PigpKSwgYmFzZTo6cy5lcnIpKTsgfQorICAgIGNvbnN0ZXhwciBFJiYgZXJyb3IoKSAmJiB7IHJl dHVybiBzdGQ6Om1vdmUoIWJhc2U6OmhhcyA/IGJhc2U6OnMuZXJyIDogKF9fRVhQRUNURURfVEhS T1coYmFkX2V4cGVjdGVkX2FjY2Vzczx2b2lkPigpKSwgYmFzZTo6cy5lcnIpKTsgfQogfTsKIAog dGVtcGxhdGU8Y2xhc3MgVCwgY2xhc3MgRT4gY29uc3RleHByIGJvb2wgb3BlcmF0b3I9PShjb25z dCBleHBlY3RlZDxULCBFPiYgeCwgY29uc3QgZXhwZWN0ZWQ8VCwgRT4mIHkpIHsgcmV0dXJuIGJv b2woeCkgPT0gYm9vbCh5KSAmJiAoeCA/IHgudmFsdWUoKSA9PSB5LnZhbHVlKCkgOiB4LmVycm9y KCkgPT0geS5lcnJvcigpKTsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVW5leHBlY3Rl ZC5oIGIvU291cmNlL1dURi93dGYvVW5leHBlY3RlZC5oCmluZGV4IGE2NTNiM2NhYmQ3NTA4NDJl NGQ2YmViZTIzNDg3NWYxMDhjZjcxM2YuLjE5M2VlNGQ2MjcyOGJjNjk4MGY1ZGM0MWJjYmMxMTVh ZTI1ZjE3MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1VuZXhwZWN0ZWQuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9VbmV4cGVjdGVkLmgKQEAgLTc4LDkgKzc4LDkgQEAgY2xhc3MgdW5leHBl Y3RlZCB7CiAgICAgY29uc3RleHByIGV4cGxpY2l0IHVuZXhwZWN0ZWQoY29uc3QgRSYgZSkgOiB2 YWwoZSkgeyB9CiAgICAgY29uc3RleHByIGV4cGxpY2l0IHVuZXhwZWN0ZWQoRSYmIGUpIDogdmFs KHN0ZDo6Zm9yd2FyZDxFPihlKSkgeyB9CiAgICAgY29uc3RleHByIGNvbnN0IEUmIHZhbHVlKCkg Y29uc3QgJiB7IHJldHVybiB2YWw7IH0KLSAgICBSRUxBWEVEX0NPTlNURVhQUiBFJiB2YWx1ZSgp ICYgeyByZXR1cm4gdmFsOyB9Ci0gICAgUkVMQVhFRF9DT05TVEVYUFIgRSYmIHZhbHVlKCkgJiYg eyByZXR1cm4gV1RGTW92ZSh2YWwpOyB9Ci0gICAgUkVMQVhFRF9DT05TVEVYUFIgY29uc3QgRSYm IHZhbHVlKCkgY29uc3QgJiYgeyByZXR1cm4gV1RGTW92ZSh2YWwpOyB9CisgICAgY29uc3RleHBy IEUmIHZhbHVlKCkgJiB7IHJldHVybiB2YWw7IH0KKyAgICBjb25zdGV4cHIgRSYmIHZhbHVlKCkg JiYgeyByZXR1cm4gV1RGTW92ZSh2YWwpOyB9CisgICAgY29uc3RleHByIGNvbnN0IEUmJiB2YWx1 ZSgpIGNvbnN0ICYmIHsgcmV0dXJuIFdURk1vdmUodmFsKTsgfQogCiBwcml2YXRlOgogICAgIEUg dmFsOwo=