180616 2017-12-08 16:54:52 -0800 Disable NoEventDispatchAssertion release assertion in WebKit1 2017-12-11 22:30:39 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa bfulgham cdumez commit-queue dbates esprehn+autocc ews-watchlist ggaren kangil.han simon.fraser zalan oldest_to_newest 1379873 0 rniwa 2017-12-08 16:54:52 -0800 There are just many delegate callbacks inside WebCore in unsafe places, and embedder of WebView can execute scripts, or modify WebView in all those sites. Since we don't have a hope of fixing all those delegate callbacks in short term, disable the release assertion added in https://trac.webkit.org/r224534 in WebKit1. 1379889 1 rniwa 2017-12-08 17:06:03 -0800 *** Bug 180617 has been marked as a duplicate of this bug. *** 1379891 2 328889 rniwa 2017-12-08 17:06:47 -0800 Created attachment 328889 Disable release assertions in WK1 1379894 3 rniwa 2017-12-08 17:12:50 -0800 <rdar://problem/35689400> 1380524 4 rniwa 2017-12-11 19:02:33 -0800 Ping reviewers. 1380558 5 328889 rniwa 2017-12-11 22:10:01 -0800 Comment on attachment 328889 Disable release assertions in WK1 cq+. Confirmed that the assertion still requires on macOS. 1380567 6 328889 commit-queue 2017-12-11 22:30:37 -0800 Comment on attachment 328889 Disable release assertions in WK1 Clearing flags on attachment: 328889 Committed r225772: <https://trac.webkit.org/changeset/225772> 1380568 7 commit-queue 2017-12-11 22:30:39 -0800 All reviewed patches have been landed. Closing bug. 328889 2017-12-08 17:06:47 -0800 2017-12-11 22:30:37 -0800 Disable release assertions in WK1 bug-180616-20171208170647.patch text/plain 6885 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNTcxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE3LTEyLTA4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERpc2FibGUgTm9FdmVudERpc3Bh dGNoQXNzZXJ0aW9uIHJlbGVhc2UgYXNzZXJ0aW9uIGluIFdlYktpdDEKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDYxNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGVkIHRoZSByZWxlYXNlIGFz c2VydGlvbiBmb3IgTm9FdmVudERpc3BhdGNoQXNzZXJ0aW9uIGluIFdlYktpdDEgc2luY2UgdGhl cmUgYXJlIG1hbnkKKyAgICAgICAgZGVsZWdhdGUgY2FsbGJhY2tzIHRoYXQgaGFwcGVuIGF0IHVu c2FmZSB0aW1pbmcsIGFuZCB3ZSBkb24ndCBoYXZlIGFueSBob3BlIG9mIGZpeGluZyB0aGVtCisg ICAgICAgIGluIHNob3J0IHRlcm0uCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRDb250 cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmNhbkV4ZWN1 dGVTY3JpcHRzKToKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6aXNTYWZlVG9VcGRhdGVTdHlsZU9yTGF5b3V0KToKKyAgICAgICAgKiBkb20vU2NyaXB0RWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRFbGVtZW50OjpleGVjdXRlQ2xhc3Np Y1NjcmlwdCk6CisgICAgICAgICogcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLmg6 CisgICAgICAgIChXZWJDb3JlOjppc0luV2ViUHJvY2Vzcyk6CisgICAgICAgICogcGxhdGZvcm0v Y29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW06CisgICAgICAgIChXZWJDb3Jl Ojppc0luV2ViUHJvY2Vzcyk6IEV4dHJhY3RlZCBmcm9tIElPU0FwcGxpY2F0aW9uOjppc1dlYlBy b2Nlc3MuCisgICAgICAgIChXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNXZWJQcm9jZXNzKToK KwogMjAxNy0xMi0wNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBXcm9uZyBjYXJldCBwb3NpdGlvbiBmb3IgaW5wdXQgZmllbGQgaW5zaWRlIGEgZml4 ZWQgcG9zaXRpb24gcGFyZW50IG9uIGlPUyAxMQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDIyNTY1NykKKysrIFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00OCw2ICs0OCw3IEBACiAjaW5jbHVkZSAiUGFnZUNvbnNvbGVDbGllbnQuaCIKICNp bmNsdWRlICJQYWdlR3JvdXAuaCIKICNpbmNsdWRlICJQbHVnaW5WaWV3QmFzZS5oIgorI2luY2x1 ZGUgIlJ1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oIgogI2luY2x1ZGUgIlNjcmlwdFNvdXJjZUNv ZGUuaCIKICNpbmNsdWRlICJTY3JpcHRhYmxlRG9jdW1lbnRQYXJzZXIuaCIKICNpbmNsdWRlICJT ZXR0aW5ncy5oIgpAQCAtNjY4LDcgKzY2OSw3IEBAIEpTVmFsdWUgU2NyaXB0Q29udHJvbGxlcjo6 ZXhlY3V0ZVNjcmlwdEkKIGJvb2wgU2NyaXB0Q29udHJvbGxlcjo6Y2FuRXhlY3V0ZVNjcmlwdHMo UmVhc29uRm9yQ2FsbGluZ0NhbkV4ZWN1dGVTY3JpcHRzIHJlYXNvbikKIHsKICAgICBpZiAocmVh c29uID09IEFib3V0VG9FeGVjdXRlU2NyaXB0KQotICAgICAgICBSRUxFQVNFX0FTU0VSVF9XSVRI X1NFQ1VSSVRZX0lNUExJQ0FUSU9OKE5vRXZlbnREaXNwYXRjaEFzc2VydGlvbjo6SW5NYWluVGhy ZWFkOjppc0V2ZW50QWxsb3dlZCgpKTsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9TRUNV UklUWV9JTVBMSUNBVElPTihOb0V2ZW50RGlzcGF0Y2hBc3NlcnRpb246OkluTWFpblRocmVhZDo6 aXNFdmVudEFsbG93ZWQoKSB8fCAhaXNJbldlYlByb2Nlc3MoKSk7CiAKICAgICBpZiAobV9mcmFt ZS5kb2N1bWVudCgpICYmIG1fZnJhbWUuZG9jdW1lbnQoKS0+aXNTYW5kYm94ZWQoU2FuZGJveFNj cmlwdHMpKSB7CiAgICAgICAgIC8vIEZJWE1FOiBUaGlzIG1lc3NhZ2Ugc2hvdWxkIGJlIG1vdmVk IG9mZiB0aGUgY29uc29sZSBvbmNlIGEgc29sdXRpb24gdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMzI3NCBleGlzdHMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAJKHJldmlzaW9uIDIyNTY1NykKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE1Miw2ICsxNTIsNyBAQAogI2luY2x1ZGUgIlJlbmRlcldp ZGdldC5oIgogI2luY2x1ZGUgIlJlcXVlc3RBbmltYXRpb25GcmFtZUNhbGxiYWNrLmgiCiAjaW5j bHVkZSAiUmVzb3VyY2VMb2FkT2JzZXJ2ZXIuaCIKKyNpbmNsdWRlICJSdW50aW1lQXBwbGljYXRp b25DaGVja3MuaCIKICNpbmNsdWRlICJSdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgiCiAjaW5jbHVk ZSAiU1ZHRG9jdW1lbnRFeHRlbnNpb25zLmgiCiAjaW5jbHVkZSAiU1ZHRWxlbWVudC5oIgpAQCAt MTkyNCwxNSArMTkyNSw5IEBAIGJvb2wgRG9jdW1lbnQ6Om5lZWRzU3R5bGVSZWNhbGMoKSBjb25z dAogCiBpbmxpbmUgYm9vbCBzdGF0aWMgaXNTYWZlVG9VcGRhdGVTdHlsZU9yTGF5b3V0KEZyYW1l VmlldyogZnJhbWVWaWV3KQogewotI2lmIFVTRShXRUJfVEhSRUFEKQotICAgIC8vIEZJWE1FOiBS ZW1vdmUgdGhpcyBjb2RlOiA8cmRhcjovL3Byb2JsZW0vMzU1MjI3MTk+Ci0gICAgYm9vbCB1c2lu Z1dlYlRocmVhZCA9IFdlYlRocmVhZElzRW5hYmxlZCgpOwotI2Vsc2UKLSAgICBib29sIHVzaW5n V2ViVGhyZWFkID0gZmFsc2U7Ci0jZW5kaWYKICAgICBib29sIGlzU2FmZVRvRXhlY3V0ZVNjcmlw dCA9IE5vRXZlbnREaXNwYXRjaEFzc2VydGlvbjo6SW5NYWluVGhyZWFkOjppc0V2ZW50QWxsb3dl ZCgpOwogICAgIGJvb2wgaXNJbkZyYW1lRmxhdHRlbmluZyA9IGZyYW1lVmlldyAmJiBmcmFtZVZp ZXctPmlzSW5DaGlsZEZyYW1lV2l0aEZyYW1lRmxhdHRlbmluZygpOwotICAgIHJldHVybiBpc1Nh ZmVUb0V4ZWN1dGVTY3JpcHQgfHwgaXNJbkZyYW1lRmxhdHRlbmluZyB8fCB1c2luZ1dlYlRocmVh ZDsKKyAgICByZXR1cm4gaXNTYWZlVG9FeGVjdXRlU2NyaXB0IHx8IGlzSW5GcmFtZUZsYXR0ZW5p bmcgfHwgIWlzSW5XZWJQcm9jZXNzKCk7CiB9CiAKIGJvb2wgRG9jdW1lbnQ6OnVwZGF0ZVN0eWxl SWZOZWVkZWQoKQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNwcAkocmV2aXNp b24gMjI1NjU3KQorKysgU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00Myw2ICs0Myw3IEBACiAjaW5jbHVkZSAiTUlNRVR5cGVSZWdpc3RyeS5o IgogI2luY2x1ZGUgIk5vRXZlbnREaXNwYXRjaEFzc2VydGlvbi5oIgogI2luY2x1ZGUgIlBlbmRp bmdTY3JpcHQuaCIKKyNpbmNsdWRlICJSdW50aW1lQXBwbGljYXRpb25DaGVja3MuaCIKICNpbmNs dWRlICJTVkdTY3JpcHRFbGVtZW50LmgiCiAjaW5jbHVkZSAiU2NyaXB0Q29udHJvbGxlci5oIgog I2luY2x1ZGUgIlNjcmlwdFJ1bm5lci5oIgpAQCAtMzYxLDcgKzM2Miw3IEBAIGJvb2wgU2NyaXB0 RWxlbWVudDo6cmVxdWVzdE1vZHVsZVNjcmlwdCgKIAogdm9pZCBTY3JpcHRFbGVtZW50OjpleGVj dXRlQ2xhc3NpY1NjcmlwdChjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3VyY2VDb2RlKQogewot ICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oTm9FdmVudERpc3Bh dGNoQXNzZXJ0aW9uOjpJbk1haW5UaHJlYWQ6OmlzRXZlbnRBbGxvd2VkKCkpOworICAgIFJFTEVB U0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oTm9FdmVudERpc3BhdGNoQXNzZXJ0 aW9uOjpJbk1haW5UaHJlYWQ6OmlzRXZlbnRBbGxvd2VkKCkgfHwgIWlzSW5XZWJQcm9jZXNzKCkp OwogICAgIEFTU0VSVChtX2FscmVhZHlTdGFydGVkKTsKIAogICAgIGlmIChzb3VyY2VDb2RlLmlz RW1wdHkoKSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlv bkNoZWNrcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVB cHBsaWNhdGlvbkNoZWNrcy5oCShyZXZpc2lvbiAyMjU2NTcpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaAkod29ya2luZyBjb3B5KQpAQCAtMzIs OCArMzIsMTYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogV0VCQ09SRV9FWFBPUlQgdm9pZCBzZXRQ cmVzZW50aW5nQXBwbGljYXRpb25QSUQoaW50KTsKIFdFQkNPUkVfRVhQT1JUIGludCBwcmVzZW50 aW5nQXBwbGljYXRpb25QSUQoKTsKIAorI2lmIFBMQVRGT1JNKFdJTikKK2lubGluZSBib29sIGlz SW5XZWJQcm9jZXNzKCkgeyByZXR1cm4gZmFsc2U7IH0KKyNlbGlmICFQTEFURk9STShDT0NPQSkK K2lubGluZSBib29sIGlzSW5XZWJQcm9jZXNzKCkgeyByZXR1cm4gdHJ1ZTsgfQorI2VuZGlmCisK ICNpZiBQTEFURk9STShDT0NPQSkKIAorYm9vbCBpc0luV2ViUHJvY2VzcygpOworCiBXRUJDT1JF X0VYUE9SVCB2b2lkIHNldEFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmllcihjb25zdCBTdHJpbmcm KTsKIFN0cmluZyBhcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXIoKTsKIApJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUnVudGltZUFwcGxp Y2F0aW9uQ2hlY2tzQ29jb2EubW0JKHJldmlzaW9uIDIyNTY1NykKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2NvY29hL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tCSh3b3JraW5n IGNvcHkpCkBAIC02NSw2ICs2NSwxNCBAQCB2b2lkIHNldEFwcGxpY2F0aW9uQnVuZGxlSWRlbnRp Zmllcihjb25zCiAgICAgYXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyT3ZlcnJpZGUoKSA9IGJ1 bmRsZUlkZW50aWZpZXI7CiB9CiAKK2Jvb2wgaXNJbldlYlByb2Nlc3MoKQoreworICAgIHN0YXRp YyBib29sIG1haW5CdW5kbGVJc1dlYlByb2Nlc3MgPSBbW1tOU0J1bmRsZSBtYWluQnVuZGxlXSBi dW5kbGVJZGVudGlmaWVyXSBpc0VxdWFsVG9TdHJpbmc6QCJjb20uYXBwbGUuV2ViS2l0LldlYkNv bnRlbnQuRGV2ZWxvcG1lbnQiXQorICAgICAgICB8fCBbW1tOU0J1bmRsZSBtYWluQnVuZGxlXSBi dW5kbGVJZGVudGlmaWVyXSBpc0VxdWFsVG9TdHJpbmc6QCJjb20uYXBwbGUuV2ViS2l0LldlYkNv bnRlbnQiXQorICAgICAgICB8fCBbW1tOU0J1bmRsZSBtYWluQnVuZGxlXSBidW5kbGVJZGVudGlm aWVyXSBpc0VxdWFsVG9TdHJpbmc6QCJjb20uYXBwbGUuV2ViUHJvY2VzcyJdOworICAgIHJldHVy biBtYWluQnVuZGxlSXNXZWJQcm9jZXNzOworfQorCiBzdGF0aWMgYm9vbCBhcHBsaWNhdGlvbkJ1 bmRsZUlzRXF1YWxUbyhjb25zdCBTdHJpbmcmIGJ1bmRsZUlkZW50aWZpZXJTdHJpbmcpCiB7CiAg ICAgcmV0dXJuIGFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmllcigpID09IGJ1bmRsZUlkZW50aWZp ZXJTdHJpbmc7CkBAIC0yMDcsMTAgKzIxNSw3IEBAIGJvb2wgSU9TQXBwbGljYXRpb246OmlzV2Vi QXBwKCkKIC8vIEZJWE1FOiB0aGlzIG5lZWRzIHRvIGJlIGNoYW5nZWQgd2hlbiB0aGUgV2ViUHJv Y2VzcyBpcyBjaGFuZ2VkIHRvIGFuIFhQQyBzZXJ2aWNlLgogYm9vbCBJT1NBcHBsaWNhdGlvbjo6 aXNXZWJQcm9jZXNzKCkKIHsKLSAgICBzdGF0aWMgYm9vbCBpc1dlYlByb2Nlc3MgPSBbW1tOU0J1 bmRsZSBtYWluQnVuZGxlXSBidW5kbGVJZGVudGlmaWVyXSBpc0VxdWFsVG9TdHJpbmc6QCJjb20u YXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuRGV2ZWxvcG1lbnQiXQotICAgICAgICB8fCBbW1tOU0J1 bmRsZSBtYWluQnVuZGxlXSBidW5kbGVJZGVudGlmaWVyXSBpc0VxdWFsVG9TdHJpbmc6QCJjb20u YXBwbGUuV2ViS2l0LldlYkNvbnRlbnQiXQotICAgICAgICB8fCBbW1tOU0J1bmRsZSBtYWluQnVu ZGxlXSBidW5kbGVJZGVudGlmaWVyXSBpc0VxdWFsVG9TdHJpbmc6QCJjb20uYXBwbGUuV2ViUHJv Y2VzcyJdOwotICAgIHJldHVybiBpc1dlYlByb2Nlc3M7CisgICAgcmV0dXJuIGlzSW5XZWJQcm9j ZXNzKCk7CiB9CiAKIGJvb2wgSU9TQXBwbGljYXRpb246OmlzSUJvb2tzKCkK