18061 2008-03-25 02:04:46 -0700 PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets 2008-03-28 11:27:10 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED http://acid3.acidtests.org/ Gtk P2 Normal --- 1 jasper webkit-unassigned alp oldest_to_newest 75085 0 jasper 2008-03-25 02:04:46 -0700 The attached patch adds a missing clampNegativeToZero() call to stop PlatformScrollBarGtk from allocating negative width and/or height for widgets. This stops massive barfage of warnings like this on, for example, the Acid3 test: (juniper:12951): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -15 and height 15 75086 1 20024 jasper 2008-03-25 02:05:32 -0700 Created attachment 20024 prevent PlatformScrollBarGtk from allocating negative width and/or height for widgets 75653 2 alp 2008-03-28 11:27:10 -0700 Landed in r31399. Including the bug URL/subject in the ChangeLog entry is a good idea for future patches. I also removed the comment since it's self-explanatory. Thanks! 20024 2008-03-25 02:05:32 -0700 2008-03-28 11:21:32 -0700 prevent PlatformScrollBarGtk from allocating negative width and/or height for widgets PlatformScrollBarGtk-prevent-allocation-of-widgets-with-negative-size.patch text/plain 1560 jasper SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMTI3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMDMtMjUgIEphc3BlciBCcnlhbnQtR3JlZW5lICA8amFzcGVy QHVuaXguZ2Vlay5uej4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNaXNzaW5nIGNsYW1wTmVnYXRpdmVUb1plcm8oKSBjYWxsIG1lYW50IHRoYXQgd2Ug dHJpZWQgdG8gYWxsb2NhdGUgd2lkZ2V0cyB3aXRoIG5lZ2F0aXZlIHdpZHRoIGFuZC9vciBoZWln aHQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JvbGxCYXJHdGsuY3BwOgor ICAgICAgICAoUGxhdGZvcm1TY3JvbGxiYXI6Omdlb21ldHJ5Q2hhbmdlZCk6CisKIDIwMDgtMDMt MjUgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIEN1dCBhbmQgcGFz dGUgZXJyb3IgaW4gdGhlIHpvb20gY29kZS4gIEEgd2lkdGgoKSBzaG91bGQgaGF2ZSBiZWVuIGEg aGVpZ2h0KCkuICBSZWdyZXNzaW9uIHRlc3RzIGNhdWdodCB0aGlzLgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JvbGxCYXJHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vZ3RrL1BsYXRmb3JtU2Nyb2xsQmFyR3RrLmNwcAkocmV2aXNpb24gMzEyNzcp CisrKyBXZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcm9sbEJhckd0ay5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEyMiw3ICsxMjIsMTIgQEAgdm9pZCBQbGF0Zm9ybVNjcm9sbGJhcjo6Z2Vv bWV0cnlDaGFuZ2VkKAogCiAgICAgRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSBzdGF0aWNfY2FzdDxG cmFtZVZpZXcqPihwYXJlbnQoKSk7CiAgICAgSW50UmVjdCB3aW5kb3dSZWN0ID0gSW50UmVjdChm cmFtZVZpZXctPmNvbnRlbnRzVG9XaW5kb3coZnJhbWVHZW9tZXRyeSgpLmxvY2F0aW9uKCkpLCBm cmFtZUdlb21ldHJ5KCkuc2l6ZSgpKTsKLSAgICBHdGtBbGxvY2F0aW9uIGFsbG9jYXRpb24gPSB7 IHdpbmRvd1JlY3QueCgpLCB3aW5kb3dSZWN0LnkoKSwgd2luZG93UmVjdC53aWR0aCgpLCB3aW5k b3dSZWN0LmhlaWdodCgpIH07CisKKyAgICAvLyBEb24ndCBhbGxvdyB0aGUgYWxsb2NhdGlvbiBz aXplIHRvIGJlIG5lZ2F0aXZlCisgICAgSW50U2l6ZSBzeiA9IGZyYW1lR2VvbWV0cnkoKS5zaXpl KCk7CisgICAgc3ouY2xhbXBOZWdhdGl2ZVRvWmVybygpOworCisgICAgR3RrQWxsb2NhdGlvbiBh bGxvY2F0aW9uID0geyB3aW5kb3dSZWN0LngoKSwgd2luZG93UmVjdC55KCksIHN6LndpZHRoKCks IHN6LmhlaWdodCgpIH07CiAgICAgZ3RrX3dpZGdldF9zaXplX2FsbG9jYXRlKGd0a1dpZGdldCgp LCAmYWxsb2NhdGlvbik7CiB9CiAK