180609 2017-12-08 14:54:05 -0800 APIClient.h uses things from <tuple> without including it explicitly 2017-12-10 08:48:36 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned achristensen commit-queue darin don.olmstead rniwa webkit-bug-importer oldest_to_newest 1379821 0 stephan.szabo 2017-12-08 14:54:05 -0800 Similar to https://bugs.webkit.org/show_bug.cgi?id=179926, APIClient.h uses tuple related items without explicitly including <tuple>. This can cause compilation failures on toolchains where including <algorithm> and <array> doesn't guarantee the appropriate tuple_size and tuple_element used in the header being available. 1379878 1 328886 stephan.szabo 2017-12-08 16:57:41 -0800 Created attachment 328886 Add <tuple> include to APIClient.h 1380069 2 328886 commit-queue 2017-12-10 08:47:28 -0800 Comment on attachment 328886 Add <tuple> include to APIClient.h Clearing flags on attachment: 328886 Committed r225732: <https://trac.webkit.org/changeset/225732> 1380070 3 commit-queue 2017-12-10 08:47:30 -0800 All reviewed patches have been landed. Closing bug. 1380071 4 webkit-bug-importer 2017-12-10 08:48:36 -0800 <rdar://problem/35956521> 328886 2017-12-08 16:57:41 -0800 2017-12-10 08:47:28 -0800 Add <tuple> include to APIClient.h 180609-1.diff text/plain 888 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTIzMTFhZTZiYmEuLjIwODUzYzdhZjMxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDE3LTEyLTA4ICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNv bT4KKworICAgICAgICBBUElDbGllbnQuaCB1c2VzIHRoaW5ncyBmcm9tIDx0dXBsZT4gd2l0aG91 dCBpbmNsdWRpbmcgaXQgZXhwbGljaXRseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNjA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0FQSUNsaWVudC5oOgorCiAyMDE3LTEyLTA4 ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UGFzcyBzdGQ6Om9wdGlvbmFsPFdlYnNpdGVQb2xpY2llcz4gaW5zdGVhZCBvZiBXZWJzaXRlUG9s aWNpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9BUElDbGllbnQuaCBi L1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9BUElDbGllbnQuaAppbmRleCAyZDJkODlhNWM1Ny4u YzEyZTMwYjAzZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9BUElDbGll bnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9BUEkvQVBJQ2xpZW50LmgKQEAgLTI4LDYg KzI4LDcgQEAKIAogI2luY2x1ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRlIDxhcnJheT4KKyNpbmNs dWRlIDx0dXBsZT4KIAogbmFtZXNwYWNlIEFQSSB7CiAK