<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>180608</bug_id>
          
          <creation_ts>2017-12-08 14:32:37 -0800</creation_ts>
          <short_desc>[WPE] Add API version to library soname and pkg-config files</short_desc>
          <delta_ts>2018-04-11 06:26:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>Other</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>178894</blocked>
    
    <blocked>179915</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1379796</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-08 14:32:37 -0800</bug_when>
    <thetext>Add API version to library soname and pkg-config files</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379797</commentid>
    <comment_count>1</comment_count>
      <attachid>328871</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-08 14:33:36 -0800</bug_when>
    <thetext>Created attachment 328871
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379799</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-08 14:37:18 -0800</bug_when>
    <thetext>(No r? because it&apos;s not properly tested yet.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1399523</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-02-15 10:53:44 -0800</bug_when>
    <thetext>* The include directory for public headers is already versioned

* I don&apos;t think the libexecdir for installed processes is versioned, need to confirm and fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1412514</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-04-06 16:37:50 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #3)
&gt; * I don&apos;t think the libexecdir for installed processes is versioned, need to
&gt; confirm and fix

Even better, the secondary processes are being installed into /usr/bin... I&apos;ll handle that in a separate bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1412987</commentid>
    <comment_count>5</comment_count>
      <attachid>328871</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-04-09 13:03:54 -0700</bug_when>
    <thetext>Comment on attachment 328871
Patch

Clearing flags on attachment: 328871

Committed r230449: &lt;https://trac.webkit.org/changeset/230449&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1412988</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-04-09 13:03:56 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1413653</commentid>
    <comment_count>7</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2018-04-11 06:26:54 -0700</bug_when>
    <thetext>(In reply to WebKit Commit Bot from comment #5)
&gt; Comment on attachment 328871 [details]
&gt; Patch
&gt; 
&gt; Clearing flags on attachment: 328871
&gt; 
&gt; Committed r230449: &lt;https://trac.webkit.org/changeset/230449&gt;

This broke the run-minibrowser script for wpe. Hope we can improve testing things in the future. A fix for this is already in bug 184357</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>328871</attachid>
            <date>2017-12-08 14:33:36 -0800</date>
            <delta_ts>2018-04-09 13:03:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-180608-20171208163335.patch</filename>
            <type>text/plain</type>
            <size>2626</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk4ZGY2MDczZGQ4NjEyNDhj
YzkwOWE2Yjk0YjZlNTk4Zjg4ZDZkMTguLmUwNzkzYWMxYWI3Y2U1ZDJmZjcyZjA4NDZmNjFkNmUz
NGYyNzZiN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTItMDggIE1pY2hhZWwg
Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdIEFkZCBB
UEkgdmVyc2lvbiB0byBsaWJyYXJ5IHNvbmFtZSBhbmQgcGtnLWNvbmZpZyBmaWxlcworICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNjA4CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybVdQRS5j
bWFrZToKKyAgICAgICAgKiB3cGUvd3BlLXdlYmtpdC5wYy5pbjoKKwogMjAxNy0xMi0wOCAgQ2hy
aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFByb2Nlc3NQb29sQ29uZmln
dXJhdGlvbjo6Y29weSgpIGZhaWxzIHRvIGNvcHkgdGhlIHNlcnZpY2Ugd29ya2VyIHBhdGgKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UgYi9Tb3VyY2UvV2ViS2l0
L1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IDJlMDkzY2Y2MGViMGE5MmViNWY5NTU3YTIyOGViZGFk
MDFjNWI0YmIuLmRhMmQwZWEwNTM2YjQ4YzhmNGFmMDVmZTE2NTExZjRjMjJkNjQ5ZDggMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIvU291cmNlL1dlYktp
dC9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtMSw2ICsxLDYgQEAKIGluY2x1ZGUoSW5zcGVjdG9yR1Jl
c291cmNlcy5jbWFrZSkKIAotc2V0KFdlYktpdF9PVVRQVVRfTkFNRSBXUEVXZWJLaXQpCitzZXQo
V2ViS2l0X09VVFBVVF9OQU1FIFdQRVdlYktpdC0ke1dQRV9BUElfVkVSU0lPTn0pCiBzZXQoV2Vi
S2l0X1dlYlByb2Nlc3NfT1VUUFVUX05BTUUgV1BFV2ViUHJvY2VzcykKIHNldChXZWJLaXRfTmV0
d29ya1Byb2Nlc3NfT1VUUFVUX05BTUUgV1BFTmV0d29ya1Byb2Nlc3MpCiBzZXQoV2ViS2l0X1N0
b3JhZ2VQcm9jZXNzX09VVFBVVF9OQU1FIFdQRVN0b3JhZ2VQcm9jZXNzKQpAQCAtOSw3ICs5LDcg
QEAgZmlsZShNQUtFX0RJUkVDVE9SWSAke0RFUklWRURfU09VUkNFU19XUEVfQVBJX0RJUn0pCiBm
aWxlKE1BS0VfRElSRUNUT1JZICR7Rk9SV0FSRElOR19IRUFERVJTX1dQRV9ESVJ9KQogZmlsZShN
QUtFX0RJUkVDVE9SWSAke0ZPUldBUkRJTkdfSEVBREVSU19XUEVfRVhURU5TSU9OX0RJUn0pCiAK
LWNvbmZpZ3VyZV9maWxlKHdwZS93cGUtd2Via2l0LnBjLmluICR7Q01BS0VfQklOQVJZX0RJUn0v
d3BlLXdlYmtpdC5wYyBAT05MWSkKK2NvbmZpZ3VyZV9maWxlKHdwZS93cGUtd2Via2l0LnBjLmlu
ICR7Q01BS0VfQklOQVJZX0RJUn0vd3BlLXdlYmtpdC0ke1dQRV9BUElfVkVSU0lPTn0ucGMgQE9O
TFkpCiAKIGFkZF9kZWZpbml0aW9ucygtRFdFQktJVDJfQ09NUElMQVRJT04pCiAKQEAgLTQ3OSw3
ICs0NzksNyBAQCBhZGRfbGlicmFyeShXUEVJbmplY3RlZEJ1bmRsZSBNT0RVTEUgIiR7V0VCS0lU
X0RJUn0vV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUAogQUREX1dFQktJVF9QUkVGSVhfSEVB
REVSKFdQRUluamVjdGVkQnVuZGxlKQogdGFyZ2V0X2xpbmtfbGlicmFyaWVzKFdQRUluamVjdGVk
QnVuZGxlIFdlYktpdCkKIAotaW5zdGFsbChGSUxFUyAiJHtDTUFLRV9CSU5BUllfRElSfS93cGUt
d2Via2l0LnBjIgoraW5zdGFsbChGSUxFUyAiJHtDTUFLRV9CSU5BUllfRElSfS93cGUtd2Via2l0
LSR7V1BFX0FQSV9WRVJTSU9OfS5wYyIKICAgICBERVNUSU5BVElPTiAiJHtDTUFLRV9JTlNUQUxM
X0xJQkRJUn0vcGtnY29uZmlnIgogICAgIENPTVBPTkVOVCAiRGV2ZWxvcG1lbnQiCiApCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dwZS93cGUtd2Via2l0LnBjLmluIGIvU291cmNlL1dlYktp
dC93cGUvd3BlLXdlYmtpdC5wYy5pbgppbmRleCBhNTc2OGQ2YWRlOGQ1OTI4MmFjNjNlOTczMzA5
N2VjOWYwYmZhNmFlLi40NDlhZDBmYzk0NGRiNTAyYjY1MGM5MGI2NGNkZTBmNzA1ZGE3MDk0IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3dwZS93cGUtd2Via2l0LnBjLmluCisrKyBiL1NvdXJj
ZS9XZWJLaXQvd3BlL3dwZS13ZWJraXQucGMuaW4KQEAgLTgsNSArOCw1IEBAIERlc2NyaXB0aW9u
OiBFbWJlZGRhYmxlIFdlYiBjb250ZW50IGVuZ2luZQogVVJMOiBodHRwczovL3dwZXdlYmtpdC5v
cmcKIFZlcnNpb246IEBQUk9KRUNUX1ZFUlNJT05ACiBSZXF1aXJlczogZ2xpYi0yLjAgbGlic291
cC0yLjQKLUxpYnM6IC1MJHtsaWJkaXJ9IC1sV1BFV2ViS2l0CitMaWJzOiAtTCR7bGliZGlyfSAt
bFdQRVdlYktpdC1AV1BFX0FQSV9WRVJTSU9OQAogQ2ZsYWdzOiAtSSR7aW5jbHVkZWRpcn0vd3Bl
LUBXUEVfQVBJX1ZFUlNJT05AIC1JJHtpbmNsdWRlZGlyfS93cGUtQFdQRV9BUElfVkVSU0lPTkAv
V1BFCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>