180604 2017-12-08 13:54:19 -0800 Remove unused code in WebPageGroup 2017-12-08 14:24:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen webkit-bug-importer youennf oldest_to_newest 1379762 0 achristensen 2017-12-08 13:54:19 -0800 Remove unused code in WebPageGroup 1379764 1 328865 achristensen 2017-12-08 13:54:35 -0800 Created attachment 328865 Patch 1379782 2 328865 youennf 2017-12-08 14:16:27 -0800 Comment on attachment 328865 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328865&action=review > Source/WebKit/UIProcess/WebPageGroup.cpp:129 > + return m_userContentController.get(); Might not need get() 1379786 3 achristensen 2017-12-08 14:23:33 -0800 http://trac.webkit.org/r225700 1379788 4 webkit-bug-importer 2017-12-08 14:24:28 -0800 <rdar://problem/35943468> 328865 2017-12-08 13:54:35 -0800 2017-12-08 14:16:27 -0800 Patch bug-180604-20171208135434.patch text/plain 4414 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjU2OTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEyLTA4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVudXNl ZCBjb2RlIGluIFdlYlBhZ2VHcm91cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgwNjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZUdyb3VwLmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViUGFnZUdyb3VwOjp1c2VyQ29udGVudENvbnRyb2xsZXIpOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlR3JvdXA6OmNyZWF0ZU5vbk51bGwpOiBEZWxldGVkLgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlR3JvdXA6OnByZWZlcmVuY2VzRGlkQ2hhbmdlKTogRGVsZXRlZC4KKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViUGFnZUdyb3VwLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBy b2Nlc3NQb29sLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OldlYlByb2Nl c3NQb29sKToKKwogMjAxNy0xMi0wOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIE1vZGVybml6ZSBBUElXZWJzaXRlRGF0YVN0b3JlLmggYW5k IFdlYlByb2Nlc3NQb29sLmgKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VH cm91cC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZUdy b3VwLmNwcAkocmV2aXNpb24gMjI1Njc5KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi UGFnZUdyb3VwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTksMTEgKzU5LDYgQEAgUmVmPFdlYlBh Z2VHcm91cD4gV2ViUGFnZUdyb3VwOjpjcmVhdGUoYwogICAgIHJldHVybiBhZG9wdFJlZigqbmV3 IFdlYlBhZ2VHcm91cChpZGVudGlmaWVyLCB2aXNpYmxlVG9JbmplY3RlZEJ1bmRsZSwgdmlzaWJs ZVRvSGlzdG9yeUNsaWVudCkpOwogfQogCi1SZWY8V2ViUGFnZUdyb3VwPiBXZWJQYWdlR3JvdXA6 OmNyZWF0ZU5vbk51bGwoY29uc3QgU3RyaW5nJiBpZGVudGlmaWVyLCBib29sIHZpc2libGVUb0lu amVjdGVkQnVuZGxlLCBib29sIHZpc2libGVUb0hpc3RvcnlDbGllbnQpCi17Ci0gICAgcmV0dXJu IGFkb3B0UmVmKCpuZXcgV2ViUGFnZUdyb3VwKGlkZW50aWZpZXIsIHZpc2libGVUb0luamVjdGVk QnVuZGxlLCB2aXNpYmxlVG9IaXN0b3J5Q2xpZW50KSk7Ci19Ci0KIFdlYlBhZ2VHcm91cCogV2Vi UGFnZUdyb3VwOjpnZXQodWludDY0X3QgcGFnZUdyb3VwSUQpCiB7CiAgICAgcmV0dXJuIHdlYlBh Z2VHcm91cE1hcCgpLmdldChwYWdlR3JvdXBJRCk7CkBAIC0xMjksMTcgKzEyNCw5IEBAIFdlYlBy ZWZlcmVuY2VzJiBXZWJQYWdlR3JvdXA6OnByZWZlcmVuY2UKICAgICByZXR1cm4gKm1fcHJlZmVy ZW5jZXM7CiB9CiAKLXZvaWQgV2ViUGFnZUdyb3VwOjpwcmVmZXJlbmNlc0RpZENoYW5nZSgpCi17 Ci0gICAgZm9yIChIYXNoU2V0PFdlYlBhZ2VQcm94eSo+OjppdGVyYXRvciBpdCA9IG1fcGFnZXMu YmVnaW4oKSwgZW5kID0gbV9wYWdlcy5lbmQoKTsgaXQgIT0gZW5kOyArK2l0KSB7Ci0gICAgICAg IFdlYlBhZ2VQcm94eSogcGFnZSA9ICppdDsKLSAgICAgICAgcGFnZS0+cHJlZmVyZW5jZXNEaWRD aGFuZ2UoKTsKLSAgICB9Ci19Ci0KIFdlYlVzZXJDb250ZW50Q29udHJvbGxlclByb3h5JiBXZWJQ YWdlR3JvdXA6OnVzZXJDb250ZW50Q29udHJvbGxlcigpCiB7Ci0gICAgcmV0dXJuICptX3VzZXJD b250ZW50Q29udHJvbGxlcjsKKyAgICByZXR1cm4gbV91c2VyQ29udGVudENvbnRyb2xsZXIuZ2V0 KCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2ViUGFnZUdyb3VwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViUGFnZUdyb3VwLmgJKHJldmlzaW9uIDIyNTY3OSkKKysrIFNvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYlBhZ2VHcm91cC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMyw4ICsyMyw3IEBACiAg KiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAotI2lmbmRlZiBXZWJQYWdl R3JvdXBfaAotI2RlZmluZSBXZWJQYWdlR3JvdXBfaAorI3ByYWdtYSBvbmNlCiAKICNpbmNsdWRl ICJBUElPYmplY3QuaCIKICNpbmNsdWRlICJXZWJQYWdlR3JvdXBEYXRhLmgiCkBAIC00NCw3ICs0 Myw3IEBAIGNsYXNzIFdlYlBhZ2VHcm91cCA6IHB1YmxpYyBBUEk6Ok9iamVjdEkKIHB1YmxpYzoK ICAgICBXZWJQYWdlR3JvdXAoY29uc3QgU3RyaW5nJiBpZGVudGlmaWVyID0gU3RyaW5nKCksIGJv b2wgdmlzaWJsZVRvSW5qZWN0ZWRCdW5kbGUgPSB0cnVlLCBib29sIHZpc2libGVUb0hpc3RvcnlD bGllbnQgPSB0cnVlKTsKICAgICBzdGF0aWMgUmVmPFdlYlBhZ2VHcm91cD4gY3JlYXRlKGNvbnN0 IFN0cmluZyYgaWRlbnRpZmllciA9IFN0cmluZygpLCBib29sIHZpc2libGVUb0luamVjdGVkQnVu ZGxlID0gdHJ1ZSwgYm9vbCB2aXNpYmxlVG9IaXN0b3J5Q2xpZW50ID0gdHJ1ZSk7Ci0gICAgc3Rh dGljIFJlZjxXZWJQYWdlR3JvdXA+IGNyZWF0ZU5vbk51bGwoY29uc3QgU3RyaW5nJiBpZGVudGlm aWVyID0gU3RyaW5nKCksIGJvb2wgdmlzaWJsZVRvSW5qZWN0ZWRCdW5kbGUgPSB0cnVlLCBib29s IHZpc2libGVUb0hpc3RvcnlDbGllbnQgPSB0cnVlKTsKKwogICAgIHN0YXRpYyBXZWJQYWdlR3Jv dXAqIGdldCh1aW50NjRfdCBwYWdlR3JvdXBJRCk7CiAKICAgICB2aXJ0dWFsIH5XZWJQYWdlR3Jv dXAoKTsKQEAgLTU4LDE3ICs1NywxNCBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHNldFByZWZlcmVu Y2VzKFdlYlByZWZlcmVuY2VzKik7CiAgICAgV2ViUHJlZmVyZW5jZXMmIHByZWZlcmVuY2VzKCkg Y29uc3Q7Ci0gICAgdm9pZCBwcmVmZXJlbmNlc0RpZENoYW5nZSgpOwogCiAgICAgV2ViVXNlckNv bnRlbnRDb250cm9sbGVyUHJveHkmIHVzZXJDb250ZW50Q29udHJvbGxlcigpOwogCiBwcml2YXRl OgogICAgIFdlYlBhZ2VHcm91cERhdGEgbV9kYXRhOwogICAgIFJlZlB0cjxXZWJQcmVmZXJlbmNl cz4gbV9wcmVmZXJlbmNlczsKLSAgICBSZWZQdHI8V2ViVXNlckNvbnRlbnRDb250cm9sbGVyUHJv eHk+IG1fdXNlckNvbnRlbnRDb250cm9sbGVyOworICAgIFJlZjxXZWJVc2VyQ29udGVudENvbnRy b2xsZXJQcm94eT4gbV91c2VyQ29udGVudENvbnRyb2xsZXI7CiAgICAgSGFzaFNldDxXZWJQYWdl UHJveHkqPiBtX3BhZ2VzOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Ci0KLSNlbmRpZiAv LyBXZWJQYWdlR3JvdXBfaApJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vz c1Bvb2wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nl c3NQb29sLmNwcAkocmV2aXNpb24gMjI1Njk0KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUHJvY2Vzc1Bvb2wuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTYsNyArMjE2LDcgQEAgc3Rh dGljIEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNhc2VJbnNlbnNpdAogCiBXZWJQcm9jZXNzUG9vbDo6 V2ViUHJvY2Vzc1Bvb2woQVBJOjpQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24mIGNvbmZpZ3VyYXRp b24pCiAgICAgOiBtX2NvbmZpZ3VyYXRpb24oY29uZmlndXJhdGlvbi5jb3B5KCkpCi0gICAgLCBt X2RlZmF1bHRQYWdlR3JvdXAoV2ViUGFnZUdyb3VwOjpjcmVhdGVOb25OdWxsKCkpCisgICAgLCBt X2RlZmF1bHRQYWdlR3JvdXAoV2ViUGFnZUdyb3VwOjpjcmVhdGUoKSkKICAgICAsIG1faW5qZWN0 ZWRCdW5kbGVDbGllbnQoc3RkOjptYWtlX3VuaXF1ZTxBUEk6OkluamVjdGVkQnVuZGxlQ2xpZW50 PigpKQogICAgICwgbV9hdXRvbWF0aW9uQ2xpZW50KHN0ZDo6bWFrZV91bmlxdWU8QVBJOjpBdXRv bWF0aW9uQ2xpZW50PigpKQogICAgICwgbV9kb3dubG9hZENsaWVudChzdGQ6Om1ha2VfdW5pcXVl PEFQSTo6RG93bmxvYWRDbGllbnQ+KCkpCg==