180587 2017-12-08 10:42:32 -0800 Improve error handling in RegistrationDatabase 2017-12-08 11:02:29 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson commit-queue webkit-bug-importer oldest_to_newest 1379634 0 cdumez 2017-12-08 10:42:32 -0800 Improve error handling in RegistrationDatabase. 1379635 1 328832 cdumez 2017-12-08 10:43:17 -0800 Created attachment 328832 Patch 1379638 2 328832 beidson 2017-12-08 10:45:06 -0800 Comment on attachment 328832 Patch I'm doing this differently. 1379642 3 beidson 2017-12-08 10:50:58 -0800 Sorry to clarify - I am fixing this in the bugzilla in which it was reported https://bugs.webkit.org/show_bug.cgi?id=180518 Not sure why we need another bug open. 1379647 4 beidson 2017-12-08 10:57:34 -0800 There's disagreement in the more efficient way of doing this, so we should land this one instead and revisit when we don't have other high priority tasks 1379651 5 328832 cdumez 2017-12-08 11:01:08 -0800 Comment on attachment 328832 Patch Clearing flags on attachment: 328832 Committed r225685: <https://trac.webkit.org/changeset/225685> 1379652 6 cdumez 2017-12-08 11:01:10 -0800 All reviewed patches have been landed. Closing bug. 1379654 7 webkit-bug-importer 2017-12-08 11:02:29 -0800 <rdar://problem/35938450> 328832 2017-12-08 10:43:17 -0800 2017-12-08 11:01:08 -0800 Patch bug-180587-20171208104316.patch text/plain 4355 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ1YzgxZDZhODU5YzNk ZmQ3NGU0MWY3ZWFiOGIwYzAxNDBkMDRmNy4uMGY1NGI5NjE3ZTc1NzhmZjE1NDEyYmRkYmFkZjkx NTE1MDg5MjhiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTEyLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wcm92ZSBlcnJvciBoYW5k bGluZyBpbiBSZWdpc3RyYXRpb25EYXRhYmFzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1JlZ2lzdHJhdGlv bkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlZ2lzdHJhdGlvbkRhdGFiYXNlOjpv cGVuU1FMaXRlRGF0YWJhc2UpOgorICAgICAgICAoV2ViQ29yZTo6UmVnaXN0cmF0aW9uRGF0YWJh c2U6OmRvUHVzaENoYW5nZXMpOgorCiAyMDE3LTEyLTA3ICBEYXJpbiBBZGxlciAgPGRhcmluQGFw cGxlLmNvbT4KIAogICAgICAgICBTaW1wbGlmeSBhbmQgc3RyZWFtbGluZSBzb21lIENvbG9yLXJl bGF0ZWQgY29kZSB0byBwcmVwYXJlIGZvciBzb21lIENvbG9yL0V4dGVuZGVkQ29sb3Igd29yawpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3Ry YXRpb25EYXRhYmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVy L1JlZ2lzdHJhdGlvbkRhdGFiYXNlLmNwcAppbmRleCA2NjE1YTRhNTRkMWI5N2I2Y2JjMGY1MWQx NTQ2MTIyYjRhZWU1MTdkLi4yN2RlOTRlNDhiMGUxNmUwOWY2ZDQ5OTQwOTIwNDY0NzBlOTBmNzIz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1JlZ2lz dHJhdGlvbkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uv c2VydmVyL1JlZ2lzdHJhdGlvbkRhdGFiYXNlLmNwcApAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1 ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlICJSZWdpc3RyYXRpb25TdG9yZS5oIgogI2luY2x1ZGUg IlNRTGl0ZURhdGFiYXNlLmgiCisjaW5jbHVkZSAiU1FMaXRlRmlsZVN5c3RlbS5oIgogI2luY2x1 ZGUgIlNRTGl0ZVN0YXRlbWVudC5oIgogI2luY2x1ZGUgIlNRTGl0ZVRyYW5zYWN0aW9uLmgiCiAj aW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KQEAgLTg5LDEwICs5MCwxMiBAQCB2b2lkIFJlZ2lz dHJhdGlvbkRhdGFiYXNlOjpvcGVuU1FMaXRlRGF0YWJhc2UoY29uc3QgU3RyaW5nJiBmdWxsRmls ZW5hbWUpCiAgICAgU3RyaW5nIGVycm9yTWVzc2FnZTsKICAgICBhdXRvIHNjb3BlRXhpdCA9IG1h a2VTY29wZUV4aXQoWyYsIGVycm9yTWVzc2FnZSA9ICZlcnJvck1lc3NhZ2VdIHsKICAgICAgICAg QVNTRVJUX1VOVVNFRChlcnJvck1lc3NhZ2UsICFlcnJvck1lc3NhZ2UtPmlzTnVsbCgpKTsKLSAg ICAgICAgTE9HX0VSUk9SKCJGYWlsZWQgdG8gb3BlbiBTZXJ2aWNlIFdvcmtlciByZWdpc3RyYXRp b24gZGF0YWJhc2U6ICVzIiwgZXJyb3JNZXNzYWdlLT51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAg UkVMRUFTRV9MT0dfRVJST1IoU2VydmljZVdvcmtlciwgIkZhaWxlZCB0byBvcGVuIFNlcnZpY2Ug V29ya2VyIHJlZ2lzdHJhdGlvbiBkYXRhYmFzZTogJXMiLCBlcnJvck1lc3NhZ2UtPnV0ZjgoKS5k YXRhKCkpOwogICAgICAgICBtX2RhdGFiYXNlID0gbnVsbHB0cjsKICAgICAgICAgcG9zdFRhc2tS ZXBseShjcmVhdGVDcm9zc1RocmVhZFRhc2soKnRoaXMsICZSZWdpc3RyYXRpb25EYXRhYmFzZTo6 ZGF0YWJhc2VGYWlsZWRUb09wZW4pKTsKICAgICB9KTsKKworICAgIFNRTGl0ZUZpbGVTeXN0ZW06 OmVuc3VyZURhdGFiYXNlRGlyZWN0b3J5RXhpc3RzKG1fZGF0YWJhc2VEaXJlY3RvcnkuaXNvbGF0 ZWRDb3B5KCkpOwogICAgIAogICAgIG1fZGF0YWJhc2UgPSBzdGQ6Om1ha2VfdW5pcXVlPFNRTGl0 ZURhdGFiYXNlPigpOwogICAgIGlmICghbV9kYXRhYmFzZS0+b3BlbihmdWxsRmlsZW5hbWUpKSB7 CkBAIC0yMDYsMTQgKzIwOSwxNSBAQCB2b2lkIFJlZ2lzdHJhdGlvbkRhdGFiYXNlOjpwdXNoQ2hh bmdlcyhWZWN0b3I8U2VydmljZVdvcmtlckNvbnRleHREYXRhPiYmIGRhdGFzKQogCiB2b2lkIFJl Z2lzdHJhdGlvbkRhdGFiYXNlOjpkb1B1c2hDaGFuZ2VzKFZlY3RvcjxTZXJ2aWNlV29ya2VyQ29u dGV4dERhdGE+JiYgZGF0YXMpCiB7Ci0gICAgQVNTRVJUKG1fZGF0YWJhc2UpOworICAgIGlmICgh bV9kYXRhYmFzZSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgU1FMaXRlVHJhbnNhY3Rpb24gdHJh bnNhY3Rpb24oKm1fZGF0YWJhc2UpOwogICAgIHRyYW5zYWN0aW9uLmJlZ2luKCk7CiAKICAgICBT UUxpdGVTdGF0ZW1lbnQgc3FsKCptX2RhdGFiYXNlLCBBU0NJSUxpdGVyYWwoIklOU0VSVCBJTlRP IFJlY29yZHMgVkFMVUVTICg/LCA/LCA/LCA/LCA/LCA/LCA/LCA/LCA/KSIpKTsKICAgICBpZiAo c3FsLnByZXBhcmUoKSAhPSBTUUxJVEVfT0spIHsKLSAgICAgICAgTE9HX0VSUk9SKCJGYWlsZWQg dG8gcHJlcGFyZSBzdGF0ZW1lbnQgdG8gc3RvcmUgcmVnaXN0cmF0aW9uIGRhdGEgaW50byByZWNv cmRzIHRhYmxlICglaSkgLSAlcyIsIG1fZGF0YWJhc2UtPmxhc3RFcnJvcigpLCBtX2RhdGFiYXNl LT5sYXN0RXJyb3JNc2coKSk7CisgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFNlcnZpY2VXb3Jr ZXIsICJGYWlsZWQgdG8gcHJlcGFyZSBzdGF0ZW1lbnQgdG8gc3RvcmUgcmVnaXN0cmF0aW9uIGRh dGEgaW50byByZWNvcmRzIHRhYmxlICglaSkgLSAlcyIsIG1fZGF0YWJhc2UtPmxhc3RFcnJvcigp LCBtX2RhdGFiYXNlLT5sYXN0RXJyb3JNc2coKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAK QEAgLTIyMyw3ICsyMjcsNyBAQCB2b2lkIFJlZ2lzdHJhdGlvbkRhdGFiYXNlOjpkb1B1c2hDaGFu Z2VzKFZlY3RvcjxTZXJ2aWNlV29ya2VyQ29udGV4dERhdGE+JiYgZGF0YQogICAgICAgICAgICAg aWYgKHNxbC5wcmVwYXJlKCkgIT0gU1FMSVRFX09LCiAgICAgICAgICAgICAgICAgfHwgc3FsLmJp bmRUZXh0KDEsIGRhdGEucmVnaXN0cmF0aW9uLmtleS50b0RhdGFiYXNlS2V5KCkpICE9IFNRTElU RV9PSwogICAgICAgICAgICAgICAgIHx8IHNxbC5zdGVwKCkgIT0gU1FMSVRFX0RPTkUpIHsKLSAg ICAgICAgICAgICAgICBMT0dfRVJST1IoIkZhaWxlZCB0byByZW1vdmUgcmVnaXN0cmF0aW9uIGRh dGEgZnJvbSByZWNvcmRzIHRhYmxlICglaSkgLSAlcyIsIG1fZGF0YWJhc2UtPmxhc3RFcnJvcigp LCBtX2RhdGFiYXNlLT5sYXN0RXJyb3JNc2coKSk7CisgICAgICAgICAgICAgICAgUkVMRUFTRV9M T0dfRVJST1IoU2VydmljZVdvcmtlciwgIkZhaWxlZCB0byByZW1vdmUgcmVnaXN0cmF0aW9uIGRh dGEgZnJvbSByZWNvcmRzIHRhYmxlICglaSkgLSAlcyIsIG1fZGF0YWJhc2UtPmxhc3RFcnJvcigp LCBtX2RhdGFiYXNlLT5sYXN0RXJyb3JNc2coKSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICAgICAgfQogCkBAIC0yNDAsNyArMjQ0LDcgQEAgdm9pZCBSZWdpc3RyYXRpb25EYXRh YmFzZTo6ZG9QdXNoQ2hhbmdlcyhWZWN0b3I8U2VydmljZVdvcmtlckNvbnRleHREYXRhPiYmIGRh dGEKICAgICAgICAgICAgIHx8IHNxbC5iaW5kVGV4dCg4LCBkYXRhLnNjcmlwdCkgIT0gU1FMSVRF X09LCiAgICAgICAgICAgICB8fCBzcWwuYmluZFRleHQoOSwgd29ya2VyVHlwZVRvU3RyaW5nKGRh dGEud29ya2VyVHlwZSkpICE9IFNRTElURV9PSwogICAgICAgICAgICAgfHwgc3FsLnN0ZXAoKSAh PSBTUUxJVEVfRE9ORSkgewotICAgICAgICAgICAgTE9HX0VSUk9SKCJGYWlsZWQgdG8gc3RvcmUg cmVnaXN0cmF0aW9uIGRhdGEgaW50byByZWNvcmRzIHRhYmxlICglaSkgLSAlcyIsIG1fZGF0YWJh c2UtPmxhc3RFcnJvcigpLCBtX2RhdGFiYXNlLT5sYXN0RXJyb3JNc2coKSk7CisgICAgICAgICAg ICBSRUxFQVNFX0xPR19FUlJPUihTZXJ2aWNlV29ya2VyLCAiRmFpbGVkIHRvIHN0b3JlIHJlZ2lz dHJhdGlvbiBkYXRhIGludG8gcmVjb3JkcyB0YWJsZSAoJWkpIC0gJXMiLCBtX2RhdGFiYXNlLT5s YXN0RXJyb3IoKSwgbV9kYXRhYmFzZS0+bGFzdEVycm9yTXNnKCkpOwogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICB9CiAgICAgfQo=