180545 2017-12-07 13:13:26 -0800 Web Inspector: Fix style in remote inspector classes 2017-12-07 16:23:00 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue ews-watchlist inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam youennf oldest_to_newest 1379245 0 joepeck 2017-12-07 13:13:26 -0800 Fix style in remote inspector classes Make some things `const` and use `final` instead of `override` when possible. 1379248 1 328726 joepeck 2017-12-07 13:15:16 -0800 Created attachment 328726 [PATCH] Proposed Fix 1379250 2 328726 youennf 2017-12-07 13:18:41 -0800 Comment on attachment 328726 [PATCH] Proposed Fix Can you put some of the final methods as private instead of public? 1379337 3 joepeck 2017-12-07 15:59:48 -0800 We probably can, but that rarely makes sense to me, especially if it was public in a parent class. I know I've seen this pattern elsewhere though, maybe someone can explain the advantage of that to me. 1379339 4 youennf 2017-12-07 16:12:47 -0800 We usually try to restrict the public methods to the minimum. With this pattern, if B derives from A and C is the method being overridden, C can only be called in the context of code using A references/pointers. There may be valid cases for which C can be called from B classes in which case B::C can be made public, but this does not seem to happen a lot. 1379350 5 328726 commit-queue 2017-12-07 16:22:59 -0800 Comment on attachment 328726 [PATCH] Proposed Fix Clearing flags on attachment: 328726 Committed r225654: <https://trac.webkit.org/changeset/225654> 1379351 6 commit-queue 2017-12-07 16:23:00 -0800 All reviewed patches have been landed. Closing bug. 328726 2017-12-07 13:15:16 -0800 2017-12-07 16:22:59 -0800 [PATCH] Proposed Fix style-1.patch text/plain 7956 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRlYmIxYzM2YjQwLi45ZGJhMjRlODQyNiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMTItMDcgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBGaXggc3R5bGUgaW4gcmVtb3RlIGluc3BlY3RvciBjbGFzc2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA1NDUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9yZW1vdGUvUmVtb3Rl Q29udHJvbGxhYmxlVGFyZ2V0Lmg6CisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJ bnNwZWN0aW9uVGFyZ2V0Lmg6CisgICAgICAgICogcnVudGltZS9KU0dsb2JhbE9iamVjdERlYnVn Z2FibGUuaDoKKwogMjAxNy0xMi0wNyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgW1JlLWxhbmRpbmcgcjIyNTYyMF0gUmVmYWN0b3Jpbmc6IFJlbmFtZSBTY3JhbWJs ZWRQdHIgdG8gUG9pc29uZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5z cGVjdG9yL3JlbW90ZS9SZW1vdGVDb250cm9sbGFibGVUYXJnZXQuaCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUNvbnRyb2xsYWJsZVRhcmdldC5oCmluZGV4 IDE4MmM1MjQ2MzQ0Li44YWI2ZDc2Yjc5YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlQ29udHJvbGxhYmxlVGFyZ2V0LmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlQ29udHJvbGxhYmxlVGFy Z2V0LmgKQEAgLTU4LDEwICs1OCwxMSBAQCBwdWJsaWM6CiAKICNpZiBVU0UoQ0YpCiAgICAgLy8g VGhlIGRpc3BhdGNoIGJsb2NrIHdpbGwgYmUgc2NoZWR1bGVkIG9uIGEgZ2xvYmFsIHJ1biBsb29w IGlmIG51bGwgaXMgcmV0dXJuZWQuCi0gICAgdmlydHVhbCBDRlJ1bkxvb3BSZWYgdGFyZ2V0UnVu TG9vcCgpIHsgcmV0dXJuIG51bGxwdHI7IH0KKyAgICB2aXJ0dWFsIENGUnVuTG9vcFJlZiB0YXJn ZXRSdW5Mb29wKCkgY29uc3QgeyByZXR1cm4gbnVsbHB0cjsgfQogI2VuZGlmCisKIHByaXZhdGU6 Ci0gICAgdW5zaWduZWQgbV9pZGVudGlmaWVyIHswfTsKKyAgICB1bnNpZ25lZCBtX2lkZW50aWZp ZXIgeyAwIH07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBJbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rpb25UYXJn ZXQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3Bl Y3Rpb25UYXJnZXQuaAppbmRleCA4MWNmZTAwNjgzMy4uN2E5MzllNTkzY2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rpb25U YXJnZXQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1v dGVJbnNwZWN0aW9uVGFyZ2V0LmgKQEAgLTQyLDcgKzQyLDcgQEAgcHVibGljOgogICAgIHZvaWQg c2V0UmVtb3RlRGVidWdnaW5nQWxsb3dlZChib29sKTsKIAogI2lmIFVTRShDRikKLSAgICBDRlJ1 bkxvb3BSZWYgdGFyZ2V0UnVuTG9vcCgpIG92ZXJyaWRlIHsgcmV0dXJuIG1fcnVuTG9vcC5nZXQo KTsgfQorICAgIENGUnVuTG9vcFJlZiB0YXJnZXRSdW5Mb29wKCkgY29uc3QgZmluYWwgeyByZXR1 cm4gbV9ydW5Mb29wLmdldCgpOyB9CiAgICAgdm9pZCBzZXRUYXJnZXRSdW5Mb29wKENGUnVuTG9v cFJlZiBydW5Mb29wKSB7IG1fcnVuTG9vcCA9IHJ1bkxvb3A7IH0KICNlbmRpZgogCkBAIC01Nyw5 ICs1NywxMCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHVucGF1c2VGb3JJbml0aWFsaXpl ZEluc3BlY3RvcigpOwogCiAgICAgLy8gUmVtb3RlQ29udHJvbGxhYmxlVGFyZ2V0IG92ZXJyaWRl cy4KLSAgICBib29sIHJlbW90ZUNvbnRyb2xBbGxvd2VkKCkgY29uc3Qgb3ZlcnJpZGU7CisgICAg Ym9vbCByZW1vdGVDb250cm9sQWxsb3dlZCgpIGNvbnN0IGZpbmFsOworCiBwcml2YXRlOgotICAg IGJvb2wgbV9hbGxvd2VkIHtmYWxzZX07CisgICAgYm9vbCBtX2FsbG93ZWQgeyBmYWxzZSB9Owog I2lmIFVTRShDRikKICAgICBSZXRhaW5QdHI8Q0ZSdW5Mb29wUmVmPiBtX3J1bkxvb3A7CiAjZW5k aWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2Jq ZWN0RGVidWdnYWJsZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxP YmplY3REZWJ1Z2dhYmxlLmgKaW5kZXggM2ExMjhmZDBiYjYuLjA1Nzk5MDk0ZmQ2IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdERlYnVnZ2Fi bGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdERl YnVnZ2FibGUuaApAQCAtNDYsMTcgKzQ2LDE3IEBAIHB1YmxpYzoKICAgICBKU0dsb2JhbE9iamVj dERlYnVnZ2FibGUoSlNHbG9iYWxPYmplY3QmKTsKICAgICB+SlNHbG9iYWxPYmplY3REZWJ1Z2dh YmxlKCkgeyB9CiAKLSAgICBJbnNwZWN0b3I6OlJlbW90ZUNvbnRyb2xsYWJsZVRhcmdldDo6VHlw ZSB0eXBlKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gSW5zcGVjdG9yOjpSZW1vdGVDb250cm9s bGFibGVUYXJnZXQ6OlR5cGU6OkphdmFTY3JpcHQ7IH0KKyAgICBJbnNwZWN0b3I6OlJlbW90ZUNv bnRyb2xsYWJsZVRhcmdldDo6VHlwZSB0eXBlKCkgY29uc3QgZmluYWwgeyByZXR1cm4gSW5zcGVj dG9yOjpSZW1vdGVDb250cm9sbGFibGVUYXJnZXQ6OlR5cGU6OkphdmFTY3JpcHQ7IH0KIAotICAg IFN0cmluZyBuYW1lKCkgY29uc3Qgb3ZlcnJpZGU7Ci0gICAgYm9vbCBoYXNMb2NhbERlYnVnZ2Vy KCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gZmFsc2U7IH0KKyAgICBTdHJpbmcgbmFtZSgpIGNv bnN0IGZpbmFsOworICAgIGJvb2wgaGFzTG9jYWxEZWJ1Z2dlcigpIGNvbnN0IGZpbmFsIHsgcmV0 dXJuIGZhbHNlOyB9CiAKLSAgICB2b2lkIGNvbm5lY3QoSW5zcGVjdG9yOjpGcm9udGVuZENoYW5u ZWwqLCBib29sIGlzQXV0b21hdGljQ29ubmVjdGlvbiA9IGZhbHNlLCBib29sIGltbWVkaWF0ZWx5 UGF1c2UgPSBmYWxzZSkgb3ZlcnJpZGU7Ci0gICAgdm9pZCBkaXNjb25uZWN0KEluc3BlY3Rvcjo6 RnJvbnRlbmRDaGFubmVsKikgb3ZlcnJpZGU7Ci0gICAgdm9pZCBkaXNwYXRjaE1lc3NhZ2VGcm9t UmVtb3RlKGNvbnN0IFN0cmluZyYgbWVzc2FnZSkgb3ZlcnJpZGU7CisgICAgdm9pZCBjb25uZWN0 KEluc3BlY3Rvcjo6RnJvbnRlbmRDaGFubmVsKiwgYm9vbCBpc0F1dG9tYXRpY0Nvbm5lY3Rpb24g PSBmYWxzZSwgYm9vbCBpbW1lZGlhdGVseVBhdXNlID0gZmFsc2UpIGZpbmFsOworICAgIHZvaWQg ZGlzY29ubmVjdChJbnNwZWN0b3I6OkZyb250ZW5kQ2hhbm5lbCopIGZpbmFsOworICAgIHZvaWQg ZGlzcGF0Y2hNZXNzYWdlRnJvbVJlbW90ZShjb25zdCBTdHJpbmcmIG1lc3NhZ2UpIGZpbmFsOwog Ci0gICAgYm9vbCBhdXRvbWF0aWNJbnNwZWN0aW9uQWxsb3dlZCgpIGNvbnN0IG92ZXJyaWRlIHsg cmV0dXJuIHRydWU7IH0KLSAgICB2b2lkIHBhdXNlV2FpdGluZ0ZvckF1dG9tYXRpY0luc3BlY3Rp b24oKSBvdmVycmlkZTsKKyAgICBib29sIGF1dG9tYXRpY0luc3BlY3Rpb25BbGxvd2VkKCkgY29u c3QgZmluYWwgeyByZXR1cm4gdHJ1ZTsgfQorICAgIHZvaWQgcGF1c2VXYWl0aW5nRm9yQXV0b21h dGljSW5zcGVjdGlvbigpIGZpbmFsOwogCiBwcml2YXRlOgogICAgIEpTR2xvYmFsT2JqZWN0JiBt X2dsb2JhbE9iamVjdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1YmM3MTQ2YWQwOC4uMWI1MDkyMWNhZjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0xMi0wNyAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEZpeCBzdHlsZSBp biByZW1vdGUgaW5zcGVjdG9yIGNsYXNzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MDU0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGFnZS9QYWdlRGVidWdnYWJsZS5oOgorICAgICAgICAqIHdv cmtlcnMvc2VydmljZS9jb250ZXh0L1NlcnZpY2VXb3JrZXJEZWJ1Z2dhYmxlLmg6CisKIDIwMTct MTItMDcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBT ZXJ2aWNlV29ya2VyIEluc3BlY3RvcjogVXNlIHRoZSBTVydzIHNjb3BlIHVybCBmb3IgdGhlIHJl bW90ZSBpbnNwZWN0aW9uIHRhcmdldCBtZXRhZGF0YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9QYWdlRGVidWdnYWJsZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlRGVidWdn YWJsZS5oCmluZGV4IDBkZjNmNThhNTQyLi4xNmZiNGI4OGIwMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9QYWdlRGVidWdnYWJsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv UGFnZURlYnVnZ2FibGUuaApAQCAtNDEsMTggKzQxLDE4IEBAIHB1YmxpYzoKICAgICBQYWdlRGVi dWdnYWJsZShQYWdlJik7CiAgICAgflBhZ2VEZWJ1Z2dhYmxlKCkgPSBkZWZhdWx0OwogCi0gICAg SW5zcGVjdG9yOjpSZW1vdGVDb250cm9sbGFibGVUYXJnZXQ6OlR5cGUgdHlwZSgpIGNvbnN0IG92 ZXJyaWRlIHsgcmV0dXJuIEluc3BlY3Rvcjo6UmVtb3RlQ29udHJvbGxhYmxlVGFyZ2V0OjpUeXBl OjpXZWI7IH0KKyAgICBJbnNwZWN0b3I6OlJlbW90ZUNvbnRyb2xsYWJsZVRhcmdldDo6VHlwZSB0 eXBlKCkgY29uc3QgZmluYWwgeyByZXR1cm4gSW5zcGVjdG9yOjpSZW1vdGVDb250cm9sbGFibGVU YXJnZXQ6OlR5cGU6OldlYjsgfQogCi0gICAgU3RyaW5nIG5hbWUoKSBjb25zdCBvdmVycmlkZTsK LSAgICBTdHJpbmcgdXJsKCkgY29uc3Qgb3ZlcnJpZGU7Ci0gICAgYm9vbCBoYXNMb2NhbERlYnVn Z2VyKCkgY29uc3Qgb3ZlcnJpZGU7CisgICAgU3RyaW5nIG5hbWUoKSBjb25zdCBmaW5hbDsKKyAg ICBTdHJpbmcgdXJsKCkgY29uc3QgZmluYWw7CisgICAgYm9vbCBoYXNMb2NhbERlYnVnZ2VyKCkg Y29uc3QgZmluYWw7CiAKLSAgICB2b2lkIGNvbm5lY3QoSW5zcGVjdG9yOjpGcm9udGVuZENoYW5u ZWwqLCBib29sIGlzQXV0b21hdGljQ29ubmVjdGlvbiA9IGZhbHNlLCBib29sIGltbWVkaWF0ZWx5 UGF1c2UgPSBmYWxzZSkgb3ZlcnJpZGU7Ci0gICAgdm9pZCBkaXNjb25uZWN0KEluc3BlY3Rvcjo6 RnJvbnRlbmRDaGFubmVsKikgb3ZlcnJpZGU7Ci0gICAgdm9pZCBkaXNwYXRjaE1lc3NhZ2VGcm9t UmVtb3RlKGNvbnN0IFN0cmluZyYgbWVzc2FnZSkgb3ZlcnJpZGU7Ci0gICAgdm9pZCBzZXRJbmRp Y2F0aW5nKGJvb2wpIG92ZXJyaWRlOworICAgIHZvaWQgY29ubmVjdChJbnNwZWN0b3I6OkZyb250 ZW5kQ2hhbm5lbCosIGJvb2wgaXNBdXRvbWF0aWNDb25uZWN0aW9uID0gZmFsc2UsIGJvb2wgaW1t ZWRpYXRlbHlQYXVzZSA9IGZhbHNlKSBmaW5hbDsKKyAgICB2b2lkIGRpc2Nvbm5lY3QoSW5zcGVj dG9yOjpGcm9udGVuZENoYW5uZWwqKSBmaW5hbDsKKyAgICB2b2lkIGRpc3BhdGNoTWVzc2FnZUZy b21SZW1vdGUoY29uc3QgU3RyaW5nJiBtZXNzYWdlKSBmaW5hbDsKKyAgICB2b2lkIHNldEluZGlj YXRpbmcoYm9vbCkgZmluYWw7CiAKLSAgICBTdHJpbmcgbmFtZU92ZXJyaWRlKCkgY29uc3QgeyBy ZXR1cm4gbV9uYW1lT3ZlcnJpZGU7IH0KKyAgICBjb25zdCBTdHJpbmcmIG5hbWVPdmVycmlkZSgp IGNvbnN0IHsgcmV0dXJuIG1fbmFtZU92ZXJyaWRlOyB9CiAgICAgdm9pZCBzZXROYW1lT3ZlcnJp ZGUoY29uc3QgU3RyaW5nJik7CiAKIHByaXZhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS93b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TZXJ2aWNlV29ya2VyRGVidWdnYWJsZS5oIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU2VydmljZVdvcmtlckRlYnVnZ2Fi bGUuaAppbmRleCBjMmRjZDYxODUyOC4uZGJhYjcxNzg0NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3dvcmtlcnMvc2VydmljZS9jb250ZXh0L1NlcnZpY2VXb3JrZXJEZWJ1Z2dhYmxlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU2VydmljZVdvcmtl ckRlYnVnZ2FibGUuaApAQCAtNDMsMTUgKzQzLDE1IEBAIHB1YmxpYzoKICAgICBTZXJ2aWNlV29y a2VyRGVidWdnYWJsZShTZXJ2aWNlV29ya2VyVGhyZWFkUHJveHkmLCBjb25zdCBTZXJ2aWNlV29y a2VyQ29udGV4dERhdGEmKTsKICAgICB+U2VydmljZVdvcmtlckRlYnVnZ2FibGUoKSA9IGRlZmF1 bHQ7CiAKLSAgICBJbnNwZWN0b3I6OlJlbW90ZUNvbnRyb2xsYWJsZVRhcmdldDo6VHlwZSB0eXBl KCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gSW5zcGVjdG9yOjpSZW1vdGVDb250cm9sbGFibGVU YXJnZXQ6OlR5cGU6OlNlcnZpY2VXb3JrZXI7IH0KKyAgICBJbnNwZWN0b3I6OlJlbW90ZUNvbnRy b2xsYWJsZVRhcmdldDo6VHlwZSB0eXBlKCkgY29uc3QgZmluYWwgeyByZXR1cm4gSW5zcGVjdG9y OjpSZW1vdGVDb250cm9sbGFibGVUYXJnZXQ6OlR5cGU6OlNlcnZpY2VXb3JrZXI7IH0KIAotICAg IFN0cmluZyBuYW1lKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gQVNDSUlMaXRlcmFsKCJTZXJ2 aWNlV29ya2VyIik7IH0KLSAgICBTdHJpbmcgdXJsKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4g bV9zY29wZVVSTDsgfQotICAgIGJvb2wgaGFzTG9jYWxEZWJ1Z2dlcigpIGNvbnN0IG92ZXJyaWRl IHsgcmV0dXJuIGZhbHNlOyB9CisgICAgU3RyaW5nIG5hbWUoKSBjb25zdCBmaW5hbCB7IHJldHVy biBBU0NJSUxpdGVyYWwoIlNlcnZpY2VXb3JrZXIiKTsgfQorICAgIFN0cmluZyB1cmwoKSBjb25z dCBmaW5hbCB7IHJldHVybiBtX3Njb3BlVVJMOyB9CisgICAgYm9vbCBoYXNMb2NhbERlYnVnZ2Vy KCkgY29uc3QgZmluYWwgeyByZXR1cm4gZmFsc2U7IH0KIAotICAgIHZvaWQgY29ubmVjdChJbnNw ZWN0b3I6OkZyb250ZW5kQ2hhbm5lbCosIGJvb2wgaXNBdXRvbWF0aWNDb25uZWN0aW9uID0gZmFs c2UsIGJvb2wgaW1tZWRpYXRlbHlQYXVzZSA9IGZhbHNlKSBvdmVycmlkZTsKLSAgICB2b2lkIGRp c2Nvbm5lY3QoSW5zcGVjdG9yOjpGcm9udGVuZENoYW5uZWwqKSBvdmVycmlkZTsKLSAgICB2b2lk IGRpc3BhdGNoTWVzc2FnZUZyb21SZW1vdGUoY29uc3QgU3RyaW5nJiBtZXNzYWdlKSBvdmVycmlk ZTsKKyAgICB2b2lkIGNvbm5lY3QoSW5zcGVjdG9yOjpGcm9udGVuZENoYW5uZWwqLCBib29sIGlz QXV0b21hdGljQ29ubmVjdGlvbiA9IGZhbHNlLCBib29sIGltbWVkaWF0ZWx5UGF1c2UgPSBmYWxz ZSkgZmluYWw7CisgICAgdm9pZCBkaXNjb25uZWN0KEluc3BlY3Rvcjo6RnJvbnRlbmRDaGFubmVs KikgZmluYWw7CisgICAgdm9pZCBkaXNwYXRjaE1lc3NhZ2VGcm9tUmVtb3RlKGNvbnN0IFN0cmlu ZyYgbWVzc2FnZSkgZmluYWw7CiAKIHByaXZhdGU6CiAgICAgU2VydmljZVdvcmtlclRocmVhZFBy b3h5JiBtX3NlcnZpY2VXb3JrZXJUaHJlYWRQcm94eTsK