180533 2017-12-07 09:57:26 -0800 [GTK] WebInspectorProxyClient needs a virtual destructor 2017-12-08 08:28:53 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1379131 0 mcatanzaro 2017-12-07 09:57:26 -0800 Until we get an asan bot, we're doing as much astrology as programming. From bug #179914: ==19318==ERROR: AddressSanitizer: new-delete-type-mismatch on 0x60200029b7b0 in thread T0: object passed to delete has wrong type: size of the allocated type: 16 bytes; size of the deallocated type: 8 bytes. #0 0x7fcb55b356d8 in operator delete(void*, unsigned long) (/usr/lib64/libasan.so.4+0xe16d8) #1 0x7fcb53b3b572 in _WebKitWebInspectorPrivate::~_WebKitWebInspectorPrivate() ..../webkit.master/Source/WebKit/UIProcess/API/gtk/WebKitWebInspector.cpp:83 #2 0x7fcb53b3b572 in webkit_web_inspector_finalize ..../webkit.master/Source/WebKit/UIProcess/API/gtk/WebKitWebInspector.cpp:92 #3 0x7fcb51dc0688 in g_object_unref (/lib64/libgobject-2.0.so.0+0x14688) #4 0x7fcb53b28d92 in void WTF::derefGPtr<_WebKitWebInspector>(_WebKitWebInspector*) ..../webkit.master/Source/WTF/wtf/glib/GRefPtr.h:250 #5 0x7fcb53b28d92 in WTF::GRefPtr<_WebKitWebInspector>::~GRefPtr() ..../webkit.master/Source/WTF/wtf/glib/GRefPtr.h:76 #6 0x7fcb53b28d92 in _WebKitWebViewPrivate::~_WebKitWebViewPrivate() ..../webkit.master/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:196 #7 0x7fcb53b28d92 in webkit_web_view_finalize ..../webkit.master/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:261 #8 0x7fcb51dc0688 in g_object_unref (/lib64/libgobject-2.0.so.0+0x14688) #9 0x7fcb51de400f in g_value_unset (/lib64/libgobject-2.0.so.0+0x3800f) #10 0x7fcb51dd6d4c in g_signal_emit_valist (/lib64/libgobject-2.0.so.0+0x2ad4c) #11 0x7fcb51dd766e in g_signal_emit (/lib64/libgobject-2.0.so.0+0x2b66e) #12 0x41202f in browserWindowTryClose ..../webkit.master/Tools/MiniBrowser/gtk/BrowserWindow.c:277 #13 0x4140c6 in browserWindowDeleteEvent ..../webkit.master/Tools/MiniBrowser/gtk/BrowserWindow.c:1075 #14 0x7fcb52bdcb76 (/lib64/libgtk-3.so.0+0x233b76) #15 0x7fcb51dbb975 (/lib64/libgobject-2.0.so.0+0xf975) #16 0x7fcb51dd69c8 in g_signal_emit_valist (/lib64/libgobject-2.0.so.0+0x2a9c8) #17 0x7fcb51dd766e in g_signal_emit (/lib64/libgobject-2.0.so.0+0x2b66e) #18 0x7fcb52d27cd3 (/lib64/libgtk-3.so.0+0x37ecd3) #19 0x7fcb52bdbbd5 in gtk_main_do_event (/lib64/libgtk-3.so.0+0x232bd5) #20 0x7fcb526e9304 (/lib64/libgdk-3.so.0+0x37304) #21 0x7fcb5271ab21 (/lib64/libgdk-3.so.0+0x68b21) #22 0x7fcb51ae2bb6 in g_main_context_dispatch (/lib64/libglib-2.0.so.0+0x4abb6) #23 0x7fcb51ae2f5f (/lib64/libglib-2.0.so.0+0x4af5f) #24 0x7fcb51ae3271 in g_main_loop_run (/lib64/libglib-2.0.so.0+0x4b271) #25 0x7fcb52bdaca4 in gtk_main (/lib64/libgtk-3.so.0+0x231ca4) #26 0x40c8a5 in main ..../webkit.master/Tools/MiniBrowser/gtk/main.c:561 #27 0x7fcb5019b039 in __libc_start_main (/lib64/libc.so.6+0x21039) #28 0x40c9a9 in _start (/build/test-wk2/libexec/webkit2gtk-4.0/MiniBrowser+0x40c9a9) 0x60200029b7b0 is located 0 bytes inside of 16-byte region [0x60200029b7b0,0x60200029b7c0) allocated by thread T0 here: #0 0x7fcb55b34158 in operator new(unsigned long) (/usr/lib64/libasan.so.4+0xe0158) #1 0x7fcb53b3b71f in std::_MakeUniq<WebKitInspectorClient>::__single_object std::make_unique<WebKitInspectorClient, _WebKitWebInspector*&>(_WebKitWebInspector*&) /usr/include/c++/7/bits/unique_ptr.h:825 #2 0x7fcb53b3b71f in webkitWebInspectorCreate(WebKit::WebInspectorProxy*) ..../webkit.master/Source/WebKit/UIProcess/API/gtk/WebKitWebInspector.cpp:363 1379134 1 328700 mcatanzaro 2017-12-07 09:59:44 -0800 Created attachment 328700 Patch 1379564 2 328700 commit-queue 2017-12-08 08:28:51 -0800 Comment on attachment 328700 Patch Clearing flags on attachment: 328700 Committed r225676: <https://trac.webkit.org/changeset/225676> 1379565 3 commit-queue 2017-12-08 08:28:53 -0800 All reviewed patches have been landed. Closing bug. 328700 2017-12-07 09:59:44 -0800 2017-12-08 08:28:51 -0800 Patch bug-180533-20171207115943.patch text/plain 1373 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFjMDJhYmM3YzI2NTNiZTYy NzI4ODBjMTMwOTA4NWYyZTUyNTZiODIuLjE2YWM5YzRkMzRiYzYzYzY2OGVhMTlhNWMyMzZlOTc0 OWVkNDZkYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMTItMDcgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFdlYklu c3BlY3RvclByb3h5Q2xpZW50IG5lZWRzIGEgdmlydHVhbCBkZXN0cnVjdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA1MzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdGhlcndpc2UgdGhlIGRlcml2 ZWQgY2xhc3MgcG9ydGlvbiBvZiB0aGUgb2JqZWN0LCBXZWJLaXRJbnNwZWN0b3JDbGllbnQsIGlz IG5vdCBkZXN0cm95ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dlYkluc3BlY3RvclBy b3h5Q2xpZW50Lmg6CisKIDIwMTctMTItMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciByMjI1NjIyLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1dlYkluc3BlY3RvclByb3h5Q2xpZW50 LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlDbGllbnQu aAppbmRleCA1MDUwYjFjYzgzZDk4MDJmODUxN2RkNWZjMmY3NTlkNmQyZWY3ZTU4Li41OTljNDQ2 NTc2ODhhMjhhYmFlN2FhMTAxYWIyMjY3N2JkODExM2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlDbGllbnQuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlDbGllbnQuaApAQCAtMzMsNiAr MzMsNyBAQCBjbGFzcyBXZWJJbnNwZWN0b3JQcm94eTsKIAogY2xhc3MgV2ViSW5zcGVjdG9yUHJv eHlDbGllbnQgewogcHVibGljOgorICAgIHZpcnR1YWwgfldlYkluc3BlY3RvclByb3h5Q2xpZW50 KCkgPSBkZWZhdWx0OwogICAgIHZpcnR1YWwgYm9vbCBvcGVuV2luZG93KFdlYkluc3BlY3RvclBy b3h5JikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBkaWRDbG9zZShXZWJJbnNwZWN0b3JQcm94eSYp ID0gMDsKICAgICB2aXJ0dWFsIGJvb2wgYnJpbmdUb0Zyb250KFdlYkluc3BlY3RvclByb3h5Jikg PSAwOwo=