180519 2017-12-06 19:51:18 -0800 ServiceWorker Inspector: Use the SW's scope url for the remote inspection target metadata 2017-12-07 11:00:46 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck inspector-bugzilla-changes joepeck webkit-bug-importer youennf oldest_to_newest 1378991 0 joepeck 2017-12-06 19:51:18 -0800 ServiceWorker Inspector: Use the SW's scope url for the remote inspection target metadata So if there are multiple SW's for a domain they can be distinguished based on their scoping. 1378994 1 328673 joepeck 2017-12-06 19:52:25 -0800 Created attachment 328673 [PATCH] Proposed Fix 1379003 2 328673 youennf 2017-12-06 20:21:55 -0800 Comment on attachment 328673 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=328673&action=review > Source/WebCore/workers/service/context/ServiceWorkerDebuggable.h:49 > + String url() const override { return m_scopeURL; } Could be final and made private, as should name() probably. I also wonder whether url() could return a const String&. Would need to change RemoteInspectionTarget and maybe use emptyString(). 1379163 3 joepeck 2017-12-07 10:51:20 -0800 (In reply to youenn fablet from comment #2) > Comment on attachment 328673 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328673&action=review > > > Source/WebCore/workers/service/context/ServiceWorkerDebuggable.h:49 > > + String url() const override { return m_scopeURL; } > > Could be final and made private, as should name() probably. > > I also wonder whether url() could return a const String&. > Would need to change RemoteInspectionTarget and maybe use emptyString(). Good points. I'll do all of these in a follow-up at the same time. 1379164 4 joepeck 2017-12-07 10:55:32 -0800 <https://trac.webkit.org/r225633> 1379166 5 webkit-bug-importer 2017-12-07 11:00:46 -0800 <rdar://problem/35913551> 328673 2017-12-06 19:52:25 -0800 2017-12-07 10:50:53 -0800 [PATCH] Proposed Fix sw-scope-url-1.patch text/plain 2579 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhY2FhODVkNWZhOC4uOGUwY2FkNjdlMjAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNy0xMi0wNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFNlcnZpY2VXb3JrZXIgSW5zcGVjdG9yOiBVc2UgdGhlIFNXJ3Mgc2Nv cGUgdXJsIGZvciB0aGUgcmVtb3RlIGluc3BlY3Rpb24gdGFyZ2V0IG1ldGFkYXRhCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA1MTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdvcmtlcnMvc2Vydmlj ZS9jb250ZXh0L1NlcnZpY2VXb3JrZXJEZWJ1Z2dhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNlcnZpY2VXb3JrZXJEZWJ1Z2dhYmxlOjpTZXJ2aWNlV29ya2VyRGVidWdnYWJsZSk6CisgICAg ICAgICogd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU2VydmljZVdvcmtlckRlYnVnZ2FibGUuaDoK KyAgICAgICAgU3dpdGNoIHRvIHRoZSBzY29wZSBVUkwgZm9yIHRoZSByZW1vdGUgaW5zcGVjdG9y IHRhcmdldCBpbmZvLgorCiAyMDE3LTEyLTA2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKICAgICAgICAgU2VydmljZVdvcmtlciBJbnNwZWN0b3I6IFNob3VsZCBiZSBh YmxlIHRvIHNlZSBpbWFnZSBjb250ZW50IGZyb20gQ2FjaGVTdG9yYWdlLmFkZCh1cmwpIG5ldHdv cmsgcmVxdWVzdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL2Nv bnRleHQvU2VydmljZVdvcmtlckRlYnVnZ2FibGUuY3BwIGIvU291cmNlL1dlYkNvcmUvd29ya2Vy cy9zZXJ2aWNlL2NvbnRleHQvU2VydmljZVdvcmtlckRlYnVnZ2FibGUuY3BwCmluZGV4IGQ5OTM3 MWI4NDVjLi41NTFlMzlhOTM3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9z ZXJ2aWNlL2NvbnRleHQvU2VydmljZVdvcmtlckRlYnVnZ2FibGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3dvcmtlcnMvc2VydmljZS9jb250ZXh0L1NlcnZpY2VXb3JrZXJEZWJ1Z2dhYmxlLmNw cApAQCAtMzgsNyArMzgsNyBAQCB1c2luZyBuYW1lc3BhY2UgSW5zcGVjdG9yOwogCiBTZXJ2aWNl V29ya2VyRGVidWdnYWJsZTo6U2VydmljZVdvcmtlckRlYnVnZ2FibGUoU2VydmljZVdvcmtlclRo cmVhZFByb3h5JiBzZXJ2aWNlV29ya2VyVGhyZWFkUHJveHksIGNvbnN0IFNlcnZpY2VXb3JrZXJD b250ZXh0RGF0YSYgZGF0YSkKICAgICA6IG1fc2VydmljZVdvcmtlclRocmVhZFByb3h5KHNlcnZp Y2VXb3JrZXJUaHJlYWRQcm94eSkKLSAgICAsIG1fc2NyaXB0VVJMKGRhdGEuc2NyaXB0VVJMKQor ICAgICwgbV9zY29wZVVSTChkYXRhLnJlZ2lzdHJhdGlvbi5zY29wZVVSTCkKIHsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU2VydmljZVdv cmtlckRlYnVnZ2FibGUuaCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9jb250ZXh0 L1NlcnZpY2VXb3JrZXJEZWJ1Z2dhYmxlLmgKaW5kZXggYzMxMTYzYmNjOTIuLmMyZGNkNjE4NTI4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TZXJ2 aWNlV29ya2VyRGVidWdnYWJsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vydmlj ZS9jb250ZXh0L1NlcnZpY2VXb3JrZXJEZWJ1Z2dhYmxlLmgKQEAgLTQ2LDcgKzQ2LDcgQEAgcHVi bGljOgogICAgIEluc3BlY3Rvcjo6UmVtb3RlQ29udHJvbGxhYmxlVGFyZ2V0OjpUeXBlIHR5cGUo KSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBJbnNwZWN0b3I6OlJlbW90ZUNvbnRyb2xsYWJsZVRh cmdldDo6VHlwZTo6U2VydmljZVdvcmtlcjsgfQogCiAgICAgU3RyaW5nIG5hbWUoKSBjb25zdCBv dmVycmlkZSB7IHJldHVybiBBU0NJSUxpdGVyYWwoIlNlcnZpY2VXb3JrZXIiKTsgfQotICAgIFN0 cmluZyB1cmwoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBtX3NjcmlwdFVSTDsgfQorICAgIFN0 cmluZyB1cmwoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBtX3Njb3BlVVJMOyB9CiAgICAgYm9v bCBoYXNMb2NhbERlYnVnZ2VyKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gZmFsc2U7IH0KIAog ICAgIHZvaWQgY29ubmVjdChJbnNwZWN0b3I6OkZyb250ZW5kQ2hhbm5lbCosIGJvb2wgaXNBdXRv bWF0aWNDb25uZWN0aW9uID0gZmFsc2UsIGJvb2wgaW1tZWRpYXRlbHlQYXVzZSA9IGZhbHNlKSBv dmVycmlkZTsKQEAgLTU1LDcgKzU1LDcgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIFNlcnZp Y2VXb3JrZXJUaHJlYWRQcm94eSYgbV9zZXJ2aWNlV29ya2VyVGhyZWFkUHJveHk7Ci0gICAgU3Ry aW5nIG1fc2NyaXB0VVJMOworICAgIFN0cmluZyBtX3Njb3BlVVJMOwogfTsKIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQo=