180517 2017-12-06 17:40:59 -0800 Propagate WebKit2Logging channels to the Web Process 2017-12-07 16:56:40 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue simon.fraser thorton webkit-bug-importer oldest_to_newest 1378963 0 simon.fraser 2017-12-06 17:40:59 -0800 Propagate WebKit2Logging channels to the Web Process 1378964 1 328666 simon.fraser 2017-12-06 17:42:16 -0800 Created attachment 328666 Patch 1378973 2 328666 ap 2017-12-06 18:47:48 -0800 Comment on attachment 328666 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328666&action=review > Source/WebKit/ChangeLog:8 > + If you set WebKit2Logging, you want those channels active in both the UI process and I generally don’t, as that’s quite confusing. I guess I made the same comment when you implemented this for WebCore logging too. 1379361 3 328666 commit-queue 2017-12-07 16:54:55 -0800 Comment on attachment 328666 Patch Clearing flags on attachment: 328666 Committed r225655: <https://trac.webkit.org/changeset/225655> 1379362 4 commit-queue 2017-12-07 16:54:56 -0800 All reviewed patches have been landed. Closing bug. 1379365 5 webkit-bug-importer 2017-12-07 16:56:40 -0800 <rdar://problem/35923679> 328666 2017-12-06 17:42:16 -0800 2017-12-07 16:54:55 -0800 Patch bug-180517-20171206174215.patch text/plain 6680 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYzNTgxZWNlZTYxMTAxOTM3 ZDZmNmQ1MGQwNDYzOGQ2NmIxMWEwNWEuLmFhYzM3N2U4ODk5NTk0MzY3ZjE3MjRhNmJkYTRkMjFh YWI4Y2VhODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTctMTItMDYgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUHJvcGFnYXRlIFdlYktp dDJMb2dnaW5nIGNoYW5uZWxzIHRvIHRoZSBXZWIgUHJvY2VzcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNTE3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgeW91IHNldCBXZWJLaXQyTG9nZ2luZywg eW91IHdhbnQgdGhvc2UgY2hhbm5lbHMgYWN0aXZlIGluIGJvdGggdGhlIFVJIHByb2Nlc3MgYW5k CisgICAgICAgIHRoZSB3ZWIgcHJvY2VzcywgYnV0IHdpdGhvdXQgdHJpY2t5ICdkZWZhdWx0cycg Z3lyYXRpb25zLCBzZXR0aW5nIHRoZW0gaW4gdGhlIHdlYiBwcm9jZXNzCisgICAgICAgIHdhcyBo YXJkLgorCisgICAgICAgIEluc3RlYWQsIHNlbmQgdGhlbSB0aHJvdWdoIHRvIHRoZSBwcm9jZXNz IHZpYSBXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLCBhcyB3ZSBkbworICAgICAgICBmb3Ig V2ViQ29yZUxvZ2dpbmcgY2hhbm5lbHMuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Mb2dJbml0aWFs aXphdGlvbi5oOgorICAgICAgICAqIFBsYXRmb3JtL0xvZ2dpbmcuY3BwOgorICAgICAgICAoV2Vi S2l0Ojppbml0aWFsaXplTG9nQ2hhbm5lbHNJZk5lY2Vzc2FyeSk6CisgICAgICAgICogU2hhcmVk L1dlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQ cm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjplbmNvZGUgY29uc3QpOgorICAgICAgICAoV2ViS2l0 OjpXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjpkZWNvZGUpOgorICAgICAgICAqIFNoYXJl ZC9XZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmg6CisgICAgICAgICogVUlQcm9jZXNzL0Nv Y29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQ b29sOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKToKKyAgICAgICAgKiBXZWJQcm9jZXNz L2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6 cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTctMTItMDUgIEJyZW50IEZ1bGdo YW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgTGltaXQgdXNlciBhZ2VudCB2ZXJz aW9uaW5nIHRvIGFuIHVwcGVyIGJvdW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRm b3JtL0xvZ0luaXRpYWxpemF0aW9uLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0xvZ0luaXRp YWxpemF0aW9uLmgKaW5kZXggYzU1YjZjYWUxYWUwMjA4NmNkY2FkM2Y2ODA2OTBiODdiODgxZWZh OS4uMjU2YTQ1OTczMThkMTFhZGVkZTA3NWIxZTEyMTVmZDYzY2ZlYWY4MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9QbGF0Zm9ybS9Mb2dJbml0aWFsaXphdGlvbi5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvUGxhdGZvcm0vTG9nSW5pdGlhbGl6YXRpb24uaApAQCAtMzEsNyArMzEsNyBAQAogCiBu YW1lc3BhY2UgV2ViS2l0IHsKIAotdm9pZCBpbml0aWFsaXplTG9nQ2hhbm5lbHNJZk5lY2Vzc2Fy eSh2b2lkKTsKK3ZvaWQgaW5pdGlhbGl6ZUxvZ0NoYW5uZWxzSWZOZWNlc3Nhcnkoc3RkOjpvcHRp b25hbDxTdHJpbmc+ID0gc3RkOjpudWxsb3B0KTsKIFN0cmluZyBsb2dMZXZlbFN0cmluZygpOwog CiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vTG9nZ2luZy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0xvZ2dpbmcuY3BwCmluZGV4 IDdkYTBmMWY1MzE0NmMxMzliZjU0NjAxMjIzYzUyZTExYmZiZmIwMzcuLjZhZDZmMGViN2UyYzNi NzZjMWI3ZWRiMjhiZjVlZGI0MDQ3NDQyNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxh dGZvcm0vTG9nZ2luZy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9Mb2dnaW5nLmNw cApAQCAtNDIsMTUgKzQyLDE3IEBAIHN0YXRpYyBXVEZMb2dDaGFubmVsKiBsb2dDaGFubmVsc1td ID0gewogbmFtZXNwYWNlIFdlYktpdCB7CiAKIHN0YXRpYyBjb25zdCBzaXplX3QgbG9nQ2hhbm5l bENvdW50ID0gV1RGX0FSUkFZX0xFTkdUSChsb2dDaGFubmVscyk7CitzdGF0aWMgYm9vbCBsb2dD aGFubmVsc05lZWRJbml0aWFsaXphdGlvbiA9IHRydWU7CiAKLXZvaWQgaW5pdGlhbGl6ZUxvZ0No YW5uZWxzSWZOZWNlc3NhcnkoKQordm9pZCBpbml0aWFsaXplTG9nQ2hhbm5lbHNJZk5lY2Vzc2Fy eShzdGQ6Om9wdGlvbmFsPFN0cmluZz4gbG9nQ2hhbm5lbFN0cmluZykKIHsKLSAgICBzdGF0aWMg Ym9vbCBoYXZlSW5pdGlhbGl6ZWRMb2dnaW5nQ2hhbm5lbHMgPSBmYWxzZTsKLSAgICBpZiAoaGF2 ZUluaXRpYWxpemVkTG9nZ2luZ0NoYW5uZWxzKQorICAgIGlmICghbG9nQ2hhbm5lbHNOZWVkSW5p dGlhbGl6YXRpb24gJiYgIWxvZ0NoYW5uZWxTdHJpbmcpCiAgICAgICAgIHJldHVybjsKLSAgICBo YXZlSW5pdGlhbGl6ZWRMb2dnaW5nQ2hhbm5lbHMgPSB0cnVlOwotICAgIAotICAgIFdURkluaXRp YWxpemVMb2dDaGFubmVsU3RhdGVzRnJvbVN0cmluZyhsb2dDaGFubmVscywgbG9nQ2hhbm5lbENv dW50LCBsb2dMZXZlbFN0cmluZygpLnV0ZjgoKS5kYXRhKCkpOworCisgICAgbG9nQ2hhbm5lbHNO ZWVkSW5pdGlhbGl6YXRpb24gPSBmYWxzZTsKKworICAgIFN0cmluZyBlbmFibGVkQ2hhbm5lbHNT dHJpbmcgPSBsb2dDaGFubmVsU3RyaW5nID8gbG9nQ2hhbm5lbFN0cmluZy52YWx1ZSgpIDogbG9n TGV2ZWxTdHJpbmcoKTsKKyAgICBXVEZJbml0aWFsaXplTG9nQ2hhbm5lbFN0YXRlc0Zyb21TdHJp bmcobG9nQ2hhbm5lbHMsIGxvZ0NoYW5uZWxDb3VudCwgZW5hYmxlZENoYW5uZWxzU3RyaW5nLnV0 ZjgoKS5kYXRhKCkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwIGIvU291 cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHAKaW5kZXgg ZmY3MTRlYTM2M2M3OGUyOTM2ZWNhYWI5YTJkNjExMTk3ZjI4Njk5ZC4uNmM2Mzg4NmVmZGU5NDk0 N2JjZmQ4YTE3ZGFhMmViOGJlY2E2YmZlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFy ZWQvV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9T aGFyZWQvV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHAKQEAgLTY3LDYgKzY3LDcgQEAg dm9pZCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjplbmNvZGUoSVBDOjpFbmNvZGVyJiBl bmNvZGVyKSBjb25zdAogI2VuZGlmCiAgICAgZW5jb2RlciA8PCBtZWRpYUtleVN0b3JhZ2VEaXJl Y3Rvcnk7CiAgICAgZW5jb2RlciA8PCB3ZWJDb3JlTG9nZ2luZ0NoYW5uZWxzOworICAgIGVuY29k ZXIgPDwgd2ViS2l0TG9nZ2luZ0NoYW5uZWxzOwogICAgIGVuY29kZXIgPDwgbWVkaWFLZXlTdG9y YWdlRGlyZWN0b3J5RXh0ZW5zaW9uSGFuZGxlOwogI2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCiAg ICAgZW5jb2RlciA8PCBhdWRpb0NhcHR1cmVFeHRlbnNpb25IYW5kbGU7CkBAIC0xOTAsNiArMTkx LDggQEAgYm9vbCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjpkZWNvZGUoSVBDOjpEZWNv ZGVyJiBkZWNvZGVyLCBXZWJQcm9jZXNzQ3JlYXQKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg IGlmICghZGVjb2Rlci5kZWNvZGUocGFyYW1ldGVycy53ZWJDb3JlTG9nZ2luZ0NoYW5uZWxzKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlmICghZGVjb2Rlci5kZWNvZGUocGFyYW1ldGVy cy53ZWJLaXRMb2dnaW5nQ2hhbm5lbHMpKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYg KCFkZWNvZGVyLmRlY29kZShwYXJhbWV0ZXJzLm1lZGlhS2V5U3RvcmFnZURpcmVjdG9yeUV4dGVu c2lvbkhhbmRsZSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICNpZiBFTkFCTEUoTUVESUFfU1RS RUFNKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJvY2Vzc0NyZWF0aW9u UGFyYW1ldGVycy5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJvY2Vzc0NyZWF0aW9uUGFy YW1ldGVycy5oCmluZGV4IDY3M2FhNGMyZTNlNTFlYjNjNjIxZWI2NGY2ZDk1MzkyZDIyOTU0OGUu LmJjYjQwYWQ5ODU0ZjI5ODcwNmQxZjI0NDQzNzJkOTU0MjE4NGM5OGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaAorKysgYi9T b3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgKQEAgLTk1 LDYgKzk1LDcgQEAgc3RydWN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMgewogICAgIFN0 cmluZyBtZWRpYUtleVN0b3JhZ2VEaXJlY3Rvcnk7CiAKICAgICBTdHJpbmcgd2ViQ29yZUxvZ2dp bmdDaGFubmVsczsKKyAgICBTdHJpbmcgd2ViS2l0TG9nZ2luZ0NoYW5uZWxzOwogCiAgICAgVmVj dG9yPFN0cmluZz4gdXJsU2NoZW1lc1JlZ2lzdGVyZWRBc0VtcHR5RG9jdW1lbnQ7CiAgICAgVmVj dG9yPFN0cmluZz4gdXJsU2NoZW1lc1JlZ2lzdGVyZWRBc1NlY3VyZTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW0gYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1tCmluZGV4IGM1 ZTJkNmM4OTYyZjczM2I5ZGQ2MWE5ODhiOWY3M2E0NjdhZTEzYzQuLjgxNTY3ZTJhMGVhYTEyMzI0 MzM3YjY3YjQ4OGIyNjI5MjU4ZGI5ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbQpAQCAtMjY0LDYgKzI2NCw3IEBAIHZv aWQgV2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoV2ViUHJvY2Vz c0NyZWF0aW9uUGFyYW1ldGVycyYKIAogI2lmICFMT0dfRElTQUJMRUQgfHwgIVJFTEVBU0VfTE9H X0RJU0FCTEVECiAgICAgcGFyYW1ldGVycy53ZWJDb3JlTG9nZ2luZ0NoYW5uZWxzID0gW1tOU1Vz ZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gc3RyaW5nRm9yS2V5OkAiV2ViQ29yZUxv Z2dpbmciXTsKKyAgICBwYXJhbWV0ZXJzLndlYktpdExvZ2dpbmdDaGFubmVscyA9IFtbTlNVc2Vy RGVmYXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIHN0cmluZ0ZvcktleTpAIldlYktpdDJMb2dn aW5nIl07CiAjZW5kaWYKIAogICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBhbmQgcmVsYXRlZCBw YXJhbWV0ZXIgd2hlbiA8cmRhcjovL3Byb2JsZW0vMjk0NDgzNjg+IGlzIGZpeGVkLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbSBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KaW5kZXgg NzFhY2QwNTcyYTRlZDA5OGVjYzE2NjY3ZTY3MjE3M2ZhMTc4NGNlNi4uYWI4ODBkZmRjYjIzMDU2 Mjk1M2Q3NzdhZDdlZWFjNTI1OGU2NTA5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCkBAIC0yOCw2ICsyOCw3IEBACiAjaW1wb3J0 ICJXZWJQcm9jZXNzQ29jb2EuaCIKIAogI2ltcG9ydCAiTGVnYWN5Q3VzdG9tUHJvdG9jb2xNYW5h Z2VyLmgiCisjaW1wb3J0ICJMb2dJbml0aWFsaXphdGlvbi5oIgogI2ltcG9ydCAiTG9nZ2luZy5o IgogI2ltcG9ydCAiT2JqQ09iamVjdEdyYXBoLmgiCiAjaW1wb3J0ICJTYW5kYm94RXh0ZW5zaW9u LmgiCkBAIC0xMDQsNiArMTA1LDcgQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxp emVXZWJQcm9jZXNzKFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmJiBwYXIKIHsKICNpZiAh TE9HX0RJU0FCTEVEIHx8ICFSRUxFQVNFX0xPR19ESVNBQkxFRAogICAgIFdlYkNvcmU6OmluaXRp YWxpemVMb2dDaGFubmVsc0lmTmVjZXNzYXJ5KHBhcmFtZXRlcnMud2ViQ29yZUxvZ2dpbmdDaGFu bmVscyk7CisgICAgV2ViS2l0Ojppbml0aWFsaXplTG9nQ2hhbm5lbHNJZk5lY2Vzc2FyeShwYXJh bWV0ZXJzLndlYktpdExvZ2dpbmdDaGFubmVscyk7CiAjZW5kaWYKIAogICAgIFdlYkNvcmU6OnNl dEFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmllcihwYXJhbWV0ZXJzLnVpUHJvY2Vzc0J1bmRsZUlk ZW50aWZpZXIpOwo=