180493 2017-12-06 12:25:15 -0800 Layout Test media/event-queue-crash.html is flaky 2018-01-11 13:14:37 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 eric.carlson ap commit-queue eric.carlson graouts jer.noble webkit-bug-importer oldest_to_newest 1378740 0 jlewis3 2017-12-06 12:25:15 -0800 media/event-queue-crash.html is a flaky failure on macOS. According to the dashboard it has flaked on High Sierra Release, Sierra Debug WK1, and El Capitan Release WK2: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fevent-queue-crash.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r225575%20(1576)/results.html https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/1576 There isn't a clear regression point on the dashboard. Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/media/event-queue-crash-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/media/event-queue-crash-actual.txt @@ -1,4 +1,3 @@ -CONSOLE MESSAGE: line 34: SyntaxError: Unexpected token '}'. Expected '(' to start an 'if' condition. When an element containing video is removed, WebKit should not crash. PASS. WebKit didn't crash. 1379185 1 webkit-bug-importer 2017-12-07 11:29:50 -0800 <rdar://problem/35914377> 1379881 2 ap 2017-12-08 17:01:38 -0800 Matt, is this reproducible? 1387820 3 jlewis3 2018-01-10 13:06:05 -0800 Yes, I was able to reproduce the failure on High Sierra however I had to run this multiple times to get the failure: run-webkit-tests media/event-queue-crash.html --no-retry-failure --verbose --iterations=50 -f -g 1387915 4 330978 eric.carlson 2018-01-10 15:42:13 -0800 Created attachment 330978 Patch 1388243 5 331056 eric.carlson 2018-01-11 08:24:08 -0800 Created attachment 331056 Patch 1388286 6 331056 commit-queue 2018-01-11 10:20:18 -0800 Comment on attachment 331056 Patch Clearing flags on attachment: 331056 Committed r226785: <https://trac.webkit.org/changeset/226785> 1388287 7 commit-queue 2018-01-11 10:20:20 -0800 All reviewed patches have been landed. Closing bug. 1388399 8 jlewis3 2018-01-11 13:14:37 -0800 Re-baselined test in: https://trac.webkit.org/changeset/226798/webkit 330978 2018-01-10 15:42:13 -0800 2018-01-11 08:24:06 -0800 Patch bug-180493-20180110154213.patch text/plain 1725 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2NzM3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWFiMTViMGRiYmZiNjE1YTY2ZDBk OTUyMWVjOGRhYzY1YTg1NzMwZC4uMGFlYTY2YzQ5MjVmNWNmYmU2Mzk2YzI1NGQzNzBlMGIzNDQz NGYxMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAxLTEwICBFcmljIENhcmxzb24gIDxl cmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBUZXN0IG1lZGlhL2V2ZW50 LXF1ZXVlLWNyYXNoLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MDQ5MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU5MTQz Nzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBU ZXN0RXhwZWN0YXRpb25zOiBBZGQgRHVtcEpTQ29uc29sZUxvZ0luU3RkRXJyLgorICAgICAgICAq IG1lZGlhL2V2ZW50LXF1ZXVlLWNyYXNoLmh0bWw6IEluY3JlYXNlIHRoZSB0aW1lb3V0IGZyb20g MTBtcyB0byAxMDBtcy4KKwogMjAxOC0wMS0xMCAgTWF0dCBMZXdpcyAgPGpsZXdpczNAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkanVzdGVkIGV4cGVjdGF0aW9ucyBmb3Igd2VicnRjL3ZpZGVvLXVu bXV0ZS5odG1sLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xh eW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggY2Y4Y2Y2OTU2NWVhMDgzMjY4YmM4YjEx NGM3NzI5M2MyMTM1NDJlNy4uYzI3MTM2ZDlkMjdlMDIxZGJlNGZiMDQyZTE4ZTQyNGQ1NWNhYTY5 NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRU ZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNjg0LDMgKzE2ODQsNSBAQCB3ZWJraXQub3JnL2Iv MTc4Nzg1IHBlcmYvb2JqZWN0LWtleXMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKICMgVGhlcmUg aXMgYSBidWcgaW4gdGhlIHRlc3QKIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd29y a2Vycy93b3JrZXItcGVyZm9ybWFuY2Uud29ya2VyLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQorCitt ZWRpYS9ldmVudC1xdWV1ZS1jcmFzaC5odG1sIFsgRHVtcEpTQ29uc29sZUxvZ0luU3RkRXJyIF0K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL2V2ZW50LXF1ZXVlLWNyYXNoLmh0bWwgYi9M YXlvdXRUZXN0cy9tZWRpYS9ldmVudC1xdWV1ZS1jcmFzaC5odG1sCmluZGV4IDVlZTA0ZGE3NDJl MTlkMDVlZDJlOGMwMTRmZWViZDg3NmQ1YjI2YzguLjFlMzFmN2MyMDZmODQzODU1OTExOTU5MzUy NWFmZDFjMzdmOGZhN2MgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL2V2ZW50LXF1ZXVl LWNyYXNoLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvZXZlbnQtcXVldWUtY3Jhc2guaHRt bApAQCAtMTcsNyArMTcsNyBAQAogICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewogICAg ICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQogICAgICAgICAgICAgICAgIHRlc3RSdW5u ZXIubm90aWZ5RG9uZSgpOwotICAgICAgICB9LCAxMCk7CisgICAgICAgIH0sIDEwMCk7CiAgICAg fQogPC9zY3JpcHQ+CiAK 331056 2018-01-11 08:24:08 -0800 2018-01-11 10:20:18 -0800 Patch bug-180493-20180111082407.patch text/plain 1799 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2NzgxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGU1ZWY2N2JkOTA0MmY0MzdkZjA4 OWJhY2Q3ZjFmNmQwOTgxMmFmNi4uOTEyOGQ4OWIwMDZmNmY2ZjkyNjM3ZjdlNmJmYjIwYTQ0MjY5 MjE1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAxLTExICBFcmljIENhcmxzb24gIDxl cmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBUZXN0IG1lZGlhL2V2ZW50 LXF1ZXVlLWNyYXNoLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MDQ5MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU5MTQz Nzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmVyIE5vYmxlLgorCisgICAgICAgICogVGVzdEV4 cGVjdGF0aW9uczogQWRkIER1bXBKU0NvbnNvbGVMb2dJblN0ZEVyci4KKyAgICAgICAgKiBtZWRp YS9ldmVudC1xdWV1ZS1jcmFzaC5odG1sOiBJbmNyZWFzZSB0aGUgdGltZW91dCBmcm9tIDEwbXMg dG8gMTAwbXMuCisKIDIwMTgtMDEtMTEgIE1pZ3VlbCBHb21leiAgPG1hZ29tZXpAaWdhbGlhLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkIEdUSysgYW5kIFdQRSBnYXJkZW5pbmcgYWZ0ZXIgcjIy Njc3My4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGU1MzYyZWFiMTIyZGRlZGQwNTVlMTMyZTA5YTRl MWNjZDQ1ZDEyNTYuLjA4ZDJjODNiNWU3NjkxMDNiZTI1YTAyNTk4NmIzYmU1ZWU4OTQ2OTMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv VGVzdEV4cGVjdGF0aW9ucwpAQCAtMTY4NSw0ICsxNjg1LDYgQEAgd2Via2l0Lm9yZy9iLzE3ODc4 NSBwZXJmL29iamVjdC1rZXlzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogIyBUaGVyZSBpcyBhIGJ1 ZyBpbiB0aGUgdGVzdAogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93b3JrZXJzL3dv cmtlci1wZXJmb3JtYW5jZS53b3JrZXIuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKK21lZGlhL2V2 ZW50LXF1ZXVlLWNyYXNoLmh0bWwgWyBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIgXQorCiB3ZWJr aXQub3JnL2IvMTgxMjIyIGh0dHAvdGVzdHMvd29ya2Vycy9zZXJ2aWNlL2NvcnMtaW1hZ2UtZmV0 Y2guaHRtbCBbIFNraXAgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvZXZlbnQtcXVl dWUtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL2V2ZW50LXF1ZXVlLWNyYXNoLmh0bWwK aW5kZXggNWVlMDRkYTc0MmUxOWQwNWVkMmU4YzAxNGZlZWJkODc2ZDViMjZjOC4uMWUzMWY3YzIw NmY4NDM4NTU5MTE5NTkzNTI1YWZkMWMzN2Y4ZmE3YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv bWVkaWEvZXZlbnQtcXVldWUtY3Jhc2guaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9ldmVu dC1xdWV1ZS1jcmFzaC5odG1sCkBAIC0xNyw3ICsxNyw3IEBACiAgICAgICAgIHNldFRpbWVvdXQo ZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCiAgICAgICAg ICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Ci0gICAgICAgIH0sIDEwKTsKKyAgICAg ICAgfSwgMTAwKTsKICAgICB9CiA8L3NjcmlwdD4KIAo=