180492 2017-12-06 12:09:24 -0800 We need to grab the JSLock in InjectedBundle::createWebDataFromUint8Array 2017-12-07 17:13:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180438 InRadar P2 Normal --- 1 saam saam achristensen ap beidson benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset rniwa ryanhaddad sam thorton ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1378732 0 saam 2017-12-06 12:09:24 -0800 ... 1379046 1 328682 saam 2017-12-06 23:03:58 -0800 Created attachment 328682 patch Let's see if this builds. I haven't tried locally. 1379302 2 328682 achristensen 2017-12-07 15:04:33 -0800 Comment on attachment 328682 patch Please give a radar, a reason, or even better: a test that used to do something bad and now does something good. 1379304 3 saam 2017-12-07 15:07:35 -0800 (In reply to Alex Christensen from comment #2) > Comment on attachment 328682 [details] > patch > > Please give a radar, a reason, or even better: a test that used to do > something bad and now does something good. Ryan pointed out that a test is already failing because of this. See: https://bugs.webkit.org/show_bug.cgi?id=180438 and https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r225440%20(4421)/webaudio/audiobuffersource-crash-log.txt Is that enough? I'm happy to add this reason to the changelog: ``` WKBundleCreateWKDataFromUInt8Array may allocate from the JS heap. To do so, you must be holding the JSLock. ``` 1379308 4 achristensen 2017-12-07 15:11:14 -0800 Please add that to the ChangeLog, and also move the change to InjectedBundle::createWebDataFromUint8Array instead of at the API layer in case we add something else that calls that. 1379317 5 328748 saam 2017-12-07 15:21:38 -0800 Created attachment 328748 patch 1379379 6 328748 commit-queue 2017-12-07 17:12:22 -0800 Comment on attachment 328748 patch Clearing flags on attachment: 328748 Committed r225658: <https://trac.webkit.org/changeset/225658> 1379380 7 commit-queue 2017-12-07 17:12:23 -0800 All reviewed patches have been landed. Closing bug. 1379383 8 webkit-bug-importer 2017-12-07 17:13:36 -0800 <rdar://problem/35924114> 328682 2017-12-06 23:03:58 -0800 2017-12-07 15:21:38 -0800 patch c-backup.diff text/plain 1833 saam SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjU2MjEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTEyLTA2ICBTYWFtIEJhcmF0 aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFdlIG5lZWQgdG8gZ3JhYiB0aGUgSlNM b2NrIGluIFdLQnVuZGxlQ3JlYXRlV0tEYXRhRnJvbVVJbnQ4QXJyYXkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDQ5MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvYy9XS0J1bmRsZS5jcHA6CisgICAgICAgIChXS0J1bmRsZUNyZWF0ZVdLRGF0YUZy b21VSW50OEFycmF5KToKKwogMjAxNy0xMi0wMiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5j b20+CiAKICAgICAgICAgTW9kZXJuaXplIHNvbWUgYXNwZWN0cyBvZiB0ZXh0IGNvZGVjcywgZWxp bWluYXRlIFdlYktpdCB1c2Ugb2Ygc3RyY2FzZWNtcApJbmRleDogU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGUuY3Bw CShyZXZpc2lvbiAyMjU2MjApCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvQVBJL2MvV0tCdW5kbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAog LyoKLSAqIENvcHlyaWdodCAoQykgMjAxMC0yMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMC0yMDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMzgsNiArMzgsOCBA QAogI2luY2x1ZGUgIldlYkZyYW1lLmgiCiAjaW5jbHVkZSAiV2ViUGFnZS5oIgogI2luY2x1ZGUg IldlYlBhZ2VHcm91cFByb3h5LmgiCisjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5o PgorI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTTG9jay5oPgogI2luY2x1ZGUgPFdlYkNvcmUv RGF0YWJhc2VUcmFja2VyLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZUxvYWRPYnNlcnZl ci5oPgogCkBAIC0yMjUsNiArMjI3LDggQEAgdm9pZCBXS0J1bmRsZVNldERhdGFiYXNlUXVvdGEo V0tCdW5kbGVSZQogCiBXS0RhdGFSZWYgV0tCdW5kbGVDcmVhdGVXS0RhdGFGcm9tVUludDhBcnJh eShXS0J1bmRsZVJlZiBidW5kbGUsIEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVmIGRh dGEpCiB7CisgICAgSlNDOjpFeGVjU3RhdGUqIGV4ZWMgPSB0b0pTKGNvbnRleHQpOworICAgIEpT Qzo6SlNMb2NrSG9sZGVyIGxvY2soZXhlYyk7CiAgICAgcmV0dXJuIHRvQVBJKCZ0b0ltcGwoYnVu ZGxlKS0+Y3JlYXRlV2ViRGF0YUZyb21VaW50OEFycmF5KGNvbnRleHQsIGRhdGEpLmxlYWtSZWYo KSk7CiB9CiAK 328748 2017-12-07 15:21:38 -0800 2017-12-07 17:12:22 -0800 patch c-backup.diff text/plain 1661 saam SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjU2NDYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEyLTA3ICBTYWFtIEJhcmF0 aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFdlIG5lZWQgdG8gZ3JhYiB0aGUgSlNM b2NrIGluIEluamVjdGVkQnVuZGxlOjpjcmVhdGVXZWJEYXRhRnJvbVVpbnQ4QXJyYXkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDQ5MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluamVjdGVkQnVuZGxl OjpjcmVhdGVXZWJEYXRhRnJvbVVpbnQ4QXJyYXkgY2FsbHMgaW50byBXZWJDb3JlIEFQSXMgdGhh dCBhbGxvY2F0ZQorICAgICAgICBvdXQgb2YgdGhlIEpTIGhlYXAuIEl0J3Mgb25seSBsZWdhbCB0 byBhbGxvY2F0ZSBvdXQgb2YgdGhlIEpTIGhlYXAgd2hlbiBob2xkaW5nIHRoZSBKUyBsb2NrLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVuZGxlOjpjcmVhdGVXZWJEYXRhRnJvbVVpbnQ4 QXJyYXkpOgorCiAyMDE3LTEyLTA3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K IAogICAgICAgICBDYWNoZVN0b3JhZ2UgQ2FjaGUgc2hvdWxkIG5vdCByZW1vdmUgYW55IGRpc2sg ZW50cnkgd2hlbiBjbGVhcmluZyBpdHMgbWVtb3J5IHJlcHJlc2VudGF0aW9uCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9Jbmpl Y3RlZEJ1bmRsZS5jcHAJKHJldmlzaW9uIDIyNTYyMCkKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTU4MSw2ICs1ODEsNyBAQCB1aW50NjRfdCBJbmplY3RlZEJ1bmRsZTo6d2ViTm90aWZpY2F0aW9u CiBSZWY8QVBJOjpEYXRhPiBJbmplY3RlZEJ1bmRsZTo6Y3JlYXRlV2ViRGF0YUZyb21VaW50OEFy cmF5KEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVmIGRhdGEpCiB7CiAgICAgSlNDOjpF eGVjU3RhdGUqIGV4ZWNTdGF0ZSA9IHRvSlMoY29udGV4dCk7CisgICAgSlNMb2NrSG9sZGVyIGxv Y2soZXhlY1N0YXRlKTsKICAgICBSZWZQdHI8VWludDhBcnJheT4gYXJyYXlEYXRhID0gV2ViQ29y ZTo6dG9VbnNoYXJlZFVpbnQ4QXJyYXkoZXhlY1N0YXRlLT52bSgpLCB0b0pTKGV4ZWNTdGF0ZSwg ZGF0YSkpOwogICAgIHJldHVybiBBUEk6OkRhdGE6OmNyZWF0ZShzdGF0aWNfY2FzdDx1bnNpZ25l ZCBjaGFyKj4oYXJyYXlEYXRhLT5iYXNlQWRkcmVzcygpKSwgYXJyYXlEYXRhLT5ieXRlTGVuZ3Ro KCkpOwogfQo=