180436 2017-12-05 12:14:13 -0800 [Win64] Compile error in testmasm.cpp. 2017-12-05 13:43:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1378276 0 pvollan 2017-12-05 12:14:13 -0800 Source\JavaScriptCore\assembler\testmasm.cpp(186): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) 1378278 1 328482 pvollan 2017-12-05 12:22:10 -0800 Created attachment 328482 Patch 1378309 2 328482 mark.lam 2017-12-05 13:06:55 -0800 Comment on attachment 328482 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328482&action=review r=me with fix. > Source/JavaScriptCore/assembler/testmasm.cpp:186 > + }), pointer + offset + (1ll << static_cast<int>(scale)) * length); let's make it static_cast<size_t>(1). I think that is what we really want. 1378314 3 pvollan 2017-12-05 13:16:55 -0800 (In reply to Mark Lam from comment #2) > Comment on attachment 328482 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328482&action=review > > r=me with fix. > > > Source/JavaScriptCore/assembler/testmasm.cpp:186 > > + }), pointer + offset + (1ll << static_cast<int>(scale)) * length); > > let's make it static_cast<size_t>(1). I think that is what we really want. Thanks for reviewing! I will update before landing. 1378337 4 pvollan 2017-12-05 13:42:06 -0800 Committed r225536: <https://trac.webkit.org/changeset/225536/webkit>. 1378339 5 webkit-bug-importer 2017-12-05 13:43:17 -0800 <rdar://problem/35863628> 328482 2017-12-05 12:22:10 -0800 2017-12-05 13:06:55 -0800 Patch bug-180436-20171205212211.patch text/plain 1410 pvollan SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI1NTI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE3LTEyLTA1ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAg ICAgICBbV2luNjRdIENvbXBpbGUgZXJyb3IgaW4gdGVzdG1hc20uY3BwLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNDM2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IE1TVkMgd2FybmluZyAoMzIt Yml0IHNoaWZ0IGltcGxpY2l0bHkgY29udmVydGVkIHRvIDY0IGJpdHMpLgorICAgICAgICAKKyAg ICAgICAgKiBhc3NlbWJsZXIvdGVzdG1hc20uY3BwOgorICAgICAgICAoSlNDOjp0ZXN0R2V0RWZm ZWN0aXZlQWRkcmVzcyk6CisKIDIwMTctMTItMDEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBHQyBjb25zdHJhaW50IHNvbHZpbmcgc2hvdWxkIGJlIHBhcmFsbGVs CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcAko cmV2aXNpb24gMjI1NTI1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci90ZXN0 bWFzbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4Myw3ICsxODMsNyBAQCB2b2lkIHRlc3RHZXRF ZmZlY3RpdmVBZGRyZXNzKHNpemVfdCBwb2luCiAgICAgICAgIGppdC5nZXRFZmZlY3RpdmVBZGRy ZXNzKENDYWxsSGVscGVyczo6QmFzZUluZGV4KEdQUkluZm86OnJlZ1QwLCBHUFJJbmZvOjpyZWdU MSwgc2NhbGUsIG9mZnNldCksIEdQUkluZm86OnJldHVyblZhbHVlR1BSKTsKICAgICAgICAgaml0 LmVtaXRGdW5jdGlvbkVwaWxvZ3VlKCk7CiAgICAgICAgIGppdC5yZXQoKTsKLSAgICB9KSwgcG9p bnRlciArIG9mZnNldCArICgxIDw8IHN0YXRpY19jYXN0PGludD4oc2NhbGUpKSAqIGxlbmd0aCk7 CisgICAgfSksIHBvaW50ZXIgKyBvZmZzZXQgKyAoMWxsIDw8IHN0YXRpY19jYXN0PGludD4oc2Nh bGUpKSAqIGxlbmd0aCk7CiB9CiAKIC8vIGJyYW5jaFRydW5jYXRlRG91YmxlVG9JbnQzMigpLCB3 aGVuIGVuY291bnRlcmluZyBJbmZpbml0eSwgLUluZmluaXR5IG9yIGEK