180425 2017-12-05 08:38:32 -0800 IsoAlignedMemoryAllocator needs to free all of its memory when the VM destructs 2017-12-05 13:56:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179288 InRadar P2 Normal --- 1 fpizlo fpizlo ap ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1378168 0 fpizlo 2017-12-05 08:38:32 -0800 ... 1378174 1 fpizlo 2017-12-05 08:55:42 -0800 Otherwise we will have leaks due to iso-allocated MarkedBlocks from workers, like here: https://build.webkit.org/LeaksViewer/?url=%2Fresults%2FApple%20High%20Sierra%20%28Leaks%29%2Fr225314%20%281178%29%2F 1378324 2 328491 fpizlo 2017-12-05 13:32:03 -0800 Created attachment 328491 the patch 1378328 3 328491 saam 2017-12-05 13:36:14 -0800 Comment on attachment 328491 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=328491&action=review > Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp:64 > + if (!result) > + return nullptr; Lets make the above "tryFastAlignedMalloc" 1378340 4 328491 fpizlo 2017-12-05 13:45:52 -0800 Comment on attachment 328491 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=328491&action=review > Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp:41 > + free(block); Also, I should call fastFree here. 1378345 5 fpizlo 2017-12-05 13:55:26 -0800 Landed in https://trac.webkit.org/changeset/225540/webkit 1378346 6 webkit-bug-importer 2017-12-05 13:56:21 -0800 <rdar://problem/35863996> 328491 2017-12-05 13:32:03 -0800 2017-12-05 13:36:14 -0800 the patch blah.patch text/plain 1863 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI1NTMzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE3LTEyLTA1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SXNvQWxpZ25lZE1lbW9yeUFsbG9jYXRvciBuZWVkcyB0byBmcmVlIGFsbCBvZiBpdHMgbWVtb3J5 IHdoZW4gdGhlIFZNIGRlc3RydWN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgwNDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisgICAgICAgIAorICAgICAgICBGYWlsdXJlIHRvIGRvIHNvIGNhdXNlcyBsZWFrcyBhZnRl ciBzdGFydGluZyB3b3JrZXJzLgorCisgICAgICAgICogaGVhcC9Jc29BbGlnbmVkTWVtb3J5QWxs b2NhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6SXNvQWxpZ25lZE1lbW9yeUFsbG9jYXRvcjo6fklz b0FsaWduZWRNZW1vcnlBbGxvY2F0b3IpOgorICAgICAgICAoSlNDOjpJc29BbGlnbmVkTWVtb3J5 QWxsb2NhdG9yOjp0cnlBbGxvY2F0ZUFsaWduZWRNZW1vcnkpOgorCiAyMDE3LTEyLTAxICBGaWxp cCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgR0MgY29uc3RyYWludCBzb2x2 aW5nIHNob3VsZCBiZSBwYXJhbGxlbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SXNvQWxpZ25lZE1lbW9yeUFsbG9jYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvSXNvQWxpZ25lZE1lbW9yeUFsbG9jYXRvci5jcHAJKHJldmlzaW9uIDIy NTUyMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0lzb0FsaWduZWRNZW1vcnlBbGxv Y2F0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCwxMiBAQCBJc29BbGlnbmVkTWVt b3J5QWxsb2NhdG9yOjpJc29BbGlnbmVkTWVtCiAKIElzb0FsaWduZWRNZW1vcnlBbGxvY2F0b3I6 On5Jc29BbGlnbmVkTWVtb3J5QWxsb2NhdG9yKCkKIHsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAw OyBpIDwgbV9ibG9ja3Muc2l6ZSgpOyArK2kpIHsKKyAgICAgICAgdm9pZCogYmxvY2sgPSBtX2Js b2Nrc1tpXTsKKyAgICAgICAgaWYgKCFtX2NvbW1pdHRlZFtpXSkKKyAgICAgICAgICAgIE9TQWxs b2NhdG9yOjpjb21taXQoYmxvY2ssIE1hcmtlZEJsb2NrOjpibG9ja1NpemUsIHRydWUsIGZhbHNl KTsKKyAgICAgICAgZnJlZShibG9jayk7CisgICAgfQogfQogCiB2b2lkKiBJc29BbGlnbmVkTWVt b3J5QWxsb2NhdG9yOjp0cnlBbGxvY2F0ZUFsaWduZWRNZW1vcnkoc2l6ZV90IGFsaWdubWVudCwg c2l6ZV90IHNpemUpCkBAIC01NCw2ICs2MCw4IEBAIHZvaWQqIElzb0FsaWduZWRNZW1vcnlBbGxv Y2F0b3I6OnRyeUFsbG8KICAgICB9CiAgICAgCiAgICAgdm9pZCogcmVzdWx0ID0gZmFzdEFsaWdu ZWRNYWxsb2MoTWFya2VkQmxvY2s6OmJsb2NrU2l6ZSwgTWFya2VkQmxvY2s6OmJsb2NrU2l6ZSk7 CisgICAgaWYgKCFyZXN1bHQpCisgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIHVuc2lnbmVk IGluZGV4ID0gbV9ibG9ja3Muc2l6ZSgpOwogICAgIG1fYmxvY2tzLmFwcGVuZChyZXN1bHQpOwog ICAgIG1fYmxvY2tJbmRpY2VzLmFkZChyZXN1bHQsIGluZGV4KTsK