180407 2017-12-05 02:51:40 -0800 WebDriver: several tests in imported/w3c/webdriver/tests/sessions/new_session/merge.py are failing 2018-01-23 08:25:02 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/w3c/webdriver/issues/1203 InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez webkit-bug-importer oldest_to_newest 1378132 0 cgarcia 2017-12-05 02:51:40 -0800 WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_platform_name[body0] PASSED WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_platform_name[body1] PASSED WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_invalid[acceptInsecureCerts-value0] PASSED WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_invalid[unhandledPromptBehavior-value1] FAILED WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_invalid[unhandledPromptBehavior-value2] FAILED WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_invalid[timeouts-value3] PASSED WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_invalid[timeouts-value4] PASSED WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName FAILED WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_browserName FAILED Similar backtraces: new_session = <function create_session at 0x7f1318721758>, add_browser_capabilites = <function update_capabilities at 0x7f1318721848>, key = 'unhandledPromptBehavior' value = ('accept', 'accept') @pytest.mark.parametrize("key,value", invalid_merge) def test_merge_invalid(new_session, add_browser_capabilites, key, value): with pytest.raises(error.InvalidArgumentException): new_session({"capabilities": {"alwaysMatch": add_browser_capabilites({key: value[0]}), > "firstMatch": [{}, {key: value[1]}]}}) E Failed: DID NOT RAISE <class 'webdriver.error.InvalidArgumentException'> add_browser_capabilites = <function update_capabilities at 0x7f1318721848> key = 'unhandledPromptBehavior' new_session = <function create_session at 0x7f1318721758> value = ('accept', 'accept') We are accepting capabilities that we shouldn't. 1392042 1 cgarcia 2018-01-23 06:42:39 -0800 This is actually a bug in the spec, see https://github.com/w3c/webdriver/issues/1203. It seems the idea in any case is that we should check all the firstMatch capabilities before matching them, and return if there's any error. test_merge_platformName and test_merge_browserName are different issues, I'll file separate bug reports for those. 1392046 2 332026 cgarcia 2018-01-23 06:50:12 -0800 Created attachment 332026 Patch 1392063 3 cgarcia 2018-01-23 08:23:06 -0800 Committed r227414: <https://trac.webkit.org/changeset/227414> 1392064 4 webkit-bug-importer 2018-01-23 08:25:02 -0800 <rdar://problem/36776979> 332026 2018-01-23 06:50:12 -0800 2018-01-23 08:12:01 -0800 Patch wd-first-match-validate.diff text/plain 4909 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggYThmYTZmMjg4ZjAuLjEwNWQwMjU3MThlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAxLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IHNldmVyYWwgdGVzdHMgaW4g aW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9zZXNzaW9ucy9uZXdfc2Vzc2lvbi9tZXJnZS5w eSBhcmUgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgwNDA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBpcyBhY3R1YWxseSBhIGJ1ZyBpbiB0aGUgc3BlYywgc2VlIGh0dHBzOi8vZ2l0 aHViLmNvbS93M2Mvd2ViZHJpdmVyL2lzc3Vlcy8xMjAzLiBJdCBzZWVtcyB0aGUgaWRlYSBpbiBh bnkKKyAgICAgICAgY2FzZSBpcyB0aGF0IHdlIHNob3VsZCBjaGVjayBhbGwgdGhlIGZpcnN0TWF0 Y2ggY2FwYWJpbGl0aWVzIGJlZm9yZSBtYXRjaGluZyB0aGVtLCBhbmQgcmV0dXJuIGlmIHRoZXJl J3MgYW55CisgICAgICAgIGVycm9yLgorCisgICAgICAgICogV2ViRHJpdmVyU2VydmljZS5jcHA6 CisgICAgICAgIChXZWJEcml2ZXI6OldlYkRyaXZlclNlcnZpY2U6Om1lcmdlQ2FwYWJpbGl0aWVz IGNvbnN0KToKKyAgICAgICAgKFdlYkRyaXZlcjo6V2ViRHJpdmVyU2VydmljZTo6cHJvY2Vzc0Nh cGFiaWxpdGllcyBjb25zdCk6CisKIDIwMTgtMDEtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFdlYkRyaXZlcjogdGVzdCBpbXBvcnRlZC93 M2Mvd2ViZHJpdmVyL3Rlc3RzL3Nlc3Npb25zL25ld19zZXNzaW9uL3Jlc3BvbnNlLnB5Ojp0ZXN0 X3RpbWVvdXRzIGZhaWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNl cnZpY2UuY3BwIGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcAppbmRleCA4 ODI1ZWJkOTdkZS4uM2E4MTMzYWRmYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvV2Vi RHJpdmVyU2VydmljZS5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNl LmNwcApAQCAtNDYwLDEyICs0NjAsOCBAQCBSZWZQdHI8SlNPTjo6T2JqZWN0PiBXZWJEcml2ZXJT ZXJ2aWNlOjptZXJnZUNhcGFiaWxpdGllcyhjb25zdCBKU09OOjpPYmplY3QmIHJlcQogICAgICAg ICByZXN1bHQtPnNldFZhbHVlKGl0LT5rZXksIFJlZlB0cjxKU09OOjpWYWx1ZT4oaXQtPnZhbHVl KSk7CiAKICAgICBhdXRvIGZpcnN0TWF0Y2hFbmQgPSBmaXJzdE1hdGNoQ2FwYWJpbGl0aWVzLmVu ZCgpOwotICAgIGZvciAoYXV0byBpdCA9IGZpcnN0TWF0Y2hDYXBhYmlsaXRpZXMuYmVnaW4oKTsg aXQgIT0gZmlyc3RNYXRjaEVuZDsgKytpdCkgewotICAgICAgICBpZiAocmVxdWlyZWRDYXBhYmls aXRpZXMuZmluZChpdC0+a2V5KSAhPSByZXF1aXJlZEVuZCkKLSAgICAgICAgICAgIHJldHVybiBu dWxscHRyOwotCisgICAgZm9yIChhdXRvIGl0ID0gZmlyc3RNYXRjaENhcGFiaWxpdGllcy5iZWdp bigpOyBpdCAhPSBmaXJzdE1hdGNoRW5kOyArK2l0KQogICAgICAgICByZXN1bHQtPnNldFZhbHVl KGl0LT5rZXksIFJlZlB0cjxKU09OOjpWYWx1ZT4oaXQtPnZhbHVlKSk7Ci0gICAgfQogCiAgICAg cmV0dXJuIHJlc3VsdDsKIH0KQEAgLTU5Myw2ICs1ODksMTggQEAgUmVmUHRyPEpTT046Ok9iamVj dD4gV2ViRHJpdmVyU2VydmljZTo6cHJvY2Vzc0NhcGFiaWxpdGllcyhjb25zdCBKU09OOjpPYmpl Y3QmIHAKICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwo Q29tbWFuZFJlc3VsdDo6RXJyb3JDb2RlOjpJbnZhbGlkQXJndW1lbnQsIFN0cmluZygiSW52YWxp ZCBmaXJzdE1hdGNoIGNhcGFiaWxpdGllcyIpKSk7CiAgICAgICAgICAgICByZXR1cm4gbnVsbHB0 cjsKICAgICAgICAgfQorCisgICAgICAgIC8vIFZhbGlkYXRlIGhlcmUgdGhhdCBmaXJzdE1hdGNo Q2FwYWJpbGl0aWVzIGRvbid0IHNoYWRvdyBhbHdheXNNYXRjaENhcGFiaWxpdGllcy4KKyAgICAg ICAgYXV0byByZXF1aXJlZEVuZCA9IHJlcXVpcmVkQ2FwYWJpbGl0aWVzLT5lbmQoKTsKKyAgICAg ICAgYXV0byBmaXJzdE1hdGNoRW5kID0gZmlyc3RNYXRjaENhcGFiaWxpdGllcy0+ZW5kKCk7Cisg ICAgICAgIGZvciAoYXV0byBpdCA9IGZpcnN0TWF0Y2hDYXBhYmlsaXRpZXMtPmJlZ2luKCk7IGl0 ICE9IGZpcnN0TWF0Y2hFbmQ7ICsraXQpIHsKKyAgICAgICAgICAgIGlmIChyZXF1aXJlZENhcGFi aWxpdGllcy0+ZmluZChpdC0+a2V5KSAhPSByZXF1aXJlZEVuZCkgeworICAgICAgICAgICAgICAg IGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJlc3VsdDo6RXJy b3JDb2RlOjpJbnZhbGlkQXJndW1lbnQsCisgICAgICAgICAgICAgICAgICAgIG1ha2VTdHJpbmco IkludmFsaWQgZmlyc3RNYXRjaCBjYXBhYmlsaXRpZXM6IGtleSAiLCBpdC0+a2V5LCAiIGlzIHBy ZXNlbnQgaW4gYWx3YXlzTWF0Y2giKSkpOworICAgICAgICAgICAgICAgIHJldHVybiBudWxscHRy OworICAgICAgICAgICAgfQorICAgICAgICB9CisKICAgICAgICAgLy8gNS4yLiBBcHBlbmQgdmFs aWRhdGVkIGNhcGFiaWxpdGllcyB0byB2YWxpZGF0ZWQgZmlyc3QgbWF0Y2ggY2FwYWJpbGl0aWVz LgogICAgICAgICB2YWxpZGF0ZWRGaXJzdE1hdGNoQ2FwYWJpbGl0aWVzTGlzdC51bmNoZWNrZWRB cHBlbmQoV1RGTW92ZShmaXJzdE1hdGNoQ2FwYWJpbGl0aWVzKSk7CiAgICAgfQpkaWZmIC0tZ2l0 IGEvV2ViRHJpdmVyVGVzdHMvQ2hhbmdlTG9nIGIvV2ViRHJpdmVyVGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IDVhMWRmNTQ3ZDEyLi4yY2Y4ZjI2Mjc1ZCAxMDA2NDQKLS0tIGEvV2ViRHJpdmVyVGVzdHMv Q2hhbmdlTG9nCisrKyBiL1dlYkRyaXZlclRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDE4LTAxLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K KworICAgICAgICBXZWJEcml2ZXI6IHNldmVyYWwgdGVzdHMgaW4gaW1wb3J0ZWQvdzNjL3dlYmRy aXZlci90ZXN0cy9zZXNzaW9ucy9uZXdfc2Vzc2lvbi9tZXJnZS5weSBhcmUgZmFpbGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNDA3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGV4cGVj dGF0aW9ucyBmb3IgdGVzdHMgdGhhdCBhcmUgcGFzc2luZyBub3cgYW5kIHVwZGF0ZSB0aGUgYnVn IG51bWJlciBvZiB0aGUgb3RoZXIgb25lcyByZWZlcmVuY2luZworICAgICAgICAjMTgwNDA3Lgor CisgICAgICAgICogVGVzdEV4cGVjdGF0aW9ucy5qc29uOgorCiAyMDE4LTAxLTIzICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6 IHRlc3QgaW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9zZXNzaW9ucy9uZXdfc2Vzc2lvbi9y ZXNwb25zZS5weTo6dGVzdF90aW1lb3V0cyBmYWlscwpkaWZmIC0tZ2l0IGEvV2ViRHJpdmVyVGVz dHMvVGVzdEV4cGVjdGF0aW9ucy5qc29uIGIvV2ViRHJpdmVyVGVzdHMvVGVzdEV4cGVjdGF0aW9u cy5qc29uCmluZGV4IDkwMzZiYjk2YjJmLi4xYmZhNzFjM2JjMSAxMDA2NDQKLS0tIGEvV2ViRHJp dmVyVGVzdHMvVGVzdEV4cGVjdGF0aW9ucy5qc29uCisrKyBiL1dlYkRyaXZlclRlc3RzL1Rlc3RF eHBlY3RhdGlvbnMuanNvbgpAQCAtMTkzLDE3ICsxOTMsMTEgQEAKICAgICB9LAogICAgICJpbXBv cnRlZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL3Nlc3Npb25zL25ld19zZXNzaW9uL21lcmdlLnB5Ijog ewogICAgICAgICAic3VidGVzdHMiOiB7Ci0gICAgICAgICAgICAidGVzdF9tZXJnZV9pbnZhbGlk W3VuaGFuZGxlZFByb21wdEJlaGF2aW9yLXZhbHVlMV0iOiB7Ci0gICAgICAgICAgICAgICAgImV4 cGVjdGVkIjogeyJhbGwiOiB7InN0YXR1cyI6IFsiRkFJTCJdLCAiYnVnIjogIndlYmtpdC5vcmcv Yi8xODA0MDcifX0KLSAgICAgICAgICAgIH0sCi0gICAgICAgICAgICAidGVzdF9tZXJnZV9pbnZh bGlkW3VuaGFuZGxlZFByb21wdEJlaGF2aW9yLXZhbHVlMl0iOiB7Ci0gICAgICAgICAgICAgICAg ImV4cGVjdGVkIjogeyJhbGwiOiB7InN0YXR1cyI6IFsiRkFJTCJdLCAiYnVnIjogIndlYmtpdC5v cmcvYi8xODA0MDcifX0KLSAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAidGVzdF9tZXJnZV9w bGF0Zm9ybU5hbWUiOiB7Ci0gICAgICAgICAgICAgICAgImV4cGVjdGVkIjogeyJhbGwiOiB7InN0 YXR1cyI6IFsiRkFJTCJdLCAiYnVnIjogIndlYmtpdC5vcmcvYi8xODA0MDcifX0KKyAgICAgICAg ICAgICAgICAiZXhwZWN0ZWQiOiB7ImFsbCI6IHsic3RhdHVzIjogWyJGQUlMIl0sICJidWciOiAi d2Via2l0Lm9yZy9iLzE4MTk4NCJ9fQogICAgICAgICAgICAgfSwKICAgICAgICAgICAgICJ0ZXN0 X21lcmdlX2Jyb3dzZXJOYW1lIjogewotICAgICAgICAgICAgICAgICJleHBlY3RlZCI6IHsiYWxs IjogeyJzdGF0dXMiOiBbIkZBSUwiXSwgImJ1ZyI6ICJ3ZWJraXQub3JnL2IvMTgwNDA3In19Cisg ICAgICAgICAgICAgICAgImV4cGVjdGVkIjogeyJhbGwiOiB7InN0YXR1cyI6IFsiRkFJTCJdLCAi YnVnIjogIndlYmtpdC5vcmcvYi8xODE5ODUifX0KICAgICAgICAgICAgIH0KICAgICAgICAgfQog ICAgIH0sCg==