180395 2017-12-04 23:18:00 -0800 Math: don't redundantly check for exceptions, just release scope 2017-12-04 23:52:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 180297 1 jfbastien jfbastien commit-queue darin fpizlo jfbastien keith_miller mark.lam msaboff rmorisset saam webkit-bug-importer oldest_to_newest 1378101 0 jfbastien 2017-12-04 23:18:00 -0800 In #180297 two of the exeptions checks could just have been exception scope releases before the return, which is ever-so-slightly more efficient. Make it so. 1378102 1 328442 jfbastien 2017-12-04 23:20:33 -0800 Created attachment 328442 patch Mark rubber-stamped this in-person earlier today. 1378107 2 328442 commit-queue 2017-12-04 23:51:36 -0800 Comment on attachment 328442 patch Clearing flags on attachment: 328442 Committed r225519: <https://trac.webkit.org/changeset/225519> 1378108 3 commit-queue 2017-12-04 23:51:38 -0800 All reviewed patches have been landed. Closing bug. 1378109 4 webkit-bug-importer 2017-12-04 23:52:19 -0800 <rdar://problem/35849413> 328442 2017-12-04 23:20:33 -0800 2017-12-04 23:51:36 -0800 patch 0001-Math-don-t-redundantly-check-for-exceptions-just-rel.patch text/plain 2451 jfbastien RnJvbSBiNjdmMTRjNjRjNzlhNTY0OTQzYWMwNzM5ZDc1YTNjYjFjOGMxOTc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBNb24sIDQgRGVjIDIwMTcgMjM6MjA6MDIgLTA4MDAKU3ViamVjdDogW1BBVENIXSBNYXRoOiBk b24ndCByZWR1bmRhbnRseSBjaGVjayBmb3IgZXhjZXB0aW9ucywganVzdCByZWxlYXNlCiBzY29w ZQoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICB8IDE3 ICsrKysrKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoT2Jq ZWN0LmNwcCB8ICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMiBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBhMGRmOGI0Li42NGQ5ZWZj IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNy0xMi0wNCAg SkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWF0aDogZG9uJ3Qg cmVkdW5kYW50bHkgY2hlY2sgZm9yIGV4Y2VwdGlvbnMsIGp1c3QgcmVsZWFzZSBzY29wZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMzk1CisKKyAg ICAgICAgUnViYmVyIHN0YW1wZWQgYnkgTWFyayBMYW0uCisKKyAgICAgICAgVHdvIG9mIHRoZSBl eGNlcHRpb25zIGNoZWNrcyBjb3VsZCBqdXN0IGhhdmUgYmVlbiBleGNlcHRpb24gc2NvcGUKKyAg ICAgICAgcmVsZWFzZXMgYmVmb3JlIHRoZSByZXR1cm4sIHdoaWNoIGlzIGV2ZXItc28tc2xpZ2h0 bHkgbW9yZQorICAgICAgICBlZmZpY2llbnQuIFRoZSBzYW1lIHRlY2huaWNhbGx5IGFwcGxpZXMg d2hlcmUgd2UgaGF2ZSBsb29wcyBvdmVyCisgICAgICAgIHBhcmFtZXRlcnMsIGJ1dCBkb2luZyB0 aGUgc2NvcGUgcmVsZWFzZSB0aGVyZSBpc24ndCByZWFsbHkgbW9yZQorICAgICAgICBlZmZpY2ll bnQgYW5kIGlzIHdheSBoYXJkZXIgdG8gcmVhZC4KKworICAgICAgICAqIHJ1bnRpbWUvTWF0aE9i amVjdC5jcHA6CisgICAgICAgIChKU0M6Om1hdGhQcm90b0Z1bmNBVGFuMik6CisgICAgICAgIChK U0M6Om1hdGhQcm90b0Z1bmNQb3cpOgorCiAyMDE3LTEyLTA0ICBEYXZpZCBRdWVzYWRhICA8ZGF2 aWRfcXVlc2FkYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgY2xhc3MgZm9yIHBhcnNpbmcg YXBwbGljYXRpb24gbWFuaWZlc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9NYXRoT2JqZWN0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01h dGhPYmplY3QuY3BwCmluZGV4IDVjZDUzNTkuLmI0ZjkzYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3QuY3BwCkBAIC0xNTMsOCArMTUzLDggQEAgRW5jb2Rl ZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBtYXRoUHJvdG9GdW5jQVRhbjIoRXhlY1N0YXRlKiBleGVj KQogICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKICAgICBkb3VibGUg YXJnMCA9IGV4ZWMtPmFyZ3VtZW50KDApLnRvTnVtYmVyKGV4ZWMpOwogICAgIFJFVFVSTl9JRl9F WENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOworICAgIHNjb3BlLnJlbGVhc2UoKTsK ICAgICBkb3VibGUgYXJnMSA9IGV4ZWMtPmFyZ3VtZW50KDEpLnRvTnVtYmVyKGV4ZWMpOwotICAg IFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwogICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoanNEb3VibGVOdW1iZXIoYXRhbjIoYXJnMCwgYXJnMSkpKTsKIH0K IApAQCAtMjY1LDggKzI2NSw4IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgbWF0aFBy b3RvRnVuY1BvdyhFeGVjU3RhdGUqIGV4ZWMpCiAKICAgICBkb3VibGUgYXJnID0gZXhlYy0+YXJn dW1lbnQoMCkudG9OdW1iZXIoZXhlYyk7CiAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwg ZW5jb2RlZEpTVmFsdWUoKSk7CisgICAgc2NvcGUucmVsZWFzZSgpOwogICAgIGRvdWJsZSBhcmcy ID0gZXhlYy0+YXJndW1lbnQoMSkudG9OdW1iZXIoZXhlYyk7Ci0gICAgUkVUVVJOX0lGX0VYQ0VQ VElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKEpTVmFsdWUob3BlcmF0aW9uTWF0aFBvdyhhcmcsIGFyZzIpKSk7CiB9Ci0tIAoyLjkuMwoK