180379 2017-12-04 14:14:18 -0800 Exclude some more leak callstacks 2017-12-04 15:46:07 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck ap commit-queue ews-watchlist glenn joepeck lforschler webkit-bug-importer oldest_to_newest 1377909 0 joepeck 2017-12-04 14:14:18 -0800 Exclude some more leak callstacks And fix a typo in related code. 1377914 1 328390 joepeck 2017-12-04 14:17:52 -0800 Created attachment 328390 [PATCH] Proposed Fix I spent 30 minutes trying to figure out how to run: Tools/Scripts/webkitpy/port/leakdetector_unittest.py without success. However it looks like the perl under the hood turns this string into a Regex so I can't just do '-[NSSpellChecker init]'. 1377915 2 ews-watchlist 2017-12-04 14:19:08 -0800 Attachment 328390 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/port/leakdetector.py:51: [LeakDetector._types_to_exclude_from_leaks] An attribute affected in webkitpy.port.leakdetector_unittest line 52 hide this method [pylint/E0202] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1377919 3 328390 ap 2017-12-04 14:25:48 -0800 Comment on attachment 328390 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=328390&action=review > I spent 30 minutes trying to figure out how to run: > > Tools/Scripts/webkitpy/port/leakdetector_unittest.py test-webkitpy is the script to run. It passed in EWS. Please update the radars saying that you added these exclusions! > Tools/Scripts/webkitpy/port/leakdetector.py:60 > + 'NSSpellChecker init', # <rdar://problem/35434615> This seems acceptable for now, but really this silences all leaks in NSSpellChecker initialisation, which may be too much. FWIW, see <http://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/port/leakdetector.py?rev=225239> for how to make these exclusions conditional based on macOS version. 1377925 4 joepeck 2017-12-04 14:46:22 -0800 > > I spent 30 minutes trying to figure out how to run: > > > > Tools/Scripts/webkitpy/port/leakdetector_unittest.py > > test-webkitpy is the script to run. It passed in EWS. test-webkitpy never completes for me when run locally. It seems to hang with 7 tests left, forever (or at least more then a few minutes which is when I killed it) I also can't figure out how to run just a subset of tests with it. 1377933 5 328390 commit-queue 2017-12-04 14:51:17 -0800 Comment on attachment 328390 [PATCH] Proposed Fix Clearing flags on attachment: 328390 Committed r225496: <https://trac.webkit.org/changeset/225496> 1377934 6 commit-queue 2017-12-04 14:51:18 -0800 All reviewed patches have been landed. Closing bug. 1377936 7 webkit-bug-importer 2017-12-04 14:52:20 -0800 <rdar://problem/35840167> 1377947 8 ap 2017-12-04 15:15:15 -0800 > test-webkitpy never completes for me when run locally. It seems to hang with 7 tests left, forever (or at least more then a few minutes which is when I killed it) That would be a bad bug. Please run with --verbose, and file a bug about this. 1377966 9 joepeck 2017-12-04 15:46:07 -0800 > That would be a bad bug. Please run with --verbose, and file a bug about this. I worked this out with Safari engineers on IRC. It has to deal with my PYTHONPATH including some things that changes test-webkitpy behavior. I have a workaround. -- For the purposes of this bug, what I really wanted was this: $ Tools/Scripts/test-webkitpy webkitpy.port.leakdetector_unittest Where the magic identifier is the path to leakdetector_unittest.py with '/' characters replaced with '.'s. 328390 2017-12-04 14:17:52 -0800 2017-12-04 14:51:17 -0800 [PATCH] Proposed Fix leaks-ignore-1.patch text/plain 3411 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MGEx MzA4YjY4Yi4uNjk1MjRkZWY5Y2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNy0xMi0wNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIEV4Y2x1ZGUgc29tZSBtb3JlIGxl YWsgY2FsbHN0YWNrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgwMzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGVha2RldGVjdG9yLnB5OgorICAgICAgICAo TGVha0RldGVjdG9yLl90eXBlc190b19leGNsdWRlX2Zyb21fbGVha3MpOgorICAgICAgICAoTGVh a0RldGVjdG9yLl9jYWxsc3RhY2tzX3RvX2V4Y2x1ZGVfZnJvbV9sZWFrcyk6CisgICAgICAgIChM ZWFrRGV0ZWN0b3IuX2xlYWtzX2FyZ3MpOgorICAgICAgICAoTGVha0RldGVjdG9yLl90eXBlc190 b19leGx1ZGVfZnJvbV9sZWFrcyk6IERlbGV0ZWQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9wb3J0L2xlYWtkZXRlY3Rvcl91bml0dGVzdC5weToKKyAgICAgICAgKExlYWtEZXRlY3RvclRl c3QudGVzdF9sZWFrc19hcmdzKToKKwogMjAxNy0xMi0wMyAgWXVzdWtlIFN1enVraSAgPHV0YXRh bmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBXVEYgc2hvdWxkbid0IGhhdmUgYm90aCBUaHJl YWQgYW5kIFRocmVhZElkZW50aWZpZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC9sZWFrZGV0ZWN0b3IucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGVh a2RldGVjdG9yLnB5CmluZGV4IGE1NmFkNDIxZDBhLi44MjlhMTZhZjVmZiAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xlYWtkZXRlY3Rvci5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvbGVha2RldGVjdG9yLnB5CkBAIC00OCwxMyArNDgsMTYgQEAg Y2xhc3MgTGVha0RldGVjdG9yKG9iamVjdCk6CiAgICAgIyBUaGlzIGFsbG93cyB1cyBpZ25vcmUg a25vd24gbGVha3MgYW5kIG9ubHkgYmUgYWxlcnRlZCB3aGVuIG5ldyBsZWFrcyBvY2N1ci4gU29t ZSBsZWFrcyBhcmUgaW4gdGhlIG9sZAogICAgICMgdmVyc2lvbnMgb2YgdGhlIHN5c3RlbSBmcmFt ZXdvcmtzIHRoYXQgYXJlIGJlaW5nIHVzZWQgYnkgdGhlIGxlYWtzIGJvdHMuIEV2ZW4gdGhvdWdo IGEgbGVhayBoYXMgYmVlbgogICAgICMgZml4ZWQsIGl0IHdpbGwgYmUgbGlzdGVkIGhlcmUgdW50 aWwgdGhlIGJvdCBoYXMgYmVlbiB1cGRhdGVkIHdpdGggdGhlIG5ld2VyIGZyYW1ld29ya3MuCi0g ICAgZGVmIF90eXBlc190b19leGx1ZGVfZnJvbV9sZWFrcyhzZWxmKToKKyAgICBkZWYgX3R5cGVz X3RvX2V4Y2x1ZGVfZnJvbV9sZWFrcyhzZWxmKToKICAgICAgICAgIyBDdXJyZW50bHkgd2UgZG9u J3QgaGF2ZSBhbnkgdHlwZSBleGNsdWRlcyBmcm9tIE9TIGxlYWtzLCBidXQgd2Ugd2lsbCBsaWtl bHkgYWdhaW4gaW4gdGhlIGZ1dHVyZS4KICAgICAgICAgcmV0dXJuIFtdCiAKICAgICBkZWYgX2Nh bGxzdGFja3NfdG9fZXhjbHVkZV9mcm9tX2xlYWtzKHNlbGYpOgogICAgICAgICBjYWxsc3RhY2tz ID0gWwogICAgICAgICAgICAgJ1dURjo6Qml0VmVjdG9yOjpPdXRPZkxpbmVCaXRzOjpjcmVhdGUn LCAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE2NjIKKyAgICAg ICAgICAgICdXZWJDb3JlOjpjcmVhdGVQcml2YXRlU3RvcmFnZVNlc3Npb24nLCAjIDxyZGFyOi8v cHJvYmxlbS8zNTE4OTU2NT4KKyAgICAgICAgICAgICdDSURldmljZU1hbmFnZXJTdGFydE1vbml0 b3JpbmcnLCAjIDxyZGFyOi8vcHJvYmxlbS8zNTcxMTA1Mj4KKyAgICAgICAgICAgICdOU1NwZWxs Q2hlY2tlciBpbml0JywgIyA8cmRhcjovL3Byb2JsZW0vMzU0MzQ2MTU+CiAgICAgICAgIF0KICAg ICAgICAgcmV0dXJuIGNhbGxzdGFja3MKIApAQCAtNjIsNyArNjUsNyBAQCBjbGFzcyBMZWFrRGV0 ZWN0b3Iob2JqZWN0KToKICAgICAgICAgbGVha3NfYXJncyA9IFtdCiAgICAgICAgIGZvciBjYWxs c3RhY2sgaW4gc2VsZi5fY2FsbHN0YWNrc190b19leGNsdWRlX2Zyb21fbGVha3MoKToKICAgICAg ICAgICAgIGxlYWtzX2FyZ3MgKz0gWyctLWV4Y2x1ZGUtY2FsbHN0YWNrPSVzJyAlIGNhbGxzdGFj a10KLSAgICAgICAgZm9yIGV4Y2x1ZGVkX3R5cGUgaW4gc2VsZi5fdHlwZXNfdG9fZXhsdWRlX2Zy b21fbGVha3MoKToKKyAgICAgICAgZm9yIGV4Y2x1ZGVkX3R5cGUgaW4gc2VsZi5fdHlwZXNfdG9f ZXhjbHVkZV9mcm9tX2xlYWtzKCk6CiAgICAgICAgICAgICBsZWFrc19hcmdzICs9IFsnLS1leGNs dWRlLXR5cGU9JXMnICUgZXhjbHVkZWRfdHlwZV0KICAgICAgICAgbGVha3NfYXJncy5hcHBlbmQo cGlkKQogICAgICAgICByZXR1cm4gbGVha3NfYXJncwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L2xlYWtkZXRlY3Rvcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC9sZWFrZGV0ZWN0b3JfdW5pdHRlc3QucHkKaW5kZXggZmMyNjE5Y2ExNDEu LmNhM2U2MWM5NmNmIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGVh a2RldGVjdG9yX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9s ZWFrZGV0ZWN0b3JfdW5pdHRlc3QucHkKQEAgLTQ5LDcgKzQ5LDcgQEAgY2xhc3MgTGVha0RldGVj dG9yVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3RfbGVha3NfYXJncyhzZWxm KToKICAgICAgICAgZGV0ZWN0b3IgPSBzZWxmLl9tYWtlX2RldGVjdG9yKCkKICAgICAgICAgZGV0 ZWN0b3IuX2NhbGxzdGFja3NfdG9fZXhjbHVkZV9mcm9tX2xlYWtzID0gbGFtYmRhOiBbJ2ZvbyBi YXInLCAnQkFaJ10KLSAgICAgICAgZGV0ZWN0b3IuX3R5cGVzX3RvX2V4bHVkZV9mcm9tX2xlYWtz ID0gbGFtYmRhOiBbJ2FiY2RlZmcnLCAnaGkgamtsbW5vJ10KKyAgICAgICAgZGV0ZWN0b3IuX3R5 cGVzX3RvX2V4Y2x1ZGVfZnJvbV9sZWFrcyA9IGxhbWJkYTogWydhYmNkZWZnJywgJ2hpIGprbG1u byddCiAgICAgICAgIGV4cGVjdGVkX2FyZ3MgPSBbJy0tZXhjbHVkZS1jYWxsc3RhY2s9Zm9vIGJh cicsICctLWV4Y2x1ZGUtY2FsbHN0YWNrPUJBWicsICctLWV4Y2x1ZGUtdHlwZT1hYmNkZWZnJywg Jy0tZXhjbHVkZS10eXBlPWhpIGprbG1ubycsIDEyMzRdCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwoZGV0ZWN0b3IuX2xlYWtzX2FyZ3MoMTIzNCksIGV4cGVjdGVkX2FyZ3MpCiAK