180377 2017-12-04 14:05:54 -0800 REGRESSION (r211531): Text flow changes and overlaps other text after double-click selecting paragraph 2017-12-04 14:52:31 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser zalan oldest_to_newest 1377897 0 zalan 2017-12-04 14:05:54 -0800 rdar://problem/34337967 1377904 1 328387 zalan 2017-12-04 14:09:35 -0800 Created attachment 328387 Patch 1377913 2 328387 koivisto 2017-12-04 14:17:17 -0800 Comment on attachment 328387 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328387&action=review > Source/WebCore/rendering/SimpleLineLayout.cpp:605 > + line.setLogicalLeftOffset(flow.logicalLeftOffsetForLine(height, DoNotIndentText, logicalHeight) + (shouldApplyTextIndent && isFirstLine ? flow.textIndentOffset() : LayoutUnit(0))); I wonder if the default argument for the height in flow.logicalLeft/RightOffsetForLine could be removed? It feels wrong to call it without knowing where the line is. 1377916 3 zalan 2017-12-04 14:19:59 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 328387 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328387&action=review > > > Source/WebCore/rendering/SimpleLineLayout.cpp:605 > > + line.setLogicalLeftOffset(flow.logicalLeftOffsetForLine(height, DoNotIndentText, logicalHeight) + (shouldApplyTextIndent && isFirstLine ? flow.textIndentOffset() : LayoutUnit(0))); > > I wonder if the default argument for the height in > flow.logicalLeft/RightOffsetForLine could be removed? It feels wrong to call > it without knowing where the line is. Yeah, good point. Will address it in a separate patch. 1377937 4 328387 commit-queue 2017-12-04 14:52:30 -0800 Comment on attachment 328387 Patch Clearing flags on attachment: 328387 Committed r225497: <https://trac.webkit.org/changeset/225497> 1377938 5 commit-queue 2017-12-04 14:52:31 -0800 All reviewed patches have been landed. Closing bug. 328387 2017-12-04 14:09:35 -0800 2017-12-04 14:52:30 -0800 Patch bug-180377-20171204140934.patch text/plain 4818 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzEzMmRmMTZiZTZiMTg3 ZDlkZWRmMTE5NDc2ZmM4MDJlNDUzM2ExMS4uMWFmNGZjNjYyY2FjYzAyZjk4ZTI0MmVmZTc1OTEz M2FkMGU5Zjg1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEyLTA0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIxMTUz MSk6IFRleHQgZmxvdyBjaGFuZ2VzIGFuZCBvdmVybGFwcyBvdGhlciB0ZXh0IGFmdGVyIGRvdWJs ZS1jbGljayBzZWxlY3RpbmcgcGFyYWdyYXBoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODAzNzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM0MzM3 OTY3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRh a2UgZmxvYXRzIGludG8gYWNjb3VudCB3aGVuIGNvbXB1dGluZyB0aGUgYXZhaWxhYmxlIHdpZHRo IGZvciBhIGNlcnRhaW4gdmVydGljYWwgcG9zaXRpb24uCisKKyAgICAgICAgVGVzdDogZmFzdC9i bG9jay9mbG9hdC9zaW1wbGUtbGluZS1sYXlvdXQtZmxvYXQtc2hyaW5rLWxpbmUuaHRtbAorCisg ICAgICAgICogcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U2ltcGxlTGluZUxheW91dDo6dXBkYXRlTGluZUNvbnN0cmFpbnMpOgorCiAyMDE3LTExLTI5 ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgR0Mgc2hvdWxkIHN1 cHBvcnQgaXNvaGVhcHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1w bGVMaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5 b3V0LmNwcAppbmRleCBjODM2ZDFlYzVmNDY5NGRmZWQ2Y2FhMTMxM2YyZjg0NjhhYzljYjExLi44 Nzc3ZGMwOTliOGU4MDdiNjc0ZWFiOWY5NjdjNjExYzZlZDkzMzZjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCkBAIC02MDEsOCArNjAxLDkgQEAg c3RhdGljIHZvaWQgdXBkYXRlTGluZUNvbnN0cmFpbnMoY29uc3QgUmVuZGVyQmxvY2tGbG93JiBm bG93LCBMaW5lU3RhdGUmIGxpbmUsIGMKIHsKICAgICBib29sIHNob3VsZEFwcGx5VGV4dEluZGVu dCA9ICFmbG93LmlzQW5vbnltb3VzKCkgfHwgZmxvdy5wYXJlbnQoKS0+Zmlyc3RDaGlsZCgpID09 ICZmbG93OwogICAgIExheW91dFVuaXQgaGVpZ2h0ID0gZmxvdy5sb2dpY2FsSGVpZ2h0KCk7Ci0g ICAgbGluZS5zZXRMb2dpY2FsTGVmdE9mZnNldChmbG93LmxvZ2ljYWxMZWZ0T2Zmc2V0Rm9yTGlu ZShoZWlnaHQsIERvTm90SW5kZW50VGV4dCkgKyAoc2hvdWxkQXBwbHlUZXh0SW5kZW50ICYmIGlz Rmlyc3RMaW5lID8gZmxvdy50ZXh0SW5kZW50T2Zmc2V0KCkgOiBMYXlvdXRVbml0KDApKSk7Ci0g ICAgZmxvYXQgbG9naWNhbFJpZ2h0T2Zmc2V0ID0gZmxvdy5sb2dpY2FsUmlnaHRPZmZzZXRGb3JM aW5lKGhlaWdodCwgRG9Ob3RJbmRlbnRUZXh0KTsKKyAgICBMYXlvdXRVbml0IGxvZ2ljYWxIZWln aHQgPSBmbG93Lm1pbkxpbmVIZWlnaHRGb3JSZXBsYWNlZFJlbmRlcmVyKGZhbHNlLCAwKTsKKyAg ICBsaW5lLnNldExvZ2ljYWxMZWZ0T2Zmc2V0KGZsb3cubG9naWNhbExlZnRPZmZzZXRGb3JMaW5l KGhlaWdodCwgRG9Ob3RJbmRlbnRUZXh0LCBsb2dpY2FsSGVpZ2h0KSArIChzaG91bGRBcHBseVRl eHRJbmRlbnQgJiYgaXNGaXJzdExpbmUgPyBmbG93LnRleHRJbmRlbnRPZmZzZXQoKSA6IExheW91 dFVuaXQoMCkpKTsKKyAgICBmbG9hdCBsb2dpY2FsUmlnaHRPZmZzZXQgPSBmbG93LmxvZ2ljYWxS aWdodE9mZnNldEZvckxpbmUoaGVpZ2h0LCBEb05vdEluZGVudFRleHQsIGxvZ2ljYWxIZWlnaHQp OwogICAgIGxpbmUuc2V0QXZhaWxhYmxlV2lkdGgoc3RkOjptYXg8ZmxvYXQ+KDAsIGxvZ2ljYWxS aWdodE9mZnNldCAtIGxpbmUubG9naWNhbExlZnRPZmZzZXQoKSkpOwogICAgIGlmIChzdHlsZS50 ZXh0QWxpZ24gPT0gSlVTVElGWSkKICAgICAgICAgbGluZS5zZXROZWVkc0FsbEZyYWdtZW50cygp OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IDZjYWNiOGUwOTg3ZjU1NzBhYzhiMDk0ZDY4NjRlMjNiMDhhYmMxMzYuLjhiY2Nh YzBlNGY4MGQzNWRmMWIzMGQ3ODEyZjc5ODE5MDAwNzA5ZjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA QAorMjAxNy0xMi0wNCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIyMTE1MzEpOiBUZXh0IGZsb3cgY2hhbmdlcyBhbmQgb3ZlcmxhcHMgb3Ro ZXIgdGV4dCBhZnRlciBkb3VibGUtY2xpY2sgc2VsZWN0aW5nIHBhcmFncmFwaAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMzc3CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNDMzNzk2Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGZhc3QvYmxvY2svZmxvYXQvc2ltcGxlLWxpbmUtbGF5b3V0LWZs b2F0LXNocmluay1saW5lLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvYmxv Y2svZmxvYXQvc2ltcGxlLWxpbmUtbGF5b3V0LWZsb2F0LXNocmluay1saW5lLmh0bWw6IEFkZGVk LgorCiAyMDE3LTExLTI5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgTGF5b3V0VGVzdCBodHRwL3Rlc3RzL3dvcmtlcnMvc2VydmljZS9yZWdpc3RyYXRpb24tY2xl YXItcmVkdW5kYW50LXdvcmtlci5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9ibG9jay9mbG9hdC9zaW1wbGUtbGluZS1sYXlvdXQtZmxvYXQtc2hy aW5rLWxpbmUtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvc2lt cGxlLWxpbmUtbGF5b3V0LWZsb2F0LXNocmluay1saW5lLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uODZhYTViNzMzY2FjYTU0ZTg4ODQ1NTU5MGFjYTg3NzA2ZTViMGYzOAotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvc2ltcGxlLWxpbmUtbGF5b3V0LWZs b2F0LXNocmluay1saW5lLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxlPgorLmZsb2F0aW5nIHsKKyAgICB3aWR0aDog NDBweDsKKyAgICBoZWlnaHQ6IDEwcHg7CisgICAgYm9yZGVyOiAxcHggc29saWQgYmx1ZTsKK30K KworLmNvbnRhaW5lciB7IAorICAgIHdpZHRoOiAxNTBweDsKK30KKzwvc3R5bGU+Cis8c2NyaXB0 PgoraWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldFNpbXBs ZUxpbmVMYXlvdXRFbmFibGVkKGZhbHNlKTsKKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8 ZGl2IGNsYXNzPWNvbnRhaW5lcj4KKyAgPGRpdiBjbGFzcz1mbG9hdGluZyBzdHlsZT0iZmxvYXQ6 IGxlZnQiPjwvZGl2PgorICA8ZGl2IGNsYXNzPWZsb2F0aW5nIHN0eWxlPSJmbG9hdDogcmlnaHQ7 IGNsZWFyOiBsZWZ0Ij48L2Rpdj4KKyAgPGRpdj5QYXNzIGlmICJ0aGlzIiB3cmFwcyB0byB0aGUg c2Vjb25kIGxpbmUuPC9kaXY+Cis8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvc2ltcGxlLWxpbmUtbGF5b3V0LWZsb2F0LXNo cmluay1saW5lLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L3NpbXBsZS1saW5l LWxheW91dC1mbG9hdC1zaHJpbmstbGluZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjhhNzg3MDNiNDgzODll YWFhNTFkMGQwYWQzOGE0YzVjZjk0NDJhNWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Jsb2NrL2Zsb2F0L3NpbXBsZS1saW5lLWxheW91dC1mbG9hdC1zaHJpbmstbGluZS5o dG1sCkBAIC0wLDAgKzEsMjMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxz dHlsZT4KKy5mbG9hdGluZyB7CisgICAgd2lkdGg6IDQwcHg7CisgICAgaGVpZ2h0OiAxMHB4Owor ICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsdWU7Cit9CisKKy5jb250YWluZXIgeyAKKyAgICB3aWR0 aDogMTUwcHg7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2IGNsYXNzPWNvbnRh aW5lcj4KKyAgPGRpdiBjbGFzcz1mbG9hdGluZyBzdHlsZT0iZmxvYXQ6IGxlZnQiPjwvZGl2Pgor ICA8ZGl2IGNsYXNzPWZsb2F0aW5nIHN0eWxlPSJmbG9hdDogcmlnaHQ7IGNsZWFyOiBsZWZ0Ij48 L2Rpdj4KKyAgPGRpdj5QYXNzIGlmICJ0aGlzIiB3cmFwcyB0byB0aGUgc2Vjb25kIGxpbmUuPC9k aXY+Cis8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K