<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>180372</bug_id>
          
          <creation_ts>2017-12-04 13:11:44 -0800</creation_ts>
          <short_desc>ServiceWorkerGlobalScope::skipWaiting(Ref&lt;DeferredPromise&gt;&amp;&amp;) is unsafe</short_desc>
          <delta_ts>2017-12-04 13:57:58 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=180329</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1377844</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-12-04 13:11:44 -0800</bug_when>
    <thetext>ServiceWorkerGlobalScope::skipWaiting(Ref&lt;DeferredPromise&gt;&amp;&amp;) is unsafe.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377858</commentid>
    <comment_count>1</comment_count>
      <attachid>328380</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-12-04 13:23:13 -0800</bug_when>
    <thetext>Created attachment 328380
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377888</commentid>
    <comment_count>2</comment_count>
      <attachid>328380</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-12-04 13:56:29 -0800</bug_when>
    <thetext>Comment on attachment 328380
Patch

Clearing flags on attachment: 328380

Committed r225491: &lt;https://trac.webkit.org/changeset/225491&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377889</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-12-04 13:56:30 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377891</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-12-04 13:57:58 -0800</bug_when>
    <thetext>&lt;rdar://problem/35838565&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>328380</attachid>
            <date>2017-12-04 13:23:13 -0800</date>
            <delta_ts>2017-12-04 13:56:29 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-180372-20171204132313.patch</filename>
            <type>text/plain</type>
            <size>3461</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDI1ZjljNzVkZDYzM2Ux
NGU0MTNjMWM3YmYyNTEyMzU1OWIyNjMzYy4uMGM2ZGMwMGQ1OTgyMmM1MzZiOGZlMjY0NTYyMzYx
ZjQzZTg5ZTZhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEyLTA0ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZVdvcmtlckdsb2Jh
bFNjb3BlOjpza2lwV2FpdGluZyhSZWY8RGVmZXJyZWRQcm9taXNlPiYmKSBpcyB1bnNhZmUKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDM3MgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZiB0aGUgV29y
a2VyVGhyZWFkIGFuZCBjYXB0dXJlIGl0IGluIHRoZSBsYW1iZGEuIEtlZXAgdGhlIHBlbmRpbmcg
cHJvbWlzZXMgaW4KKyAgICAgICAgYSBIYXNoTWFwIG9uIHRoZSBTZXJ2aWNlV29ya2VyR2xvYmFs
U2NvcGUgc28gdGhhdCB0aGV5IHN0YXkgb24gdGhlIHdvcmtlciB0aHJlYWQuCisKKyAgICAgICAg
KiB3b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckdsb2JhbFNjb3BlLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZTo6c2tpcFdhaXRpbmcpOgorICAgICAg
ICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyR2xvYmFsU2NvcGUuaDoKKwogMjAxNy0x
Mi0wNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1
cHBvcnQgaHR0cHM6Ly93M2MuZ2l0aHViLmlvL1NlcnZpY2VXb3JrZXIvI29uLWNsaWVudC11bmxv
YWQtYWxnb3JpdGhtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uv
U2VydmljZVdvcmtlckdsb2JhbFNjb3BlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vy
dmljZS9TZXJ2aWNlV29ya2VyR2xvYmFsU2NvcGUuY3BwCmluZGV4IGQ3NjI4ZGU2NGQwZGQ5YTQw
NWQ5ZmZiNDVlYjE1N2RiNTk1NDgwZWQuLjQ4ODI4ZDk2YTY2YWFhYzFlMTMxMmUwNmY5MTA0ODg5
NjI0ZDQ5ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2
aWNlV29ya2VyR2xvYmFsU2NvcGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vy
dmljZS9TZXJ2aWNlV29ya2VyR2xvYmFsU2NvcGUuY3BwCkBAIC01MCwxMSArNTAsMTYgQEAgU2Vy
dmljZVdvcmtlckdsb2JhbFNjb3BlOjp+U2VydmljZVdvcmtlckdsb2JhbFNjb3BlKCkgPSBkZWZh
dWx0OwogCiB2b2lkIFNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZTo6c2tpcFdhaXRpbmcoUmVmPERl
ZmVycmVkUHJvbWlzZT4mJiBwcm9taXNlKQogewotICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXMs
IHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgdGhyZWFkSWRlbnRpZmllciA9IHRocmVh
ZCgpLmlkZW50aWZpZXIoKSwgcHJvbWlzZSA9IFdURk1vdmUocHJvbWlzZSldKCkgbXV0YWJsZSB7
CisgICAgdWludDY0X3QgcmVxdWVzdElkZW50aWZpZXIgPSArK21fbGFzdFJlcXVlc3RJZGVudGlm
aWVyOworICAgIG1fcGVuZGluZ1NraXBXYWl0aW5nUHJvbWlzZXMuYWRkKHJlcXVlc3RJZGVudGlm
aWVyLCBXVEZNb3ZlKHByb21pc2UpKTsKKworICAgIGNhbGxPbk1haW5UaHJlYWQoW3dvcmtlclRo
cmVhZCA9IG1ha2VSZWYodGhyZWFkKCkpLCByZXF1ZXN0SWRlbnRpZmllcl0oKSBtdXRhYmxlIHsK
ICAgICAgICAgaWYgKGF1dG8qIGNvbm5lY3Rpb24gPSBTV0NvbnRleHRNYW5hZ2VyOjpzaW5nbGV0
b24oKS5jb25uZWN0aW9uKCkpIHsKLSAgICAgICAgICAgIGNvbm5lY3Rpb24tPnNraXBXYWl0aW5n
KHRocmVhZElkZW50aWZpZXIsIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gV1RGTW92ZShwcm90ZWN0
ZWRUaGlzKSwgcHJvbWlzZSA9IFdURk1vdmUocHJvbWlzZSldKCkgbXV0YWJsZSB7Ci0gICAgICAg
ICAgICAgICAgdGhyZWFkKCkucnVuTG9vcCgpLnBvc3RUYXNrKFtwcm9taXNlID0gV1RGTW92ZShw
cm9taXNlKSwgcHJvdGVjdGVkVGhpcyA9IFdURk1vdmUocHJvdGVjdGVkVGhpcyldKGF1dG8mKSB7
Ci0gICAgICAgICAgICAgICAgICAgIHByb21pc2UtPnJlc29sdmUoKTsKKyAgICAgICAgICAgIGNv
bm5lY3Rpb24tPnNraXBXYWl0aW5nKHdvcmtlclRocmVhZC0+aWRlbnRpZmllcigpLCBbd29ya2Vy
VGhyZWFkID0gV1RGTW92ZSh3b3JrZXJUaHJlYWQpLCByZXF1ZXN0SWRlbnRpZmllcl0geworICAg
ICAgICAgICAgICAgIHdvcmtlclRocmVhZC0+cnVuTG9vcCgpLnBvc3RUYXNrKFtyZXF1ZXN0SWRl
bnRpZmllcl0oYXV0byYgY29udGV4dCkgeworICAgICAgICAgICAgICAgICAgICBhdXRvJiBzY29w
ZSA9IGRvd25jYXN0PFNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZT4oY29udGV4dCk7CisgICAgICAg
ICAgICAgICAgICAgIGlmIChhdXRvIHByb21pc2UgPSBzY29wZS5tX3BlbmRpbmdTa2lwV2FpdGlu
Z1Byb21pc2VzLnRha2UocmVxdWVzdElkZW50aWZpZXIpKQorICAgICAgICAgICAgICAgICAgICAg
ICAgcHJvbWlzZS0+cmVzb2x2ZSgpOwogICAgICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAg
fSk7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vydmlj
ZS9TZXJ2aWNlV29ya2VyR2xvYmFsU2NvcGUuaCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vy
dmljZS9TZXJ2aWNlV29ya2VyR2xvYmFsU2NvcGUuaAppbmRleCBhN2RiMGNjNDNiNWU0YWY3ODI4
ZDgyMjU1NDBiZDc5ZWFjNTQ2MjlhLi4yMTE0MzFlZjM4NTQwNDlhOWQwOTcxMmU5NTU2MjU3MDE4
OGI5NDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2Vydmlj
ZVdvcmtlckdsb2JhbFNjb3BlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNl
L1NlcnZpY2VXb3JrZXJHbG9iYWxTY29wZS5oCkBAIC03Nyw2ICs3Nyw5IEBAIHByaXZhdGU6CiAg
ICAgUmVmPFNlcnZpY2VXb3JrZXJDbGllbnRzPiBtX2NsaWVudHM7CiAgICAgSGFzaE1hcDxTZXJ2
aWNlV29ya2VyQ2xpZW50SWRlbnRpZmllciwgU2VydmljZVdvcmtlckNsaWVudCo+IG1fY2xpZW50
TWFwOwogICAgIFZlY3RvcjxSZWY8RXh0ZW5kYWJsZUV2ZW50Pj4gbV9leHRlbmRlZEV2ZW50czsK
KworICAgIHVpbnQ2NF90IG1fbGFzdFJlcXVlc3RJZGVudGlmaWVyIHsgMCB9OworICAgIEhhc2hN
YXA8dWludDY0X3QsIFJlZlB0cjxEZWZlcnJlZFByb21pc2U+PiBtX3BlbmRpbmdTa2lwV2FpdGlu
Z1Byb21pc2VzOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>