180359 2017-12-04 09:05:41 -0800 Add support https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm 2017-12-04 10:56:25 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1377710 0 youennf 2017-12-04 09:05:41 -0800 Add support https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm 1377726 1 328354 youennf 2017-12-04 09:42:18 -0800 Created attachment 328354 Patch 1377756 2 328354 cdumez 2017-12-04 10:24:33 -0800 Comment on attachment 328354 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328354&action=review > Source/WebCore/workers/service/server/SWServerRegistration.cpp:165 > + handleClientUnload(); This looks wrong to me. The fact that removeClientUsingRegistration() is called does not necessarily mean a client was unloaded. 1377757 3 328354 cdumez 2017-12-04 10:26:09 -0800 Comment on attachment 328354 Patch I guess it does not matter though because the algorithm is a no-op when the unloaded client is not using the registration. 1377759 4 328354 cdumez 2017-12-04 10:29:06 -0800 Comment on attachment 328354 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328354&action=review yeah, seems fine given the client unload algorithm. > Source/WebCore/workers/service/server/SWServerRegistration.cpp:293 > + return; Technically the spec does not return here. I don't know if is matters or if it is a bug in the spec. Do we ever want to call tryActivate() on a registration that is uninstalling? 1377765 5 youennf 2017-12-04 10:35:42 -0800 (In reply to Chris Dumez from comment #4) > Comment on attachment 328354 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328354&action=review > > yeah, seems fine given the client unload algorithm. > > > Source/WebCore/workers/service/server/SWServerRegistration.cpp:293 > > + return; > > Technically the spec does not return here. I don't know if is matters or if > it is a bug in the spec. Do we ever want to call tryActivate() on a > registration that is uninstalling? Right, spec could be made clearer here. 1377775 6 328354 commit-queue 2017-12-04 10:55:11 -0800 Comment on attachment 328354 Patch Clearing flags on attachment: 328354 Committed r225483: <https://trac.webkit.org/changeset/225483> 1377776 7 commit-queue 2017-12-04 10:55:12 -0800 All reviewed patches have been landed. Closing bug. 1377777 8 webkit-bug-importer 2017-12-04 10:56:25 -0800 <rdar://problem/35833226> 328354 2017-12-04 09:42:18 -0800 2017-12-04 10:55:11 -0800 Patch bug-180359-20171204094217.patch text/plain 2880 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdhYTdjMWY5OTgwMjE1 ZWRhNDkxNWExMjY4ZTJlMTkxZjY2Njk0My4uMGE0MjNjMTA1ZTRiNzYxNzRlZjM1YjQ0MmFmN2Q4 ZTE0OTExY2YzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEyLTA0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc3VwcG9ydCBodHRw czovL3czYy5naXRodWIuaW8vU2VydmljZVdvcmtlci8jb24tY2xpZW50LXVubG9hZC1hbGdvcml0 aG0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDM1 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg YWxnb3JpdGhtIGlzIG5lZWRlZCBmb3IgaW1wbGVtZW50YXRpb24gb2YgY2xhaW0uCisgICAgICAg IEFzIHBlciBzcGVjaWZpY2F0aW9uLCBpdCBpcyBydW4gZm9yIGV2ZXJ5IGNsaWVudCB1bmxvYWQs IGhlbmNlIHdoeSB0aGlzIGlzIHB1dCBpbiByZW1vdmVDbGllbnRVc2luZ1JlZ2lzdHJhdGlvbi4K KworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXJSZWdpc3RyYXRpb24u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U1dTZXJ2ZXJSZWdpc3RyYXRpb246OnJlbW92ZUNsaWVu dFVzaW5nUmVnaXN0cmF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlNXU2VydmVyUmVnaXN0cmF0 aW9uOjpoYW5kbGVDbGllbnRVbmxvYWQpOgorICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9zZXJ2 ZXIvU1dTZXJ2ZXJSZWdpc3RyYXRpb24uaDoKKwogMjAxNy0xMi0wMiAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgV29ya2VyQ2FjaGVTdG9yYWdlQ29ubmVjdGlv biBzaG91bGQgaGFuZGxlIHRoZSBjYXNlIG9mIHRlcm1pbmF0ZWQgd29ya2VycwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlclJlZ2lzdHJh dGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVy UmVnaXN0cmF0aW9uLmNwcAppbmRleCA4Mjc0OWU0OGY4ZDdhYzUxYzA2Y2Y3MmRmNzhhMWE4ODZi MzNhMDQ5Li4xMDdkMjhlY2NjNzM2OGFmNDdiYzQ1ZTk3OGVkYjYwZDZlNzgyMjU0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyUmVnaXN0 cmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NX U2VydmVyUmVnaXN0cmF0aW9uLmNwcApAQCAtMTYxLDYgKzE2MSw4IEBAIHZvaWQgU1dTZXJ2ZXJS ZWdpc3RyYXRpb246OnJlbW92ZUNsaWVudFVzaW5nUmVnaXN0cmF0aW9uKGNvbnN0IFNlcnZpY2VX b3JrZXJDbGllCiAKICAgICBpZiAoaXRlcmF0b3ItPnZhbHVlLmlzRW1wdHkoKSkKICAgICAgICAg bV9jbGllbnRzVXNpbmdSZWdpc3RyYXRpb24ucmVtb3ZlKGl0ZXJhdG9yKTsKKworICAgIGhhbmRs ZUNsaWVudFVubG9hZCgpOwogfQogCiAvLyBodHRwczovL3czYy5naXRodWIuaW8vU2VydmljZVdv cmtlci8jbm90aWZ5LWNvbnRyb2xsZXItY2hhbmdlCkBAIC0yODIsNiArMjg0LDE2IEBAIHZvaWQg U1dTZXJ2ZXJSZWdpc3RyYXRpb246OmRpZEZpbmlzaEFjdGl2YXRpb24oU2VydmljZVdvcmtlcklk ZW50aWZpZXIgc2VydmljZVdvCiAgICAgdXBkYXRlV29ya2VyU3RhdGUoKmFjdGl2ZVdvcmtlcigp LCBTZXJ2aWNlV29ya2VyU3RhdGU6OkFjdGl2YXRlZCk7CiB9CiAKKy8vIGh0dHBzOi8vdzNjLmdp dGh1Yi5pby9TZXJ2aWNlV29ya2VyLyNvbi1jbGllbnQtdW5sb2FkLWFsZ29yaXRobQordm9pZCBT V1NlcnZlclJlZ2lzdHJhdGlvbjo6aGFuZGxlQ2xpZW50VW5sb2FkKCkKK3sKKyAgICBpZiAoaGFz Q2xpZW50c1VzaW5nUmVnaXN0cmF0aW9uKCkpCisgICAgICAgIHJldHVybjsKKyAgICBpZiAoaXNV bmluc3RhbGxpbmcoKSAmJiB0cnlDbGVhcigpKQorICAgICAgICByZXR1cm47CisgICAgdHJ5QWN0 aXZhdGUoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5BQkxF KFNFUlZJQ0VfV09SS0VSKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2 aWNlL3NlcnZlci9TV1NlcnZlclJlZ2lzdHJhdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvd29ya2Vy cy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlclJlZ2lzdHJhdGlvbi5oCmluZGV4IDIwYjI3ZDI5YzAy NjYxYmEwOGYzOTlkMjgyYzI0NzA0ZDZkMTQzNjAuLjEwZTcwYWUzZTE4ZmZkOGNhYmJiNzRjMzRi ZDMyOGM0ZGFjYzQwMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vydmlj ZS9zZXJ2ZXIvU1dTZXJ2ZXJSZWdpc3RyYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3Jr ZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyUmVnaXN0cmF0aW9uLmgKQEAgLTkwLDYgKzkwLDcg QEAgcHJpdmF0ZToKICAgICB2b2lkIGZvckVhY2hDb25uZWN0aW9uKGNvbnN0IFdURjo6RnVuY3Rp b248dm9pZChTV1NlcnZlcjo6Q29ubmVjdGlvbiYpPiYpOwogCiAgICAgdm9pZCBhY3RpdmF0ZSgp OworICAgIHZvaWQgaGFuZGxlQ2xpZW50VW5sb2FkKCk7CiAKICAgICBTZXJ2aWNlV29ya2VyUmVn aXN0cmF0aW9uSWRlbnRpZmllciBtX2lkZW50aWZpZXI7CiAgICAgU2VydmljZVdvcmtlclJlZ2lz dHJhdGlvbktleSBtX3JlZ2lzdHJhdGlvbktleTsK