180353 2017-12-04 06:13:26 -0800 Make ScrollingTreeNode::enclosingFrameNode return the node itself for frame nodes 2017-12-06 16:29:33 -0800 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 175135 149264 173833 1 fred.wang fred.wang cmarcelo ews-watchlist jamesr luiz tonikitoo webkit-bug-importer oldest_to_newest 1377668 0 fred.wang 2017-12-04 06:13:26 -0800 This function was introduced in bug 175135 to solve an issue with overflow nodes, but it should really include the frame itself when we implement ios frame scrolling. 1377669 1 328343 fred.wang 2017-12-04 06:27:10 -0800 Created attachment 328343 Patch 1377672 2 328343 tonikitoo 2017-12-04 06:54:56 -0800 Comment on attachment 328343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328343&action=review > Source/WebCore/ChangeLog:8 > + This function was introduced in bug 175135 to solve a rendering bug with fixed nodes in fixed nodes -> fixed positioned nodes, for clarity. > Source/WebCore/ChangeLog:20 > + (WebCore::ScrollingTreeNode::enclosingFrameNode const): Deleted. Renamed to make explicit nit: "Deleted" here is confusing. please remove. 1377703 3 fred.wang 2017-12-04 08:46:01 -0800 Committed r225480: <https://trac.webkit.org/changeset/225480> 1378900 4 webkit-bug-importer 2017-12-06 16:29:33 -0800 <rdar://problem/35896089> 328343 2017-12-04 06:27:10 -0800 2017-12-04 06:54:56 -0800 Patch 180353.patch text/plain 5035 fred.wang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYmE5NjdmMzI0NS4uMDk0OGIwZGEzMDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxNy0xMi0wNCAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+ CisKKyAgICAgICAgTWFrZSBTY3JvbGxpbmdUcmVlTm9kZTo6ZW5jbG9zaW5nRnJhbWVOb2RlIHJl dHVybiB0aGUgbm9kZSBpdHNlbGYgZm9yIGZyYW1lIG5vZGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAzNTMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZ1bmN0aW9uIHdhcyBpbnRyb2R1Y2Vk IGluIGJ1ZyAxNzUxMzUgdG8gc29sdmUgYSByZW5kZXJpbmcgYnVnIHdpdGggZml4ZWQgbm9kZXMg aW4KKyAgICAgICAgb3ZlcmZsb3cgbm9kZXMuIEZvciBhIGZyYW1lIG5vZGUsIHRoZSByZWZlcmVu Y2UgZnJhbWUgdG8gdXNlIGZvciBmaXhlZCBub2RlcyBpcyBhY3R1YWxseSB0aGUKKyAgICAgICAg ZnJhbWUgbm9kZSBpdHNlbGYgb3Igb3RoZXJ3aXNlIHdlIHdpbGwgZ2V0IHRoZSBzYW1lIHJlbmRl cmluZyBidWcuIFRoaXMgcGF0Y2ggbWFrZXMKKyAgICAgICAgZW5jbG9zaW5nRnJhbWVOb2RlIHJl dHVybiB0aGUgbm9kZSBpdHNlbGYgd2hlbiBpdCBpcyBhIGZyYW1lIG5vZGUgYW5kIHJlbmFtZXMg aXQgdG8gY2xhcmlmeQorICAgICAgICB0aGlzIGJlaGF2aW9yLiBDdXJyZW50bHksIGVuY2xvc2lu Z0ZyYW1lTm9kZSBpcyBub3QgdXNlZCBmb3IgZnJhbWUgbm9kZXMgc28gdGhlIGJlaGF2aW9yIGlz CisgICAgICAgIHVuY2hhbmdlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGJlaGF2aW9yIGlz IHVuY2hhbmdlZC4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVOb2Rl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ1RyZWVOb2RlOjplbmNsb3NpbmdGcmFt ZU5vZGVJbmNsdWRpbmdTZWxmKTogU3RhcnQgdGhlIHNlYXJjaCBmcm9tIGEgZnJhbWUKKyAgICAg ICAgc2Nyb2xsaW5nIG5vZGUgZnJvbSB0aGUgbm9kZSBpdHNlbGYuCisgICAgICAgIChXZWJDb3Jl OjpTY3JvbGxpbmdUcmVlTm9kZTo6ZW5jbG9zaW5nRnJhbWVOb2RlIGNvbnN0KTogRGVsZXRlZC4g UmVuYW1lZCB0byBtYWtlIGV4cGxpY2l0CisgICAgICAgIHRoYXQgdGhpcyBmdW5jdGlvbiBtYXkg aW5jbHVkZSB0aGUgbm9kZSBpdHNlbGYuCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xs aW5nVHJlZU5vZGUuaDogUmVuYW1lZC4KKwogMjAxNy0xMi0wNCAgRnJlZGVyaWMgV2FuZyAgPGZ3 YW5nQGlnYWxpYS5jb20+CiAKICAgICAgICAgQnVnIDE2MTMwMCAtIE1vdmUgUmVuZGVyTWF0aE1M Um9vdDpSb290VHlwZSBhbmQgUmVuZGVyTWF0aE1MU2NyaXB0czpTY3JpcHRzVHlwZSB0byBlbGVt ZW50IGNsYXNzZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ1RyZWVOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9s bGluZ1RyZWVOb2RlLmNwcAppbmRleCA2YzM3NTY5MDk2Yy4uMDUwM2NkYjI2Y2EgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVOb2RlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlTm9kZS5jcHAK QEAgLTc3LDkgKzc3LDkgQEAgdm9pZCBTY3JvbGxpbmdUcmVlTm9kZTo6ZHVtcFByb3BlcnRpZXMo VGV4dFN0cmVhbSYgdHMsIFNjcm9sbGluZ1N0YXRlVHJlZUFzVGV4dEIKICAgICAgICAgdHMuZHVt cFByb3BlcnR5KCJub2RlSUQiLCBzY3JvbGxpbmdOb2RlSUQoKSk7CiB9CiAKLVNjcm9sbGluZ1Ry ZWVGcmFtZVNjcm9sbGluZ05vZGUqIFNjcm9sbGluZ1RyZWVOb2RlOjplbmNsb3NpbmdGcmFtZU5v ZGUoKSBjb25zdAorU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZSogU2Nyb2xsaW5nVHJl ZU5vZGU6OmVuY2xvc2luZ0ZyYW1lTm9kZUluY2x1ZGluZ1NlbGYoKQogewotICAgIGF1dG8qIG5v ZGUgPSBwYXJlbnQoKTsKKyAgICBhdXRvKiBub2RlID0gdGhpczsKICAgICB3aGlsZSAobm9kZSAm JiAhbm9kZS0+aXNGcmFtZVNjcm9sbGluZ05vZGUoKSkKICAgICAgICAgbm9kZSA9IG5vZGUtPnBh cmVudCgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3Jv bGxpbmdUcmVlTm9kZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n VHJlZU5vZGUuaAppbmRleCA5ZmU1YWIxNzEzNS4uZmQ4YzUwYzRkODAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVOb2RlLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZU5vZGUuaApAQCAtNjYsNyAr NjYsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBhcHBlbmRDaGlsZChSZWY8U2Nyb2xsaW5nVHJlZU5v ZGU+JiYpOwogICAgIHZvaWQgcmVtb3ZlQ2hpbGQoU2Nyb2xsaW5nVHJlZU5vZGUmKTsKIAotICAg IFdFQkNPUkVfRVhQT1JUIFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGUqIGVuY2xvc2lu Z0ZyYW1lTm9kZSgpIGNvbnN0OworICAgIFdFQkNPUkVfRVhQT1JUIFNjcm9sbGluZ1RyZWVGcmFt ZVNjcm9sbGluZ05vZGUqIGVuY2xvc2luZ0ZyYW1lTm9kZUluY2x1ZGluZ1NlbGYoKTsKIAogICAg IFdFQkNPUkVfRVhQT1JUIHZvaWQgZHVtcChXVEY6OlRleHRTdHJlYW0mLCBTY3JvbGxpbmdTdGF0 ZVRyZWVBc1RleHRCZWhhdmlvcikgY29uc3Q7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggZTVjNTEwMWFmZmQuLmZi MzRlZTE5MjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACiswMTctMTItMDQgIEZyZWRlcmlj IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIE1ha2UgU2Nyb2xsaW5nVHJlZU5v ZGU6OmVuY2xvc2luZ0ZyYW1lTm9kZSByZXR1cm4gdGhlIG5vZGUgaXRzZWxmIGZvciBmcmFtZSBu b2RlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgw MzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBmdW5jdGlvbiB3YXMgaW50cm9kdWNlZCBpbiBidWcgMTc1MTM1IHRvIHNvbHZlIGEgcmVuZGVy aW5nIGJ1ZyB3aXRoIGZpeGVkIG5vZGVzIGluCisgICAgICAgIG92ZXJmbG93IG5vZGVzLiBGb3Ig YSBmcmFtZSBub2RlLCB0aGUgcmVmZXJlbmNlIGZyYW1lIHRvIHVzZSBmb3IgZml4ZWQgbm9kZXMg aXMgYWN0dWFsbHkgdGhlCisgICAgICAgIGZyYW1lIG5vZGUgaXRzZWxmIG9yIG90aGVyd2lzZSB3 ZSB3aWxsIGdldCB0aGUgc2FtZSByZW5kZXJpbmcgYnVnLiBUaGlzIHBhdGNoIG1ha2VzCisgICAg ICAgIGVuY2xvc2luZ0ZyYW1lTm9kZSByZXR1cm4gdGhlIG5vZGUgaXRzZWxmIHdoZW4gaXQgaXMg YSBmcmFtZSBub2RlIGFuZCByZW5hbWVzIGl0IHRvIGNsYXJpZnkKKyAgICAgICAgdGhpcyBiZWhh dmlvci4gQ3VycmVudGx5LCBlbmNsb3NpbmdGcmFtZU5vZGUgaXMgbm90IHVzZWQgZm9yIGZyYW1l IG5vZGVzIHNvIHRoZSBiZWhhdmlvciBpcworICAgICAgICB1bmNoYW5nZWQuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvUmVtb3RlTGF5ZXJUcmVlL2lvcy9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9k ZURlbGVnYXRlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpTY3JvbGxpbmdUcmVlU2Nyb2xsaW5n Tm9kZURlbGVnYXRlSU9TOjp1cGRhdGVDaGlsZE5vZGVzQWZ0ZXJTY3JvbGwpOiBVc2UgYXV0byog YW5kCisgICAgICAgIHRoZSBuZXcgZnVuY3Rpb24gbmFtZS4KKwogMjAxNy0xMi0wMyAgWXVzdWtl IFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBXVEYgc2hvdWxkbid0 IGhhdmUgYm90aCBUaHJlYWQgYW5kIFRocmVhZElkZW50aWZpZXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZUxheWVyVHJlZS9pb3MvU2Nyb2xsaW5nVHJlZVNjcm9s bGluZ05vZGVEZWxlZ2F0ZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZUxh eWVyVHJlZS9pb3MvU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGVEZWxlZ2F0ZUlPUy5tbQppbmRl eCAwNDE4NDMxNGQ3Ni4uMTM1Mzk2MGZmZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1JlbW90ZUxheWVyVHJlZS9pb3MvU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGVEZWxl Z2F0ZUlPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZW1vdGVMYXllclRyZWUv aW9zL1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlRGVsZWdhdGVJT1MubW0KQEAgLTI0Niw3ICsy NDYsNyBAQCB2b2lkIFNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlRGVsZWdhdGVJT1M6OnVwZGF0 ZUNoaWxkTm9kZXNBZnRlclNjcm9sbChjb25zdCBGbAogICAgICAgICByZXR1cm47CiAKICAgICBG bG9hdFJlY3QgZml4ZWRQb3NpdGlvblJlY3Q7Ci0gICAgU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xs aW5nTm9kZSogZnJhbWVOb2RlID0gc2Nyb2xsaW5nTm9kZSgpLmVuY2xvc2luZ0ZyYW1lTm9kZSgp OworICAgIGF1dG8qIGZyYW1lTm9kZSA9IHNjcm9sbGluZ05vZGUoKS5lbmNsb3NpbmdGcmFtZU5v ZGVJbmNsdWRpbmdTZWxmKCk7CiAgICAgaWYgKGZyYW1lTm9kZSAmJiBmcmFtZU5vZGUtPnBhcmVu dCgpKQogICAgICAgICBmaXhlZFBvc2l0aW9uUmVjdCA9IGZyYW1lTm9kZS0+Zml4ZWRQb3NpdGlv blJlY3QoKTsKICAgICBlbHNlCg==