180350 2017-12-04 04:21:12 -0800 WebDriver: evaluateJavaScriptFunction should return null when return value is undefined 2018-01-29 22:33:42 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez webkit-bug-importer oldest_to_newest 1377656 0 cgarcia 2017-12-04 04:21:12 -0800 undefined can't be converted to JSON string, in which case JSON.stringify() returns undefined and we handle that case to return an empty string. We currently handle this case for execute script commands, but not in all other cases where we use evaluateJavaScriptFunction. It would be simpler if evaluateJavaScriptFunction returned null, because in that case we wouldn't need to handle it as a special case. 15.2 Executing Script https://w3c.github.io/webdriver/webdriver-spec.html#dfn-json-clone 1377658 1 328341 cgarcia 2017-12-04 04:27:50 -0800 Created attachment 328341 Patch 1389885 2 cgarcia 2018-01-16 22:41:00 -0800 Brian, could you check if this affects safari driver? Maybe you need to adapt the driver implementation, like I did. 1394302 3 328341 bburg 2018-01-29 15:40:02 -0800 Comment on attachment 328341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328341&action=review This does not seem to regress any safaridriver tests, feel free to land as you please. > Source/WebDriver/ChangeLog:8 > + Stop handling the empty string a as a special case of evaluateJavaScriptFunction result. Nit: 'a as a' 1394431 4 cgarcia 2018-01-29 22:31:40 -0800 (In reply to Brian Burg from comment #3) > Comment on attachment 328341 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328341&action=review > > This does not seem to regress any safaridriver tests, feel free to land as > you please. Cool, thanks! > > Source/WebDriver/ChangeLog:8 > > + Stop handling the empty string a as a special case of evaluateJavaScriptFunction result. > > Nit: 'a as a' 1394432 5 cgarcia 2018-01-29 22:32:46 -0800 Committed r227773: <https://trac.webkit.org/changeset/227773> 1394433 6 webkit-bug-importer 2018-01-29 22:33:42 -0800 <rdar://problem/37016996> 328341 2017-12-04 04:27:50 -0800 2018-01-16 03:39:26 -0800 Patch wd-js-undefined.diff text/plain 3578 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggNjYxYzA4YThkZDAuLjhjN2U1NTY2MDBmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTA0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGV2YWx1YXRlSmF2YVNjcmlw dEZ1bmN0aW9uIHNob3VsZCByZXR1cm4gbnVsbCB3aGVuIHJldHVybiB2YWx1ZSBpcyB1bmRlZmlu ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDM1 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3Ag aGFuZGxpbmcgdGhlIGVtcHR5IHN0cmluZyBhIGFzIGEgc3BlY2lhbCBjYXNlIG9mIGV2YWx1YXRl SmF2YVNjcmlwdEZ1bmN0aW9uIHJlc3VsdC4KKworICAgICAgICAqIFNlc3Npb24uY3BwOgorICAg ICAgICAoV2ViRHJpdmVyOjpTZXNzaW9uOjpleGVjdXRlU2NyaXB0KToKKwogMjAxNy0xMi0wNCAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2Vi RHJpdmVyOiBpbXBsZW1lbnQgZWxlbWVudCBwcm9wZXJ0eSBjb21tYW5kCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNw cAppbmRleCA5ODczM2Y3NWExNC4uZTUyZDg2YzYzMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJE cml2ZXIvU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcApAQCAt MTcyMywxMCArMTcyMyw2IEBAIHZvaWQgU2Vzc2lvbjo6ZXhlY3V0ZVNjcmlwdChjb25zdCBTdHJp bmcmIHNjcmlwdCwgUmVmUHRyPEpTT046OkFycmF5PiYmIGFyZ3VtZW50CiAgICAgICAgICAgICAg ICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3VsdDo6ZmFpbChDb21tYW5kUmVzdWx0OjpF cnJvckNvZGU6OlVua25vd25FcnJvcikpOwogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgICAgIH0KLSAgICAgICAgICAgIGlmICh2YWx1ZVN0cmluZy5pc0VtcHR5KCkpIHsKLSAgICAg ICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0OjpzdWNjZXNzKCkpOwot ICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgIH0KICAgICAgICAgICAgIFJlZlB0 cjxKU09OOjpWYWx1ZT4gcmVzdWx0VmFsdWU7CiAgICAgICAgICAgICBpZiAoIUpTT046OlZhbHVl OjpwYXJzZUpTT04odmFsdWVTdHJpbmcsIHJlc3VsdFZhbHVlKSkgewogICAgICAgICAgICAgICAg IGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJlc3VsdDo6RXJy b3JDb2RlOjpVbmtub3duRXJyb3IpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggZTVjNTEwMWFmZmQuLmNhYWFjMTk1 MzQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTEyLTA0ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGV2YWx1 YXRlSmF2YVNjcmlwdEZ1bmN0aW9uIHNob3VsZCByZXR1cm4gbnVsbCB3aGVuIHJldHVybiB2YWx1 ZSBpcyB1bmRlZmluZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4MDM1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIHVuZGVmaW5lZCBjYW4ndCBiZSBjb252ZXJ0ZWQgdG8gSlNPTiBzdHJpbmcsIGluIHdo aWNoIGNhc2UgSlNPTi5zdHJpbmdpZnkoKSByZXR1cm5zIHVuZGVmaW5lZCBhbmQgd2UgaGFuZGxl IHRoYXQKKyAgICAgICAgY2FzZSB0byByZXR1cm4gYW4gZW1wdHkgc3RyaW5nLiBXZSBjdXJyZW50 bHkgaGFuZGxlIHRoaXMgY2FzZSBmb3IgZXhlY3V0ZSBzY3JpcHQgY29tbWFuZHMsIGJ1dCBub3Qg aW4gYWxsIG90aGVyCisgICAgICAgIGNhc2VzIHdoZXJlIHdlIHVzZSBldmFsdWF0ZUphdmFTY3Jp cHRGdW5jdGlvbi4gSXQgd291bGQgYmUgc2ltcGxlciBpZiBldmFsdWF0ZUphdmFTY3JpcHRGdW5j dGlvbiByZXR1cm5lZCBudWxsLAorICAgICAgICBiZWNhdXNlIGluIHRoYXQgY2FzZSB3ZSB3b3Vs ZG4ndCBuZWVkIHRvIGhhbmRsZSBpdCBhcyBhIHNwZWNpYWwgY2FzZS4KKworICAgICAgICAxNS4y IEV4ZWN1dGluZyBTY3JpcHQKKyAgICAgICAgaHR0cHM6Ly93M2MuZ2l0aHViLmlvL3dlYmRyaXZl ci93ZWJkcml2ZXItc3BlYy5odG1sI2Rmbi1qc29uLWNsb25lCisKKyAgICAgICAgRml4ZXM6IGlt cG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvc3RhdGUvZ2V0X2VsZW1lbnRfcHJvcGVydHkucHk6 OnRlc3RfZWxlbWVudF9ub25fZXhpc3RlbnQKKworICAgICAgICAqIFdlYlByb2Nlc3MvQXV0b21h dGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmpzOgorICAgICAgICAobGV0LkF1dG9tYXRp b25TZXNzaW9uUHJveHkucHJvdG90eXBlLl9qc29uU3RyaW5naWZ5KTogUmV0dXJuICJudWxsIiBp bnN0ZWFkIG9mICIiIHdoZW4gdW5kZWZpbmVkIGlzIGdpdmVuLgorCiAyMDE3LTEyLTAzICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFdURiBzaG91bGRu J3QgaGF2ZSBib3RoIFRocmVhZCBhbmQgVGhyZWFkSWRlbnRpZmllcgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94 eS5qcyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25T ZXNzaW9uUHJveHkuanMKaW5kZXggODBjNmJiZDQ0N2QuLmUxNDVlNzRlZDc2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lv blByb3h5LmpzCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1 dG9tYXRpb25TZXNzaW9uUHJveHkuanMKQEAgLTg4LDcgKzg4LDcgQEAgbGV0IEF1dG9tYXRpb25T ZXNzaW9uUHJveHkgPSBjbGFzcyBBdXRvbWF0aW9uU2Vzc2lvblByb3h5CiAKICAgICBfanNvblN0 cmluZ2lmeShvcmlnaW5hbCkKICAgICB7Ci0gICAgICAgIHJldHVybiBKU09OLnN0cmluZ2lmeShv cmlnaW5hbCwgKGtleSwgdmFsdWUpID0+IHRoaXMuX3JlcGxhY2VKU09OVmFsdWUoa2V5LCB2YWx1 ZSkpIHx8ICIiOworICAgICAgICByZXR1cm4gSlNPTi5zdHJpbmdpZnkob3JpZ2luYWwsIChrZXks IHZhbHVlKSA9PiB0aGlzLl9yZXBsYWNlSlNPTlZhbHVlKGtleSwgdmFsdWUpKSB8fCAibnVsbCI7 CiAgICAgfQogCiAgICAgX3Jldml2ZUpTT05WYWx1ZShrZXksIHZhbHVlKQo=