180331 2017-12-03 02:09:14 -0800 [GStreamer] More leaks in TextCombinerGStreamer 2017-12-04 00:53:33 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro webkit-bug-importer oldest_to_newest 1377455 0 cgarcia 2017-12-03 02:09:14 -0800 I've noticed more leaks reading the code, but I couldn't check them with valgrind, because I don't know how to trigger that code path. I'll just clean up the file using smart pointer everywhere. 1377456 1 328289 cgarcia 2017-12-03 02:11:18 -0800 Created attachment 328289 Patch 1377625 2 cgarcia 2017-12-04 00:52:31 -0800 Committed r225473: <https://trac.webkit.org/changeset/225473> 1377626 3 webkit-bug-importer 2017-12-04 00:53:33 -0800 <rdar://problem/35825070> 328289 2017-12-03 02:11:18 -0800 2017-12-03 11:07:57 -0800 Patch wcore-gst-leaks.diff text/plain 6365 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZDNmOTYyMzFmNi4uMDc5NmNhNTI2MGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0xMi0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gTW9yZSBsZWFrcyBpbiBUZXh0Q29tYmlu ZXJHU3RyZWFtZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4MDMzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEkndmUgbm90aWNlZCBtb3JlIGxlYWtzIHJlYWRpbmcgdGhlIGNvZGUsIGJ1dCBJIGNvdWxk bid0IGNoZWNrIHRoZW0gd2l0aCB2YWxncmluZCwgYmVjYXVzZSBJIGRvbid0IGtub3cgaG93IHRv CisgICAgICAgIHRyaWdnZXIgdGhhdCBjb2RlIHBhdGguIFRoaXMgcGF0Y2ggY2xlYW5zIHVwIHRo ZSBmaWxlIHVzaW5nIHNtYXJ0IHBvaW50ZXIgZXZlcnl3aGVyZS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwOgorICAgICAg ICAod2Via2l0X3RleHRfY29tYmluZXJfcGFkX2luaXQpOgorICAgICAgICAod2Via2l0VGV4dENv bWJpbmVyUGFkRXZlbnQpOgorICAgICAgICAod2Via2l0VGV4dENvbWJpbmVyUmVsZWFzZVBhZCk6 CisKIDIwMTctMTItMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHU3RyZWFtZXJdIEdzdFBhZCBsZWFrZWQgaW4gV2ViS2l0VGV4dENvbWJp bmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvVGV4dENvbWJpbmVyR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwCmluZGV4IDRkMzMzMjlk MTMxLi45MjE5ZTMxZDhkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL1RleHRDb21iaW5lckdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RleHRDb21iaW5lckdTdHJlYW1lci5j cHAKQEAgLTk0LDggKzk0LDYgQEAgc3RhdGljIHZvaWQgd2Via2l0X3RleHRfY29tYmluZXJfaW5p dChXZWJLaXRUZXh0Q29tYmluZXIqIGNvbWJpbmVyKQogCiBzdGF0aWMgdm9pZCB3ZWJraXRfdGV4 dF9jb21iaW5lcl9wYWRfaW5pdChXZWJLaXRUZXh0Q29tYmluZXJQYWQqIHBhZCkKIHsKLSAgICBw YWQtPnRhZ3MgPSAwOwotCiAgICAgZ3N0X3BhZF9zZXRfZXZlbnRfZnVuY3Rpb24oR1NUX1BBRChw YWQpLCB3ZWJraXRUZXh0Q29tYmluZXJQYWRFdmVudCk7CiB9CiAKQEAgLTEzNywxNyArMTM1LDE3 IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRUZXh0Q29tYmluZXJQYWRFdmVudChHc3RQYWQqIHBh ZCwgR3N0T2JqZWN0KiBwYXJlbnQsIEdzdEV2CiAgICAgICAgIGdzdF9ldmVudF9wYXJzZV9jYXBz KGV2ZW50LCAmY2Fwcyk7CiAgICAgICAgIEFTU0VSVChjYXBzKTsKIAotICAgICAgICBHc3RQYWQq IHRhcmdldCA9IGdzdF9naG9zdF9wYWRfZ2V0X3RhcmdldChHU1RfR0hPU1RfUEFEKHBhZCkpOwor ICAgICAgICBHUmVmUHRyPEdzdFBhZD4gdGFyZ2V0ID0gYWRvcHRHUmVmKGdzdF9naG9zdF9wYWRf Z2V0X3RhcmdldChHU1RfR0hPU1RfUEFEKHBhZCkpKTsKICAgICAgICAgQVNTRVJUKHRhcmdldCk7 CiAKLSAgICAgICAgR3N0RWxlbWVudCogdGFyZ2V0UGFyZW50ID0gZ3N0X3BhZF9nZXRfcGFyZW50 X2VsZW1lbnQodGFyZ2V0KTsKKyAgICAgICAgR1JlZlB0cjxHc3RFbGVtZW50PiB0YXJnZXRQYXJl bnQgPSBhZG9wdEdSZWYoZ3N0X3BhZF9nZXRfcGFyZW50X2VsZW1lbnQodGFyZ2V0LmdldCgpKSk7 CiAgICAgICAgIEFTU0VSVCh0YXJnZXRQYXJlbnQpOwogCi0gICAgICAgIEdzdENhcHMqIHRleHRD YXBzID0gZ3N0X2NhcHNfbmV3X2VtcHR5X3NpbXBsZSgidGV4dC94LXJhdyIpOwotICAgICAgICBp ZiAoZ3N0X2NhcHNfY2FuX2ludGVyc2VjdCh0ZXh0Q2FwcywgY2FwcykpIHsKKyAgICAgICAgR1Jl ZlB0cjxHc3RDYXBzPiB0ZXh0Q2FwcyA9IGFkb3B0R1JlZihnc3RfY2Fwc19uZXdfZW1wdHlfc2lt cGxlKCJ0ZXh0L3gtcmF3IikpOworICAgICAgICBpZiAoZ3N0X2NhcHNfY2FuX2ludGVyc2VjdCh0 ZXh0Q2Fwcy5nZXQoKSwgY2FwcykpIHsKICAgICAgICAgICAgIC8qIENhcHMgYXJlIHBsYWluIHRl eHQsIHB1dCBhIFdlYlZUVCBlbmNvZGVyIGJldHdlZW4gdGhlIGdob3N0cGFkIGFuZAogICAgICAg ICAgICAgICogdGhlIGZ1bm5lbCAqLwotICAgICAgICAgICAgaWYgKHRhcmdldFBhcmVudCA9PSBj b21iaW5lci0+ZnVubmVsKSB7CisgICAgICAgICAgICBpZiAodGFyZ2V0UGFyZW50LmdldCgpID09 IGNvbWJpbmVyLT5mdW5uZWwpIHsKICAgICAgICAgICAgICAgICAvKiBTZXR1cCBhIFdlYlZUVCBl bmNvZGVyICovCiAgICAgICAgICAgICAgICAgR3N0RWxlbWVudCogZW5jb2RlciA9IGdzdF9lbGVt ZW50X2ZhY3RvcnlfbWFrZSgid2VidnR0ZW5jIiwgbnVsbHB0cik7CiAgICAgICAgICAgICAgICAg QVNTRVJUKGVuY29kZXIpOwpAQCAtMTU5LDQ1ICsxNTcsMzggQEAgc3RhdGljIGdib29sZWFuIHdl YmtpdFRleHRDb21iaW5lclBhZEV2ZW50KEdzdFBhZCogcGFkLCBHc3RPYmplY3QqIHBhcmVudCwg R3N0RXYKICAgICAgICAgICAgICAgICBBU1NFUlQocmV0KTsKIAogICAgICAgICAgICAgICAgIC8q IFN3aXRjaCB0aGUgZ2hvc3RwYWQgdG8gdGFyZ2V0IHRoZSBXZWJWVFQgZW5jb2RlciAqLwotICAg ICAgICAgICAgICAgIEdzdFBhZCogc2lua1BhZCA9IGdzdF9lbGVtZW50X2dldF9zdGF0aWNfcGFk KGVuY29kZXIsICJzaW5rIik7CisgICAgICAgICAgICAgICAgR1JlZlB0cjxHc3RQYWQ+IHNpbmtQ YWQgPSBhZG9wdEdSZWYoZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19wYWQoZW5jb2RlciwgInNpbmsi KSk7CiAgICAgICAgICAgICAgICAgQVNTRVJUKHNpbmtQYWQpOwogCi0gICAgICAgICAgICAgICAg cmV0ID0gZ3N0X2dob3N0X3BhZF9zZXRfdGFyZ2V0KEdTVF9HSE9TVF9QQUQocGFkKSwgc2lua1Bh ZCk7CisgICAgICAgICAgICAgICAgcmV0ID0gZ3N0X2dob3N0X3BhZF9zZXRfdGFyZ2V0KEdTVF9H SE9TVF9QQUQocGFkKSwgc2lua1BhZC5nZXQoKSk7CiAgICAgICAgICAgICAgICAgQVNTRVJUKHJl dCk7Ci0gICAgICAgICAgICAgICAgZ3N0X29iamVjdF91bnJlZihzaW5rUGFkKTsKIAogICAgICAg ICAgICAgICAgIC8qIENvbm5lY3QgdGhlIFdlYlZUVCBlbmNvZGVyIHRvIHRoZSBmdW5uZWwgKi8K LSAgICAgICAgICAgICAgICBHc3RQYWQqIHNyY1BhZCA9IGdzdF9lbGVtZW50X2dldF9zdGF0aWNf cGFkKGVuY29kZXIsICJzcmMiKTsKKyAgICAgICAgICAgICAgICBHUmVmUHRyPEdzdFBhZD4gc3Jj UGFkID0gYWRvcHRHUmVmKGdzdF9lbGVtZW50X2dldF9zdGF0aWNfcGFkKGVuY29kZXIsICJzcmMi KSk7CiAgICAgICAgICAgICAgICAgQVNTRVJUKHNyY1BhZCk7CiAKLSAgICAgICAgICAgICAgICBy ZXQgPSBHU1RfUEFEX0xJTktfU1VDQ0VTU0ZVTChnc3RfcGFkX2xpbmsoc3JjUGFkLCB0YXJnZXQp KTsKKyAgICAgICAgICAgICAgICByZXQgPSBHU1RfUEFEX0xJTktfU1VDQ0VTU0ZVTChnc3RfcGFk X2xpbmsoc3JjUGFkLmdldCgpLCB0YXJnZXQuZ2V0KCkpKTsKICAgICAgICAgICAgICAgICBBU1NF UlQocmV0KTsKLSAgICAgICAgICAgICAgICBnc3Rfb2JqZWN0X3VucmVmKHNyY1BhZCk7CiAgICAg ICAgICAgICB9IC8qIGVsc2U6IHBpcGVsaW5lIGlzIGFscmVhZHkgY29ycmVjdCAqLwogICAgICAg ICB9IGVsc2UgewogICAgICAgICAgICAgLyogQ2FwcyBhcmUgbm90IHBsYWluIHRleHQsIHJlbW92 ZSB0aGUgV2ViVlRUIGVuY29kZXIgKi8KLSAgICAgICAgICAgIGlmICh0YXJnZXRQYXJlbnQgIT0g Y29tYmluZXItPmZ1bm5lbCkgeworICAgICAgICAgICAgaWYgKHRhcmdldFBhcmVudC5nZXQoKSAh PSBjb21iaW5lci0+ZnVubmVsKSB7CiAgICAgICAgICAgICAgICAgLyogR2V0IHRoZSBmdW5uZWwg c2luayBwYWQgKi8KLSAgICAgICAgICAgICAgICBHc3RQYWQqIHNyY1BhZCA9IGdzdF9lbGVtZW50 X2dldF9zdGF0aWNfcGFkKHRhcmdldFBhcmVudCwgInNyYyIpOworICAgICAgICAgICAgICAgIEdS ZWZQdHI8R3N0UGFkPiBzcmNQYWQgPSBhZG9wdEdSZWYoZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19w YWQodGFyZ2V0UGFyZW50LmdldCgpLCAic3JjIikpOwogICAgICAgICAgICAgICAgIEFTU0VSVChz cmNQYWQpOwogCi0gICAgICAgICAgICAgICAgR3N0UGFkKiBzaW5rUGFkID0gZ3N0X3BhZF9nZXRf cGVlcihzcmNQYWQpOworICAgICAgICAgICAgICAgIEdSZWZQdHI8R3N0UGFkPiBzaW5rUGFkID0g YWRvcHRHUmVmKGdzdF9wYWRfZ2V0X3BlZXIoc3JjUGFkLmdldCgpKSk7CiAgICAgICAgICAgICAg ICAgQVNTRVJUKHNpbmtQYWQpOwotICAgICAgICAgICAgICAgIGdzdF9vYmplY3RfdW5yZWYoc3Jj UGFkKTsKIAogICAgICAgICAgICAgICAgIC8qIFN3aXRjaCB0aGUgZ2hvc3RwYWQgdG8gdGFyZ2V0 IHRoZSBmdW5uZWwgKi8KLSAgICAgICAgICAgICAgICByZXQgPSBnc3RfZ2hvc3RfcGFkX3NldF90 YXJnZXQoR1NUX0dIT1NUX1BBRChwYWQpLCBzaW5rUGFkKTsKKyAgICAgICAgICAgICAgICByZXQg PSBnc3RfZ2hvc3RfcGFkX3NldF90YXJnZXQoR1NUX0dIT1NUX1BBRChwYWQpLCBzaW5rUGFkLmdl dCgpKTsKICAgICAgICAgICAgICAgICBBU1NFUlQocmV0KTsKLSAgICAgICAgICAgICAgICBnc3Rf b2JqZWN0X3VucmVmKHNpbmtQYWQpOwogCiAgICAgICAgICAgICAgICAgLyogUmVtb3ZlIHRoZSBX ZWJWVFQgZW5jb2RlciAqLwotICAgICAgICAgICAgICAgIHJldCA9IGdzdF9iaW5fcmVtb3ZlKEdT VF9CSU4oY29tYmluZXIpLCB0YXJnZXRQYXJlbnQpOworICAgICAgICAgICAgICAgIHJldCA9IGdz dF9iaW5fcmVtb3ZlKEdTVF9CSU4oY29tYmluZXIpLCB0YXJnZXRQYXJlbnQuZ2V0KCkpOwogICAg ICAgICAgICAgICAgIEFTU0VSVChyZXQpOwogICAgICAgICAgICAgfSAvKiBlbHNlOiBwaXBlbGlu ZSBpcyBhbHJlYWR5IGNvcnJlY3QgKi8KICAgICAgICAgfQotICAgICAgICBnc3RfY2Fwc191bnJl Zih0ZXh0Q2Fwcyk7Ci0gICAgICAgIGdzdF9vYmplY3RfdW5yZWYodGFyZ2V0UGFyZW50KTsKLSAg ICAgICAgZ3N0X29iamVjdF91bnJlZih0YXJnZXQpOwogICAgICAgICBicmVhazsKICAgICB9CiAg ICAgY2FzZSBHU1RfRVZFTlRfVEFHOiB7CkBAIC0yNTQsMTMgKzI0NSwxMiBAQCBzdGF0aWMgR3N0 UGFkKiB3ZWJraXRUZXh0Q29tYmluZXJSZXF1ZXN0TmV3UGFkKEdzdEVsZW1lbnQgKiBlbGVtZW50 LAogc3RhdGljIHZvaWQgd2Via2l0VGV4dENvbWJpbmVyUmVsZWFzZVBhZChHc3RFbGVtZW50ICpl bGVtZW50LCBHc3RQYWQgKnBhZCkKIHsKICAgICBXZWJLaXRUZXh0Q29tYmluZXIqIGNvbWJpbmVy ID0gV0VCS0lUX1RFWFRfQ09NQklORVIoZWxlbWVudCk7Ci0gICAgR3N0UGFkKiBwZWVyID0gZ3N0 X3BhZF9nZXRfcGVlcihwYWQpOwotICAgIGlmIChwZWVyKSB7Ci0gICAgICAgIEdzdEVsZW1lbnQq IHBhcmVudCA9IGdzdF9wYWRfZ2V0X3BhcmVudF9lbGVtZW50KHBlZXIpOworICAgIGlmIChHUmVm UHRyPEdzdFBhZD4gcGVlciA9IGFkb3B0R1JlZihnc3RfcGFkX2dldF9wZWVyKHBhZCkpKSB7Cisg ICAgICAgIEdSZWZQdHI8R3N0RWxlbWVudD4gcGFyZW50ID0gYWRvcHRHUmVmKGdzdF9wYWRfZ2V0 X3BhcmVudF9lbGVtZW50KHBlZXIuZ2V0KCkpKTsKICAgICAgICAgQVNTRVJUKHBhcmVudCk7Ci0g ICAgICAgIGdzdF9lbGVtZW50X3JlbGVhc2VfcmVxdWVzdF9wYWQocGFyZW50LCBwZWVyKTsKLSAg ICAgICAgaWYgKHBhcmVudCAhPSBjb21iaW5lci0+ZnVubmVsKQotICAgICAgICAgICAgZ3N0X2Jp bl9yZW1vdmUoR1NUX0JJTihjb21iaW5lciksIHBhcmVudCk7CisgICAgICAgIGdzdF9lbGVtZW50 X3JlbGVhc2VfcmVxdWVzdF9wYWQocGFyZW50LmdldCgpLCBwZWVyLmdldCgpKTsKKyAgICAgICAg aWYgKHBhcmVudC5nZXQoKSAhPSBjb21iaW5lci0+ZnVubmVsKQorICAgICAgICAgICAgZ3N0X2Jp bl9yZW1vdmUoR1NUX0JJTihjb21iaW5lciksIHBhcmVudC5nZXQoKSk7CiAgICAgfQogCiAgICAg Z3N0X2VsZW1lbnRfcmVtb3ZlX3BhZChlbGVtZW50LCBwYWQpOwo=