<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>180315</bug_id>
          
          <creation_ts>2017-12-02 11:20:10 -0800</creation_ts>
          <short_desc>forEachLiveCell should be safe in the case of concurrent aboutToMarkSlow() without grabbing a lock for each call to isLive</short_desc>
          <delta_ts>2017-12-02 11:58:34 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>165909</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1377328</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2017-12-02 11:20:10 -0800</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377339</commentid>
    <comment_count>1</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2017-12-02 11:58:34 -0800</bug_when>
    <thetext>It just occurred to me that the algorithm for forEachLiveCell could be:

- If the block is allocated, just walk all objects.

- If the block has newly allocated at the outset, then walk that.  I think that grabbing the lock at the beginning just to verify that newly allocated is set up is sufficient.

- Otherwise, walk the mark bits, and recheck the state of the block at the end.  If the block is still in the mark bits state, then we&apos;re done.  If it&apos;s not, then rewalk it.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>