<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>180314</bug_id>
          
          <creation_ts>2017-12-02 11:07:21 -0800</creation_ts>
          <short_desc>[GStreamer] GstPad leaked in WebKitTextCombiner</short_desc>
          <delta_ts>2017-12-03 01:10:05 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1377325</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-12-02 11:07:21 -0800</bug_when>
    <thetext>gst_element_get_static_pad() returns a full reference that si never freed, because gst_ghost_pad_new doesn&apos;t take the ownership of the given pad.

==1306== 68,856 (33,792 direct, 35,064 indirect) bytes in 64 blocks are definitely lost in loss record 20,295 of 20,320
==1306==    at 0xF7AF03C: g_type_create_instance (gtype.c:1845)
==1306==    by 0xF78FAF7: g_object_new_internal (gobject.c:1797)
==1306==    by 0xF79184F: g_object_new_valist (gobject.c:2120)
==1306==    by 0xF791BAB: g_object_new (gobject.c:1640)
==1306==    by 0xD3D36E0: gst_pad_new_from_template (gstpad.c:868)
==1306==    by 0xD3D373B: gst_pad_new_from_static_template (gstpad.c:893)
==1306==    by 0x262E4FAB: gst_funnel_init (gstfunnel.c:213)
==1306==    by 0xF7AEF72: g_type_create_instance (gtype.c:1866)
==1306==    by 0xF78FAF7: g_object_new_internal (gobject.c:1797)
==1306==    by 0xF7911B4: g_object_new_with_properties (gobject.c:1965)
==1306==    by 0xF791BC0: g_object_new (gobject.c:1637)
==1306==    by 0xD3B9CA5: gst_element_factory_create (gstelementfactory.c:372)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377326</commentid>
    <comment_count>1</comment_count>
      <attachid>328242</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-12-02 11:09:27 -0800</bug_when>
    <thetext>Created attachment 328242
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377451</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-12-03 01:08:52 -0800</bug_when>
    <thetext>Committed r225459: &lt;https://trac.webkit.org/changeset/225459&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377453</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-12-03 01:10:05 -0800</bug_when>
    <thetext>&lt;rdar://problem/35817669&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>328242</attachid>
            <date>2017-12-02 11:09:27 -0800</date>
            <delta_ts>2017-12-02 14:38:14 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>wcore-gst-pad-leak.diff</filename>
            <type>text/plain</type>
            <size>1997</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA0NjcyMzBiYTU0MC4uMjM0MDVjZWQ3ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxNy0xMi0wMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln
YWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gR3N0UGFkIGxlYWtlZCBpbiBXZWJLaXRU
ZXh0Q29tYmluZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE4MDMxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIGdzdF9lbGVtZW50X2dldF9zdGF0aWNfcGFkKCkgcmV0dXJucyBhIGZ1bGwgcmVmZXJlbmNl
IHRoYXQgc2kgbmV2ZXIgZnJlZWQsIGJlY2F1c2UgZ3N0X2dob3N0X3BhZF9uZXcgZG9lc24ndAor
ICAgICAgICB0YWtlIHRoZSBvd25lcnNoaXAgb2YgdGhlIGdpdmVuIHBhZC4KKworICAgICAgICAq
IHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwOgor
ICAgICAgICAod2Via2l0X3RleHRfY29tYmluZXJfaW5pdCk6CisKIDIwMTctMTItMDIgIENhcmxv
cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFt
ZXJdIEdzdENhcHMgbGVha2VkIGluIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRl
R1NUUGxheUJpbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv
Z3N0cmVhbWVyL1RleHRDb21iaW5lckdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVGV4dENvbWJpbmVyR1N0cmVhbWVyLmNwcAppbmRleCAw
MmRlMWU4YmQ3YS4uNGQzMzMyOWQxMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3Ry
ZWFtZXIuY3BwCkBAIC0yNCw5ICsyNCwxMSBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIK
KyNpbmNsdWRlICJUZXh0Q29tYmluZXJHU3RyZWFtZXIuaCIKKwogI2lmIEVOQUJMRShWSURFTykg
JiYgVVNFKEdTVFJFQU1FUikgJiYgRU5BQkxFKFZJREVPX1RSQUNLKQogCi0jaW5jbHVkZSAiVGV4
dENvbWJpbmVyR1N0cmVhbWVyLmgiCisjaW5jbHVkZSAiR1JlZlB0ckdTdHJlYW1lci5oIgogCiBz
dGF0aWMgR3N0U3RhdGljUGFkVGVtcGxhdGUgc2lua1RlbXBsYXRlID0KICAgICBHU1RfU1RBVElD
X1BBRF9URU1QTEFURSgic2lua18ldSIsIEdTVF9QQURfU0lOSywgR1NUX1BBRF9SRVFVRVNULApA
QCAtODMsMTAgKzg1LDEwIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF90ZXh0X2NvbWJpbmVyX2luaXQo
V2ViS2l0VGV4dENvbWJpbmVyKiBjb21iaW5lcikKICAgICBVTlVTRURfUEFSQU0ocmV0KTsKICAg
ICBBU1NFUlQocmV0KTsKIAotICAgIEdzdFBhZCogcGFkID0gZ3N0X2VsZW1lbnRfZ2V0X3N0YXRp
Y19wYWQoY29tYmluZXItPmZ1bm5lbCwgInNyYyIpOworICAgIEdSZWZQdHI8R3N0UGFkPiBwYWQg
PSBhZG9wdEdSZWYoZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19wYWQoY29tYmluZXItPmZ1bm5lbCwg
InNyYyIpKTsKICAgICBBU1NFUlQocGFkKTsKIAotICAgIHJldCA9IGdzdF9lbGVtZW50X2FkZF9w
YWQoR1NUX0VMRU1FTlQoY29tYmluZXIpLCBnc3RfZ2hvc3RfcGFkX25ldygic3JjIiwgcGFkKSk7
CisgICAgcmV0ID0gZ3N0X2VsZW1lbnRfYWRkX3BhZChHU1RfRUxFTUVOVChjb21iaW5lciksIGdz
dF9naG9zdF9wYWRfbmV3KCJzcmMiLCBwYWQuZ2V0KCkpKTsKICAgICBBU1NFUlQocmV0KTsKIH0K
IAo=
</data>
<flag name="review"
          id="347434"
          type_id="1"
          status="+"
          setter="mcatanzaro"
    />
          </attachment>
      

    </bug>

</bugzilla>