180306 2017-12-01 21:58:42 -0800 Try proxying all function arguments 2017-12-04 13:22:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 180297 180375 1 jfbastien jfbastien commit-queue fpizlo jfbastien keith_miller mark.lam mcatanzaro msaboff rmorisset saam webkit-bug-importer ysuzuki oldest_to_newest 1377235 0 jfbastien 2017-12-01 21:58:42 -0800 In bug #180297 we found that some of the Math functions weren't doing their exception checks. Enumerate all functions and try calling all of them to see if there's anything else that fails. 1377236 1 328212 jfbastien 2017-12-01 22:15:22 -0800 Created attachment 328212 patch Everything passes! 1377242 2 328212 commit-queue 2017-12-01 22:48:31 -0800 Comment on attachment 328212 patch Clearing flags on attachment: 328212 Committed r225444: <https://trac.webkit.org/changeset/225444> 1377243 3 commit-queue 2017-12-01 22:48:33 -0800 All reviewed patches have been landed. Closing bug. 1377244 4 webkit-bug-importer 2017-12-01 22:49:25 -0800 <rdar://problem/35812613> 1377805 5 mcatanzaro 2017-12-04 12:07:41 -0800 All the new tests are crashing for WPE and GTK: ** The following JSC stress test failures have been introduced: stress/proxy-all-the-parameters.js.default stress/proxy-all-the-parameters.js.dfg-eager stress/proxy-all-the-parameters.js.dfg-eager-no-cjit-validate stress/proxy-all-the-parameters.js.dfg-maximal-flush-validate-no-cjit stress/proxy-all-the-parameters.js.ftl-eager stress/proxy-all-the-parameters.js.ftl-eager-no-cjit stress/proxy-all-the-parameters.js.ftl-eager-no-cjit-b3o1 stress/proxy-all-the-parameters.js.ftl-no-cjit-b3o1 stress/proxy-all-the-parameters.js.ftl-no-cjit-no-inline-validate stress/proxy-all-the-parameters.js.ftl-no-cjit-no-put-stack-validate stress/proxy-all-the-parameters.js.ftl-no-cjit-small-pool stress/proxy-all-the-parameters.js.ftl-no-cjit-validate-sampling-profiler stress/proxy-all-the-parameters.js.no-cjit-collect-continuously stress/proxy-all-the-parameters.js.no-cjit-validate-phases stress/proxy-all-the-parameters.js.no-ftl stress/proxy-all-the-parameters.js.no-llint Results for JSC stress tests: 16 failures found. Let's see if I can figure out how to run the tests and get a backtrace. 1377824 6 jfbastien 2017-12-04 12:32:57 -0800 (In reply to Michael Catanzaro from comment #5) > All the new tests are crashing for WPE and GTK: > > > ** The following JSC stress test failures have been introduced: > stress/proxy-all-the-parameters.js.default > stress/proxy-all-the-parameters.js.dfg-eager > stress/proxy-all-the-parameters.js.dfg-eager-no-cjit-validate > stress/proxy-all-the-parameters.js.dfg-maximal-flush-validate-no-cjit > stress/proxy-all-the-parameters.js.ftl-eager > stress/proxy-all-the-parameters.js.ftl-eager-no-cjit > stress/proxy-all-the-parameters.js.ftl-eager-no-cjit-b3o1 > stress/proxy-all-the-parameters.js.ftl-no-cjit-b3o1 > stress/proxy-all-the-parameters.js.ftl-no-cjit-no-inline-validate > stress/proxy-all-the-parameters.js.ftl-no-cjit-no-put-stack-validate > stress/proxy-all-the-parameters.js.ftl-no-cjit-small-pool > stress/proxy-all-the-parameters.js.ftl-no-cjit-validate-sampling-profiler > stress/proxy-all-the-parameters.js.no-cjit-collect-continuously > stress/proxy-all-the-parameters.js.no-cjit-validate-phases > stress/proxy-all-the-parameters.js.no-ftl > stress/proxy-all-the-parameters.js.no-llint > > Results for JSC stress tests: > 16 failures found. > > > Let's see if I can figure out how to run the tests and get a backtrace. When you run locally can you set verbose and check what function is run before the failure? You might be injecting a function that we shouldn’t call into the globally namespace. And this test will call it :) 1377849 7 mcatanzaro 2017-12-04 13:14:28 -0800 (In reply to Michael Catanzaro from comment #5) > Let's see if I can figure out how to run the tests and get a backtrace. They all pass on my personal machine. Sigh. Yuskue, is this something you might want to look into? 1377850 8 jfbastien 2017-12-04 13:16:42 -0800 (In reply to Michael Catanzaro from comment #7) > (In reply to Michael Catanzaro from comment #5) > > Let's see if I can figure out how to run the tests and get a backtrace. > > They all pass on my personal machine. Sigh. > > Yuskue, is this something you might want to look into? Wild guess is that it's calling some internal function, and if I filter out objects whose name starts with "$" we'll be good. I'll upload a patch to do so. 1377851 9 mcatanzaro 2017-12-04 13:17:59 -0800 (In reply to Michael Catanzaro from comment #7) > (In reply to Michael Catanzaro from comment #5) > > Let's see if I can figure out how to run the tests and get a backtrace. > > They all pass on my personal machine. Sigh. Um, actually I think I was not running the tests properly. They completed instantaneously. But now I've tried passing more arguments to run-jsc-tests, just like our bots do, and it's no longer completing immediately. 1377852 10 mcatanzaro 2017-12-04 13:18:16 -0800 (In reply to JF Bastien from comment #8) > Wild guess is that it's calling some internal function, and if I filter out > objects whose name starts with "$" we'll be good. I'll upload a patch to do > so. Happy to test it. 1377857 11 jfbastien 2017-12-04 13:22:37 -0800 Will try to address this in https://bugs.webkit.org/show_bug.cgi?id=180375 328212 2017-12-01 22:15:22 -0800 2017-12-01 22:48:31 -0800 patch 0001-Try-proxying-all-function-arguments.patch text/plain 3605 jfbastien RnJvbSAwNDliODlmMmViZDRmZDk1MjIxN2JlOTNmZDU5NTNiNDczNmQ2ZWY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBGcmksIDEgRGVjIDIwMTcgMjI6MTQ6NTAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBUcnkgcHJv eHlpbmcgYWxsIGZ1bmN0aW9uIGFyZ3VtZW50cwoKLS0tCiBKU1Rlc3RzL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAxNiArKysrKysrCiBKU1Rlc3RzL3N0cmVzcy9wcm94eS1h bGwtdGhlLXBhcmFtZXRlcnMuanMgfCA3MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK IDIgZmlsZXMgY2hhbmdlZCwgODYgaW5zZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IEpT VGVzdHMvc3RyZXNzL3Byb3h5LWFsbC10aGUtcGFyYW1ldGVycy5qcwoKZGlmZiAtLWdpdCBhL0pT VGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTM5NDhiMS4uNjFjYTE0 YWYgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDUgKzEsMjEgQEAKIDIwMTctMTItMDEgIEpGIEJhc3RpZW4gIDxqZmJhc3RpZW5AYXBw bGUuY29tPgogCisgICAgICAgIFRyeSBwcm94eWluZyBhbGwgZnVuY3Rpb24gYXJndW1lbnRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAzMDYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9w cm94eS1hbGwtdGhlLXBhcmFtZXRlcnMuanM6IEFkZGVkLgorICAgICAgICAoaXNQcm9wZXJ0eU9m VHlwZSk6CisgICAgICAgIChnZXRQcm9wZXJ0aWVzKToKKyAgICAgICAgKGdlbmVyYXRlT2JqZWN0 cyk6CisgICAgICAgIChnZXRPYmplY3RzKToKKyAgICAgICAgKGdldEZ1bmN0aW9ucyk6CisgICAg ICAgIChnZXQgdGhyb3cpOgorICAgICAgICAobGV0Lm8ub2YuZ2V0T2JqZWN0cy5sZXQuZi5vZi5n ZXRGdW5jdGlvbnMuY2F0Y2gpOgorCisyMDE3LTEyLTAxICBKRiBCYXN0aWVuICA8amZiYXN0aWVu QGFwcGxlLmNvbT4KKwogICAgICAgICBKYXZhU2NyaXB0Q29yZTogbWlzc2luZyBleGNlcHRpb24g Y2hlY2tzIGluIE1hdGggZnVuY3Rpb25zIHRoYXQgdGFrZSBtb3JlIHRoYW4gb25lIGFyZ3VtZW50 CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAyOTcK ICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1NzQ1NTU2PgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9z dHJlc3MvcHJveHktYWxsLXRoZS1wYXJhbWV0ZXJzLmpzIGIvSlNUZXN0cy9zdHJlc3MvcHJveHkt YWxsLXRoZS1wYXJhbWV0ZXJzLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LmJhMWE0Y2UKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9wcm94eS1hbGwtdGhl LXBhcmFtZXRlcnMuanMKQEAgLTAsMCArMSw3MCBAQAorY29uc3QgdmVyYm9zZSA9IGZhbHNlOwor Citjb25zdCBpZ25vcmUgPSBbJ3F1aXQnLCAncmVhZGxpbmUnLCAnd2FpdEZvclJlcG9ydCcsICdm bGFzaEhlYXBBY2Nlc3MnLCAnbGVhdmluZycsICdnZXRSZXBvcnQnXTsKKworZnVuY3Rpb24gaXNQ cm9wZXJ0eU9mVHlwZShvYmosIG5hbWUsIHR5cGUpIHsKKyAgICBsZXQgZGVzYzsKKyAgICBkZXNj ID0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihvYmosIG5hbWUpCisgICAgcmV0dXJu IHR5cGVvZiB0eXBlID09PSAndW5kZWZpbmVkJyB8fCB0eXBlb2YgZGVzYy52YWx1ZSA9PT0gdHlw ZTsKK30KKworZnVuY3Rpb24gZ2V0UHJvcGVydGllcyhvYmosIHR5cGUpIHsKKyAgICBsZXQgcHJv cGVydGllcyA9IFtdOworICAgIGZvciAobGV0IG5hbWUgb2YgT2JqZWN0LmdldE93blByb3BlcnR5 TmFtZXMob2JqKSkgeworICAgICAgICBpZiAoaXNQcm9wZXJ0eU9mVHlwZShvYmosIG5hbWUsIHR5 cGUpKQorICAgICAgICAgICAgcHJvcGVydGllcy5wdXNoKG5hbWUpOworICAgIH0KKyAgICByZXR1 cm4gcHJvcGVydGllczsKK30KKworZnVuY3Rpb24qIGdlbmVyYXRlT2JqZWN0cyhyb290ID0gdGhp cywgbGV2ZWwgPSAwKSB7CisgICAgaWYgKGxldmVsID4gNCkKKyAgICAgICAgcmV0dXJuOworICAg IGxldCBvYmpfbmFtZXMgPSBnZXRQcm9wZXJ0aWVzKHJvb3QsICdvYmplY3QnKTsKKyAgICBmb3Ig KGxldCBvYmpfbmFtZSBvZiBvYmpfbmFtZXMpIHsKKyAgICAgICAgbGV0IG9iaiA9IHJvb3Rbb2Jq X25hbWVdOworICAgICAgICB5aWVsZCBvYmo7CisgICAgICAgIHlpZWxkKiBnZW5lcmF0ZU9iamVj dHMob2JqLCBsZXZlbCArIDEpOworICAgIH0KK30KKworZnVuY3Rpb24gZ2V0T2JqZWN0cygpIHsK KyAgICBsZXQgb2JqZWN0cyA9IFtdOworICAgIGZvciAobGV0IG9iaiBvZiBnZW5lcmF0ZU9iamVj dHMoKSkKKyAgICAgICAgaWYgKCFvYmplY3RzLmluY2x1ZGVzKG9iaikpCisgICAgICAgICAgICBv YmplY3RzLnB1c2gob2JqKTsKKyAgICByZXR1cm4gb2JqZWN0czsKK30KKworZnVuY3Rpb24gZ2V0 RnVuY3Rpb25zKG9iaikgeworICAgIHJldHVybiBnZXRQcm9wZXJ0aWVzKG9iaiwgJ2Z1bmN0aW9u Jyk7Cit9CisKK2NvbnN0IHRocm93ZXIgPSBuZXcgUHJveHkoe30sIHsgZ2V0KCkgeyB0aHJvdyAw eGMwZGVmZWZlOyB9IH0pOworCitmb3IgKGxldCBvIG9mIGdldE9iamVjdHMoKSkgeworICAgIGZv ciAobGV0IGYgb2YgZ2V0RnVuY3Rpb25zKG8pKSB7CisgICAgICAgIGlmIChpZ25vcmUuaW5jbHVk ZXMoZikpCisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgY29uc3QgYXJpdHlQbHVzT25l ID0gb1tmXS5sZW5ndGggKyAxOworICAgICAgICBpZiAodmVyYm9zZSkKKyAgICAgICAgICAgIHBy aW50KGBDYWxsaW5nICR7b31bJyR7Zn0nXSgke0FycmF5KGFyaXR5UGx1c09uZSkuZmlsbCgidGhy b3dlciIpfSlgKTsKKyAgICAgICAgdHJ5IHsKKyAgICAgICAgICAgIG9bZl0oQXJyYXkoYXJpdHlQ bHVzT25lKS5maWxsKHRocm93ZXIpKTsKKyAgICAgICAgfSBjYXRjaCAoZSkgeworICAgICAgICAg ICAgaWYgKGAke2V9YC5pbmNsdWRlcygnY29uc3RydWN0b3Igd2l0aG91dCBuZXcgaXMgaW52YWxp ZCcpKSB7CisgICAgICAgICAgICAgICAgdHJ5IHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKHZl cmJvc2UpCisgICAgICAgICAgICAgICAgICAgICAgICBwcmludChgICAgIENvbnN0cnVjdGluZyBp bnN0ZWFkYCk7CisgICAgICAgICAgICAgICAgICAgIG5ldyBvW2ZdKEFycmF5KGFyaXR5UGx1c09u ZSkuZmlsbCh0aHJvd2VyKSk7CisgICAgICAgICAgICAgICAgfSBjYXRjaCAoZSkgeworICAgICAg ICAgICAgICAgICAgICBpZiAodmVyYm9zZSkKKyAgICAgICAgICAgICAgICAgICAgICAgIHByaW50 KGAgICAgdGhyZXcgJHtlfWApOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0gZWxz ZSB7CisgICAgICAgICAgICAgICAgaWYgKHZlcmJvc2UpCisgICAgICAgICAgICAgICAgICAgIHBy aW50KGAgICAgdGhyZXcgJHtlfWApOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfQor fQotLSAKMi4xMC4xCgo=