180293 2017-12-01 16:15:59 -0800 download-latest-github-release.py should use existing release ANY time latest is not found 2017-12-04 15:06:14 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling achristensen annulen bfulgham commit-queue don.olmstead lforschler pvollan webkit-bug-importer oldest_to_newest 1377136 0 ross.kirsling 2017-12-01 16:15:59 -0800 download-latest-github-release.py should use existing release ANY time latest is not found 1377145 1 328183 ross.kirsling 2017-12-01 16:23:43 -0800 Created attachment 328183 Patch 1377922 2 328183 pvollan 2017-12-04 14:38:54 -0800 Comment on attachment 328183 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328183&action=review R=me. > Tools/Scripts/download-latest-github-release.py:117 > + release_url, latest_version_info = find_latest_release(args) Could 'find_latest_release' still throw an exception? If so, we might want to catch that. 1377935 3 ross.kirsling 2017-12-04 14:51:52 -0800 (In reply to Per Arne Vollan from comment #2) > > Tools/Scripts/download-latest-github-release.py:117 > > + release_url, latest_version_info = find_latest_release(args) > > Could 'find_latest_release' still throw an exception? If so, we might want > to catch that. A few days ago, Basuke added an outer `try` because find_latest_release was catching just HTTPError instead of the more general URLError (which includes network errors and the like). This patch changes find_latest_release to catch URLError so that the outer `try` is unnecessary. It could still hit a TypeError when decoding the JSON response, but we probably want user intervention in such a strange case anyway. 1377943 4 328183 commit-queue 2017-12-04 15:05:03 -0800 Comment on attachment 328183 Patch Clearing flags on attachment: 328183 Committed r225498: <https://trac.webkit.org/changeset/225498> 1377944 5 commit-queue 2017-12-04 15:05:05 -0800 All reviewed patches have been landed. Closing bug. 1377945 6 webkit-bug-importer 2017-12-04 15:06:14 -0800 <rdar://problem/35840632> 328183 2017-12-01 16:23:43 -0800 2017-12-04 15:05:03 -0800 Patch bug-180293-20171201162342.patch text/plain 5099 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1Mzc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODUxMjg3OGYwNzBiNTBiMTk2OGQ3OTZhOTg2YmUwNzAz ODU5YmYwMC4uODQ2NWQ0NzhjYjZlMjNlNWI3MWQ0M2JhYTZlYmIwMGUzN2MxMjI5NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDE3LTEyLTAxICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBkb3dubG9hZC1sYXRlc3QtZ2l0aHViLXJlbGVhc2UucHkgc2hvdWxkIHVzZSBl eGlzdGluZyByZWxlYXNlIEFOWSB0aW1lIGxhdGVzdCBpcyBub3QgZm91bmQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDI5MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9kb3dubG9hZC1s YXRlc3QtZ2l0aHViLXJlbGVhc2UucHk6CisgICAgICAgIChmaW5kX2xhdGVzdF9yZWxlYXNlKToK KyAgICAgICAgSGFuZGxlIGFsbCBVUkxFcnJvcnMsIG5vdCBqdXN0IEhUVFBFcnJvcnMuIFN0b3Ag c3BlY2lhbC1jYXNpbmcgNDA0cy4KKworICAgICAgICAobWFpbik6CisgICAgICAgIFJlYXJyYW5n ZSBsb2dpYyBzbyBhbnkgZmFpbHVyZSB0byBkZXRlY3QgYSBsYXRlc3QgcmVsZWFzZSBmYWxscyBi YWNrIHRvIGFuIGV4aXN0aW5nIHJlbGVhc2UuIEltcHJvdmUgbG9nZ2luZy4KKworICAgICAgICAo U3RhdHVzKToKKyAgICAgICAgKGRvd25sb2FkX3JlbGVhc2UpOgorICAgICAgICAobG9hZF92ZXJz aW9uX2luZm8pOiBSZW5hbWVkIGZyb20gZXhpc3RpbmdfdmVyc2lvbiBpbmZvLgorICAgICAgICAo aGFzX2xhdGVzdF9yZWxlYXNlKTogRGVsZXRlZC4KKyAgICAgICAgQ2xlYW51cC4KKwogMjAxNy0x MS0zMCAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CiAKICAgICAgICAg TWFrZSBMZWdhY3lDdXN0b21Qcm90b2NvbE1hbmFnZXIgb3B0aW9uYWwgZm9yIG5ldHdvcmsgcHJv Y2VzcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9kb3dubG9hZC1sYXRlc3QtZ2l0aHViLXJl bGVhc2UucHkgYi9Ub29scy9TY3JpcHRzL2Rvd25sb2FkLWxhdGVzdC1naXRodWItcmVsZWFzZS5w eQppbmRleCA1YTJjMjgxODc5M2YwZTNhMTdhMWFkNzFjN2FjOTU0NDFiMjcyMDQ5Li5mNTE2YzYx N2Q5MTgyZGUxYTY3ZmQxMGMzZGQ3YmQzZmFjYWE1ODAzIDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL2Rvd25sb2FkLWxhdGVzdC1naXRodWItcmVsZWFzZS5weQorKysgYi9Ub29scy9TY3JpcHRz L2Rvd25sb2FkLWxhdGVzdC1naXRodWItcmVsZWFzZS5weQpAQCAtNDYsNyArNDYsNyBAQCBjbGFz cyBTdGF0dXM6CiAgICAgRE9XTkxPQURFRCA9IDAKICAgICBVUF9UT19EQVRFID0gMQogICAgIENP VUxEX05PVF9GSU5EID0gMgotICAgIFVTRV9FWElTVElOR19WRVJTSU9OID0gMworICAgIFVTSU5H X0VYSVNUSU5HID0gMwogCiAKIGRlZiBwYXJzZV9hcmdzKGFyZ3YpOgpAQCAtNjksOSArNjksOCBA QCBkZWYgZmluZF9sYXRlc3RfcmVsZWFzZShhcmdzKToKIAogICAgIHRyeToKICAgICAgICAgcmVz cG9uc2UgPSB1cmxsaWIyLnVybG9wZW4ocmVxdWVzdCkKLSAgICBleGNlcHQgdXJsbGliMi5IVFRQ RXJyb3IsIGVycm9yOgotICAgICAgICBpZiBlcnJvci5jb2RlICE9IDQwNDoKLSAgICAgICAgICAg IHByaW50IGVycm9yLmNvZGUsIGVycm9yLnJlYXNvbgorICAgIGV4Y2VwdCB1cmxsaWIyLlVSTEVy cm9yIGFzIGVycm9yOgorICAgICAgICBwcmludCBlcnJvcgogICAgICAgICByZXR1cm4gTm9uZSwg Tm9uZQogCiAgICAgZGF0YSA9IGpzb24ubG9hZHMocmVzcG9uc2UucmVhZCgpKQpAQCAtODIsNyAr ODEsMTIgQEAgZGVmIGZpbmRfbGF0ZXN0X3JlbGVhc2UoYXJncyk6CiAgICAgcmV0dXJuIE5vbmUs IE5vbmUKIAogCi1kZWYgZXhpc3RpbmdfdmVyc2lvbl9pbmZvKHZlcnNpb25faW5mb19wYXRoKToK K2RlZiBkb3dubG9hZF9yZWxlYXNlKHNvdXJjZV91cmwsIHRhcmdldF9wYXRoKToKKyAgICB3aXRo IG9wZW4odGFyZ2V0X3BhdGgsICd3YicpIGFzIGZpbGU6CisgICAgICAgIGZpbGUud3JpdGUodXJs bGliMi51cmxvcGVuKHNvdXJjZV91cmwpLnJlYWQoKSkKKworCitkZWYgbG9hZF92ZXJzaW9uX2lu Zm8odmVyc2lvbl9pbmZvX3BhdGgpOgogICAgIGlmIG5vdCBvcy5wYXRoLmV4aXN0cyh2ZXJzaW9u X2luZm9fcGF0aCk6CiAgICAgICAgIHJldHVybiBOb25lCiAKQEAgLTkwLDE1ICs5NCw2IEBAIGRl ZiBleGlzdGluZ192ZXJzaW9uX2luZm8odmVyc2lvbl9pbmZvX3BhdGgpOgogICAgICAgICByZXR1 cm4ganNvbi5sb2FkKGZpbGUpCiAKIAotZGVmIGhhc19sYXRlc3RfcmVsZWFzZSh2ZXJzaW9uX2lu Zm9fcGF0aCwgdmVyc2lvbl9pbmZvKToKLSAgICByZXR1cm4gZXhpc3RpbmdfdmVyc2lvbl9pbmZv KHZlcnNpb25faW5mb19wYXRoKSA9PSB2ZXJzaW9uX2luZm8KLQotCi1kZWYgZG93bmxvYWRfcmVs ZWFzZShzb3VyY2VfdXJsLCB0YXJnZXRfcGF0aCk6Ci0gICAgd2l0aCBvcGVuKHRhcmdldF9wYXRo LCAnd2InKSBhcyBmaWxlOgotICAgICAgICBmaWxlLndyaXRlKHVybGxpYjIudXJsb3Blbihzb3Vy Y2VfdXJsKS5yZWFkKCkpCi0KLQogZGVmIHNhdmVfdmVyc2lvbl9pbmZvKHZlcnNpb25faW5mb19w YXRoLCB2ZXJzaW9uX2luZm8pOgogICAgIHdpdGggb3Blbih2ZXJzaW9uX2luZm9fcGF0aCwgJ3cn KSBhcyBmaWxlOgogICAgICAgICBqc29uLmR1bXAodmVyc2lvbl9pbmZvLCBmaWxlKQpAQCAtMTEw LDM1ICsxMDUsMzcgQEAgZGVmIG1haW4oYXJndik6CiAgICAgYmluYXJ5X3BhdGggPSBvcy5wYXRo LmpvaW4oYXJncy5vdXRwdXRfZGlyLCBhcmdzLmZpbGVuYW1lKQogICAgIHZlcnNpb25faW5mb19w YXRoID0gYmluYXJ5X3BhdGggKyAnLnZlcnNpb24nCiAKLSAgICBwcmludCAnU2Vla2luZyBsYXRl c3QgcmVsZWFzZSBvZiB7fSBmcm9tIHt9Li4uJy5mb3JtYXQoYXJncy5maWxlbmFtZSwgYXJncy5y ZXBvKQorICAgIHByaW50ICdVcGRhdGluZyB7fS4uLicuZm9ybWF0KGFyZ3MuZmlsZW5hbWUpCiAK LSAgICB0cnk6Ci0gICAgICAgIHJlbGVhc2VfdXJsLCB2ZXJzaW9uX2luZm8gPSBmaW5kX2xhdGVz dF9yZWxlYXNlKGFyZ3MpCisgICAgZXhpc3RpbmdfdmVyc2lvbl9pbmZvID0gbG9hZF92ZXJzaW9u X2luZm8odmVyc2lvbl9pbmZvX3BhdGgpCisgICAgaWYgZXhpc3RpbmdfdmVyc2lvbl9pbmZvOgor ICAgICAgICBwcmludCAnRm91bmQgZXhpc3RpbmcgcmVsZWFzZTonLCBleGlzdGluZ192ZXJzaW9u X2luZm9bJ3RhZ19uYW1lJ10KKyAgICBlbHNlOgorICAgICAgICBwcmludCAnTm8gZXhpc3Rpbmcg cmVsZWFzZSBmb3VuZC4nCiAKLSAgICAgICAgaWYgbm90IHJlbGVhc2VfdXJsOgotICAgICAgICAg ICAgcHJpbnQgJ05vIHJlbGVhc2UgZm91bmQhJwotICAgICAgICAgICAgcmV0dXJuIFN0YXR1cy5D T1VMRF9OT1RfRklORAorICAgIHByaW50ICdTZWVraW5nIGxhdGVzdCByZWxlYXNlIGZyb20ge30u Li4nLmZvcm1hdChhcmdzLnJlcG8pCisgICAgcmVsZWFzZV91cmwsIGxhdGVzdF92ZXJzaW9uX2lu Zm8gPSBmaW5kX2xhdGVzdF9yZWxlYXNlKGFyZ3MpCiAKLSAgICAgICAgaWYgaGFzX2xhdGVzdF9y ZWxlYXNlKHZlcnNpb25faW5mb19wYXRoLCB2ZXJzaW9uX2luZm8pOgotICAgICAgICAgICAgcHJp bnQgJ0FscmVhZHkgdXAtdG8tZGF0ZTonLCBleGlzdGluZ192ZXJzaW9uX2luZm8odmVyc2lvbl9p bmZvX3BhdGgpCi0gICAgICAgICAgICByZXR1cm4gU3RhdHVzLlVQX1RPX0RBVEUKKyAgICBpZiBu b3QgbGF0ZXN0X3ZlcnNpb25faW5mbzoKKyAgICAgICAgaWYgZXhpc3RpbmdfdmVyc2lvbl9pbmZv OgorICAgICAgICAgICAgcHJpbnQgJ0ZhbGxpbmcgYmFjayB0byBleGlzdGluZyByZWxlYXNlIScK KyAgICAgICAgICAgIHJldHVybiBTdGF0dXMuVVNJTkdfRVhJU1RJTkcKIAotICAgIGV4Y2VwdCB1 cmxsaWIyLlVSTEVycm9yLCBlcnJvcjoKLSAgICAgICAgcHJpbnQgZXJyb3IKKyAgICAgICAgcHJp bnQgJ05vIHJlbGVhc2UgZm91bmQhJworICAgICAgICByZXR1cm4gU3RhdHVzLkNPVUxEX05PVF9G SU5ECisKKyAgICBwcmludCAnRm91bmQgbGF0ZXN0IHJlbGVhc2U6JywgbGF0ZXN0X3ZlcnNpb25f aW5mb1sndGFnX25hbWUnXQogCi0gICAgICAgIHZlcnNpb25faW5mbyA9IGV4aXN0aW5nX3ZlcnNp b25faW5mbyh2ZXJzaW9uX2luZm9fcGF0aCkKLSAgICAgICAgaWYgdmVyc2lvbl9pbmZvOgotICAg ICAgICAgICAgcHJpbnQgJ1VzZSBleGlzdGluZyB2ZXJzaW9uOicsIHZlcnNpb25faW5mbwotICAg ICAgICAgICAgcmV0dXJuIFN0YXR1cy5VU0VfRVhJU1RJTkdfVkVSU0lPTgotICAgICAgICBlbHNl OgotICAgICAgICAgICAgcmV0dXJuIFN0YXR1cy5DT1VMRF9OT1RfRklORAorICAgIGlmIGxhdGVz dF92ZXJzaW9uX2luZm8gPT0gZXhpc3RpbmdfdmVyc2lvbl9pbmZvOgorICAgICAgICBwcmludCAn QWxyZWFkeSB1cC10by1kYXRlIScKKyAgICAgICAgcmV0dXJuIFN0YXR1cy5VUF9UT19EQVRFCiAK ICAgICBpZiBub3Qgb3MucGF0aC5leGlzdHMoYXJncy5vdXRwdXRfZGlyKToKICAgICAgICAgb3Mu bWFrZWRpcnMoYXJncy5vdXRwdXRfZGlyKQogCi0gICAgcHJpbnQgJ0Rvd25sb2FkaW5nIHt9IHRv IHt9Li4uJy5mb3JtYXQodmVyc2lvbl9pbmZvWyd0YWdfbmFtZSddLCBvcy5wYXRoLmFic3BhdGgo YXJncy5vdXRwdXRfZGlyKSkKKyAgICBwcmludCAnRG93bmxvYWRpbmcgdG8ge30uLi4nLmZvcm1h dChvcy5wYXRoLmFic3BhdGgoYXJncy5vdXRwdXRfZGlyKSkKICAgICBkb3dubG9hZF9yZWxlYXNl KHJlbGVhc2VfdXJsLCBiaW5hcnlfcGF0aCkKLSAgICBzYXZlX3ZlcnNpb25faW5mbyh2ZXJzaW9u X2luZm9fcGF0aCwgdmVyc2lvbl9pbmZvKQorICAgIHNhdmVfdmVyc2lvbl9pbmZvKHZlcnNpb25f aW5mb19wYXRoLCBsYXRlc3RfdmVyc2lvbl9pbmZvKQogICAgIHByaW50ICdEb25lIScKIAogICAg IHJldHVybiBTdGF0dXMuRE9XTkxPQURFRAo=