<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>180274</bug_id>
          
          <creation_ts>2017-12-01 13:21:06 -0800</creation_ts>
          <short_desc>Having a bad time needs to handle ArrayClass indexing type as well</short_desc>
          <delta_ts>2017-12-01 15:40:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>gskachkov</cc>
    
    <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1377013</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-12-01 13:21:06 -0800</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377015</commentid>
    <comment_count>1</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-12-01 13:27:58 -0800</bug_when>
    <thetext>&lt;rdar://problem/35667869&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377020</commentid>
    <comment_count>2</comment_count>
      <attachid>328147</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-12-01 13:29:29 -0800</bug_when>
    <thetext>Created attachment 328147
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377022</commentid>
    <comment_count>3</comment_count>
      <attachid>328147</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2017-12-01 13:32:07 -0800</bug_when>
    <thetext>Comment on attachment 328147
patch

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377023</commentid>
    <comment_count>4</comment_count>
      <attachid>328147</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-12-01 13:33:08 -0800</bug_when>
    <thetext>Comment on attachment 328147
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328147&amp;action=review

&gt; Source/JavaScriptCore/runtime/JSObject.cpp:1611
&gt; +        switchToSlowPutArrayStorage(vm);

Isn&apos;t this infinitely recursing?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377025</commentid>
    <comment_count>5</comment_count>
      <attachid>328147</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-12-01 13:34:03 -0800</bug_when>
    <thetext>Comment on attachment 328147
patch

oops, didn&apos;t mean to set the r? flag</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377030</commentid>
    <comment_count>6</comment_count>
      <attachid>328147</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-12-01 13:40:12 -0800</bug_when>
    <thetext>Comment on attachment 328147
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328147&amp;action=review

r=me too.

&gt;&gt; Source/JavaScriptCore/runtime/JSObject.cpp:1611
&gt;&gt; +        switchToSlowPutArrayStorage(vm);
&gt; 
&gt; Isn&apos;t this infinitely recursing?

OK, I see what&apos;s happening.  The ensureArrayStorage() ensures that the indexingType is no longer ArrayClass before recursing.  Nothing to see here.  Moving along.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377031</commentid>
    <comment_count>7</comment_count>
      <attachid>328147</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-12-01 13:42:04 -0800</bug_when>
    <thetext>Comment on attachment 328147
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328147&amp;action=review

&gt; Source/JavaScriptCore/ChangeLog:13
&gt; +        in non empty indexing types as broken, instead of having to opt out all

I suggest replacing &quot;non empty&quot; with &quot;non-empty&quot; to be consistent with your usage below.  Plus it&apos;s easier to read.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377046</commentid>
    <comment_count>8</comment_count>
      <attachid>328153</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-12-01 13:59:32 -0800</bug_when>
    <thetext>Created attachment 328153
patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377104</commentid>
    <comment_count>9</comment_count>
      <attachid>328153</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-12-01 15:40:16 -0800</bug_when>
    <thetext>Comment on attachment 328153
patch for landing

Clearing flags on attachment: 328153

Committed r225423: &lt;https://trac.webkit.org/changeset/225423&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377105</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-12-01 15:40:18 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>328147</attachid>
            <date>2017-12-01 13:29:29 -0800</date>
            <delta_ts>2017-12-01 13:59:32 -0800</delta_ts>
            <desc>patch</desc>
            <filename>a-backup.diff</filename>
            <type>text/plain</type>
            <size>5803</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyMjU0MDcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDE2IEBACisyMDE3LTEyLTAxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu
Y29tPgorCisgICAgICAgIEhhdmluZyBhIGJhZCB0aW1lIG5lZWRzIHRvIGhhbmRsZSBBcnJheUNs
YXNzIGluZGV4aW5nIHR5cGUgYXMgd2VsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMjc0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTY2Nzg2
OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0
cmVzcy9hcnJheS1wcm90b3R5cGUtc2xvdy1wdXQtaGF2aW5nLWEtYmFkLXRpbWUtMi5qczogQWRk
ZWQuCisgICAgICAgIChhc3NlcnQpOgorICAgICAgICAqIHN0cmVzcy9hcnJheS1wcm90b3R5cGUt
c2xvdy1wdXQtaGF2aW5nLWEtYmFkLXRpbWUuanM6IEFkZGVkLgorICAgICAgICAoYXNzZXJ0KToK
KwogMjAxNy0xMS0zMCAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKICAgICAg
ICAgV2ViQXNzZW1ibHk6IGltcHJvdmUgc3RhY2sgdHJhY2UKSW5kZXg6IEpTVGVzdHMvc3RyZXNz
L2FycmF5LXByb3RvdHlwZS1zbG93LXB1dC1oYXZpbmctYS1iYWQtdGltZS0yLmpzCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2FycmF5LXByb3RvdHlwZS1zbG93LXB1dC1oYXZpbmctYS1i
YWQtdGltZS0yLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2FycmF5LXByb3Rv
dHlwZS1zbG93LXB1dC1oYXZpbmctYS1iYWQtdGltZS0yLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w
LDAgKzEsMTQgQEAKK2Z1bmN0aW9uIGFzc2VydChiKSB7CisgICAgaWYgKCFiKQorICAgICAgICB0
aHJvdyBuZXcgRXJyb3I7Cit9CisKK2xldCByZXN1bHQ7CitPYmplY3QuZGVmaW5lUHJvcGVydHko
T2JqZWN0LnByb3RvdHlwZSwgJzEnLCB7CisgICAgZ2V0KCkgeyByZXR1cm4gcmVzdWx0OyB9LAor
ICAgIHNldCh4KSB7IHJlc3VsdCA9IHg7IH0KK30pOworQXJyYXkucHJvdG90eXBlLmxlbmd0aCA9
IDB4MTAwMDAwMDA7CitBcnJheS5wcm90b3R5cGVbMV0gPSA0MjsKK2Fzc2VydChyZXN1bHQgPT09
IDQyKTsKK2Fzc2VydChBcnJheS5wcm90b3R5cGVbMV0gPT09IDQyKTsKSW5kZXg6IEpTVGVzdHMv
c3RyZXNzL2FycmF5LXByb3RvdHlwZS1zbG93LXB1dC1oYXZpbmctYS1iYWQtdGltZS5qcwo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9hcnJheS1wcm90b3R5cGUtc2xvdy1wdXQtaGF2aW5n
LWEtYmFkLXRpbWUuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvYXJyYXktcHJv
dG90eXBlLXNsb3ctcHV0LWhhdmluZy1hLWJhZC10aW1lLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w
LDAgKzEsMTUgQEAKK2Z1bmN0aW9uIGFzc2VydChiKSB7CisgICAgaWYgKCFiKQorICAgICAgICB0
aHJvdyBuZXcgRXJyb3I7Cit9CisKK2xldCByZXN1bHQ7CitPYmplY3QuZGVmaW5lUHJvcGVydHko
T2JqZWN0LnByb3RvdHlwZSwgJzEnLCB7CisgICAgZ2V0KCkgeyByZXR1cm4gcmVzdWx0OyB9LAor
ICAgIHNldCh4KSB7IHJlc3VsdCA9IHg7IH0KK30pOworCitBcnJheS5wcm90b3R5cGUubGVuZ3Ro
ID0gNTsKK0FycmF5LnByb3RvdHlwZVsxXSA9IDQyOworYXNzZXJ0KHJlc3VsdCA9PT0gNDIpOwor
YXNzZXJ0KEFycmF5LnByb3RvdHlwZVsxXSA9PT0gNDIpOwpJbmRleDogU291cmNlL0phdmFTY3Jp
cHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyMjU0MDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTctMTItMDEgIFNhYW0gQmFy
YXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2aW5nIGEgYmFkIHRpbWUgbmVl
ZHMgdG8gaGFuZGxlIEFycmF5Q2xhc3MgaW5kZXhpbmcgdHlwZSBhcyB3ZWxsCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAyNzQKKyAgICAgICAgPHJk
YXI6Ly9wcm9ibGVtLzM1NjY3ODY5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gbWFrZSBzdXJlIHRvIHRyYW5zaXRpb24gQXJyYXlD
bGFzcyB0byBTbG93UHV0QXJyYXlTdG9yYWdlIGFzIHdlbGwuCisgICAgICAgIE90aGVyd2lzZSwg
d2UnbGwgZW5kIHVwIHdpdGggdGhlIHdyb25nIFN0cnVjdHVyZSwgd2hpY2ggd2lsbCBsZWFkIHVz
IHRvIG5vdAorICAgICAgICBhZGhlcmUgdG8gdGhlIHNwZWMuIFRoZSBidWcgd2FzIHRoYXQgd2Ug
d2VyZSBub3QgY29uc2lkZXJpbmcgQXJyYXlDbGFzcyBpbnNpZGUgCisgICAgICAgIGhhc0Jyb2tl
bkluZGV4aW5nLiBUaGlzIHBhdGNoIHJld3JpdGVzIHRoYXQgZnVuY3Rpb24gdG8gYXV0b21hdGlj
YWxseSBvcHQKKyAgICAgICAgaW4gbm9uIGVtcHR5IGluZGV4aW5nIHR5cGVzIGFzIGJyb2tlbiwg
aW5zdGVhZCBvZiBoYXZpbmcgdG8gb3B0IG91dCBhbGwKKyAgICAgICAgbm9uLWVtcHR5IGluZGV4
aW5nIHR5cGVzIGJlc2lkZXMgU2xvd1B1dEFycmF5U3RvcmFnZS4KKworICAgICAgICAqIHJ1bnRp
bWUvSW5kZXhpbmdUeXBlLmg6CisgICAgICAgIChKU0M6Omhhc1Nsb3dQdXRBcnJheVN0b3JhZ2Up
OgorICAgICAgICAoSlNDOjpzaG91bGRVc2VTbG93UHV0KToKKyAgICAgICAgKiBydW50aW1lL0pT
R2xvYmFsT2JqZWN0LmNwcDoKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0LmNwcDoKKyAgICAg
ICAgKEpTQzo6SlNPYmplY3Q6OnN3aXRjaFRvU2xvd1B1dEFycmF5U3RvcmFnZSk6CisKIDIwMTct
MTEtMzAgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAg
W0pTQ10gVXNlIEpTRml4ZWRBcnJheSBmb3Igb3BfbmV3X2FycmF5X2J1ZmZlcgpJbmRleDogU291
cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW5kZXhpbmdUeXBlLmgKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW5kZXhpbmdUeXBlLmgJKHJldmlzaW9uIDIy
NTQwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0luZGV4aW5nVHlwZS5oCSh3
b3JraW5nIGNvcHkpCkBAIC0xNTMsMTEgKzE1MywxNiBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaGFz
QW55QXJyYXlTdG9yYWdlKEluCiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVpbnQ4X3Q+KGluZGV4
aW5nVHlwZSAmIEluZGV4aW5nU2hhcGVNYXNrKSA+PSBBcnJheVN0b3JhZ2VTaGFwZTsKIH0KIAot
c3RhdGljIGlubGluZSBib29sIHNob3VsZFVzZVNsb3dQdXQoSW5kZXhpbmdUeXBlIGluZGV4aW5n
VHlwZSkKK3N0YXRpYyBpbmxpbmUgYm9vbCBoYXNTbG93UHV0QXJyYXlTdG9yYWdlKEluZGV4aW5n
VHlwZSBpbmRleGluZ1R5cGUpCiB7CiAgICAgcmV0dXJuIChpbmRleGluZ1R5cGUgJiBJbmRleGlu
Z1NoYXBlTWFzaykgPT0gU2xvd1B1dEFycmF5U3RvcmFnZVNoYXBlOwogfQogCitzdGF0aWMgaW5s
aW5lIGJvb2wgc2hvdWxkVXNlU2xvd1B1dChJbmRleGluZ1R5cGUgaW5kZXhpbmdUeXBlKQorewor
ICAgIHJldHVybiBoYXNTbG93UHV0QXJyYXlTdG9yYWdlKGluZGV4aW5nVHlwZSk7Cit9CisKIGlu
bGluZSBJbmRleGluZ1R5cGUgaW5kZXhpbmdUeXBlRm9yVmFsdWUoSlNWYWx1ZSB2YWx1ZSkKIHsK
ICAgICBpZiAodmFsdWUuaXNJbnQzMigpKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1
bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0
Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcAkocmV2aXNpb24gMjI1NDAzKQorKysgU291
cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwCSh3b3JraW5nIGNv
cHkpCkBAIC0xMTIzLDExICsxMTIzLDggQEAgT2JqZWN0c1dpdGhCcm9rZW5JbmRleGluZ0ZpbmRl
cjo6T2JqZWN0cwogCiBpbmxpbmUgYm9vbCBoYXNCcm9rZW5JbmRleGluZyhKU09iamVjdCogb2Jq
ZWN0KQogewotICAgIC8vIFRoaXMgd2lsbCBjaGFuZ2UgaWYgd2UgaGF2ZSBtb3JlIGluZGV4aW5n
IHR5cGVzLgogICAgIEluZGV4aW5nVHlwZSB0eXBlID0gb2JqZWN0LT5pbmRleGluZ1R5cGUoKTsK
LSAgICAvLyBUaGlzIGNvdWxkIGJlIG1hZGUgb2J2aW91c2x5IG1vcmUgZWZmaWNpZW50LCBidXQg
aXNuJ3QgbWFkZSBzbyByaWdodCBub3csIGJlY2F1c2UKLSAgICAvLyB3ZSBleHBlY3QgdGhpcyB0
byBiZSBhbiB1bmxpa2VseSBzbG93IHBhdGggYW55d2F5LgotICAgIHJldHVybiBoYXNVbmRlY2lk
ZWQodHlwZSkgfHwgaGFzSW50MzIodHlwZSkgfHwgaGFzRG91YmxlKHR5cGUpIHx8IGhhc0NvbnRp
Z3VvdXModHlwZSkgfHwgaGFzQXJyYXlTdG9yYWdlKHR5cGUpOworICAgIHJldHVybiB0eXBlICYm
ICFoYXNTbG93UHV0QXJyYXlTdG9yYWdlKHR5cGUpOwogfQogCiBpbmxpbmUgdm9pZCBPYmplY3Rz
V2l0aEJyb2tlbkluZGV4aW5nRmluZGVyOjp2aXNpdChKU0NlbGwqIGNlbGwpCkluZGV4OiBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCShyZXZpc2lvbiAyMjU0MDMp
CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJKHdvcmtpbmcg
Y29weSkKQEAgLTE2MDMsNiArMTYwMywxNCBAQCBBcnJheVN0b3JhZ2UqIEpTT2JqZWN0OjplbnN1
cmVBcnJheVN0b3JhCiB2b2lkIEpTT2JqZWN0Ojpzd2l0Y2hUb1Nsb3dQdXRBcnJheVN0b3JhZ2Uo
Vk0mIHZtKQogewogICAgIHN3aXRjaCAoaW5kZXhpbmdUeXBlKCkpIHsKKyAgICBjYXNlIEFycmF5
Q2xhc3M6CisgICAgICAgIGVuc3VyZUFycmF5U3RvcmFnZSh2bSk7CisgICAgICAgIFJFTEVBU0Vf
QVNTRVJUKGhhc0FueUFycmF5U3RvcmFnZShpbmRleGluZ1R5cGUoKSkpOworICAgICAgICBpZiAo
aGFzU2xvd1B1dEFycmF5U3RvcmFnZShpbmRleGluZ1R5cGUoKSkpCisgICAgICAgICAgICByZXR1
cm47CisgICAgICAgIHN3aXRjaFRvU2xvd1B1dEFycmF5U3RvcmFnZSh2bSk7CisgICAgICAgIGJy
ZWFrOworCiAgICAgY2FzZSBBTExfVU5ERUNJREVEX0lOREVYSU5HX1RZUEVTOgogICAgICAgICBj
b252ZXJ0VW5kZWNpZGVkVG9BcnJheVN0b3JhZ2Uodm0sIE5vblByb3BlcnR5VHJhbnNpdGlvbjo6
QWxsb2NhdGVTbG93UHV0QXJyYXlTdG9yYWdlKTsKICAgICAgICAgYnJlYWs7Cg==
</data>
<flag name="review"
          id="347349"
          type_id="1"
          status="+"
          setter="mark.lam"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>328153</attachid>
            <date>2017-12-01 13:59:32 -0800</date>
            <delta_ts>2017-12-01 15:40:16 -0800</delta_ts>
            <desc>patch for landing</desc>
            <filename>a-backup.diff</filename>
            <type>text/plain</type>
            <size>5825</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyMjU0MDcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDE2IEBACisyMDE3LTEyLTAxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu
Y29tPgorCisgICAgICAgIEhhdmluZyBhIGJhZCB0aW1lIG5lZWRzIHRvIGhhbmRsZSBBcnJheUNs
YXNzIGluZGV4aW5nIHR5cGUgYXMgd2VsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMjc0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTY2Nzg2
OT4KKworICAgICAgICBSZXZpZXdlZCBieSBLZWl0aCBNaWxsZXIgYW5kIE1hcmsgTGFtLgorCisg
ICAgICAgICogc3RyZXNzL2FycmF5LXByb3RvdHlwZS1zbG93LXB1dC1oYXZpbmctYS1iYWQtdGlt
ZS0yLmpzOiBBZGRlZC4KKyAgICAgICAgKGFzc2VydCk6CisgICAgICAgICogc3RyZXNzL2FycmF5
LXByb3RvdHlwZS1zbG93LXB1dC1oYXZpbmctYS1iYWQtdGltZS5qczogQWRkZWQuCisgICAgICAg
IChhc3NlcnQpOgorCiAyMDE3LTExLTMwICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNv
bT4KIAogICAgICAgICBXZWJBc3NlbWJseTogaW1wcm92ZSBzdGFjayB0cmFjZQpJbmRleDogSlNU
ZXN0cy9zdHJlc3MvYXJyYXktcHJvdG90eXBlLXNsb3ctcHV0LWhhdmluZy1hLWJhZC10aW1lLTIu
anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvYXJyYXktcHJvdG90eXBlLXNsb3ctcHV0
LWhhdmluZy1hLWJhZC10aW1lLTIuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3Mv
YXJyYXktcHJvdG90eXBlLXNsb3ctcHV0LWhhdmluZy1hLWJhZC10aW1lLTIuanMJKHdvcmtpbmcg
Y29weSkKQEAgLTAsMCArMSwxNCBAQAorZnVuY3Rpb24gYXNzZXJ0KGIpIHsKKyAgICBpZiAoIWIp
CisgICAgICAgIHRocm93IG5ldyBFcnJvcjsKK30KKworbGV0IHJlc3VsdDsKK09iamVjdC5kZWZp
bmVQcm9wZXJ0eShPYmplY3QucHJvdG90eXBlLCAnMScsIHsKKyAgICBnZXQoKSB7IHJldHVybiBy
ZXN1bHQ7IH0sCisgICAgc2V0KHgpIHsgcmVzdWx0ID0geDsgfQorfSk7CitBcnJheS5wcm90b3R5
cGUubGVuZ3RoID0gMHgxMDAwMDAwMDsKK0FycmF5LnByb3RvdHlwZVsxXSA9IDQyOworYXNzZXJ0
KHJlc3VsdCA9PT0gNDIpOworYXNzZXJ0KEFycmF5LnByb3RvdHlwZVsxXSA9PT0gNDIpOwpJbmRl
eDogSlNUZXN0cy9zdHJlc3MvYXJyYXktcHJvdG90eXBlLXNsb3ctcHV0LWhhdmluZy1hLWJhZC10
aW1lLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2FycmF5LXByb3RvdHlwZS1zbG93
LXB1dC1oYXZpbmctYS1iYWQtdGltZS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVz
cy9hcnJheS1wcm90b3R5cGUtc2xvdy1wdXQtaGF2aW5nLWEtYmFkLXRpbWUuanMJKHdvcmtpbmcg
Y29weSkKQEAgLTAsMCArMSwxNSBAQAorZnVuY3Rpb24gYXNzZXJ0KGIpIHsKKyAgICBpZiAoIWIp
CisgICAgICAgIHRocm93IG5ldyBFcnJvcjsKK30KKworbGV0IHJlc3VsdDsKK09iamVjdC5kZWZp
bmVQcm9wZXJ0eShPYmplY3QucHJvdG90eXBlLCAnMScsIHsKKyAgICBnZXQoKSB7IHJldHVybiBy
ZXN1bHQ7IH0sCisgICAgc2V0KHgpIHsgcmVzdWx0ID0geDsgfQorfSk7CisKK0FycmF5LnByb3Rv
dHlwZS5sZW5ndGggPSA1OworQXJyYXkucHJvdG90eXBlWzFdID0gNDI7Cithc3NlcnQocmVzdWx0
ID09PSA0Mik7Cithc3NlcnQoQXJyYXkucHJvdG90eXBlWzFdID09PSA0Mik7CkluZGV4OiBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNTQwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyNSBAQAorMjAxNy0xMi0w
MSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBIYXZpbmcgYSBi
YWQgdGltZSBuZWVkcyB0byBoYW5kbGUgQXJyYXlDbGFzcyBpbmRleGluZyB0eXBlIGFzIHdlbGwK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDI3NAor
ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU2Njc4Njk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
S2VpdGggTWlsbGVyIGFuZCBNYXJrIExhbS4KKworICAgICAgICBXZSBuZWVkIHRvIG1ha2Ugc3Vy
ZSB0byB0cmFuc2l0aW9uIEFycmF5Q2xhc3MgdG8gU2xvd1B1dEFycmF5U3RvcmFnZSBhcyB3ZWxs
LgorICAgICAgICBPdGhlcndpc2UsIHdlJ2xsIGVuZCB1cCB3aXRoIHRoZSB3cm9uZyBTdHJ1Y3R1
cmUsIHdoaWNoIHdpbGwgbGVhZCB1cyB0byBub3QKKyAgICAgICAgYWRoZXJlIHRvIHRoZSBzcGVj
LiBUaGUgYnVnIHdhcyB0aGF0IHdlIHdlcmUgbm90IGNvbnNpZGVyaW5nIEFycmF5Q2xhc3MgaW5z
aWRlIAorICAgICAgICBoYXNCcm9rZW5JbmRleGluZy4gVGhpcyBwYXRjaCByZXdyaXRlcyB0aGF0
IGZ1bmN0aW9uIHRvIGF1dG9tYXRpY2FsbHkgb3B0CisgICAgICAgIGluIG5vbi1lbXB0eSBpbmRl
eGluZyB0eXBlcyBhcyBicm9rZW4sIGluc3RlYWQgb2YgaGF2aW5nIHRvIG9wdCBvdXQgYWxsCisg
ICAgICAgIG5vbi1lbXB0eSBpbmRleGluZyB0eXBlcyBiZXNpZGVzIFNsb3dQdXRBcnJheVN0b3Jh
Z2UuCisKKyAgICAgICAgKiBydW50aW1lL0luZGV4aW5nVHlwZS5oOgorICAgICAgICAoSlNDOjpo
YXNTbG93UHV0QXJyYXlTdG9yYWdlKToKKyAgICAgICAgKEpTQzo6c2hvdWxkVXNlU2xvd1B1dCk6
CisgICAgICAgICogcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHA6CisgICAgICAgICogcnVudGlt
ZS9KU09iamVjdC5jcHA6CisgICAgICAgIChKU0M6OkpTT2JqZWN0Ojpzd2l0Y2hUb1Nsb3dQdXRB
cnJheVN0b3JhZ2UpOgorCiAyMDE3LTExLTMwICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFA
Z21haWwuY29tPgogCiAgICAgICAgIFtKU0NdIFVzZSBKU0ZpeGVkQXJyYXkgZm9yIG9wX25ld19h
cnJheV9idWZmZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0luZGV4aW5n
VHlwZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0luZGV4
aW5nVHlwZS5oCShyZXZpc2lvbiAyMjU0MDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu
dGltZS9JbmRleGluZ1R5cGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTUzLDExICsxNTMsMTYgQEAg
c3RhdGljIGlubGluZSBib29sIGhhc0FueUFycmF5U3RvcmFnZShJbgogICAgIHJldHVybiBzdGF0
aWNfY2FzdDx1aW50OF90PihpbmRleGluZ1R5cGUgJiBJbmRleGluZ1NoYXBlTWFzaykgPj0gQXJy
YXlTdG9yYWdlU2hhcGU7CiB9CiAKLXN0YXRpYyBpbmxpbmUgYm9vbCBzaG91bGRVc2VTbG93UHV0
KEluZGV4aW5nVHlwZSBpbmRleGluZ1R5cGUpCitzdGF0aWMgaW5saW5lIGJvb2wgaGFzU2xvd1B1
dEFycmF5U3RvcmFnZShJbmRleGluZ1R5cGUgaW5kZXhpbmdUeXBlKQogewogICAgIHJldHVybiAo
aW5kZXhpbmdUeXBlICYgSW5kZXhpbmdTaGFwZU1hc2spID09IFNsb3dQdXRBcnJheVN0b3JhZ2VT
aGFwZTsKIH0KIAorc3RhdGljIGlubGluZSBib29sIHNob3VsZFVzZVNsb3dQdXQoSW5kZXhpbmdU
eXBlIGluZGV4aW5nVHlwZSkKK3sKKyAgICByZXR1cm4gaGFzU2xvd1B1dEFycmF5U3RvcmFnZShp
bmRleGluZ1R5cGUpOworfQorCiBpbmxpbmUgSW5kZXhpbmdUeXBlIGluZGV4aW5nVHlwZUZvclZh
bHVlKEpTVmFsdWUgdmFsdWUpCiB7CiAgICAgaWYgKHZhbHVlLmlzSW50MzIoKSkKSW5kZXg6IFNv
dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAJKHJl
dmlzaW9uIDIyNTQwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFs
T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyMywxMSArMTEyMyw4IEBAIE9iamVjdHNX
aXRoQnJva2VuSW5kZXhpbmdGaW5kZXI6Ok9iamVjdHMKIAogaW5saW5lIGJvb2wgaGFzQnJva2Vu
SW5kZXhpbmcoSlNPYmplY3QqIG9iamVjdCkKIHsKLSAgICAvLyBUaGlzIHdpbGwgY2hhbmdlIGlm
IHdlIGhhdmUgbW9yZSBpbmRleGluZyB0eXBlcy4KICAgICBJbmRleGluZ1R5cGUgdHlwZSA9IG9i
amVjdC0+aW5kZXhpbmdUeXBlKCk7Ci0gICAgLy8gVGhpcyBjb3VsZCBiZSBtYWRlIG9idmlvdXNs
eSBtb3JlIGVmZmljaWVudCwgYnV0IGlzbid0IG1hZGUgc28gcmlnaHQgbm93LCBiZWNhdXNlCi0g
ICAgLy8gd2UgZXhwZWN0IHRoaXMgdG8gYmUgYW4gdW5saWtlbHkgc2xvdyBwYXRoIGFueXdheS4K
LSAgICByZXR1cm4gaGFzVW5kZWNpZGVkKHR5cGUpIHx8IGhhc0ludDMyKHR5cGUpIHx8IGhhc0Rv
dWJsZSh0eXBlKSB8fCBoYXNDb250aWd1b3VzKHR5cGUpIHx8IGhhc0FycmF5U3RvcmFnZSh0eXBl
KTsKKyAgICByZXR1cm4gdHlwZSAmJiAhaGFzU2xvd1B1dEFycmF5U3RvcmFnZSh0eXBlKTsKIH0K
IAogaW5saW5lIHZvaWQgT2JqZWN0c1dpdGhCcm9rZW5JbmRleGluZ0ZpbmRlcjo6dmlzaXQoSlND
ZWxsKiBjZWxsKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3Qu
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0
LmNwcAkocmV2aXNpb24gMjI1NDAzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv
SlNPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAzLDYgKzE2MDMsMTQgQEAgQXJyYXlT
dG9yYWdlKiBKU09iamVjdDo6ZW5zdXJlQXJyYXlTdG9yYQogdm9pZCBKU09iamVjdDo6c3dpdGNo
VG9TbG93UHV0QXJyYXlTdG9yYWdlKFZNJiB2bSkKIHsKICAgICBzd2l0Y2ggKGluZGV4aW5nVHlw
ZSgpKSB7CisgICAgY2FzZSBBcnJheUNsYXNzOgorICAgICAgICBlbnN1cmVBcnJheVN0b3JhZ2Uo
dm0pOworICAgICAgICBSRUxFQVNFX0FTU0VSVChoYXNBbnlBcnJheVN0b3JhZ2UoaW5kZXhpbmdU
eXBlKCkpKTsKKyAgICAgICAgaWYgKGhhc1Nsb3dQdXRBcnJheVN0b3JhZ2UoaW5kZXhpbmdUeXBl
KCkpKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBzd2l0Y2hUb1Nsb3dQdXRBcnJheVN0
b3JhZ2Uodm0pOworICAgICAgICBicmVhazsKKwogICAgIGNhc2UgQUxMX1VOREVDSURFRF9JTkRF
WElOR19UWVBFUzoKICAgICAgICAgY29udmVydFVuZGVjaWRlZFRvQXJyYXlTdG9yYWdlKHZtLCBO
b25Qcm9wZXJ0eVRyYW5zaXRpb246OkFsbG9jYXRlU2xvd1B1dEFycmF5U3RvcmFnZSk7CiAgICAg
ICAgIGJyZWFrOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>