180256 2017-12-01 09:56:08 -0800 [GStreamer] Fix USE_GSTREAMER_GL check for GStreamer 1.10 2017-12-01 10:56:04 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply clopez commit-queue mcatanzaro oldest_to_newest 1376857 0 mcatanzaro 2017-12-01 09:56:08 -0800 It's not safe to change the value of build options after WEBKIT_OPTION_END, since it breaks the option dependency checker. I don't think that actually hurts anything in this case, but let's not encourage bad practice. Also, it's not good for features to be silently disabled. Failing the build at the CMake stage lets distributors know that a feature will be missing. And of course, it's still possible to disable USE_GSTREAMER_GL to avoid the increased GStreamer requirement. 1376860 1 328110 mcatanzaro 2017-12-01 10:00:10 -0800 Created attachment 328110 Patch 1376904 2 328110 commit-queue 2017-12-01 10:39:18 -0800 Comment on attachment 328110 Patch Clearing flags on attachment: 328110 Committed r225401: <https://trac.webkit.org/changeset/225401> 1376905 3 commit-queue 2017-12-01 10:39:19 -0800 All reviewed patches have been landed. Closing bug. 1376916 4 clopez 2017-12-01 10:56:04 -0800 This broke both Debian and Ubuntu GTK bots. I fixed that locally by passing --cmakeargs=-DUSE_GSTREAMER_GL=OFF 328110 2017-12-01 10:00:10 -0800 2017-12-01 10:39:18 -0800 Patch bug-180256-20171201120009.patch text/plain 1927 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvR1N0 cmVhbWVyQ2hlY2tzLmNtYWtlIGIvU291cmNlL2NtYWtlL0dTdHJlYW1lckNoZWNrcy5jbWFrZQpp bmRleCA1YTYxMDFkMzI3MzlmMTgxYzg5NjVhZjgwNGZmODgyOTU2MWFiMzYzLi5iZGY5ZjIyNDUz OTljODYyNWY3ODI2ZmVmNWRlNGM3NGE2MDdkYjUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Uv R1N0cmVhbWVyQ2hlY2tzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9HU3RyZWFtZXJDaGVja3Mu Y21ha2UKQEAgLTM0LDggKzM0LDcgQEAgaWYgKEVOQUJMRV9WSURFTyBPUiBFTkFCTEVfV0VCX0FV RElPKQogCiAgICAgaWYgKFVTRV9HU1RSRUFNRVJfR0wpCiAgICAgICAgIGlmIChQQ19HU1RSRUFN RVJfVkVSU0lPTiBWRVJTSU9OX0xFU1MgIjEuMTAiKQotICAgICAgICAgICAgc2V0KFVTRV9HU1RS RUFNRVJfR0wgT0ZGKQotICAgICAgICAgICAgbWVzc2FnZShTVEFUVVMgIkRpc2FibGluZyBHU1RS RUFNRVJfR0wgYXMgdGhlIEdTdHJlYW1lciB2ZXJzaW9uIGlzIG9sZGVyIHRoYW4gMS4xMC4iKQor ICAgICAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiR1N0cmVhbWVyIDEuMTAgaXMgbmVlZGVk IGZvciBVU0VfR1NUUkVBTUVSX0dMLiIpCiAgICAgICAgIGVsc2UgKCkKICAgICAgICAgICAgIGlm IChOT1QgUENfR1NUUkVBTUVSX0dMX0ZPVU5EKQogICAgICAgICAgICAgICAgIG1lc3NhZ2UoRkFU QUxfRVJST1IgIkdTdHJlYW1lckdMIGlzIG5lZWRlZCBmb3IgVVNFX0dTVFJFQU1FUl9HTC4iKQpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDI1ZmE0NzlhNDZjYzNkYzFi YWI1MDdiNGM3NGI1YzE3YWQxNmJjNTcuLjk5ZjEwYmZjNGI2MGVmNDYwYjk3ODU3ZGIxZGQxOTRh ODU5YjliZmQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOSBAQAorMjAxNy0xMi0wMSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gRml4IFVTRV9HU1RSRUFNRVJfR0wgY2hlY2sg Zm9yIEdTdHJlYW1lciAxLjEwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODAyNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJdCdzIG5vdCBzYWZlIHRvIGNoYW5nZSB0aGUgdmFsdWUgb2YgYnVpbGQgb3B0 aW9ucyBhZnRlciBXRUJLSVRfT1BUSU9OX0VORCwgc2luY2UgaXQgYnJlYWtzCisgICAgICAgIHRo ZSBvcHRpb24gZGVwZW5kZW5jeSBjaGVja2VyLiBJIGRvbid0IHRoaW5rIHRoYXQgYWN0dWFsbHkg aHVydHMgYW55dGhpbmcgaW4gdGhpcyBjYXNlLCBidXQKKyAgICAgICAgbGV0J3Mgbm90IGVuY291 cmFnZSBiYWQgcHJhY3RpY2UuIEFsc28sIGl0J3Mgbm90IGdvb2QgZm9yIGZlYXR1cmVzIHRvIGJl IHNlY3JldGx5IGRpc2FibGVkLgorICAgICAgICBOb2JvZHkgcmVhZHMgQ01ha2Ugb3V0cHV0IHVu bGVzcyB0aGVyZSBpcyBhIGZhdGFsIGVycm9yLiBGYWlsaW5nIHRoZSBidWlsZCBhdCB0aGUgQ01h a2UKKyAgICAgICAgc3RhZ2UgbGV0cyBkaXN0cmlidXRvcnMga25vdyB0aGF0IGEgZmVhdHVyZSB3 aWxsIGJlIG1pc3NpbmcuIEFuZCBvZiBjb3Vyc2UsIGl0J3Mgc3RpbGwKKyAgICAgICAgcG9zc2li bGUgdG8gZGlzYWJsZSBVU0VfR1NUUkVBTUVSX0dMIHRvIGF2b2lkIHRoZSBpbmNyZWFzZWQgR1N0 cmVhbWVyIHJlcXVpcmVtZW50LgorCisgICAgICAgICogU291cmNlL2NtYWtlL0dTdHJlYW1lckNo ZWNrcy5jbWFrZToKKwogMjAxNy0xMS0yOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBNYWMgQ01ha2UgYnVpbGQuCg==