<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>180249</bug_id>
          
          <creation_ts>2017-12-01 08:32:06 -0800</creation_ts>
          <short_desc>The GC load balancer should not rely on a global mutex</short_desc>
          <delta_ts>2017-12-03 14:21:25 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>180250</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>gskachkov</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1376815</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2017-12-01 08:32:06 -0800</bug_when>
    <thetext>The Heap::m_markingMutex was a great first attempt at synchronizing a load balancer.  It&apos;s amazing how long that thing has survived.  But profiling shows that this is one of the most (and sometimes the absolute most) contended mutex in WebKit when running Speedometer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1376816</commentid>
    <comment_count>1</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2017-12-01 08:33:10 -0800</bug_when>
    <thetext>@Ryosuke: seems like we have a Speedometer perf opportunity from giving the GC a proper load balancer instead of our current single-global-lock-protecting-a-stack algorithm.

If load balancers were like 3D engines, then our GC uses the Wolfenstein 3D of load balancers.  I think we can do better.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377482</commentid>
    <comment_count>2</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2017-12-03 11:55:59 -0800</bug_when>
    <thetext>I guess it would be useful to know how much wall time is spent in GC during Speedometer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1377512</commentid>
    <comment_count>3</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2017-12-03 14:21:25 -0800</bug_when>
    <thetext>(In reply to Ryosuke Niwa from comment #2)
&gt; I guess it would be useful to know how much wall time is spent in GC during
&gt; Speedometer.

I don’t have a number, but in the past it has responded to GC optimizations and regresssions about the same way as the average of other JS benchmarks.  I just got a 1% Speedometer speedup from doing something else to the GC. 

“Time spent in GC” is not an easily-defined number because the GC is concurrent.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>