180244 2017-12-01 06:02:18 -0800 WebDriver: implement element property command 2017-12-04 03:30:32 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg ews-watchlist webkit-bug-importer oldest_to_newest 1376796 0 cgarcia 2017-12-01 06:02:18 -0800 13.3 Get Element Property https://w3c.github.io/webdriver/webdriver-spec.html#get-element-property 1376797 1 328089 cgarcia 2017-12-01 06:05:44 -0800 Created attachment 328089 Patch 1376798 2 ews-watchlist 2017-12-01 06:08:24 -0800 Attachment 328089 did not pass style-queue: ERROR: Source/WebDriver/WebDriverService.h:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:1137: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:1287: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1376842 3 328089 bburg 2017-12-01 09:29:52 -0800 Comment on attachment 328089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328089&action=review r=me > Source/WebDriver/Session.cpp:1321 > + return; It's not clear to me what will happen if element.`property` is undefined. Will it return an error or not? Just looking at the W3C test names, I can't easily tell that this case is covered. 1377284 4 cgarcia 2017-12-02 07:07:17 -0800 (In reply to Brian Burg from comment #3) > Comment on attachment 328089 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328089&action=review > > r=me > > > Source/WebDriver/Session.cpp:1321 > > + return; > > It's not clear to me what will happen if element.`property` is undefined. > Will it return an error or not? Just looking at the W3C test names, I can't > easily tell that this case is covered. Good point, I think it will return a JS error, because the code will raise an exception, I guess. We should handle that case and return null. 1377641 5 cgarcia 2017-12-04 03:27:53 -0800 (In reply to Carlos Garcia Campos from comment #4) > (In reply to Brian Burg from comment #3) > > Comment on attachment 328089 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=328089&action=review > > > > r=me > > > > > Source/WebDriver/Session.cpp:1321 > > > + return; > > > > It's not clear to me what will happen if element.`property` is undefined. > > Will it return an error or not? Just looking at the W3C test names, I can't > > easily tell that this case is covered. > > Good point, I think it will return a JS error, because the code will raise > an exception, I guess. We should handle that case and return null. I've checked this and it's tested by test_element_non_existent. We need to handle it, but in a more general way, so I'll fix this and other similar cases in a follow up patch. 1377643 6 cgarcia 2017-12-04 03:29:37 -0800 Committed r225474: <https://trac.webkit.org/changeset/225474> 1377645 7 webkit-bug-importer 2017-12-04 03:30:32 -0800 <rdar://problem/35826863> 328089 2017-12-01 06:05:44 -0800 2017-12-01 09:29:52 -0800 Patch wd-element-property.diff text/plain 9295 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggNWIwOWY4ZDMxMDYuLjEwYzdjZjkzMzkwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI3IEBACisyMDE3LTEyLTAxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGltcGxlbWVudCBlbGVtZW50 IHByb3BlcnR5IGNvbW1hbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4MDI0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIDEzLjMgR2V0IEVsZW1lbnQgUHJvcGVydHkKKyAgICAgICAgaHR0cHM6Ly93M2Mu Z2l0aHViLmlvL3dlYmRyaXZlci93ZWJkcml2ZXItc3BlYy5odG1sI2dldC1lbGVtZW50LXByb3Bl cnR5CisKKyAgICAgICAgRml4ZXM6IGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvc3RhdGUv Z2V0X2VsZW1lbnRfcHJvcGVydHkucHk6OnRlc3Rfbm9fYnJvd3NpbmdfY29udGV4dAorICAgICAg ICAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9zdGF0ZS9nZXRfZWxlbWVudF9w cm9wZXJ0eS5weTo6dGVzdF9oYW5kbGVfcHJvbXB0X2Rpc21pc3MKKyAgICAgICAgICAgICAgIGlt cG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvc3RhdGUvZ2V0X2VsZW1lbnRfcHJvcGVydHkucHk6 OnRlc3RfaGFuZGxlX3Byb21wdF9hY2NlcHQKKyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93 ZWJkcml2ZXIvdGVzdHMvc3RhdGUvZ2V0X2VsZW1lbnRfcHJvcGVydHkucHk6OnRlc3RfaGFuZGxl X3Byb21wdF9taXNzaW5nX3ZhbHVlCisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2ViZHJp dmVyL3Rlc3RzL3N0YXRlL2dldF9lbGVtZW50X3Byb3BlcnR5LnB5Ojp0ZXN0X2VsZW1lbnRfc3Rh bGUKKworICAgICAgICAqIFNlc3Npb24uY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpTZXNzaW9u OjpnZXRFbGVtZW50QXR0cmlidXRlKToKKyAgICAgICAgKFdlYkRyaXZlcjo6U2Vzc2lvbjo6Z2V0 RWxlbWVudFByb3BlcnR5KToKKyAgICAgICAgKiBTZXNzaW9uLmg6CisgICAgICAgICogV2ViRHJp dmVyU2VydmljZS5jcHA6CisgICAgICAgIChXZWJEcml2ZXI6OldlYkRyaXZlclNlcnZpY2U6Omdl dEVsZW1lbnRQcm9wZXJ0eSk6CisgICAgICAgICogV2ViRHJpdmVyU2VydmljZS5oOgorCiAyMDE3 LTEyLTAxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBXZWJEcml2ZXI6IGltcGxlbWVudCBzdGF0dXMgY29tbWFuZApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAK aW5kZXggYjRkMDQ1Mjk0MzYuLjQ1Yjk3ZmE0MTVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViRHJp dmVyL1Nlc3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAKQEAgLTEy ODQsNiArMTI4NCw0NyBAQCB2b2lkIFNlc3Npb246OmdldEVsZW1lbnRBdHRyaWJ1dGUoY29uc3Qg U3RyaW5nJiBlbGVtZW50SUQsIGNvbnN0IFN0cmluZyYgYXR0cmlidQogICAgIH0pOwogfQogCit2 b2lkIFNlc3Npb246OmdldEVsZW1lbnRQcm9wZXJ0eShjb25zdCBTdHJpbmcmIGVsZW1lbnRJRCwg Y29uc3QgU3RyaW5nJiBwcm9wZXJ0eSwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4m JiBjb21wbGV0aW9uSGFuZGxlcikKK3sKKyAgICBpZiAoIW1fdG9wbGV2ZWxCcm93c2luZ0NvbnRl eHQpIHsKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3VsdDo6ZmFpbChDb21t YW5kUmVzdWx0OjpFcnJvckNvZGU6Ok5vU3VjaFdpbmRvdykpOworICAgICAgICByZXR1cm47Cisg ICAgfQorCisgICAgaGFuZGxlVXNlclByb21wdHMoW3RoaXMsIGVsZW1lbnRJRCwgcHJvcGVydHks IGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildKENvbW1hbmRS ZXN1bHQmJiByZXN1bHQpIG11dGFibGUgeworICAgICAgICBpZiAocmVzdWx0LmlzRXJyb3IoKSkg eworICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoV1RGTW92ZShyZXN1bHQpKTsKKyAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgICAgICBSZWZQdHI8SlNPTjo6QXJyYXk+IGFy Z3VtZW50cyA9IEpTT046OkFycmF5OjpjcmVhdGUoKTsKKyAgICAgICAgYXJndW1lbnRzLT5wdXNo U3RyaW5nKGNyZWF0ZUVsZW1lbnQoZWxlbWVudElEKS0+dG9KU09OU3RyaW5nKCkpOworCisgICAg ICAgIFJlZlB0cjxKU09OOjpPYmplY3Q+IHBhcmFtZXRlcnMgPSBKU09OOjpPYmplY3Q6OmNyZWF0 ZSgpOworICAgICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJicm93c2lu Z0NvbnRleHRIYW5kbGUiKSwgbV90b3BsZXZlbEJyb3dzaW5nQ29udGV4dC52YWx1ZSgpKTsKKyAg ICAgICAgaWYgKG1fY3VycmVudEJyb3dzaW5nQ29udGV4dCkKKyAgICAgICAgICAgIHBhcmFtZXRl cnMtPnNldFN0cmluZyhBU0NJSUxpdGVyYWwoImZyYW1lSGFuZGxlIiksIG1fY3VycmVudEJyb3dz aW5nQ29udGV4dC52YWx1ZSgpKTsKKyAgICAgICAgcGFyYW1ldGVycy0+c2V0U3RyaW5nKEFTQ0lJ TGl0ZXJhbCgiZnVuY3Rpb24iKSwgbWFrZVN0cmluZygiZnVuY3Rpb24oZWxlbWVudCkgeyByZXR1 cm4gZWxlbWVudC4iLCBwcm9wZXJ0eSwgIjsgfSIpKTsKKyAgICAgICAgcGFyYW1ldGVycy0+c2V0 QXJyYXkoQVNDSUlMaXRlcmFsKCJhcmd1bWVudHMiKSwgV1RGTW92ZShhcmd1bWVudHMpKTsKKyAg ICAgICAgbV9ob3N0LT5zZW5kQ29tbWFuZFRvQmFja2VuZChBU0NJSUxpdGVyYWwoImV2YWx1YXRl SmF2YVNjcmlwdEZ1bmN0aW9uIiksIFdURk1vdmUocGFyYW1ldGVycyksIFt0aGlzLCBwcm90ZWN0 ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21w bGV0aW9uSGFuZGxlcildKFNlc3Npb25Ib3N0OjpDb21tYW5kUmVzcG9uc2UmJiByZXNwb25zZSkg eworICAgICAgICAgICAgaWYgKHJlc3BvbnNlLmlzRXJyb3IgfHwgIXJlc3BvbnNlLnJlc3BvbnNl T2JqZWN0KSB7CisgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3Vs dDo6ZmFpbChXVEZNb3ZlKHJlc3BvbnNlLnJlc3BvbnNlT2JqZWN0KSkpOworICAgICAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIFN0cmluZyB2YWx1ZVN0cmlu ZzsKKyAgICAgICAgICAgIGlmICghcmVzcG9uc2UucmVzcG9uc2VPYmplY3QtPmdldFN0cmluZyhB U0NJSUxpdGVyYWwoInJlc3VsdCIpLCB2YWx1ZVN0cmluZykpIHsKKyAgICAgICAgICAgICAgICBj b21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVycm9y Q29kZTo6VW5rbm93bkVycm9yKSk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAg ICAgfQorICAgICAgICAgICAgUmVmUHRyPEpTT046OlZhbHVlPiByZXN1bHRWYWx1ZTsKKyAgICAg ICAgICAgIGlmICghSlNPTjo6VmFsdWU6OnBhcnNlSlNPTih2YWx1ZVN0cmluZywgcmVzdWx0VmFs dWUpKSB7CisgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3VsdDo6 ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6OlVua25vd25FcnJvcikpOworICAgICAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGNvbXBsZXRpb25IYW5k bGVyKENvbW1hbmRSZXN1bHQ6OnN1Y2Nlc3MoV1RGTW92ZShyZXN1bHRWYWx1ZSkpKTsKKyAgICAg ICAgfSk7CisgICAgfSk7Cit9CisKIHZvaWQgU2Vzc2lvbjo6d2FpdEZvck5hdmlnYXRpb25Ub0Nv bXBsZXRlKEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYgY29tcGxldGlvbkhhbmRs ZXIpCiB7CiAgICAgaWYgKCFtX3RvcGxldmVsQnJvd3NpbmdDb250ZXh0KSB7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uaCBiL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5o CmluZGV4IGFjNmU3NDE4MjIwLi4zMDA2ZDZiYzc0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRy aXZlci9TZXNzaW9uLmgKKysrIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmgKQEAgLTg2LDEy ICs4NiwxMyBAQCBwdWJsaWM6CiAgICAgdm9pZCBmaW5kRWxlbWVudHMoY29uc3QgU3RyaW5nJiBz dHJhdGVneSwgY29uc3QgU3RyaW5nJiBzZWxlY3RvciwgRmluZEVsZW1lbnRzTW9kZSwgY29uc3Qg U3RyaW5nJiByb290RWxlbWVudElELCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiYm KTsKICAgICB2b2lkIGdldEFjdGl2ZUVsZW1lbnQoRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3Vs dCYmKT4mJik7CiAgICAgdm9pZCBpc0VsZW1lbnRTZWxlY3RlZChjb25zdCBTdHJpbmcmIGVsZW1l bnRJRCwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7CisgICAgdm9pZCBnZXRF bGVtZW50QXR0cmlidXRlKGNvbnN0IFN0cmluZyYgZWxlbWVudElELCBjb25zdCBTdHJpbmcmIGF0 dHJpYnV0ZSwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7CisgICAgdm9pZCBn ZXRFbGVtZW50UHJvcGVydHkoY29uc3QgU3RyaW5nJiBlbGVtZW50SUQsIGNvbnN0IFN0cmluZyYg YXR0cmlidXRlLCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiYmKTsKICAgICB2b2lk IGdldEVsZW1lbnRUZXh0KGNvbnN0IFN0cmluZyYgZWxlbWVudElELCBGdW5jdGlvbjx2b2lkIChD b21tYW5kUmVzdWx0JiYpPiYmKTsKICAgICB2b2lkIGdldEVsZW1lbnRUYWdOYW1lKGNvbnN0IFN0 cmluZyYgZWxlbWVudElELCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiYmKTsKICAg ICB2b2lkIGdldEVsZW1lbnRSZWN0KGNvbnN0IFN0cmluZyYgZWxlbWVudElELCBGdW5jdGlvbjx2 b2lkIChDb21tYW5kUmVzdWx0JiYpPiYmKTsKICAgICB2b2lkIGlzRWxlbWVudEVuYWJsZWQoY29u c3QgU3RyaW5nJiBlbGVtZW50SUQsIEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYp OwogICAgIHZvaWQgaXNFbGVtZW50RGlzcGxheWVkKGNvbnN0IFN0cmluZyYgZWxlbWVudElELCBG dW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiYmKTsKLSAgICB2b2lkIGdldEVsZW1lbnRB dHRyaWJ1dGUoY29uc3QgU3RyaW5nJiBlbGVtZW50SUQsIGNvbnN0IFN0cmluZyYgYXR0cmlidXRl LCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiYmKTsKICAgICB2b2lkIGVsZW1lbnRD bGljayhjb25zdCBTdHJpbmcmIGVsZW1lbnRJRCwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3Vs dCYmKT4mJik7CiAgICAgdm9pZCBlbGVtZW50Q2xlYXIoY29uc3QgU3RyaW5nJiBlbGVtZW50SUQs IEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYpOwogICAgIHZvaWQgZWxlbWVudFNl bmRLZXlzKGNvbnN0IFN0cmluZyYgZWxlbWVudElELCBWZWN0b3I8U3RyaW5nPiYmIGtleXMsIEZ1 bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcCBiL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVy U2VydmljZS5jcHAKaW5kZXggYjYzNWRlZDQ0MDcuLjEyMjE1ODQ5MGVmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJEcml2 ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAKQEAgLTEyNyw2ICsxMjcsNyBAQCBjb25zdCBXZWJEcml2 ZXJTZXJ2aWNlOjpDb21tYW5kIFdlYkRyaXZlclNlcnZpY2U6OnNfY29tbWFuZHNbXSA9IHsKIAog ICAgIHsgSFRUUE1ldGhvZDo6R2V0LCAiL3Nlc3Npb24vJHNlc3Npb25JZC9lbGVtZW50LyRlbGVt ZW50SWQvc2VsZWN0ZWQiLCAmV2ViRHJpdmVyU2VydmljZTo6aXNFbGVtZW50U2VsZWN0ZWQgfSwK ICAgICB7IEhUVFBNZXRob2Q6OkdldCwgIi9zZXNzaW9uLyRzZXNzaW9uSWQvZWxlbWVudC8kZWxl bWVudElkL2F0dHJpYnV0ZS8kbmFtZSIsICZXZWJEcml2ZXJTZXJ2aWNlOjpnZXRFbGVtZW50QXR0 cmlidXRlIH0sCisgICAgeyBIVFRQTWV0aG9kOjpHZXQsICIvc2Vzc2lvbi8kc2Vzc2lvbklkL2Vs ZW1lbnQvJGVsZW1lbnRJZC9wcm9wZXJ0eS8kbmFtZSIsICZXZWJEcml2ZXJTZXJ2aWNlOjpnZXRF bGVtZW50UHJvcGVydHkgfSwKICAgICB7IEhUVFBNZXRob2Q6OkdldCwgIi9zZXNzaW9uLyRzZXNz aW9uSWQvZWxlbWVudC8kZWxlbWVudElkL3RleHQiLCAmV2ViRHJpdmVyU2VydmljZTo6Z2V0RWxl bWVudFRleHQgfSwKICAgICB7IEhUVFBNZXRob2Q6OkdldCwgIi9zZXNzaW9uLyRzZXNzaW9uSWQv ZWxlbWVudC8kZWxlbWVudElkL25hbWUiLCAmV2ViRHJpdmVyU2VydmljZTo6Z2V0RWxlbWVudFRh Z05hbWUgfSwKICAgICB7IEhUVFBNZXRob2Q6OkdldCwgIi9zZXNzaW9uLyRzZXNzaW9uSWQvZWxl bWVudC8kZWxlbWVudElkL3JlY3QiLCAmV2ViRHJpdmVyU2VydmljZTo6Z2V0RWxlbWVudFJlY3Qg fSwKQEAgLTExMzMsNiArMTEzNCwyNiBAQCB2b2lkIFdlYkRyaXZlclNlcnZpY2U6OmdldEVsZW1l bnRBdHRyaWJ1dGUoUmVmUHRyPEpTT046Ok9iamVjdD4mJiBwYXJhbWV0ZXJzLCBGdQogICAgIG1f c2Vzc2lvbi0+Z2V0RWxlbWVudEF0dHJpYnV0ZShlbGVtZW50SUQudmFsdWUoKSwgYXR0cmlidXRl LCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiB9CiAKK3ZvaWQgV2ViRHJpdmVyU2Vydmlj ZTo6Z2V0RWxlbWVudFByb3BlcnR5KFJlZlB0cjxKU09OOjpPYmplY3Q+JiYgcGFyYW1ldGVycywg RnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKK3sK KyAgICAvLyDCpzEzLjMgR2V0IEVsZW1lbnQgUHJvcGVydHkKKyAgICAvLyBodHRwczovL3czYy5n aXRodWIuaW8vd2ViZHJpdmVyL3dlYmRyaXZlci1zcGVjLmh0bWwjZ2V0LWVsZW1lbnQtcHJvcGVy dHkKKyAgICBpZiAoIWZpbmRTZXNzaW9uT3JDb21wbGV0ZVdpdGhFcnJvcigqcGFyYW1ldGVycywg Y29tcGxldGlvbkhhbmRsZXIpKQorICAgICAgICByZXR1cm47CisKKyAgICBhdXRvIGVsZW1lbnRJ RCA9IGZpbmRFbGVtZW50T3JDb21wbGV0ZVdpdGhFcnJvcigqcGFyYW1ldGVycywgY29tcGxldGlv bkhhbmRsZXIpOworICAgIGlmICghZWxlbWVudElEKQorICAgICAgICByZXR1cm47CisKKyAgICBT dHJpbmcgYXR0cmlidXRlOworICAgIGlmICghcGFyYW1ldGVycy0+Z2V0U3RyaW5nKEFTQ0lJTGl0 ZXJhbCgibmFtZSIpLCBhdHRyaWJ1dGUpKSB7CisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKENv bW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJlc3VsdDo6RXJyb3JDb2RlOjpJbnZhbGlkQXJndW1l bnQpKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIG1fc2Vzc2lvbi0+Z2V0RWxlbWVu dFByb3BlcnR5KGVsZW1lbnRJRC52YWx1ZSgpLCBhdHRyaWJ1dGUsIFdURk1vdmUoY29tcGxldGlv bkhhbmRsZXIpKTsKK30KKwogdm9pZCBXZWJEcml2ZXJTZXJ2aWNlOjpnZXRFbGVtZW50VGV4dChS ZWZQdHI8SlNPTjo6T2JqZWN0PiYmIHBhcmFtZXRlcnMsIEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRS ZXN1bHQmJik+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7CiAgICAgLy8gwqcxMy41IEdldCBFbGVt ZW50IFRleHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2Uu aCBiL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5oCmluZGV4IGMzZDA4MTJjMWIw Li5lODQyMTcyNmYyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2 aWNlLmgKKysrIGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmgKQEAgLTg0LDEy ICs4NCwxMyBAQCBwcml2YXRlOgogICAgIHZvaWQgZmluZEVsZW1lbnRzRnJvbUVsZW1lbnQoUmVm UHRyPEpTT046Ok9iamVjdD4mJiwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7 CiAgICAgdm9pZCBnZXRBY3RpdmVFbGVtZW50KFJlZlB0cjxKU09OOjpPYmplY3Q+JiYsIEZ1bmN0 aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYpOwogICAgIHZvaWQgaXNFbGVtZW50U2VsZWN0 ZWQoUmVmUHRyPEpTT046Ok9iamVjdD4mJiwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYm KT4mJik7CisgICAgdm9pZCBnZXRFbGVtZW50QXR0cmlidXRlKFJlZlB0cjxKU09OOjpPYmplY3Q+ JiYsIEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYpOworICAgIHZvaWQgZ2V0RWxl bWVudFByb3BlcnR5KFJlZlB0cjxKU09OOjpPYmplY3Q+JiYsIEZ1bmN0aW9uPHZvaWQgKENvbW1h bmRSZXN1bHQmJik+JiYpOwogICAgIHZvaWQgZ2V0RWxlbWVudFRleHQoUmVmUHRyPEpTT046Ok9i amVjdD4mJiwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7CiAgICAgdm9pZCBn ZXRFbGVtZW50VGFnTmFtZShSZWZQdHI8SlNPTjo6T2JqZWN0PiYmLCBGdW5jdGlvbjx2b2lkIChD b21tYW5kUmVzdWx0JiYpPiYmKTsKICAgICB2b2lkIGdldEVsZW1lbnRSZWN0KFJlZlB0cjxKU09O OjpPYmplY3Q+JiYsIEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYpOwogICAgIHZv aWQgaXNFbGVtZW50RW5hYmxlZChSZWZQdHI8SlNPTjo6T2JqZWN0PiYmLCBGdW5jdGlvbjx2b2lk IChDb21tYW5kUmVzdWx0JiYpPiYmKTsKICAgICB2b2lkIGlzRWxlbWVudERpc3BsYXllZChSZWZQ dHI8SlNPTjo6T2JqZWN0PiYmLCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiYmKTsK LSAgICB2b2lkIGdldEVsZW1lbnRBdHRyaWJ1dGUoUmVmUHRyPEpTT046Ok9iamVjdD4mJiwgRnVu Y3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7CiAgICAgdm9pZCBlbGVtZW50Q2xpY2so UmVmUHRyPEpTT046Ok9iamVjdD4mJiwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4m Jik7CiAgICAgdm9pZCBlbGVtZW50Q2xlYXIoUmVmUHRyPEpTT046Ok9iamVjdD4mJiwgRnVuY3Rp b248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7CiAgICAgdm9pZCBlbGVtZW50U2VuZEtleXMo UmVmUHRyPEpTT046Ok9iamVjdD4mJiwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4m Jik7Cg==