180227 2017-11-30 16:30:14 -0800 Many imported/w3c/web-platform-tests/service-workers/ test are failing together intermittently 2017-12-01 18:27:53 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 youennf ap beidson cdumez commit-queue ggaren mark.lam ryanhaddad webkit-bug-importer youennf oldest_to_newest 1376628 0 jlewis3 2017-11-30 16:30:14 -0800 Many imported/w3c/web-platform-tests/service-workers/ test are failing together intermittently on High Sierra. About 80 service worker test failed together and do so intermittently. I haven't been able to find a regression point. Example build: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r225336%20(1049)/results.html https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/1049 Example test: imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall.https.html Diff: --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall.https-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall.https-actual.txt @@ -1,4 +1,5 @@ +Harness Error (TIMEOUT), message = null -FAIL Test Clients.matchAll() assert_unreached: unexpected rejection: Passing MessagePort objects to postMessage is not yet supported Reached unreachable code +TIMEOUT Test Clients.matchAll() Test timed out The diffs on most of the test all have a Harness Error (TIMEOUT) 1376630 1 cdumez 2017-11-30 16:33:28 -0800 Service Worker process crash: Thread 7 Crashed:: WebCore: Worker 0 com.apple.JavaScriptCore 0x000000016f553744 WTFCrash + 36 (Assertions.cpp:273) 1 com.apple.WebCore 0x00000001603683c8 JSC::ExceptionScope::assertNoException() + 152 2 com.apple.WebCore 0x000000016180e5cb WebCore::callFunction(JSC::ExecState&, JSC::JSValue, JSC::JSValue, JSC::ArgList const&) + 283 (JSDOMPromise.cpp:48) 3 com.apple.WebCore 0x000000016180e3f5 WebCore::DOMPromise::whenSettled(std::__1::function<void ()>&&) + 709 (JSDOMPromise.cpp:69) 4 com.apple.WebCore 0x0000000163195dc8 WebCore::ExtendableEvent::addExtendLifetimePromise(WTF::Ref<WebCore::DOMPromise>&&) + 136 (ExtendableEvent.cpp:65) 5 com.apple.WebCore 0x0000000163195d13 WebCore::ExtendableEvent::waitUntil(WTF::Ref<WebCore::DOMPromise>&&) + 275 (ExtendableEvent.cpp:59) 6 com.apple.WebCore 0x00000001607d0d32 WebCore::jsExtendableEventPrototypeFunctionWaitUntilBody(JSC::ExecState*, WebCore::JSExtendableEvent*, JSC::ThrowScope&) + 322 (JSExtendableEvent.cpp:198) 7 com.apple.WebCore 0x00000001607c3f4e long long WebCore::IDLOperation<WebCore::JSExtendableEvent>::call<&(WebCore::jsExtendableEventPrototypeFunctionWaitUntilBody(JSC::ExecState*, WebCore::JSExtendableEvent*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::ExecState&, char const*) + 606 (JSDOMOperation.h:53) 8 com.apple.WebCore 0x00000001607c3cdc WebCore::jsExtendableEventPrototypeFunctionWaitUntil(JSC::ExecState*) + 28 (JSExtendableEvent.cpp:204) 9 ??? 0x00002173dc4012a8 0 + 36781500142248 10 com.apple.JavaScriptCore 0x000000016e0f8f4e llint_entry + 31992 11 com.apple.JavaScriptCore 0x000000016e0f1037 vmEntryToJavaScript + 343 12 com.apple.JavaScriptCore 0x000000016ee2309e JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) + 350 (JITCode.cpp:81) 13 com.apple.JavaScriptCore 0x000000016edca675 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 1269 (Interpreter.cpp:999) 14 com.apple.JavaScriptCore 0x000000016f020fda JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 202 (CallData.cpp:41) 15 com.apple.JavaScriptCore 0x000000016f0210b9 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) + 201 (CallData.cpp:48) 16 com.apple.JavaScriptCore 0x000000016f02135d JSC::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) + 125 (CallData.cpp:67) 17 com.apple.WebCore 0x0000000161827d0c WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext&, WebCore::Event&) + 2012 (JSEventListener.cpp:154) 18 com.apple.WebCore 0x0000000161d778f2 WebCore::EventTarget::fireEventListeners(WebCore::Event&, WTF::Vector<WTF::RefPtr<WebCore::RegisteredEventListener>, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>) + 962 (EventTarget.cpp:287) 19 com.apple.WebCore 0x0000000161d6f3ca WebCore::EventTarget::fireEventListeners(WebCore::Event&) + 314 (EventTarget.cpp:228) 20 com.apple.WebCore 0x0000000161d774a9 WebCore::EventTarget::dispatchEvent(WebCore::Event&) + 233 (EventTarget.cpp:188) 21 com.apple.WebCore 0x00000001631c6d83 WebCore::ServiceWorkerThread::fireInstallEvent()::$_8::operator()(WebCore::ScriptExecutionContext&) + 115 (ServiceWorkerThread.cpp:127) 22 com.apple.WebCore 0x00000001631c6c94 WTF::Function<void (WebCore::ScriptExecutionContext&)>::CallableWrapper<WebCore::ServiceWorkerThread::fireInstallEvent()::$_8>::call(WebCore::ScriptExecutionContext&) + 52 (Function.h:101) 23 com.apple.WebCore 0x00000001616f79de WTF::Function<void (WebCore::ScriptExecutionContext&)>::operator()(WebCore::ScriptExecutionContext&) const + 158 (Function.h:56) 24 com.apple.WebCore 0x00000001616e518d WebCore::ScriptExecutionContext::Task::performTask(WebCore::ScriptExecutionContext&) + 29 (ScriptExecutionContext.h:184) 25 com.apple.WebCore 0x0000000163184c90 WebCore::WorkerRunLoop::Task::performTask(WebCore::WorkerGlobalScope*) + 128 (WorkerRunLoop.cpp:259) 26 com.apple.WebCore 0x0000000163183cc7 WebCore::WorkerRunLoop::runInMode(WebCore::WorkerGlobalScope*, WebCore::ModePredicate const&, WebCore::WorkerRunLoop::WaitMode) + 1399 (WorkerRunLoop.cpp:203) 27 com.apple.WebCore 0x00000001631836b6 WebCore::WorkerRunLoop::run(WebCore::WorkerGlobalScope*) + 86 (WorkerRunLoop.cpp:138) 28 com.apple.WebCore 0x0000000163187e63 WebCore::WorkerThread::runEventLoop() + 51 (WorkerThread.cpp:258) 29 com.apple.WebCore 0x00000001631bc2e5 WebCore::ServiceWorkerThread::runEventLoop() + 21 (ServiceWorkerThread.cpp:95) 30 com.apple.WebCore 0x0000000163187a97 WebCore::WorkerThread::workerThread() + 1719 (WorkerThread.cpp:201) 31 com.apple.WebCore 0x00000001631939a8 WebCore::WorkerThread::start(WTF::Function<void (WTF::String const&)>&&)::$_12::operator()() const + 24 (WorkerThread.cpp:145) 32 com.apple.WebCore 0x0000000163193969 WTF::Function<void ()>::CallableWrapper<WebCore::WorkerThread::start(WTF::Function<void (WTF::String const&)>&&)::$_12>::call() + 25 (Function.h:101) 33 com.apple.JavaScriptCore 0x000000016f58cc0b WTF::Function<void ()>::operator()() const + 139 (Function.h:56) 34 com.apple.JavaScriptCore 0x000000016f5d907f WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 351 (Threading.cpp:129) 35 com.apple.JavaScriptCore 0x000000016f5de755 WTF::wtfThreadEntryPoint(void*) + 21 (ThreadingPthreads.cpp:223) 36 libsystem_pthread.dylib 0x00007fff5875d6c1 _pthread_body + 340 37 libsystem_pthread.dylib 0x00007fff5875d56d _pthread_start + 377 38 libsystem_pthread.dylib 0x00007fff5875cc5d thread_start + 13 1376632 2 cdumez 2017-11-30 16:36:29 -0800 Youenn says he's seen it before and will look into it 1376656 3 328059 youennf 2017-11-30 16:57:52 -0800 Created attachment 328059 Patch 1376697 4 youennf 2017-11-30 20:32:46 -0800 I was not able to reproduce locally the crash so cannot fully validate that this patch fixes the issue. That said, given the stack trace, the patch makes sense to me. Mark, could you review it? That said, we should really enable the storage process to restart a crashing service worker process. 1376909 5 328059 ggaren 2017-12-01 10:44:41 -0800 Comment on attachment 328059 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328059&action=review > Source/WebCore/bindings/js/JSDOMPromise.cpp:73 > + EXCEPTION_ASSERT_UNUSED(scope, !scope.exception() || isTerminatedExecutionException(vm, scope.exception())); If you're asserting that the only possible exception is termination, I think you need to update callFunction to do the same. It currently asserts no exception. 1376925 6 328059 ap 2017-12-01 11:09:24 -0800 Comment on attachment 328059 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328059&action=review > Source/WebCore/ChangeLog:8 > + No observable change. I hoped for better :) 1376926 7 ap 2017-12-01 11:10:02 -0800 > +TIMEOUT Test Clients.matchAll() Test timed out Is it a tools bug that crashes are reported as timeouts? 1376935 8 youennf 2017-12-01 11:22:34 -0800 (In reply to Geoffrey Garen from comment #5) > Comment on attachment 328059 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328059&action=review > > > Source/WebCore/bindings/js/JSDOMPromise.cpp:73 > > + EXCEPTION_ASSERT_UNUSED(scope, !scope.exception() || isTerminatedExecutionException(vm, scope.exception())); > > If you're asserting that the only possible exception is termination, I think > you need to update callFunction to do the same. It currently asserts no > exception. Oh right, it should moved there. > > Source/WebCore/ChangeLog:8 > > + No observable change. > > I hoped for better :) It is difficult to write a test there since we would need to exercise that code path in a worker at the time it gets terminated. (In reply to Alexey Proskuryakov from comment #7) > > +TIMEOUT Test Clients.matchAll() Test timed out > > Is it a tools bug that crashes are reported as timeouts? Service Worker process is crashing in debug mode due to that assertion. Web process running the actual test will then time out, potentially for one of these reasons: - some promises might never get rejected (we should fix that if that is the case) - some further service worker operations will time out since we no longer have a service worker process (we should fix that as well if that is the case) - some tests are not handling efficiently all rejections/error cases and could fail early but instead, wait to hit the JS setTimeout to end themselves. Also, if we were to restart the service worker process when crashing, we would get one test timing out, and not 80 tests. 1376938 9 328126 youennf 2017-12-01 11:27:03 -0800 Created attachment 328126 Patch 1376945 10 328128 youennf 2017-12-01 11:38:52 -0800 Created attachment 328128 Patch 1376947 11 328128 mark.lam 2017-12-01 11:44:28 -0800 Comment on attachment 328128 Patch r=me 1376974 12 328128 commit-queue 2017-12-01 12:36:53 -0800 Comment on attachment 328128 Patch Clearing flags on attachment: 328128 Committed r225406: <https://trac.webkit.org/changeset/225406> 1376975 13 commit-queue 2017-12-01 12:36:55 -0800 All reviewed patches have been landed. Closing bug. 1376977 14 webkit-bug-importer 2017-12-01 12:37:20 -0800 <rdar://problem/35802951> 1377111 15 ryanhaddad 2017-12-01 15:47:58 -0800 Still seeing 70+ service worker tests fail together after this change: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r225406%20(6094)/results.html https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r225406%20(6353)/results.html https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r225407%20(6354)/results.html 1377115 16 youennf 2017-12-01 15:51:56 -0800 (In reply to Ryan Haddad from comment #15) > Still seeing 70+ service worker tests fail together after this change: > > https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/ > r225406%20(6094)/results.html > https://build.webkit.org/results/ > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r225406%20(6353)/results.html > https://build.webkit.org/results/ > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r225407%20(6354)/results.html This is another crash that needs to be fixed at worker cache storage connection level. I'll upload a patch for it today or Monday. 1377210 17 youennf 2017-12-01 18:27:53 -0800 (In reply to youenn fablet from comment #16) > (In reply to Ryan Haddad from comment #15) > > Still seeing 70+ service worker tests fail together after this change: > > > > https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/ > > r225406%20(6094)/results.html > > https://build.webkit.org/results/ > > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r225406%20(6353)/results.html > > https://build.webkit.org/results/ > > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r225407%20(6354)/results.html > > This is another crash that needs to be fixed at worker cache storage > connection level. > I'll upload a patch for it today or Monday. Filed https://bugs.webkit.org/show_bug.cgi?id=180227 328059 2017-11-30 16:57:52 -0800 2017-12-01 11:27:02 -0800 Patch bug-180227-20171130165751.patch text/plain 1865 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE5MWM2MTk0MGVjNzZh ZTVhMWIxYzI2ZTAyMmFlYjViOTNiOTVlYy4uMjNkYmMxZWU0MTk3OWJjNTEzZDQxMWQ2MzVlMmVk OTRhYzFjM2MyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTExLTMwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYW55IGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzLyB0ZXN0IGFyZSBmYWlsaW5nIHRv Z2V0aGVyIGludGVybWl0dGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODAyMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBvYnNlcnZhYmxlIGNoYW5nZS4KKworICAgICAgICAqIGJpbmRpbmdz L2pzL0pTRE9NUHJvbWlzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01Qcm9taXNlOjp3aGVu U2V0dGxlZCk6IEFkZGluZyBjaGVja2luZyBvZiBzY29wZSBpbiBjYXNlIG9mIHdvcmtlcnMuCisK IDIwMTctMTEtMzAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgSW1wcm92ZSBmaWx0ZXIgbG9nZ2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNET01Qcm9taXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTRE9NUHJvbWlzZS5jcHAKaW5kZXggMDgwZTUzOTYwMmUwNGNkOTE3YmU3MDFkMWFhOTg5Nzk2 ZDcyMGVmZi4uMjExYTk2NWEwNzZhZWM0ZDM1NTE3MGZlZjY0MmFiZDY0OGZmZGJlNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Qcm9taXNlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVByb21pc2UuY3BwCkBAIC01Myw2ICs1Myw4 IEBAIHZvaWQgRE9NUHJvbWlzZTo6d2hlblNldHRsZWQoc3RkOjpmdW5jdGlvbjx2b2lkKCk+JiYg Y2FsbGJhY2spCiB7CiAgICAgYXV0byYgc3RhdGUgPSAqZ2xvYmFsT2JqZWN0KCktPmdsb2JhbEV4 ZWMoKTsKICAgICBhdXRvJiB2bSA9IHN0YXRlLnZtKCk7CisgICAgYXV0byBzY29wZSA9IERFQ0xB UkVfVEhST1dfU0NPUEUodm0pOworCiAgICAgYXV0byogaGFuZGxlciA9IEpTQzo6SlNOYXRpdmVT dGRGdW5jdGlvbjo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3QoKSwgMSwgU3RyaW5nIHsgfSwgW2Nh bGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldIChFeGVjU3RhdGUqKSBtdXRhYmxlIHsKICAgICAg ICAgY2FsbGJhY2soKTsKICAgICAgICAgcmV0dXJuIEpTQzo6SlNWYWx1ZTo6ZW5jb2RlKEpTQzo6 anNVbmRlZmluZWQoKSk7CkBAIC02Nyw2ICs2OSw4IEBAIHZvaWQgRE9NUHJvbWlzZTo6d2hlblNl dHRsZWQoc3RkOjpmdW5jdGlvbjx2b2lkKCk+JiYgY2FsbGJhY2spCiAgICAgYXJndW1lbnRzLmFw cGVuZChoYW5kbGVyKTsKICAgICBhcmd1bWVudHMuYXBwZW5kKGhhbmRsZXIpOwogICAgIGNhbGxG dW5jdGlvbihzdGF0ZSwgdGhlbkZ1bmN0aW9uLCBwcm9taXNlLCBhcmd1bWVudHMpOworCisgICAg RVhDRVBUSU9OX0FTU0VSVF9VTlVTRUQoc2NvcGUsICFzY29wZS5leGNlcHRpb24oKSB8fCBpc1Rl cm1pbmF0ZWRFeGVjdXRpb25FeGNlcHRpb24odm0sIHNjb3BlLmV4Y2VwdGlvbigpKSk7CiB9CiAK IEpTQzo6SlNWYWx1ZSBET01Qcm9taXNlOjpyZXN1bHQoKSBjb25zdAo= 328126 2017-12-01 11:27:03 -0800 2017-12-01 11:38:50 -0800 Patch bug-180227-20171201112702.patch text/plain 1733 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWFiNDU5ZTdlZThlYjEy M2UzMjI0MGQyYjQ5ZTU3YzNjMjE1ZDgzOC4uZjk4NWQ0ZTZlNzdhNmFlNjI1MTY2YzY5NDcwMDFk ZTBkOTJhYTMxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTAxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYW55IGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzLyB0ZXN0IGFyZSBmYWlsaW5nIHRv Z2V0aGVyIGludGVybWl0dGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODAyMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBvYnNlcnZhYmxlIGNoYW5nZS4KKworICAgICAgICAqIGJpbmRpbmdz L2pzL0pTRE9NUHJvbWlzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjYWxsRnVuY3Rpb24pOgor CiAyMDE3LTExLTMwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAg ICBJbXBsZW1lbnQgaHR0cHM6Ly93M2MuZ2l0aHViLmlvL1NlcnZpY2VXb3JrZXIvI2NsaWVudHMt Z2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVByb21pc2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Qcm9taXNlLmNwcAppbmRleCAw ODBlNTM5NjAyZTA0Y2Q5MTdiZTcwMWQxYWE5ODk3OTZkNzIwZWZmLi41MDU4ZDQzY2FhNTdlYWE3 ZDMwYjU0Y2RlMjUwYmJhZmZlOWRiNDAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTVByb21pc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTRE9NUHJvbWlzZS5jcHAKQEAgLTQwLDEyICs0MCwxNCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIHN0YXRpYyBpbmxpbmUgSlNDOjpKU1ZhbHVlIGNhbGxGdW5jdGlvbihKU0M6OkV4ZWNTdGF0 ZSYgc3RhdGUsIEpTQzo6SlNWYWx1ZSBqc0Z1bmN0aW9uLCBKU0M6OkpTVmFsdWUgdGhpc1ZhbHVl LCBjb25zdCBKU0M6OkFyZ0xpc3QmIGFyZ3VtZW50cykKIHsKLSAgICBhdXRvIHNjb3BlID0gREVD TEFSRV9DQVRDSF9TQ09QRShzdGF0ZS52bSgpKTsKKyAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9U SFJPV19TQ09QRShzdGF0ZS52bSgpKTsKICAgICBKU0M6OkNhbGxEYXRhIGNhbGxEYXRhOwogICAg IGF1dG8gY2FsbFR5cGUgPSBKU0M6OmdldENhbGxEYXRhKGpzRnVuY3Rpb24sIGNhbGxEYXRhKTsK ICAgICBBU1NFUlQoY2FsbFR5cGUgIT0gSlNDOjpDYWxsVHlwZTo6Tm9uZSk7CiAgICAgYXV0byBy ZXN1bHQgPSBjYWxsKCZzdGF0ZSwganNGdW5jdGlvbiwgY2FsbFR5cGUsIGNhbGxEYXRhLCB0aGlz VmFsdWUsIGFyZ3VtZW50cyk7Ci0gICAgc2NvcGUuYXNzZXJ0Tm9FeGNlcHRpb24oKTsKKworICAg IEVYQ0VQVElPTl9BU1NFUlRfVU5VU0VEKHNjb3BlLCAhc2NvcGUuZXhjZXB0aW9uKCkgfHwgaXNU ZXJtaW5hdGVkRXhlY3V0aW9uRXhjZXB0aW9uKHZtLCBzY29wZS5leGNlcHRpb24oKSkpOworCiAg ICAgcmV0dXJuIHJlc3VsdDsKIH0KIAo= 328128 2017-12-01 11:38:52 -0800 2017-12-01 12:36:53 -0800 Patch bug-180227-20171201113851.patch text/plain 1741 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWFiNDU5ZTdlZThlYjEy M2UzMjI0MGQyYjQ5ZTU3YzNjMjE1ZDgzOC4uZjk4NWQ0ZTZlNzdhNmFlNjI1MTY2YzY5NDcwMDFk ZTBkOTJhYTMxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTAxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYW55IGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzLyB0ZXN0IGFyZSBmYWlsaW5nIHRv Z2V0aGVyIGludGVybWl0dGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODAyMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBvYnNlcnZhYmxlIGNoYW5nZS4KKworICAgICAgICAqIGJpbmRpbmdz L2pzL0pTRE9NUHJvbWlzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjYWxsRnVuY3Rpb24pOgor CiAyMDE3LTExLTMwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAg ICBJbXBsZW1lbnQgaHR0cHM6Ly93M2MuZ2l0aHViLmlvL1NlcnZpY2VXb3JrZXIvI2NsaWVudHMt Z2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVByb21pc2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Qcm9taXNlLmNwcAppbmRleCAw ODBlNTM5NjAyZTA0Y2Q5MTdiZTcwMWQxYWE5ODk3OTZkNzIwZWZmLi40NjhjZmNhYzY0Nzc4NWVl NjAyNjY4ZmNmOTRmZTFhMWY1OGY0NzJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTVByb21pc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTRE9NUHJvbWlzZS5jcHAKQEAgLTQwLDEyICs0MCwxNCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIHN0YXRpYyBpbmxpbmUgSlNDOjpKU1ZhbHVlIGNhbGxGdW5jdGlvbihKU0M6OkV4ZWNTdGF0 ZSYgc3RhdGUsIEpTQzo6SlNWYWx1ZSBqc0Z1bmN0aW9uLCBKU0M6OkpTVmFsdWUgdGhpc1ZhbHVl LCBjb25zdCBKU0M6OkFyZ0xpc3QmIGFyZ3VtZW50cykKIHsKLSAgICBhdXRvIHNjb3BlID0gREVD TEFSRV9DQVRDSF9TQ09QRShzdGF0ZS52bSgpKTsKKyAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9U SFJPV19TQ09QRShzdGF0ZS52bSgpKTsKICAgICBKU0M6OkNhbGxEYXRhIGNhbGxEYXRhOwogICAg IGF1dG8gY2FsbFR5cGUgPSBKU0M6OmdldENhbGxEYXRhKGpzRnVuY3Rpb24sIGNhbGxEYXRhKTsK ICAgICBBU1NFUlQoY2FsbFR5cGUgIT0gSlNDOjpDYWxsVHlwZTo6Tm9uZSk7CiAgICAgYXV0byBy ZXN1bHQgPSBjYWxsKCZzdGF0ZSwganNGdW5jdGlvbiwgY2FsbFR5cGUsIGNhbGxEYXRhLCB0aGlz VmFsdWUsIGFyZ3VtZW50cyk7Ci0gICAgc2NvcGUuYXNzZXJ0Tm9FeGNlcHRpb24oKTsKKworICAg IEVYQ0VQVElPTl9BU1NFUlRfVU5VU0VEKHNjb3BlLCAhc2NvcGUuZXhjZXB0aW9uKCkgfHwgaXNU ZXJtaW5hdGVkRXhlY3V0aW9uRXhjZXB0aW9uKHN0YXRlLnZtKCksIHNjb3BlLmV4Y2VwdGlvbigp KSk7CisKICAgICByZXR1cm4gcmVzdWx0OwogfQogCg==