180224 2017-11-30 16:10:53 -0800 [Cocoa] Fix CVPixelBuffer leak 2017-11-30 16:58:46 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck achristensen ap commit-queue dino joepeck webkit-bug-importer youennf oldest_to_newest 1376599 0 joepeck 2017-11-30 16:10:53 -0800 Fix CVPixelBuffer leak CVPixelBufferCreate returns a +1 instance in its out value. RealtimeIncomingVideoSourceCocoa doesn't appear to manage it correctly. 1376608 1 328049 joepeck 2017-11-30 16:14:43 -0800 Created attachment 328049 [PATCH] Proposed Fix 1376612 2 328049 youennf 2017-11-30 16:17:24 -0800 Comment on attachment 328049 [PATCH] Proposed Fix Thanks! 1376654 3 328049 commit-queue 2017-11-30 16:57:16 -0800 Comment on attachment 328049 [PATCH] Proposed Fix Clearing flags on attachment: 328049 Committed r225374: <https://trac.webkit.org/changeset/225374> 1376655 4 commit-queue 2017-11-30 16:57:18 -0800 All reviewed patches have been landed. Closing bug. 1376657 5 webkit-bug-importer 2017-11-30 16:58:46 -0800 <rdar://problem/35786854> 328049 2017-11-30 16:14:43 -0800 2017-11-30 16:57:16 -0800 [PATCH] Proposed Fix video-leak-1.patch text/plain 2452 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMjdmMDdlMjAyOC4uNGYyYTBkMzQyM2UgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0xMS0zMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFtDb2NvYV0gRml4IENWUGl4ZWxCdWZmZXIgbGVhaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMjI0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0 cmVhbS9tYWMvUmVhbHRpbWVJbmNvbWluZ1ZpZGVvU291cmNlQ29jb2EuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVhbHRpbWVJbmNvbWluZ1ZpZGVvU291cmNlQ29jb2E6OnBpeGVsQnVmZmVyRnJv bVZpZGVvRnJhbWUpOgorICAgICAgICBBZG9wdCB0aGUgbmV3bHkgY3JlYXRlZCBwaXhlbCBidWZm ZXIuCisKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lSW5jb21pbmdWaWRlb1NvdXJjZUNvY29h OjpPbkZyYW1lKToKKyAgICAgICAgUmVsZWFzZSB0aGUgZm9ybWF0IGRlc2NyaXB0aW9uIGFzIHNv b24gYXMgd2UgYXJlIGRvbmUgd2l0aCBpdC4gT3RoZXJ3aXNlCisgICAgICAgIHdlIGNvdWxkIGhh dmUgYmFpbGVkIGJlZm9yZSByZWxlYXNpbmcgaXQuCisKIDIwMTctMTEtMjkgIEFudG9pbmUgUXVp bnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBNZWRpYSBjb250cm9scyBz aG91bGQgc3RvcCB1cGRhdGluZyB3aGlsZSBtZWRpYSBpcyBwbGF5aW5nIGluIGZ1bGxzY3JlZW4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFs dGltZUluY29taW5nVmlkZW9Tb3VyY2VDb2NvYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVJbmNvbWluZ1ZpZGVvU291cmNlQ29jb2EuY3BwCmlu ZGV4IDZhNGIzZWIzODU1Li40Y2ZlMjNkYzgwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lSW5jb21pbmdWaWRlb1NvdXJjZUNvY29h LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRp bWVJbmNvbWluZ1ZpZGVvU291cmNlQ29jb2EuY3BwCkBAIC02NSw3ICs2NSw3IEBAIENWUGl4ZWxC dWZmZXJSZWYgUmVhbHRpbWVJbmNvbWluZ1ZpZGVvU291cmNlQ29jb2E6OnBpeGVsQnVmZmVyRnJv bVZpZGVvRnJhbWUoY29uCiAgICAgICAgICAgICBhdXRvIHN0YXR1cyA9IENWUGl4ZWxCdWZmZXJD cmVhdGUoa0NGQWxsb2NhdG9yRGVmYXVsdCwgZnJhbWUud2lkdGgoKSwgZnJhbWUuaGVpZ2h0KCks IGtDVlBpeGVsRm9ybWF0VHlwZV80MjBZcENiQ3I4UGxhbmFyLCBudWxscHRyLCAmcGl4ZWxCdWZm ZXIpOwogICAgICAgICAgICAgQVNTRVJUX1VOVVNFRChzdGF0dXMsIHN0YXR1cyA9PSBub0Vycik7 CiAKLSAgICAgICAgICAgIG1fYmxhY2tGcmFtZSA9IHBpeGVsQnVmZmVyOworICAgICAgICAgICAg bV9ibGFja0ZyYW1lID0gYWRvcHRDRihwaXhlbEJ1ZmZlcik7CiAgICAgICAgICAgICBtX2JsYWNr RnJhbWVXaWR0aCA9IGZyYW1lLndpZHRoKCk7CiAgICAgICAgICAgICBtX2JsYWNrRnJhbWVIZWln aHQgPSBmcmFtZS5oZWlnaHQoKTsKIApAQCAtMTE0LDExICsxMTQsMTEgQEAgdm9pZCBSZWFsdGlt ZUluY29taW5nVmlkZW9Tb3VyY2VDb2NvYTo6T25GcmFtZShjb25zdCB3ZWJydGM6OlZpZGVvRnJh bWUmIGZyYW1lKQogCiAgICAgQ01TYW1wbGVCdWZmZXJSZWYgc2FtcGxlQnVmZmVyOwogICAgIG9z dGF0dXMgPSBDTVNhbXBsZUJ1ZmZlckNyZWF0ZVJlYWR5V2l0aEltYWdlQnVmZmVyKGtDRkFsbG9j YXRvckRlZmF1bHQsIChDVkltYWdlQnVmZmVyUmVmKXBpeGVsQnVmZmVyLCBmb3JtYXREZXNjcmlw dGlvbiwgJnRpbWluZ0luZm8sICZzYW1wbGVCdWZmZXIpOwotICAgIGlmIChvc3RhdHVzICE9IG5v RXJyKSB7Ci0gICAgICAgIExPR19FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSB0aGUgc2FtcGxlIGJ1 ZmZlcjogJWQiLCBzdGF0aWNfY2FzdDxpbnQ+KG9zdGF0dXMpKTsKLSAgICAgICAgcmV0dXJuOwot ICAgIH0KICAgICBDRlJlbGVhc2UoZm9ybWF0RGVzY3JpcHRpb24pOworICAgIGlmIChvc3RhdHVz ICE9IG5vRXJyKSB7CisgICAgICAgIExPR19FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSB0aGUgc2Ft cGxlIGJ1ZmZlcjogJWQiLCBzdGF0aWNfY2FzdDxpbnQ+KG9zdGF0dXMpKTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KIAogICAgIGF1dG8gc2FtcGxlID0gYWRvcHRDRihzYW1wbGVCdWZmZXIpOwog Cg==