180221 2017-11-30 15:30:57 -0800 Fix some NSOperationQueue leaks 2017-11-30 16:20:54 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck ap commit-queue inspector-bugzilla-changes joepeck thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1376559 0 joepeck 2017-11-30 15:30:57 -0800 Fix some NSOperationQueue leaks There are some instances of [NSOperationQueue new] that aren't being released. These will be leaks. Caught by searching for general uses of " new]" in Source. 1376561 1 328041 joepeck 2017-11-30 15:31:44 -0800 Created attachment 328041 [PATCH] Proposed Fix 1376562 2 joepeck 2017-11-30 15:32:55 -0800 Err not Web Inspector... Let me fix ChangeLog. 1376565 3 328042 joepeck 2017-11-30 15:33:50 -0800 Created attachment 328042 [PATCH] Proposed Fix 1376582 4 328042 wenson_hsieh 2017-11-30 15:47:38 -0800 Comment on attachment 328042 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=328042&action=review > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3726 > + RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue new]); Nit - auto here? > Source/WebKitLegacy/mac/WebView/WebView.mm:6732 > + RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue new]); Ditto. 1376613 5 328042 commit-queue 2017-11-30 16:18:11 -0800 Comment on attachment 328042 [PATCH] Proposed Fix Clearing flags on attachment: 328042 Committed r225369: <https://trac.webkit.org/changeset/225369> 1376614 6 commit-queue 2017-11-30 16:18:13 -0800 All reviewed patches have been landed. Closing bug. 1376618 7 webkit-bug-importer 2017-11-30 16:20:54 -0800 <rdar://problem/35785793> 328041 2017-11-30 15:31:44 -0800 2017-11-30 15:33:50 -0800 [PATCH] Proposed Fix queue-leak-1.patch text/plain 3117 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYjAxMDdhNGI5MWMuLjkzMTAwZDE1NDcxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDE3LTExLTMwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IHNvbWUgTlNPcGVyYXRpb25RdWV1ZSBsZWFr cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMjIx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW06CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBs OjpwZXJmb3JtRHJhZ09wZXJhdGlvbik6CisKIDIwMTctMTEtMjkgIEFsZXggQ2hyaXN0ZW5zZW4g IDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNb2Rlcm5pemUgQVBJOjpTZXJp YWxpemVkU2NyaXB0VmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0Nv Y29hL1dlYlZpZXdJbXBsLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmll d0ltcGwubW0KaW5kZXggOGZiNDliYTZhNzcuLjJlZjBmMWE2NTE3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQpAQCAtMzcyMyw3ICszNzIzLDggQEAg Ym9vbCBXZWJWaWV3SW1wbDo6cGVyZm9ybURyYWdPcGVyYXRpb24oaWQgPE5TRHJhZ2dpbmdJbmZv PiBkcmFnZ2luZ0luZm8pCiAgICAgICAgICAgICBOU0ZpbGVQcm9taXNlUmVjZWl2ZXIgKml0ZW0g PSBkcmFnZ2luZ0l0ZW0uaXRlbTsKICAgICAgICAgICAgIE5TRGljdGlvbmFyeSAqb3B0aW9ucyA9 IEB7IH07CiAKLSAgICAgICAgICAgIFtpdGVtIHJlY2VpdmVQcm9taXNlZEZpbGVzQXREZXN0aW5h dGlvbjpkcm9wTG9jYXRpb24gb3B0aW9uczpvcHRpb25zIG9wZXJhdGlvblF1ZXVlOltOU09wZXJh dGlvblF1ZXVlIG5ld10gcmVhZGVyOl4oTlNVUkwgKiBfTm9ubnVsbCBmaWxlVVJMLCBOU0Vycm9y ICogX051bGxhYmxlIGVycm9yT3JOaWwpIHsKKyAgICAgICAgICAgIFJldGFpblB0cjxOU09wZXJh dGlvblF1ZXVlPiBxdWV1ZSA9IGFkb3B0TlMoW05TT3BlcmF0aW9uUXVldWUgbmV3XSk7CisgICAg ICAgICAgICBbaXRlbSByZWNlaXZlUHJvbWlzZWRGaWxlc0F0RGVzdGluYXRpb246ZHJvcExvY2F0 aW9uIG9wdGlvbnM6b3B0aW9ucyBvcGVyYXRpb25RdWV1ZTpxdWV1ZS5nZXQoKSByZWFkZXI6XihO U1VSTCAqIF9Ob25udWxsIGZpbGVVUkwsIE5TRXJyb3IgKiBfTnVsbGFibGUgZXJyb3JPck5pbCkg ewogICAgICAgICAgICAgICAgIGlmIChlcnJvck9yTmlsKQogICAgICAgICAgICAgICAgICAgICBy ZXR1cm47CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwppbmRleCA2NGFhZjY0Y2Q4Zi4uYTgy ZDFhZGYxNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxNy0xMS0zMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIFdlYiBJbnNwZWN0b3I6IEZpeCBzb21lIE5TT3BlcmF0aW9uUXVldWUgbGVha3MKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDIyMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy9XZWJW aWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IHBlcmZvcm1EcmFnT3BlcmF0aW9uOl0pOgorCiAy MDE3LTExLTI3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAg ICAgIE9uZSB0b28gbWFueSB6ZXJvZXMgaW4gbWFjT1MgdmVyc2lvbiBudW1iZXIgaW4gRmVhdHVy ZURlZmluZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2Vi Vmlldy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQppbmRl eCAwNjUzY2E4MmU1Yi4uMDQ0ZTllOGU5OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9X ZWJWaWV3L1dlYlZpZXcubW0KQEAgLTY3MjksNyArNjcyOSw4IEBAIC0gKEJPT0wpcGVyZm9ybURy YWdPcGVyYXRpb246KGlkIDxOU0RyYWdnaW5nSW5mbz4pZHJhZ2dpbmdJbmZvCiAgICAgICAgICAg ICBOU0ZpbGVQcm9taXNlUmVjZWl2ZXIgKml0ZW0gPSBkcmFnZ2luZ0l0ZW0uaXRlbTsKICAgICAg ICAgICAgIE5TRGljdGlvbmFyeSAqb3B0aW9ucyA9IEB7IH07CiAKLSAgICAgICAgICAgIFtpdGVt IHJlY2VpdmVQcm9taXNlZEZpbGVzQXREZXN0aW5hdGlvbjpkcm9wTG9jYXRpb24gb3B0aW9uczpv cHRpb25zIG9wZXJhdGlvblF1ZXVlOltOU09wZXJhdGlvblF1ZXVlIG5ld10gcmVhZGVyOl4oTlNV UkwgKiBfTm9ubnVsbCBmaWxlVVJMLCBOU0Vycm9yICogX051bGxhYmxlIGVycm9yT3JOaWwpIHsK KyAgICAgICAgICAgIFJldGFpblB0cjxOU09wZXJhdGlvblF1ZXVlPiBxdWV1ZSA9IGFkb3B0TlMo W05TT3BlcmF0aW9uUXVldWUgbmV3XSk7CisgICAgICAgICAgICBbaXRlbSByZWNlaXZlUHJvbWlz ZWRGaWxlc0F0RGVzdGluYXRpb246ZHJvcExvY2F0aW9uIG9wdGlvbnM6b3B0aW9ucyBvcGVyYXRp b25RdWV1ZTpxdWV1ZS5nZXQoKSByZWFkZXI6XihOU1VSTCAqIF9Ob25udWxsIGZpbGVVUkwsIE5T RXJyb3IgKiBfTnVsbGFibGUgZXJyb3JPck5pbCkgewogICAgICAgICAgICAgICAgIGlmIChlcnJv ck9yTmlsKQogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAK 328042 2017-11-30 15:33:50 -0800 2017-11-30 16:18:11 -0800 [PATCH] Proposed Fix leak-2.patch text/plain 3087 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYjAxMDdhNGI5MWMuLmFjMTc3NGE0N2U5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDE3LTExLTMwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgRml4IHNvbWUgTlNPcGVyYXRpb25RdWV1ZSBsZWFrcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMjIxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2Vi Vmlld0ltcGwubW06CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpwZXJmb3JtRHJhZ09w ZXJhdGlvbik6CisKIDIwMTctMTEtMjkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBNb2Rlcm5pemUgQVBJOjpTZXJpYWxpemVkU2NyaXB0VmFs dWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBs Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0KaW5kZXgg OGZiNDliYTZhNzcuLjJlZjBmMWE2NTE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9D b2NvYS9XZWJWaWV3SW1wbC5tbQpAQCAtMzcyMyw3ICszNzIzLDggQEAgYm9vbCBXZWJWaWV3SW1w bDo6cGVyZm9ybURyYWdPcGVyYXRpb24oaWQgPE5TRHJhZ2dpbmdJbmZvPiBkcmFnZ2luZ0luZm8p CiAgICAgICAgICAgICBOU0ZpbGVQcm9taXNlUmVjZWl2ZXIgKml0ZW0gPSBkcmFnZ2luZ0l0ZW0u aXRlbTsKICAgICAgICAgICAgIE5TRGljdGlvbmFyeSAqb3B0aW9ucyA9IEB7IH07CiAKLSAgICAg ICAgICAgIFtpdGVtIHJlY2VpdmVQcm9taXNlZEZpbGVzQXREZXN0aW5hdGlvbjpkcm9wTG9jYXRp b24gb3B0aW9uczpvcHRpb25zIG9wZXJhdGlvblF1ZXVlOltOU09wZXJhdGlvblF1ZXVlIG5ld10g cmVhZGVyOl4oTlNVUkwgKiBfTm9ubnVsbCBmaWxlVVJMLCBOU0Vycm9yICogX051bGxhYmxlIGVy cm9yT3JOaWwpIHsKKyAgICAgICAgICAgIFJldGFpblB0cjxOU09wZXJhdGlvblF1ZXVlPiBxdWV1 ZSA9IGFkb3B0TlMoW05TT3BlcmF0aW9uUXVldWUgbmV3XSk7CisgICAgICAgICAgICBbaXRlbSBy ZWNlaXZlUHJvbWlzZWRGaWxlc0F0RGVzdGluYXRpb246ZHJvcExvY2F0aW9uIG9wdGlvbnM6b3B0 aW9ucyBvcGVyYXRpb25RdWV1ZTpxdWV1ZS5nZXQoKSByZWFkZXI6XihOU1VSTCAqIF9Ob25udWxs IGZpbGVVUkwsIE5TRXJyb3IgKiBfTnVsbGFibGUgZXJyb3JPck5pbCkgewogICAgICAgICAgICAg ICAgIGlmIChlcnJvck9yTmlsKQogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXRM ZWdhY3kvbWFjL0NoYW5nZUxvZwppbmRleCA2NGFhZjY0Y2Q4Zi4uOGRlYzRjZmQyZTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0xMS0zMCAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBzb21lIE5T T3BlcmF0aW9uUXVldWUgbGVha3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4MDIyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IHBl cmZvcm1EcmFnT3BlcmF0aW9uOl0pOgorCiAyMDE3LTExLTI3ICBUaW0gSG9ydG9uICA8dGltb3Ro eV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIE9uZSB0b28gbWFueSB6ZXJvZXMgaW4gbWFj T1MgdmVyc2lvbiBudW1iZXIgaW4gRmVhdHVyZURlZmluZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kv bWFjL1dlYlZpZXcvV2ViVmlldy5tbQppbmRleCAwNjUzY2E4MmU1Yi4uMDQ0ZTllOGU5OWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KQEAgLTY3MjksNyAr NjcyOSw4IEBAIC0gKEJPT0wpcGVyZm9ybURyYWdPcGVyYXRpb246KGlkIDxOU0RyYWdnaW5nSW5m bz4pZHJhZ2dpbmdJbmZvCiAgICAgICAgICAgICBOU0ZpbGVQcm9taXNlUmVjZWl2ZXIgKml0ZW0g PSBkcmFnZ2luZ0l0ZW0uaXRlbTsKICAgICAgICAgICAgIE5TRGljdGlvbmFyeSAqb3B0aW9ucyA9 IEB7IH07CiAKLSAgICAgICAgICAgIFtpdGVtIHJlY2VpdmVQcm9taXNlZEZpbGVzQXREZXN0aW5h dGlvbjpkcm9wTG9jYXRpb24gb3B0aW9uczpvcHRpb25zIG9wZXJhdGlvblF1ZXVlOltOU09wZXJh dGlvblF1ZXVlIG5ld10gcmVhZGVyOl4oTlNVUkwgKiBfTm9ubnVsbCBmaWxlVVJMLCBOU0Vycm9y ICogX051bGxhYmxlIGVycm9yT3JOaWwpIHsKKyAgICAgICAgICAgIFJldGFpblB0cjxOU09wZXJh dGlvblF1ZXVlPiBxdWV1ZSA9IGFkb3B0TlMoW05TT3BlcmF0aW9uUXVldWUgbmV3XSk7CisgICAg ICAgICAgICBbaXRlbSByZWNlaXZlUHJvbWlzZWRGaWxlc0F0RGVzdGluYXRpb246ZHJvcExvY2F0 aW9uIG9wdGlvbnM6b3B0aW9ucyBvcGVyYXRpb25RdWV1ZTpxdWV1ZS5nZXQoKSByZWFkZXI6XihO U1VSTCAqIF9Ob25udWxsIGZpbGVVUkwsIE5TRXJyb3IgKiBfTnVsbGFibGUgZXJyb3JPck5pbCkg ewogICAgICAgICAgICAgICAgIGlmIChlcnJvck9yTmlsKQogICAgICAgICAgICAgICAgICAgICBy ZXR1cm47CiAK