180219 2017-11-30 14:39:07 -0800 jsc shell's flashHeapAccess() should not do JS work after releasing access to the heap. 2017-11-30 14:52:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist fpizlo keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1376526 0 mark.lam 2017-11-30 14:39:07 -0800 Patch coming. <rdar://problem/35696536> 1376532 1 328033 mark.lam 2017-11-30 14:47:11 -0800 Created attachment 328033 proposed patch. 1376537 2 mark.lam 2017-11-30 14:52:34 -0800 Thanks for the review. Landed in r225352: <http://trac.webkit.org/r225352>. 328033 2017-11-30 14:47:11 -0800 2017-11-30 14:49:28 -0800 proposed patch. bug-180219.patch text/plain 2474 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjUzNTEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE3LTExLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBqc2Mgc2hlbGwncyBmbGFzaEhlYXBBY2Nlc3MoKSBzaG91bGQgbm90IGRv IEpTIHdvcmsgYWZ0ZXIgcmVsZWFzaW5nIGFjY2VzcyB0byB0aGUgaGVhcC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDIxOQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzU2OTY1MzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBzdHJlc3MvcmVncmVzcy0xODAyMTkuanM6IEFkZGVkLgorCiAyMDE3 LTExLTMwICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAg IFtERkddW0ZUTF0gb3BlcmF0aW9uSGFzSW5kZXhlZFByb3BlcnR5IGRvZXMgbm90IGNvbnNpZGVy IG5lZ2F0aXZlIGludDMyX3QKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTgwMjE5Lmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTgwMjE5LmpzCShub25leGlz dGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTgwMjE5LmpzCSh3b3JraW5nIGNvcHkp CkBAIC0wLDAgKzEsMyBAQAorLy9AIHJ1bkRlZmF1bHQKK2djKCk7CitmbGFzaEhlYXBBY2Nlc3Mo e30pOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjUzMzApCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTctMTEtMzAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAg ICAgIGpzYyBzaGVsbCdzIGZsYXNoSGVhcEFjY2VzcygpIHNob3VsZCBub3QgZG8gSlMgd29yayBh ZnRlciByZWxlYXNpbmcgYWNjZXNzIHRvIHRoZSBoZWFwLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMjE5CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8zNTY5NjUzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGpzYy5jcHA6CisgICAgICAgIChmdW5jdGlvbkZsYXNoSGVhcEFjY2Vzcyk6CisKIDIw MTctMTEtMzAgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTihyMjI1MzE0KTogW0xpbnV4XSBNb3JlIHRoYW4gMjAwMCBqc2MgdGVzdHMg YXJlIGZhaWxpbmcgYWZ0ZXIgcjIyNTMxNApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pz Yy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHJldmlz aW9uIDIyNTMzMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xNzIwLDEyICsxNzIwLDE1IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwg ZnVuY3Rpb25GbGEKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwogICAgIGF1dG8gc2NvcGUgPSBE RUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKICAgICAKLSAgICB2bS5oZWFwLnJlbGVhc2VBY2Nlc3Mo KTsKKyAgICBkb3VibGUgc2xlZXBUaW1lTXMgPSAwOwogICAgIGlmIChleGVjLT5hcmd1bWVudENv dW50KCkgPj0gMSkgewotICAgICAgICBkb3VibGUgbXMgPSBleGVjLT5hcmd1bWVudCgwKS50b051 bWJlcihleGVjKTsKKyAgICAgICAgc2xlZXBUaW1lTXMgPSBleGVjLT5hcmd1bWVudCgwKS50b051 bWJlcihleGVjKTsKICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpT VmFsdWUoKSk7Ci0gICAgICAgIHNsZWVwKFNlY29uZHM6OmZyb21NaWxsaXNlY29uZHMobXMpKTsK ICAgICB9CisKKyAgICB2bS5oZWFwLnJlbGVhc2VBY2Nlc3MoKTsKKyAgICBpZiAoc2xlZXBUaW1l TXMpCisgICAgICAgIHNsZWVwKFNlY29uZHM6OmZyb21NaWxsaXNlY29uZHMoc2xlZXBUaW1lTXMp KTsKICAgICB2bS5oZWFwLmFjcXVpcmVBY2Nlc3MoKTsKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKGpzVW5kZWZpbmVkKCkpOwogfQo=