180213 2017-11-30 12:19:44 -0800 Web Automation: computeElementLayout does not correctly translate iframe client coordinates to main frame coordinates 2017-11-30 16:11:45 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179129 InRadar P2 Normal --- 1 bburg bburg bburg cgarcia commit-queue joepeck simon.fraser thorton webkit-bug-importer oldest_to_newest 1376446 0 bburg 2017-11-30 12:19:44 -0800 The fix in https://bugs.webkit.org/show_bug.cgi?id=179129 was not completely right. We need to translate to the root view, otherwise coordinates returned are still in subframe's client coordinate system. 1376448 1 bburg 2017-11-30 12:20:57 -0800 <rdar://problem/30260141> 1376455 2 328007 bburg 2017-11-30 12:35:13 -0800 Created attachment 328007 Proposed Fix 1376600 3 328007 commit-queue 2017-11-30 16:11:43 -0800 Comment on attachment 328007 Proposed Fix Clearing flags on attachment: 328007 Committed r225367: <https://trac.webkit.org/changeset/225367> 1376601 4 commit-queue 2017-11-30 16:11:45 -0800 All reviewed patches have been landed. Closing bug. 328007 2017-11-30 12:35:13 -0800 2017-11-30 16:11:43 -0800 Proposed Fix bug-180213-20171130123513.patch text/plain 6258 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg0ZGZiNmM2NjYxYTM5NzQw NTFhNDNlODhjNDcxZTZiNzdjMTc3YzIuLmI0ZWFiMGY4N2YzOGUxOTc2ZTliZmI4OTI3MDI4ODRl MDVlMjhhNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzkgQEAKKzIwMTctMTEtMzAgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IGNvbXB1dGVF bGVtZW50TGF5b3V0IGRvZXMgbm90IGNvcnJlY3RseSB0cmFuc2xhdGUgaWZyYW1lIGNsaWVudCBj b29yZGluYXRlcyB0byBtYWluIGZyYW1lIGNvb3JkaW5hdGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAyMTMKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzMwMjYwMTQxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBjdXJyZW50IGltcGxlbWVudGF0aW9uIGNvbXB1dGVzIHBvaW50cyBpbiB0ZXJt cyBvZiB0aGUgZnJhbWUgaW4gd2hpY2ggdGhlIGVsZW1lbnQgaXMgbG9jYXRlZC4KKyAgICAgICAg SG93ZXZlciwgV2ViRHJpdmVyIGV4cGVjdHMgY29vcmRpbmF0ZXMgdG8gYmUgcmVsYXRpdmUgdG8g dGhlIHRvcC1sZXZlbCBkb2N1bWVudCBzaW5jZQorICAgICAgICB0aGVzZSBjb29yZGluYXRlcyBh cmUgdXNlZCBmb3IgZ2VuZXJhdGluZyBjbGljayBldmVudHMsIGFtb25nIG90aGVyIHRoaW5ncy4K KworICAgICAgICBUbyBjb252ZXJ0IGZyb20gZnJhbWUgY2xpZW50IGNvb3JkaW5hdGVzIHRvIG1h aW4gZnJhbWUgY2xpZW50IGNvb3JkaW5hdGVzLCByb3VuZC10cmlwCisgICAgICAgIGJvdGggaW5W aWV3Q2VudGVyUG9pbnQgYW5kIGVsZW1lbnRCb3VuZHMgdG8gcm9vdCB2aWV3IGNvb3JkaW5hdGVz IGFuZCBiYWNrCisgICAgICAgIHRvIHRoZSBtYWluIGZyYW1lJ3MgY29udGVudHMvY2xpZW50IGNv b3JkaW5hdGVzLiBUaGVuIGNvbnZlcnQgdGhpcyB0byBwYWdlIGNvb3JkaW5hdGVzIGlmIG5lZWRl ZC4KKworICAgICAgICBUaGlzIHByb2dyZXNzZXMgc2V2ZXJhbCB0ZXN0cyBpbiB0aGUgU2VsZW5p dW0gUHl0aG9uIHRlc3Qgc3VpdGU6CisKKyAgICAgICAgIC0gZXZlbnRfZmlyaW5nX3dlYmRyaXZl cl90ZXN0cy5weTo6dGVzdF9zaG91bGRfZmlyZV9uYXZpZ2F0aW9uX2V2ZW50cworICAgICAgICAg LSBmcmFtZV9zd2l0Y2hpbmdfdGVzdHMucHk6OnRlc3RTaG91bGRCZUFibGVUb0NsaWNrSW5BRnJh bWVUaGF0UmV3cml0ZXNUb3BXaW5kb3dMb2NhdGlvbgorICAgICAgICAgLSBmcmFtZV9zd2l0Y2hp bmdfdGVzdHMucHk6OnRlc3RTaG91bGRCZUFibGVUb1N3aXRjaFRvVGhlVG9wSWZUaGVGcmFtZUlz RGVsZXRlZEZyb21VbmRlclVzCisgICAgICAgICAtIGZyYW1lX3N3aXRjaGluZ190ZXN0cy5weTo6 dGVzdFNob3VsZEJlQWJsZVRvU3dpdGNoVG9UaGVUb3BJZlRoZUZyYW1lSXNEZWxldGVkRnJvbVVu ZGVyVXNXaXRoRnJhbWVJbmRleAorICAgICAgICAgLSBmcmFtZV9zd2l0Y2hpbmdfdGVzdHMucHk6 OnRlc3RTaG91bGRCZUFibGVUb1N3aXRjaFRvVGhlVG9wSWZUaGVGcmFtZUlzRGVsZXRlZEZyb21V bmRlclVzV2l0aFdlYmVsZW1lbnQKKyAgICAgICAgIC0gZnJhbWVfc3dpdGNoaW5nX3Rlc3RzLnB5 Ojp0ZXN0U2hvdWxkTm90QmVBYmxlVG9Eb0FueXRoaW5nVGhlRnJhbWVJc0RlbGV0ZWRGcm9tVW5k ZXJVcworICAgICAgICAgLSBwb3NpdGlvbl9hbmRfc2l6ZV90ZXN0cy5weTo6dGVzdFNob3VsZEdl dENvb3JkaW5hdGVzT2ZBbkludmlzaWJsZUVsZW1lbnQKKworICAgICAgICAqIFdlYlByb2Nlc3Mv QXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViQXV0b21hdGlvblNlc3Npb25Qcm94eTo6Y29tcHV0ZUVsZW1lbnRMYXlvdXQpOgorICAg ICAgICBHZXQgYm90aCB0aGUgZnJhbWUgYW5kIG1haW4gZnJhbWUgRnJhbWVWaWV3cyBhbmQgY29u dmVydCBjb29yZGluYXRlcyB0byB0aGUgcm9vdCB2aWV3LgorICAgICAgICBUaGlzIGlzIHNvbWV3 aGF0IGxvc3N5IGFzIGNsaWVudFRvRG9jdW1lbnQqIGRlYWxzIHdpdGggRmxvYXRQb2ludHMgYnV0 IGNvbnRlbnRzVG9Sb290VmlldworICAgICAgICBkZWFscyB3aXRoIEludFBvaW50cy4gRm9yIHRo ZSBwdXJwb3NlcyBvZiBXZWJEcml2ZXIsIGxvc3NpbmVzcyBpcyBub3QgYSBwcm9ibGVtIHNpbmNl CisgICAgICAgIGludGVnZXIgdmFsdWVzIGFyZSBleHBlY3RlZCBhbnl3YXkuCisKKyAgICAgICAg VGhlIGltcGVyYXRpdmUgbmF0dXJlIG9mIHRoZSBjb29yZGluYXRlIGNhbGN1bGF0aW9ucyBpcyBk aWZmaWN1bHQgdG8gZGVidWcsIHNvIEkgY29udmVydGVkCisgICAgICAgIHRoaXMgZnVuY3Rpb24g dG8gb25seSBhc3NpZ24gdG8gZWFjaCB2YXJpYWJsZSBvbmNlLgorCiAyMDE3LTExLTMwICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSByZW1vdmUgdW5uZWVk ZWQgUmV0YWluUHRyIHVzZSBpbnRyb2R1Y2VkIGluIHIyMjUxNDIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHku Y3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNl c3Npb25Qcm94eS5jcHAKaW5kZXggZTQ3Mzc0YTY4MDBjYWVlYTQ5MTQ3NGE5NzE4YjYxODAxZjkw N2E0My4uMDcwYThjYWJhMjE1MzA3ZTkxOGRjOTVjYjI3MmE5OTYwZDk0M2RiNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Np b25Qcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2Vi QXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHAKQEAgLTU3MiwzMiArNTcyLDM3IEBAIHZvaWQgV2Vi QXV0b21hdGlvblNlc3Npb25Qcm94eTo6Y29tcHV0ZUVsZW1lbnRMYXlvdXQodWludDY0X3QgcGFn ZUlELCB1aW50NjRfdCBmCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBXZWJDb3JlOjpG bG9hdFJlY3QgZWxlbWVudEJvdW5kcyA9IGNvcmVFbGVtZW50LT5ib3VuZGluZ0NsaWVudFJlY3Qo KTsKLQotICAgIGF1dG8qIGNvcmVGcmFtZVZpZXcgPSBmcmFtZS0+Y29yZUZyYW1lKCktPnZpZXco KTsKKyAgICBXZWJDb3JlOjpGcmFtZVZpZXcqIGZyYW1lVmlldyA9IGZyYW1lLT5jb3JlRnJhbWUo KS0+dmlldygpOworICAgIFdlYkNvcmU6OkZyYW1lVmlldyogbWFpblZpZXcgPSBmcmFtZS0+Y29y ZUZyYW1lKCktPm1haW5GcmFtZSgpLnZpZXcoKTsKKyAgICBXZWJDb3JlOjpJbnRSZWN0IGZyYW1l RWxlbWVudEJvdW5kcyA9IHJvdW5kZWRJbnRSZWN0KGNvcmVFbGVtZW50LT5ib3VuZGluZ0NsaWVu dFJlY3QoKSk7CisgICAgV2ViQ29yZTo6SW50UmVjdCByb290RWxlbWVudEJvdW5kcyA9IG1haW5W aWV3LT5yb290Vmlld1RvQ29udGVudHMoZnJhbWVWaWV3LT5jb250ZW50c1RvUm9vdFZpZXcoZnJh bWVFbGVtZW50Qm91bmRzKSk7CisgICAgV2ViQ29yZTo6SW50UmVjdCByZXN1bHRFbGVtZW50Qm91 bmRzOwogICAgIHN3aXRjaCAoY29vcmRpbmF0ZVN5c3RlbSkgewogICAgIGNhc2UgQ29vcmRpbmF0 ZVN5c3RlbTo6UGFnZToKLSAgICAgICAgZWxlbWVudEJvdW5kcyA9IGNvcmVGcmFtZVZpZXctPmNs aWVudFRvRG9jdW1lbnRSZWN0KGVsZW1lbnRCb3VuZHMpOworICAgICAgICByZXN1bHRFbGVtZW50 Qm91bmRzID0gV2ViQ29yZTo6SW50UmVjdChtYWluVmlldy0+Y2xpZW50VG9Eb2N1bWVudFJlY3Qo V2ViQ29yZTo6RmxvYXRSZWN0KHJvb3RFbGVtZW50Qm91bmRzKSkpOwogICAgICAgICBicmVhazsK ICAgICBjYXNlIENvb3JkaW5hdGVTeXN0ZW06OkxheW91dFZpZXdwb3J0OgogICAgICAgICAvLyBU aGUgZWxlbWVudCBib3VuZHMgYXJlIGFscmVhZHkgaW4gY2xpZW50IGNvb3JkaW5hdGVzLgorICAg ICAgICByZXN1bHRFbGVtZW50Qm91bmRzID0gcm9vdEVsZW1lbnRCb3VuZHM7CiAgICAgICAgIGJy ZWFrOwogICAgIGNhc2UgQ29vcmRpbmF0ZVN5c3RlbTo6VmlzdWFsVmlld3BvcnQ6CiAgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICBicmVhazsKICAgICB9CiAKLSAgICBzdGQ6 Om9wdGlvbmFsPFdlYkNvcmU6OkZsb2F0UG9pbnQ+IGluVmlld0NlbnRlclBvaW50OworICAgIHN0 ZDo6b3B0aW9uYWw8V2ViQ29yZTo6SW50UG9pbnQ+IHJlc3VsdEluVmlld0NlbnRlclBvaW50Owog ICAgIGJvb2wgaXNPYnNjdXJlZCA9IGZhbHNlOwogICAgIGlmIChjb250YWluZXJFbGVtZW50KSB7 Ci0gICAgICAgIGluVmlld0NlbnRlclBvaW50ID0gZWxlbWVudEluVmlld0NsaWVudENlbnRlclBv aW50KCpjb250YWluZXJFbGVtZW50LCBpc09ic2N1cmVkKTsKLSAgICAgICAgaWYgKGluVmlld0Nl bnRlclBvaW50Lmhhc192YWx1ZSgpKSB7CisgICAgICAgIHN0ZDo6b3B0aW9uYWw8V2ViQ29yZTo6 RmxvYXRQb2ludD4gZnJhbWVJblZpZXdDZW50ZXJQb2ludCA9IGVsZW1lbnRJblZpZXdDbGllbnRD ZW50ZXJQb2ludCgqY29udGFpbmVyRWxlbWVudCwgaXNPYnNjdXJlZCk7CisgICAgICAgIGlmIChm cmFtZUluVmlld0NlbnRlclBvaW50Lmhhc192YWx1ZSgpKSB7CisgICAgICAgICAgICBXZWJDb3Jl OjpJbnRQb2ludCByb290SW5WaWV3Q2VudGVyUG9pbnQgPSBtYWluVmlldy0+cm9vdFZpZXdUb0Nv bnRlbnRzKGZyYW1lVmlldy0+Y29udGVudHNUb1Jvb3RWaWV3KFdlYkNvcmU6OkludFBvaW50KGZy YW1lSW5WaWV3Q2VudGVyUG9pbnQudmFsdWUoKSkpKTsKICAgICAgICAgICAgIHN3aXRjaCAoY29v cmRpbmF0ZVN5c3RlbSkgewogICAgICAgICAgICAgY2FzZSBDb29yZGluYXRlU3lzdGVtOjpQYWdl OgotICAgICAgICAgICAgICAgIGluVmlld0NlbnRlclBvaW50ID0gY29yZUZyYW1lVmlldy0+Y2xp ZW50VG9Eb2N1bWVudFBvaW50KGluVmlld0NlbnRlclBvaW50LnZhbHVlKCkpOworICAgICAgICAg ICAgICAgIHJlc3VsdEluVmlld0NlbnRlclBvaW50ID0gV2ViQ29yZTo6SW50UG9pbnQobWFpblZp ZXctPmNsaWVudFRvRG9jdW1lbnRQb2ludChyb290SW5WaWV3Q2VudGVyUG9pbnQpKTsKICAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgQ29vcmRpbmF0ZVN5c3RlbTo6TGF5 b3V0Vmlld3BvcnQ6CiAgICAgICAgICAgICAgICAgLy8gVGhlIHBvaW50IGlzIGFscmVhZHkgaW4g Y2xpZW50IGNvb3JkaW5hdGVzLgorICAgICAgICAgICAgICAgIHJlc3VsdEluVmlld0NlbnRlclBv aW50ID0gcm9vdEluVmlld0NlbnRlclBvaW50OwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICAgICAgY2FzZSBDb29yZGluYXRlU3lzdGVtOjpWaXN1YWxWaWV3cG9ydDoKICAgICAgICAg ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKQEAgLTYwNiw3ICs2MTEsNyBAQCB2b2lkIFdl YkF1dG9tYXRpb25TZXNzaW9uUHJveHk6OmNvbXB1dGVFbGVtZW50TGF5b3V0KHVpbnQ2NF90IHBh Z2VJRCwgdWludDY0X3QgZgogICAgICAgICB9CiAgICAgfQogCi0gICAgV2ViUHJvY2Vzczo6c2lu Z2xldG9uKCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViQXV0 b21hdGlvblNlc3Npb246OkRpZENvbXB1dGVFbGVtZW50TGF5b3V0KGNhbGxiYWNrSUQsIGVuY2xv c2luZ0ludFJlY3QoZWxlbWVudEJvdW5kcyksIFdlYkNvcmU6OkludFBvaW50KGluVmlld0NlbnRl clBvaW50LnZhbHVlKCkpLCBpc09ic2N1cmVkLCBTdHJpbmcoKSksIDApOworICAgIFdlYlByb2Nl c3M6OnNpbmdsZXRvbigpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmQoTWVzc2FnZXM6 OldlYkF1dG9tYXRpb25TZXNzaW9uOjpEaWRDb21wdXRlRWxlbWVudExheW91dChjYWxsYmFja0lE LCByZXN1bHRFbGVtZW50Qm91bmRzLCByZXN1bHRJblZpZXdDZW50ZXJQb2ludC52YWx1ZSgpLCBp c09ic2N1cmVkLCBTdHJpbmcoKSksIDApOwogfQogCiB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9u UHJveHk6OnNlbGVjdE9wdGlvbkVsZW1lbnQodWludDY0X3QgcGFnZUlELCB1aW50NjRfdCBmcmFt ZUlELCBTdHJpbmcgbm9kZUhhbmRsZSwgdWludDY0X3QgY2FsbGJhY2tJRCkK