180203 2017-11-30 10:09:41 -0800 Make WorkerThread lifetime much more predictable 2017-11-30 13:03:58 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1376374 0 beidson 2017-11-30 10:09:41 -0800 Make WorkerThread lifetime much more predictable Right now it's... not. 1376395 1 327994 beidson 2017-11-30 10:48:04 -0800 Created attachment 327994 Patch 1376402 2 327994 cdumez 2017-11-30 10:59:51 -0800 Comment on attachment 327994 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327994&action=review r=me with a comment. > Source/WebCore/workers/WorkerThread.cpp:237 > + RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis)] { }); Should probably be a callOnMainThread() since we're in WebCore (and this code is likely used by iOS WK1)? 1376432 3 327999 beidson 2017-11-30 11:36:10 -0800 Created attachment 327999 Patch 1376433 4 327999 beidson 2017-11-30 11:36:25 -0800 Comment on attachment 327999 Patch Will cq+ after EWS 1376468 5 327999 commit-queue 2017-11-30 13:01:16 -0800 Comment on attachment 327999 Patch Clearing flags on attachment: 327999 Committed r225343: <https://trac.webkit.org/changeset/225343> 1376469 6 commit-queue 2017-11-30 13:01:17 -0800 All reviewed patches have been landed. Closing bug. 1376471 7 webkit-bug-importer 2017-11-30 13:03:58 -0800 <rdar://problem/35780268> 327994 2017-11-30 10:48:04 -0800 2017-11-30 11:36:09 -0800 Patch bug-180203-20171130104804.patch text/plain 3495 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTcyMWFmNTA5NDc5N2Yw MWZmNDBmZTg3OTRlZTUyMWNhM2VhOGE1NC4uYmI2NGQ3OGRmN2UzZmE3ZThmYzliNTZlYmZkNGM4 OTM3NTgyY2UwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE3LTExLTMwICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFdvcmtlclRocmVh ZCBsaWZldGltZSBtdWNoIG1vcmUgcHJlZGljdGFibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAyMDMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKEZpeGVzIGZsYWtpbmVzcyBp biBleGlzdGluZyBhbmQgZnV0dXJlIHRlc3RzKS4KKworICAgICAgICBUaGUgZmFtaWx5IG9mIGNs YXNzZXMgcmVsYXRlZCB0byBXb3JrZXJzIGhhcyBhIGNvbXBsaWNhdGVkIG93bmVyc2hpcCBtb2Rl bC4KKworICAgICAgICBGb3IgRGVkaWNhdGVkIFdvcmtlcnMsIHRoZSBXb3JrZXJUaHJlYWQgb2Jq ZWN0IGlzIG93bmVkIGJ5IHRoZSBXb3JrZXJNZXNzYWdpbmdQcm94eSwKKyAgICAgICAgd2hpY2gg bWFuYWdlcyBpdHMgb3duIGxpZmV0aW1lLiBBZGRpdGlvbmFsbHksIG90aGVyIG9iamVjdChzKSBo YXZlIHJhdyBDKysgcmVmZXJlbmNlcworICAgICAgICB0byBpdCwgYW5kIHRoZSBleHBlY3RlZCBs aWZldGltZXMgYXJlIGRlc2NyaWJlZCBpbiBjb21tZW50cyBzY2F0dGVyZWQgdGhyb3VnaCBhIGZl dyBmaWxlcy4KKworICAgICAgICBXaGF0IGl0IGJvaWxzIGRvd24gdG8gaXMgdGhhdCB0aGUgIldv cmtlciIgRE9NIG9iamVjdCAtIHdoaWNoIGxpdmVzIG9uIHRoZSBtYWluIHRocmVhZCAtIAorICAg ICAgICBpcyB0aGUga2V5IHRvIHRoZSBwcm9wZXIgZGVzdHJ1Y3Rpb24gb2YgYWxsIG9mIHRoZXNl IG9iamVjdHMuCisKKyAgICAgICAgRm9yIFNlcnZpY2VXb3JrZXJzIHJ1bm5pbmcgaW4gdGhlaXIg b3duIGNvbnRleHQgcHJvY2VzcywgdGhlcmUgaXMgbm8gIldvcmtlciIgb24gdGhlIG1haW4gdGhy ZWFkLgorCisgICAgICAgIEFzIGEgcmVzdWx0LCBTZXJ2aWNlV29ya2VycyBjYW4gZ2V0IGludG8g YSBzaXR1YXRpb24gd2hlcmUgdGhlaXIgV29ya2VyVGhyZWFkIGNhbiBiZSBkZXN0cm95ZWQgYmVm b3JlCisgICAgICAgIHRoZWlyIFNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZSBpcyBkZXN0cm95ZWQg b24gdGhlIHJ1bm5pbmcgYmFja2dyb3VuZCB0aHJlYWQuCisKKyAgICAgICAgVGhlcmUncyBubyBy ZWFzb24gdG8gbm90IGhhdmUgV29ya2VyVGhyZWFkIGd1YXJhbnRlZSBpdHMgb3duIGxpZmV0aW1l IHVudGlsIGl0cyBiYWNrZ3JvdW5kIHRocmVhZAorICAgICAgICBoYXMgYWN0dWFsbHkgY29tcGxl dGVkLgorCisgICAgICAgICogd29ya2Vycy9Xb3JrZXJUaHJlYWQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6V29ya2VyVGhyZWFkOjp3b3JrZXJUaHJlYWQpOiBQcm90ZWN0IHRoZSBXb3JrZXJUaHJl YWQgb2JqZWN0IGR1cmluZyB0aGUgZW50aXJlIHJ1bnRpbWUKKyAgICAgICAgICBvZiB0aGUgYmFj a2dyb3VuZCB0aHJlYWQgaXRzZWxmLCBhbmQgcmVsZWFzZSB0aGF0IHByb3RlY3Rpb24gb24gdGhl IG1haW4gdGhyZWFkLgorICAgICAgICAqIHdvcmtlcnMvV29ya2VyVGhyZWFkLmg6CisKIDIwMTct MTEtMzAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBNYXJrIFNl cnZpY2VXb3JrZXJHbG9iYWxTY29wZSBhcyBmaW5hbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvd29ya2Vycy9Xb3JrZXJUaHJlYWQuY3BwIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3Jr ZXJUaHJlYWQuY3BwCmluZGV4IDVlMGU0NjI4ZDlkMDdmYmI3NWIyZDI1NjhmYTUzYjdhM2ZkNWQ4 YzYuLjJhNWUxNmQ2ZTBkNGM0NWM0YTM1MTE0MzYxOTA3Y2Q4NjZjN2EyODIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL1dvcmtlclRocmVhZC5jcHAKQEAgLTE0OSw2ICsxNDksOCBAQCBib29sIFdv cmtlclRocmVhZDo6c3RhcnQoV1RGOjpGdW5jdGlvbjx2b2lkKGNvbnN0IFN0cmluZyYpPiYmIGV2 YWx1YXRlQ2FsbGJhY2spCiAKIHZvaWQgV29ya2VyVGhyZWFkOjp3b3JrZXJUaHJlYWQoKQogewor ICAgIGF1dG8gcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpOworCiAgICAgLy8gUHJvcGFn YXRlIHRoZSBtYWluVGhyZWFkJ3MgZmVudiB0byB3b3JrZXJzLgogI2lmIFBMQVRGT1JNKElPUykK ICAgICBGbG9hdGluZ1BvaW50RW52aXJvbm1lbnQ6OnNpbmdsZXRvbigpLnByb3BhZ2F0ZU1haW5U aHJlYWRFbnZpcm9ubWVudCgpOwpAQCAtMjMxLDYgKzIzMyw5IEBAIHZvaWQgV29ya2VyVGhyZWFk Ojp3b3JrZXJUaHJlYWQoKQogICAgIC8vIENsZWFuIHVwIFdlYkNvcmU6OlRocmVhZEdsb2JhbERh dGEgYmVmb3JlIFdURjo6VGhyZWFkIGdvZXMgYXdheSEKICAgICB0aHJlYWRHbG9iYWxEYXRhKCku ZGVzdHJveSgpOwogCisgICAgLy8gU2VuZCB0aGUgbGFzdCBXb3JrZXJUaHJlYWQgUmVmIHRvIGJl IERlcmVmJ2VkIG9uIHRoZSBtYWluIHRocmVhZC4KKyAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0 Y2goW3Byb3RlY3RlZFRoaXMgPSBXVEZNb3ZlKHByb3RlY3RlZFRoaXMpXSB7IH0pOworCiAgICAg Ly8gVGhlIHRocmVhZCBvYmplY3QgbWF5IGJlIGFscmVhZHkgZGVzdHJveWVkIGZyb20gbm90aWZp Y2F0aW9uIG5vdywgZG9uJ3QgdHJ5IHRvIGFjY2VzcyAidGhpcyIuCiAgICAgcHJvdGVjdG9yLT5k ZXRhY2goKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhy ZWFkLmggYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlclRocmVhZC5oCmluZGV4IGNjOTI0 Njk4YzAzY2Y0MjAyODIwNTJhMmYzOWEwNDA5N2MzZjU4MWUuLjQ5ZTVjNGJiYmY1MmJkY2E4MTU3 YzFjMDdmYjE5NmU4ZGViZWM5NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv V29ya2VyVGhyZWFkLmgKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJUaHJlYWQu aApAQCAtNTksNyArNTksNyBAQCBjbGFzcyBJREJDb25uZWN0aW9uUHJveHk7CiAKIHN0cnVjdCBX b3JrZXJUaHJlYWRTdGFydHVwRGF0YTsKIAotY2xhc3MgV29ya2VyVGhyZWFkIDogcHVibGljIFJl ZkNvdW50ZWQ8V29ya2VyVGhyZWFkPiB7CitjbGFzcyBXb3JrZXJUaHJlYWQgOiBwdWJsaWMgVGhy ZWFkU2FmZVJlZkNvdW50ZWQ8V29ya2VyVGhyZWFkPiB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB+ V29ya2VyVGhyZWFkKCk7CiAK 327999 2017-11-30 11:36:10 -0800 2017-11-30 13:01:16 -0800 Patch bug-180203-20171130113609.patch text/plain 3484 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTcyMWFmNTA5NDc5N2Yw MWZmNDBmZTg3OTRlZTUyMWNhM2VhOGE1NC4uY2UyMjBhM2NhOGE1OWI1ZTJmMGRhOTQ5ZTg4Mjhk ZTNmYTE4ZDIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE3LTExLTMwICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFdvcmtlclRocmVh ZCBsaWZldGltZSBtdWNoIG1vcmUgcHJlZGljdGFibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAyMDMKKworICAgICAgICBSZXZpZXdlZCBieSBD aHJpcyBEdW1lei4KKworICAgICAgICBObyBuZXcgdGVzdHMgKEZpeGVzIGZsYWtpbmVzcyBpbiBl eGlzdGluZyBhbmQgZnV0dXJlIHRlc3RzKS4KKworICAgICAgICBUaGUgZmFtaWx5IG9mIGNsYXNz ZXMgcmVsYXRlZCB0byBXb3JrZXJzIGhhcyBhIGNvbXBsaWNhdGVkIG93bmVyc2hpcCBtb2RlbC4K KworICAgICAgICBGb3IgRGVkaWNhdGVkIFdvcmtlcnMsIHRoZSBXb3JrZXJUaHJlYWQgb2JqZWN0 IGlzIG93bmVkIGJ5IHRoZSBXb3JrZXJNZXNzYWdpbmdQcm94eSwKKyAgICAgICAgd2hpY2ggbWFu YWdlcyBpdHMgb3duIGxpZmV0aW1lLiBBZGRpdGlvbmFsbHksIG90aGVyIG9iamVjdChzKSBoYXZl IHJhdyBDKysgcmVmZXJlbmNlcworICAgICAgICB0byBpdCwgYW5kIHRoZSBleHBlY3RlZCBsaWZl dGltZXMgYXJlIGRlc2NyaWJlZCBpbiBjb21tZW50cyBzY2F0dGVyZWQgdGhyb3VnaCBhIGZldyBm aWxlcy4KKworICAgICAgICBXaGF0IGl0IGJvaWxzIGRvd24gdG8gaXMgdGhhdCB0aGUgIldvcmtl ciIgRE9NIG9iamVjdCAtIHdoaWNoIGxpdmVzIG9uIHRoZSBtYWluIHRocmVhZCAtIAorICAgICAg ICBpcyB0aGUga2V5IHRvIHRoZSBwcm9wZXIgZGVzdHJ1Y3Rpb24gb2YgYWxsIG9mIHRoZXNlIG9i amVjdHMuCisKKyAgICAgICAgRm9yIFNlcnZpY2VXb3JrZXJzIHJ1bm5pbmcgaW4gdGhlaXIgb3du IGNvbnRleHQgcHJvY2VzcywgdGhlcmUgaXMgbm8gIldvcmtlciIgb24gdGhlIG1haW4gdGhyZWFk LgorCisgICAgICAgIEFzIGEgcmVzdWx0LCBTZXJ2aWNlV29ya2VycyBjYW4gZ2V0IGludG8gYSBz aXR1YXRpb24gd2hlcmUgdGhlaXIgV29ya2VyVGhyZWFkIGNhbiBiZSBkZXN0cm95ZWQgYmVmb3Jl CisgICAgICAgIHRoZWlyIFNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZSBpcyBkZXN0cm95ZWQgb24g dGhlIHJ1bm5pbmcgYmFja2dyb3VuZCB0aHJlYWQuCisKKyAgICAgICAgVGhlcmUncyBubyByZWFz b24gdG8gbm90IGhhdmUgV29ya2VyVGhyZWFkIGd1YXJhbnRlZSBpdHMgb3duIGxpZmV0aW1lIHVu dGlsIGl0cyBiYWNrZ3JvdW5kIHRocmVhZAorICAgICAgICBoYXMgYWN0dWFsbHkgY29tcGxldGVk LgorCisgICAgICAgICogd29ya2Vycy9Xb3JrZXJUaHJlYWQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6V29ya2VyVGhyZWFkOjp3b3JrZXJUaHJlYWQpOiBQcm90ZWN0IHRoZSBXb3JrZXJUaHJlYWQg b2JqZWN0IGR1cmluZyB0aGUgZW50aXJlIHJ1bnRpbWUKKyAgICAgICAgICBvZiB0aGUgYmFja2dy b3VuZCB0aHJlYWQgaXRzZWxmLCBhbmQgcmVsZWFzZSB0aGF0IHByb3RlY3Rpb24gb24gdGhlIG1h aW4gdGhyZWFkLgorICAgICAgICAqIHdvcmtlcnMvV29ya2VyVGhyZWFkLmg6CisKIDIwMTctMTEt MzAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBNYXJrIFNlcnZp Y2VXb3JrZXJHbG9iYWxTY29wZSBhcyBmaW5hbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv d29ya2Vycy9Xb3JrZXJUaHJlYWQuY3BwIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJU aHJlYWQuY3BwCmluZGV4IDVlMGU0NjI4ZDlkMDdmYmI3NWIyZDI1NjhmYTUzYjdhM2ZkNWQ4YzYu LmY0NTU1ODg0OWFhZmNjMmY3NmE5YTQwNTRlYTA3NmQyOTljZmY0YjIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS93b3JrZXJzL1dvcmtlclRocmVhZC5jcHAKQEAgLTE0OSw2ICsxNDksOCBAQCBib29sIFdvcmtl clRocmVhZDo6c3RhcnQoV1RGOjpGdW5jdGlvbjx2b2lkKGNvbnN0IFN0cmluZyYpPiYmIGV2YWx1 YXRlQ2FsbGJhY2spCiAKIHZvaWQgV29ya2VyVGhyZWFkOjp3b3JrZXJUaHJlYWQoKQogeworICAg IGF1dG8gcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpOworCiAgICAgLy8gUHJvcGFnYXRl IHRoZSBtYWluVGhyZWFkJ3MgZmVudiB0byB3b3JrZXJzLgogI2lmIFBMQVRGT1JNKElPUykKICAg ICBGbG9hdGluZ1BvaW50RW52aXJvbm1lbnQ6OnNpbmdsZXRvbigpLnByb3BhZ2F0ZU1haW5UaHJl YWRFbnZpcm9ubWVudCgpOwpAQCAtMjMxLDYgKzIzMyw5IEBAIHZvaWQgV29ya2VyVGhyZWFkOjp3 b3JrZXJUaHJlYWQoKQogICAgIC8vIENsZWFuIHVwIFdlYkNvcmU6OlRocmVhZEdsb2JhbERhdGEg YmVmb3JlIFdURjo6VGhyZWFkIGdvZXMgYXdheSEKICAgICB0aHJlYWRHbG9iYWxEYXRhKCkuZGVz dHJveSgpOwogCisgICAgLy8gU2VuZCB0aGUgbGFzdCBXb3JrZXJUaHJlYWQgUmVmIHRvIGJlIERl cmVmJ2VkIG9uIHRoZSBtYWluIHRocmVhZC4KKyAgICBjYWxsT25NYWluVGhyZWFkKFtwcm90ZWN0 ZWRUaGlzID0gV1RGTW92ZShwcm90ZWN0ZWRUaGlzKV0geyB9KTsKKwogICAgIC8vIFRoZSB0aHJl YWQgb2JqZWN0IG1heSBiZSBhbHJlYWR5IGRlc3Ryb3llZCBmcm9tIG5vdGlmaWNhdGlvbiBub3cs IGRvbid0IHRyeSB0byBhY2Nlc3MgInRoaXMiLgogICAgIHByb3RlY3Rvci0+ZGV0YWNoKCk7CiB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlclRocmVhZC5oIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJUaHJlYWQuaAppbmRleCBjYzkyNDY5OGMwM2NmNDIw MjgyMDUyYTJmMzlhMDQwOTdjM2Y1ODFlLi40OWU1YzRiYmJmNTJiZGNhODE1N2MxYzA3ZmIxOTZl OGRlYmVjOTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlclRocmVh ZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhyZWFkLmgKQEAgLTU5LDcg KzU5LDcgQEAgY2xhc3MgSURCQ29ubmVjdGlvblByb3h5OwogCiBzdHJ1Y3QgV29ya2VyVGhyZWFk U3RhcnR1cERhdGE7CiAKLWNsYXNzIFdvcmtlclRocmVhZCA6IHB1YmxpYyBSZWZDb3VudGVkPFdv cmtlclRocmVhZD4geworY2xhc3MgV29ya2VyVGhyZWFkIDogcHVibGljIFRocmVhZFNhZmVSZWZD b3VudGVkPFdvcmtlclRocmVhZD4gewogcHVibGljOgogICAgIHZpcnR1YWwgfldvcmtlclRocmVh ZCgpOwogCg==