180200 2017-11-30 09:18:46 -0800 WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS bots 2017-11-30 10:59:41 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue jlewis3 lforschler mitz ryanhaddad thorton webkit-bug-importer oldest_to_newest 1376344 0 wenson_hsieh 2017-11-30 09:18:46 -0800 Test was introduced in r225311. 1376355 1 327983 wenson_hsieh 2017-11-30 09:40:55 -0800 Created attachment 327983 Patch 1376359 2 wenson_hsieh 2017-11-30 09:46:24 -0800 Upon further investigation, the attachment element size seems to differ depending on whether a retina or non-retina display is used, which explains why we only encounter this on the Mac bots. 1376399 3 327983 commit-queue 2017-11-30 10:58:09 -0800 Comment on attachment 327983 Patch Clearing flags on attachment: 327983 Committed r225332: <https://trac.webkit.org/changeset/225332> 1376400 4 commit-queue 2017-11-30 10:58:10 -0800 All reviewed patches have been landed. Closing bug. 1376401 5 webkit-bug-importer 2017-11-30 10:59:41 -0800 <rdar://problem/35776711> 327983 2017-11-30 09:40:55 -0800 2017-11-30 10:58:09 -0800 Patch bug-180200-20171130094054.patch text/plain 5263 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjVhYWRmYmNmMGU4MDNmMGYwNzU5NGQ5ZDYyNjFhMmVi NzQyY2I1My4uMjVhOGNmMjIzNTAwZjA4MDJjNmM3ODhiMzhlMGU0NzFkYmQzODMwNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE3LTExLTMwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFdLQXR0YWNobWVudFRlc3RzLkluUGxhY2VJbWFnZUF0dGFjaG1lbnRUb2dnbGVE aXNwbGF5TW9kZSB0aW1lcyBvdXQgb24gbWFjT1MgYm90cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMjAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV3cml0ZXMgYW4gQVBJIHRlc3QgdG8gYXZvaWQg Y2hlY2tpbmcgYWdhaW5zdCB0aGUgaGFyZC1jb2RlZCBwbGF0Zm9ybS1kZXBlbmRlbnQgc2l6ZSBv ZiBhbiBhdHRhY2htZW50IGVsZW1lbnQuCisgICAgICAgIEluc3RlYWQsIGZpcnN0IGluc2VydCB0 aGUgYXR0YWNobWVudCBlbGVtZW50IGFzIGFuIGljb24gYW5kIGNvbXB1dGUgaXRzIHNpemUsIGFu ZCB0aGVuIGNoZWNrIHRoYXQgdGhlIHNpemUgb2YKKyAgICAgICAgdGhlIGVsZW1lbnQgaXMgcmVz dG9yZWQgdG8gdGhpcyBvcmlnaW5hbCB2YWx1ZSBhZnRlciB0b2dnbGluZyB0aGUgZGlzcGxheSBt b2RlIHRvIGluLXBsYWNlIG1vZGUgYW5kIGJhY2suCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL1dLQXR0YWNobWVudFRlc3RzLm1tOgorICAgICAgICAoLVtUZXN0 V0tXZWJWaWV3IGF0dGFjaG1lbnRFbGVtZW50U2l6ZV0pOgorICAgICAgICAoLVtUZXN0V0tXZWJW aWV3IHdhaXRGb3JBdHRhY2htZW50RWxlbWVudFNpemVUb0JlY29tZTpdKToKKyAgICAgICAgKFRl c3RXZWJLaXRBUEk6OlRFU1QpOgorICAgICAgICAocGxhdGZvcm1BdHRhY2htZW50SWNvbkVsZW1l bnRTaXplKTogRGVsZXRlZC4KKwogMjAxNy0xMS0yOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hz aWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbQXR0YWNobWVudCBTdXBwb3J0XSBJbXBsZW1lbnQg U1BJIGZvciBjbGllbnRzIHRvIG1ha2UgYW4gYXR0YWNobWVudCBlbGVtZW50IGRpc3BsYXkgaW4t cGxhY2UKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Ev V0tBdHRhY2htZW50VGVzdHMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL1dLQXR0YWNobWVudFRlc3RzLm1tCmluZGV4IDAwYTUwMzhkODQ4YmVmODU4ZjNiODBjM2Zh ZTdhNTFmNWIwODkzY2IuLmIzZGI3MzhkMWE0NWFmNjljNzk4YzFlYmM5MzE1ZWY4NGMzZTY2YzEg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tBdHRh Y2htZW50VGVzdHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2Nv YS9XS0F0dGFjaG1lbnRUZXN0cy5tbQpAQCAtMzQsMTUgKzM0LDYgQEAKIAogI2lmIFdLX0FQSV9F TkFCTEVECiAKLUNHU2l6ZSBwbGF0Zm9ybUF0dGFjaG1lbnRJY29uRWxlbWVudFNpemUoKQotewot I2lmIFBMQVRGT1JNKElPUykKLSAgICByZXR1cm4gQ0dTaXplTWFrZSgxNjAsIDExOSk7Ci0jZWxz ZQotICAgIHJldHVybiBDR1NpemVNYWtlKDYxLCA4OSk7Ci0jZW5kaWYKLX0KLQogQGludGVyZmFj ZSBBdHRhY2htZW50VXBkYXRlT2JzZXJ2ZXIgOiBOU09iamVjdCA8V0tVSURlbGVnYXRlUHJpdmF0 ZT4KIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgTlNBcnJheSAqaW5zZXJ0ZWQ7CiBA cHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIE5TQXJyYXkgKnJlbW92ZWQ7CkBAIC0xOTIs MTggKzE4MywyMiBAQCAtIChfV0tBdHRhY2htZW50ICopc3luY2hyb25vdXNseUluc2VydEF0dGFj aG1lbnRXaXRoRmlsZW5hbWU6KE5TU3RyaW5nICopZmlsZW5hbQogICAgIHJldHVybiBhdHRhY2ht ZW50LmF1dG9yZWxlYXNlKCk7CiB9CiAKKy0gKENHU2l6ZSlhdHRhY2htZW50RWxlbWVudFNpemUK K3sKKyAgICBfX2Jsb2NrIENHU2l6ZSBzaXplOworICAgIF9fYmxvY2sgYm9vbCBkb25lRXZhbHVh dGluZ1NjcmlwdCA9IGZhbHNlOworICAgIFtzZWxmIGV2YWx1YXRlSmF2YVNjcmlwdDpAInIgPSBk b2N1bWVudC5xdWVyeVNlbGVjdG9yKCdhdHRhY2htZW50JykuZ2V0Qm91bmRpbmdDbGllbnRSZWN0 KCk7IFtyLndpZHRoLCByLmhlaWdodF0iIGNvbXBsZXRpb25IYW5kbGVyOl4oTlNBcnJheTxOU051 bWJlciAqPiAqc2l6ZVJlc3VsdCwgTlNFcnJvciAqKSB7CisgICAgICAgIHNpemUgPSBDR1NpemVN YWtlKHNpemVSZXN1bHQuZmlyc3RPYmplY3QuZmxvYXRWYWx1ZSwgc2l6ZVJlc3VsdC5sYXN0T2Jq ZWN0LmZsb2F0VmFsdWUpOworICAgICAgICBkb25lRXZhbHVhdGluZ1NjcmlwdCA9IHRydWU7Cisg ICAgfV07CisgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lRXZhbHVhdGluZ1Njcmlw dCk7CisgICAgcmV0dXJuIHNpemU7Cit9CisKIC0gKHZvaWQpd2FpdEZvckF0dGFjaG1lbnRFbGVt ZW50U2l6ZVRvQmVjb21lOihDR1NpemUpZXhwZWN0ZWRTaXplCiB7CiAgICAgd2hpbGUgKFtbTlNS dW5Mb29wIGN1cnJlbnRSdW5Mb29wXSBydW5Nb2RlOk5TRGVmYXVsdFJ1bkxvb3BNb2RlIGJlZm9y ZURhdGU6W05TRGF0ZSBkaXN0YW50UGFzdF1dKSB7Ci0gICAgICAgIF9fYmxvY2sgYm9vbCBkb25l RXZhbHVhdGluZ1NjcmlwdCA9IGZhbHNlOwotICAgICAgICBfX2Jsb2NrIEJPT0wgc2l6ZUlzRXF1 YWwgPSBOTzsKLSAgICAgICAgW3NlbGYgZXZhbHVhdGVKYXZhU2NyaXB0OkAiciA9IGRvY3VtZW50 LnF1ZXJ5U2VsZWN0b3IoJ2F0dGFjaG1lbnQnKS5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKTsgW3Iu d2lkdGgsIHIuaGVpZ2h0XSIgY29tcGxldGlvbkhhbmRsZXI6XihOU0FycmF5PE5TTnVtYmVyICo+ ICpzaXplUmVzdWx0LCBOU0Vycm9yICopIHsKLSAgICAgICAgICAgIENHU2l6ZSBvYnNlcnZlZFNp emUgeyBzaXplUmVzdWx0LmZpcnN0T2JqZWN0LmZsb2F0VmFsdWUsIHNpemVSZXN1bHQubGFzdE9i amVjdC5mbG9hdFZhbHVlIH07Ci0gICAgICAgICAgICBzaXplSXNFcXVhbCA9IENHU2l6ZUVxdWFs VG9TaXplKGV4cGVjdGVkU2l6ZSwgb2JzZXJ2ZWRTaXplKTsKLSAgICAgICAgICAgIGRvbmVFdmFs dWF0aW5nU2NyaXB0ID0gdHJ1ZTsKLSAgICAgICAgfV07Ci0gICAgICAgIFRlc3RXZWJLaXRBUEk6 OlV0aWw6OnJ1bigmZG9uZUV2YWx1YXRpbmdTY3JpcHQpOwotICAgICAgICBpZiAoc2l6ZUlzRXF1 YWwpCisgICAgICAgIGlmIChDR1NpemVFcXVhbFRvU2l6ZShzZWxmLmF0dGFjaG1lbnRFbGVtZW50 U2l6ZSwgZXhwZWN0ZWRTaXplKSkKICAgICAgICAgICAgIGJyZWFrOwogICAgIH0KIH0KQEAgLTQ5 OSwxNSArNDk0LDE5IEBAIFRFU1QoV0tBdHRhY2htZW50VGVzdHMsIEluUGxhY2VJbWFnZUF0dGFj aG1lbnRUb2dnbGVEaXNwbGF5TW9kZSkKICAgICBSZXRhaW5QdHI8X1dLQXR0YWNobWVudD4gYXR0 YWNobWVudDsKICAgICB7CiAgICAgICAgIE9ic2VydmVBdHRhY2htZW50VXBkYXRlc0ZvclNjb3Bl IG9ic2VydmVyKHdlYlZpZXcuZ2V0KCkpOwotICAgICAgICBhdHRhY2htZW50ID0gcmV0YWluUHRy KFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlJbnNlcnRBdHRhY2htZW50V2l0aEZpbGVuYW1lOkAiaWNv bi5wbmciIGNvbnRlbnRUeXBlOkAiaW1hZ2UvcG5nIiBkYXRhOmltYWdlRGF0YS5nZXQoKSBvcHRp b25zOmRpc3BsYXlPcHRpb25zV2l0aE1vZGUoX1dLQXR0YWNobWVudERpc3BsYXlNb2RlSW5QbGFj ZSldKTsKLSAgICAgICAgb2JzZXJ2ZXIuZXhwZWN0QXR0YWNobWVudFVwZGF0ZXMoQFtdLCBAW2F0 dGFjaG1lbnQuZ2V0KCldKTsKKyAgICAgICAgYXR0YWNobWVudCA9IHJldGFpblB0cihbd2ViVmll dyBzeW5jaHJvbm91c2x5SW5zZXJ0QXR0YWNobWVudFdpdGhGaWxlbmFtZTpAImljb24ucG5nIiBj b250ZW50VHlwZTpAImltYWdlL3BuZyIgZGF0YTppbWFnZURhdGEuZ2V0KCkgb3B0aW9uczpkaXNw bGF5T3B0aW9uc1dpdGhNb2RlKF9XS0F0dGFjaG1lbnREaXNwbGF5TW9kZUFzSWNvbildKTsKICAg ICAgICAgW2F0dGFjaG1lbnQgZXhwZWN0UmVxdWVzdGVkRGF0YVRvQmU6aW1hZ2VEYXRhLmdldCgp XTsKLSAgICAgICAgW3dlYlZpZXcgd2FpdEZvckF0dGFjaG1lbnRFbGVtZW50U2l6ZVRvQmVjb21l OkNHU2l6ZU1ha2UoMjE1LCAxNzQpXTsKKyAgICAgICAgb2JzZXJ2ZXIuZXhwZWN0QXR0YWNobWVu dFVwZGF0ZXMoQFtdLCBAW2F0dGFjaG1lbnQuZ2V0KCldKTsKICAgICB9CisgICAgQ0dTaXplIGlj b25BdHRhY2htZW50U2l6ZSA9IFt3ZWJWaWV3IGF0dGFjaG1lbnRFbGVtZW50U2l6ZV07CisKKyAg ICBbYXR0YWNobWVudCBzeW5jaHJvbm91c2x5U2V0RGlzcGxheU9wdGlvbnM6ZGlzcGxheU9wdGlv bnNXaXRoTW9kZShfV0tBdHRhY2htZW50RGlzcGxheU1vZGVJblBsYWNlKSBlcnJvcjpuaWxdOwor ICAgIFthdHRhY2htZW50IGV4cGVjdFJlcXVlc3RlZERhdGFUb0JlOmltYWdlRGF0YS5nZXQoKV07 CisgICAgW3dlYlZpZXcgd2FpdEZvckF0dGFjaG1lbnRFbGVtZW50U2l6ZVRvQmVjb21lOkNHU2l6 ZU1ha2UoMjE1LCAxNzQpXTsKIAogICAgIFthdHRhY2htZW50IHN5bmNocm9ub3VzbHlTZXREaXNw bGF5T3B0aW9uczpkaXNwbGF5T3B0aW9uc1dpdGhNb2RlKF9XS0F0dGFjaG1lbnREaXNwbGF5TW9k ZUFzSWNvbikgZXJyb3I6bmlsXTsKICAgICBbYXR0YWNobWVudCBleHBlY3RSZXF1ZXN0ZWREYXRh VG9CZTppbWFnZURhdGEuZ2V0KCldOwotICAgIFt3ZWJWaWV3IHdhaXRGb3JBdHRhY2htZW50RWxl bWVudFNpemVUb0JlY29tZTpwbGF0Zm9ybUF0dGFjaG1lbnRJY29uRWxlbWVudFNpemUoKV07Cisg ICAgW3dlYlZpZXcgd2FpdEZvckF0dGFjaG1lbnRFbGVtZW50U2l6ZVRvQmVjb21lOmljb25BdHRh Y2htZW50U2l6ZV07CiAKICAgICBbYXR0YWNobWVudCBzeW5jaHJvbm91c2x5U2V0RGlzcGxheU9w dGlvbnM6ZGlzcGxheU9wdGlvbnNXaXRoTW9kZShfV0tBdHRhY2htZW50RGlzcGxheU1vZGVJblBs YWNlKSBlcnJvcjpuaWxdOwogICAgIFthdHRhY2htZW50IGV4cGVjdFJlcXVlc3RlZERhdGFUb0Jl OmltYWdlRGF0YS5nZXQoKV07Cg==