180191 2017-11-30 05:39:18 -0800 WebDriver: link and partial links queries don't work in xhtml documents 2017-12-01 01:52:23 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg webkit-bug-importer oldest_to_newest 1376281 0 cgarcia 2017-11-30 05:39:18 -0800 We convert the queries to use xpath, which works for html documents, but it doesn't work for xhtml. In case of xhtml we would need to provide a namespace resolver and elements would need to be prefixed with xhtml: I would be a lot easier to simply iterate the link elements and copare the text. 1376283 1 327971 cgarcia 2017-11-30 05:42:47 -0800 Created attachment 327971 Patch 1376587 2 327971 bburg 2017-11-30 15:53:29 -0800 Comment on attachment 327971 Patch r=me Oh well for trying to be clever! 1376757 3 cgarcia 2017-12-01 01:51:03 -0800 Committed r225388: <https://trac.webkit.org/changeset/225388> 1376758 4 webkit-bug-importer 2017-12-01 01:52:23 -0800 <rdar://problem/35793604> 327971 2017-11-30 05:42:47 -0800 2017-11-30 15:53:29 -0800 Patch wd-link-queries.diff text/plain 4465 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYTdmMDY0MjdmZmYuLjRhMjJmYTgxYmExIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDI3IEBACisyMDE3LTExLTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGxpbmsgYW5kIHBhcnRpYWwgbGlua3MgcXVlcmll cyBkb24ndCB3b3JrIGluIHhodG1sIGRvY3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY29udmVydCB0aGUgcXVlcmllcyB0byB1c2UgeHBh dGgsIHdoaWNoIHdvcmtzIGZvciBodG1sIGRvY3VtZW50cywgYnV0IGl0IGRvZXNuJ3Qgd29yayBm b3IgeGh0bWwuIEluIGNhc2Ugb2YKKyAgICAgICAgeGh0bWwgd2Ugd291bGQgbmVlZCB0byBwcm92 aWRlIGEgbmFtZXNwYWNlIHJlc29sdmVyIGFuZCBlbGVtZW50cyB3b3VsZCBuZWVkIHRvIGJlIHBy ZWZpeGVkIHdpdGggJ3hodG1sOicuIEl0J3MKKyAgICAgICAgZWFzaWVyIHRvIHNpbXBseSBpdGVy YXRlIHRoZSBsaW5rIGVsZW1lbnRzIGFuZCBjb21wYXJlIHRoZSB0ZXh0LgorCisgICAgICAgIEZp eGVzOiBpbXBvcnRlZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL3JldHJpZXZhbC9maW5kX2VsZW1lbnRf ZnJvbV9lbGVtZW50LnB5Ojp0ZXN0X3hodG1sX25hbWVzcGFjZVtsaW5rIHRleHQtZnVsbCBsaW5r IHRleHRdCisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL3JldHJp ZXZhbC9maW5kX2VsZW1lbnRfZnJvbV9lbGVtZW50LnB5Ojp0ZXN0X3hodG1sX25hbWVzcGFjZVtw YXJ0aWFsIGxpbmsgdGV4dC1saW5rIHRleHRdCisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mv d2ViZHJpdmVyL3Rlc3RzL3JldHJpZXZhbC9maW5kX2VsZW1lbnRfZnJvbV9lbGVtZW50cy5weTo6 dGVzdF94aHRtbF9uYW1lc3BhY2VbbGluayB0ZXh0LWZ1bGwgbGluayB0ZXh0XQorICAgICAgICAg ICAgICAgaW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9yZXRyaWV2YWwvZmluZF9lbGVtZW50 X2Zyb21fZWxlbWVudHMucHk6OnRlc3RfeGh0bWxfbmFtZXNwYWNlW3BhcnRpYWwgbGluayB0ZXh0 LWxpbmsgdGV4dF0KKyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMv cmV0cmlldmFsL2ZpbmRfZWxlbWVudC5weTo6dGVzdF94aHRtbF9uYW1lc3BhY2VbbGluayB0ZXh0 LWZ1bGwgbGluayB0ZXh0XQorICAgICAgICAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90 ZXN0cy9yZXRyaWV2YWwvZmluZF9lbGVtZW50LnB5Ojp0ZXN0X3hodG1sX25hbWVzcGFjZVtwYXJ0 aWFsIGxpbmsgdGV4dC1saW5rIHRleHRdCisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2Vi ZHJpdmVyL3Rlc3RzL3JldHJpZXZhbC9maW5kX2VsZW1lbnRzLnB5Ojp0ZXN0X3hodG1sX25hbWVz cGFjZVtsaW5rIHRleHQtZnVsbCBsaW5rIHRleHRdCisgICAgICAgICAgICAgICBpbXBvcnRlZC93 M2Mvd2ViZHJpdmVyL3Rlc3RzL3JldHJpZXZhbC9maW5kX2VsZW1lbnRzLnB5Ojp0ZXN0X3hodG1s X25hbWVzcGFjZVtwYXJ0aWFsIGxpbmsgdGV4dC1saW5rIHRleHRdCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQXV0b21hdGlvbi9hdG9tcy9GaW5kTm9kZXMuanM6CisgICAgICAgIChzd2l0Y2gpOgor ICAgICAgICAodHJ5VG9GaW5kTm9kZSk6CisKIDIwMTctMTEtMjMgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFdlYkRyaXZlcjogaGFuZGxlIHVz ZXIgcHJvbXB0cyBzaG93biB3aGlsZSBleGVjdXRpbmcgc2NyaXB0cwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9hdG9tcy9GaW5kTm9kZXMuanMgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL2F0b21zL0ZpbmROb2Rlcy5qcwppbmRleCBh ZTAyNjU5OWYyNi4uZTM2YTE0ZmI0N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0F1dG9tYXRpb24vYXRvbXMvRmluZE5vZGVzLmpzCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0F1dG9tYXRpb24vYXRvbXMvRmluZE5vZGVzLmpzCkBAIC0zNSwxOCArMzUsMTIgQEAg ZnVuY3Rpb24oc3RyYXRlZ3ksIGFuY2VzdG9yRWxlbWVudCwgcXVlcnksIGZpcnN0UmVzdWx0T25s eSwgdGltZW91dER1cmF0aW9uLCBjYWwKICAgICAgICAgc3RyYXRlZ3kgPSAiY3NzIHNlbGVjdG9y IjsKICAgICAgICAgcXVlcnkgPSAiW25hbWU9XCIiICsgZXNjYXBlKHF1ZXJ5KSArICJcIl0iOwog ICAgICAgICBicmVhazsKLSAgICBjYXNlICJsaW5rIHRleHQiOgotICAgICAgICBzdHJhdGVneSA9 ICJ4cGF0aCI7Ci0gICAgICAgIHF1ZXJ5ID0gIi4vL2FbQGhyZWZdW25vcm1hbGl6ZS1zcGFjZShk ZXNjZW5kYW50LW9yLXNlbGY6OnRleHQoKSkgPSBcIiIgKyBlc2NhcGUocXVlcnkpICsgIlwiXSI7 Ci0gICAgICAgIGJyZWFrOwotICAgIGNhc2UgInBhcnRpYWwgbGluayB0ZXh0IjoKLSAgICAgICAg c3RyYXRlZ3kgPSAieHBhdGgiOwotICAgICAgICBxdWVyeSA9ICIuLy9hW0BocmVmXVtjb250YWlu cyhub3JtYWxpemUtc3BhY2UoZGVzY2VuZGFudC1vci1zZWxmOjp0ZXh0KCkpLCBcIiIgKyBlc2Nh cGUocXVlcnkpICsgIlwiKV0iOwotICAgICAgICBicmVhazsKICAgICB9CiAKICAgICBzd2l0Y2gg KHN0cmF0ZWd5KSB7CiAgICAgY2FzZSAiY3NzIHNlbGVjdG9yIjoKKyAgICBjYXNlICJsaW5rIHRl eHQiOgorICAgIGNhc2UgInBhcnRpYWwgbGluayB0ZXh0IjoKICAgICBjYXNlICJ0YWcgbmFtZSI6 CiAgICAgY2FzZSAiY2xhc3MgbmFtZSI6CiAgICAgY2FzZSAieHBhdGgiOgpAQCAtNzAsNiArNjQs MzIgQEAgZnVuY3Rpb24oc3RyYXRlZ3ksIGFuY2VzdG9yRWxlbWVudCwgcXVlcnksIGZpcnN0UmVz dWx0T25seSwgdGltZW91dER1cmF0aW9uLCBjYWwKICAgICAgICAgICAgICAgICAgICAgcmV0dXJu IGFuY2VzdG9yRWxlbWVudC5xdWVyeVNlbGVjdG9yKHF1ZXJ5KSB8fCBudWxsOwogICAgICAgICAg ICAgICAgIHJldHVybiBBcnJheS5mcm9tKGFuY2VzdG9yRWxlbWVudC5xdWVyeVNlbGVjdG9yQWxs KHF1ZXJ5KSk7CiAKKyAgICAgICAgICAgIGNhc2UgImxpbmsgdGV4dCI6CisgICAgICAgICAgICAg ICAgbGV0IGxpbmtUZXh0UmVzdWx0ID0gW107CisgICAgICAgICAgICAgICAgZm9yIChsZXQgbGlu ayBvZiBhbmNlc3RvckVsZW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoImEiKSkgeworICAgICAg ICAgICAgICAgICAgICBpZiAobGluay50ZXh0LnRyaW0oKSA9PSBxdWVyeSkgeworICAgICAgICAg ICAgICAgICAgICAgICAgbGlua1RleHRSZXN1bHQucHVzaChsaW5rKTsKKyAgICAgICAgICAgICAg ICAgICAgICAgIGlmIChmaXJzdFJlc3VsdE9ubHkpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYnJlYWs7CisgICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICB9CisgICAg ICAgICAgICAgICAgaWYgKGZpcnN0UmVzdWx0T25seSkKKyAgICAgICAgICAgICAgICAgICAgcmV0 dXJuIGxpbmtUZXh0UmVzdWx0WzBdIHx8IG51bGw7CisgICAgICAgICAgICAgICAgcmV0dXJuIGxp bmtUZXh0UmVzdWx0OworCisgICAgICAgICAgICBjYXNlICJwYXJ0aWFsIGxpbmsgdGV4dCI6Cisg ICAgICAgICAgICAgICAgbGV0IHBhcnRpYWxMaW5rUmVzdWx0ID0gW107CisgICAgICAgICAgICAg ICAgZm9yIChsZXQgbGluayBvZiBhbmNlc3RvckVsZW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUo ImEiKSkgeworICAgICAgICAgICAgICAgICAgICBpZiAobGluay50ZXh0LmluY2x1ZGVzKHF1ZXJ5 KSkgeworICAgICAgICAgICAgICAgICAgICAgICAgcGFydGlhbExpbmtSZXN1bHQucHVzaChsaW5r KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGlmIChmaXJzdFJlc3VsdE9ubHkpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgICAgIH0KKyAgICAg ICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgaWYgKGZpcnN0UmVzdWx0T25seSkKKyAgICAg ICAgICAgICAgICAgICAgcmV0dXJuIHBhcnRpYWxMaW5rUmVzdWx0WzBdIHx8IG51bGw7CisgICAg ICAgICAgICAgICAgcmV0dXJuIHBhcnRpYWxMaW5rUmVzdWx0OworCiAgICAgICAgICAgICBjYXNl ICJ0YWcgbmFtZSI6CiAgICAgICAgICAgICAgICAgbGV0IHRhZ05hbWVSZXN1bHQgPSBhbmNlc3Rv ckVsZW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUocXVlcnkpOwogICAgICAgICAgICAgICAgIGlm IChmaXJzdFJlc3VsdE9ubHkpCg==