180188 2017-11-30 03:34:49 -0800 Build fails on x86_64 and arm64 with BMalloc disabled 2017-12-06 02:58:44 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tpopela tpopela annulen benjamin cdumez cgarcia cmarcelo dbates ews-watchlist fpizlo mark.lam tpopela webkit-bug-importer oldest_to_newest 1376263 0 tpopela 2017-11-30 03:34:49 -0800 In file included from /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource61.cpp:4:0: /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: In member function 'JSC::B3::Value* JSC::FTL::{anonymous}::LowerDFGToB3::caged(Gigacage::Kind, JSC::FTL::LValue)': /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:12325:24: error: 'isEnabled' is not a member of 'Gigacage' if (!Gigacage::isEnabled(kind)) ^~~~~~~~~ We are missing the isEnabled(Kind) method in Source/WTF/wtf/Gigacage.h. 1376264 1 tpopela 2017-11-30 03:45:50 -0800 And one more failure: /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:12335:66: error: invalid initialization of reference of type 'Gigacage::BasePtrs&' from expression of type 'Gigacage::Kind' LValue basePtr = m_out.constIntPtr(Gigacage::basePtr(kind)); ^ In file included from /builddir/build/BUILD/webkitgtk-2.19.2/Source/WTF/wtf/CagedPtr.h:28:0, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/runtime/ArrayBuffer.h:31, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/heap/Heap.h:24, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/heap/DeferGC.h:29, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/runtime/ConcurrentJSLock.h:28, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/bytecode/ArrayProfile.h:28, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/bytecode/CodeBlock.h:32, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/jit/AssemblyHelpers.h:30, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/jit/CCallHelpers.h:30, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLazySlowPath.h:30, from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLazySlowPath.cpp:27, from /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource61.cpp:1: /builddir/build/BUILD/webkitgtk-2.19.2/Source/WTF/wtf/Gigacage.h:81:22: note: in passing argument 1 of 'void*& Gigacage::basePtr(Gigacage::BasePtrs&, Gigacage::Kind)' ALWAYS_INLINE void*& basePtr(BasePtrs& basePtrs, Kind kind) ^~~~~~~ 1376268 2 327966 tpopela 2017-11-30 03:57:49 -0800 Created attachment 327966 Patch 1376273 3 327966 tpopela 2017-11-30 04:02:08 -0800 Comment on attachment 327966 Patch There is another failure while linking: ../../../lib/libjavascriptcoregtk-4.0.so.18.7.1: error: undefined reference to 'g_gigacageBasePtrs' 1376317 4 327976 tpopela 2017-11-30 07:35:40 -0800 Created attachment 327976 Patch 1376318 5 ews-watchlist 2017-11-30 07:38:19 -0800 Attachment 327976 did not pass style-queue: ERROR: Source/WTF/wtf/Gigacage.cpp:35: g_gigacageBasePtrs is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1377610 6 327976 tpopela 2017-12-03 22:26:20 -0800 Comment on attachment 327976 Patch Clearing flags on attachment: 327976 Committed r225471: <https://trac.webkit.org/changeset/225471> 1377611 7 tpopela 2017-12-03 22:26:25 -0800 All reviewed patches have been landed. Closing bug. 1377612 8 webkit-bug-importer 2017-12-03 22:28:42 -0800 <rdar://problem/35823524> 1378578 9 327976 annulen 2017-12-06 02:58:44 -0800 Comment on attachment 327976 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327976&action=review > Source/WTF/wtf/Gigacage.cpp:35 > +char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE]; In Gigacage.h there is different definition extern "C" { extern WTF_EXPORTDATA char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE]; } 327966 2017-11-30 03:57:49 -0800 2017-11-30 07:35:37 -0800 Patch bug-180188-20171130125747.patch text/plain 1310 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ4ZjFmNjU0ZWMzOTJmMmE3NjFlZDNl MjU2MDNhZDBiZWM0MGI1YmIuLjM2MWFjZDIzZThlNTEyYmVjMTZiYTRjMTY4OGUzNzA4NTU1MDEw ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMTEtMzAgIFRvbWFzIFBvcGVsYSAgPHRwb3Bl bGFAcmVkaGF0LmNvbT4KKworICAgICAgICBCdWlsZCBmYWlscyBvbiB4ODZfNjQgYW5kIGFybTY0 IHdpdGggQk1hbGxvYyBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgwMTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgbWV0aG9kcyBpbiBXVEYncyBHaWdhY2FnZS5oLgor CisgICAgICAgICogd3RmL0dpZ2FjYWdlLmg6CisgICAgICAgIChHaWdhY2FnZTo6YmFzZVB0cik6 CisgICAgICAgIChHaWdhY2FnZTo6aXNFbmFibGVkKToKKwogMjAxNy0xMS0yOSAgSkYgQmFzdGll biAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKICAgICAgICAgV1RGIC8gYm1hbGxvYzogZG9uJ3Qg d3JpdGUgdG8gMHhiYmFkYmVlZiB3aGVuIEFTQU4gaXMgbG9va2luZwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvR2lnYWNhZ2UuaCBiL1NvdXJjZS9XVEYvd3RmL0dpZ2FjYWdlLmgKaW5kZXgg Y2U4NGUzMmZiMzc0MjA3ZDgzMmQ0MTRhNjNhOTg0ZjFiYjI2MTQ0OC4uYjI3ZjNjNGYzMzM1NzRl ZTI4ZGEwNDY5MjA5ZjQ0N2NiNGE4MWMzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvR2ln YWNhZ2UuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9HaWdhY2FnZS5oCkBAIC05Nyw2ICs5NywxNiBA QCBBTFdBWVNfSU5MSU5FIEJhc2VQdHJzJiBiYXNlUHRycygpCiAgICAgcmV0dXJuICpyZWludGVy cHJldF9jYXN0PEJhc2VQdHJzKj4oZ19naWdhY2FnZUJhc2VQdHJzKTsKIH0KIAorQUxXQVlTX0lO TElORSB2b2lkKiYgYmFzZVB0cihLaW5kIGtpbmQpCit7CisgICAgcmV0dXJuIGJhc2VQdHIoYmFz ZVB0cnMoKSwga2luZCk7Cit9CisKK0FMV0FZU19JTkxJTkUgYm9vbCBpc0VuYWJsZWQoS2luZCBr aW5kKQoreworICAgIHJldHVybiAhIWJhc2VQdHIoa2luZCk7Cit9CisKIEFMV0FZU19JTkxJTkUg c2l6ZV90IG1hc2soS2luZCkgeyByZXR1cm4gMDsgfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgo= 327976 2017-11-30 07:35:40 -0800 2017-12-03 22:26:20 -0800 Patch bug-180188-20171130163539.patch text/plain 1815 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ4ZjFmNjU0ZWMzOTJmMmE3NjFlZDNl MjU2MDNhZDBiZWM0MGI1YmIuLjc5ZWRiZmQ1OTA0MjVjMGY5MzY1ODczZjJkOTM3YmMwZThjYzQ4 ODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMTEtMzAgIFRvbWFzIFBvcGVsYSAgPHRwb3Bl bGFAcmVkaGF0LmNvbT4KKworICAgICAgICBCdWlsZCBmYWlscyBvbiB4ODZfNjQgYW5kIGFybTY0 IHdpdGggQk1hbGxvYyBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgwMTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgbWV0aG9kcyBpbiBXVEYncyBHaWdhY2FnZS5oIGFu ZCBmaXggZ19naWdhY2FnZUJhc2VQdHIKKyAgICAgICAgZGVmaW5pdGlvbi4KKworICAgICAgICAq IHd0Zi9HaWdhY2FnZS5jcHA6CisgICAgICAgICogd3RmL0dpZ2FjYWdlLmg6CisgICAgICAgIChH aWdhY2FnZTo6YmFzZVB0cik6CisgICAgICAgIChHaWdhY2FnZTo6aXNFbmFibGVkKToKKwogMjAx Ny0xMS0yOSAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKICAgICAgICAgV1RG IC8gYm1hbGxvYzogZG9uJ3Qgd3JpdGUgdG8gMHhiYmFkYmVlZiB3aGVuIEFTQU4gaXMgbG9va2lu ZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvR2lnYWNhZ2UuY3BwIGIvU291cmNlL1dURi93 dGYvR2lnYWNhZ2UuY3BwCmluZGV4IGVhM2VjYzZhMjE2NTA1M2I5YWFkOWRkNWM2ZTQyMjYzZDM4 MDU5YjcuLjQ4YzIyMDJlNTE0ZWY2YjNkZjc1NTlkYmUzMTBkMWYyYjI4OTcxMGUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL0dpZ2FjYWdlLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9HaWdh Y2FnZS5jcHAKQEAgLTMyLDkgKzMyLDcgQEAKIAogI2lmIGRlZmluZWQoVVNFX1NZU1RFTV9NQUxM T0MpICYmIFVTRV9TWVNURU1fTUFMTE9DCiAKLWV4dGVybiAiQyIgewotdm9pZCogZ19naWdhY2Fn ZUJhc2VQdHI7Ci19CitjaGFyIGdfZ2lnYWNhZ2VCYXNlUHRyc1tHSUdBQ0FHRV9CQVNFX1BUUlNf U0laRV07CiAKIG5hbWVzcGFjZSBHaWdhY2FnZSB7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL0dpZ2FjYWdlLmggYi9Tb3VyY2UvV1RGL3d0Zi9HaWdhY2FnZS5oCmluZGV4IGNlODRlMzJm YjM3NDIwN2Q4MzJkNDE0YTYzYTk4NGYxYmIyNjE0NDguLmIyN2YzYzRmMzMzNTc0ZWUyOGRhMDQ2 OTIwOWY0NDdjYjRhODFjMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0dpZ2FjYWdlLmgK KysrIGIvU291cmNlL1dURi93dGYvR2lnYWNhZ2UuaApAQCAtOTcsNiArOTcsMTYgQEAgQUxXQVlT X0lOTElORSBCYXNlUHRycyYgYmFzZVB0cnMoKQogICAgIHJldHVybiAqcmVpbnRlcnByZXRfY2Fz dDxCYXNlUHRycyo+KGdfZ2lnYWNhZ2VCYXNlUHRycyk7CiB9CiAKK0FMV0FZU19JTkxJTkUgdm9p ZComIGJhc2VQdHIoS2luZCBraW5kKQoreworICAgIHJldHVybiBiYXNlUHRyKGJhc2VQdHJzKCks IGtpbmQpOworfQorCitBTFdBWVNfSU5MSU5FIGJvb2wgaXNFbmFibGVkKEtpbmQga2luZCkKK3sK KyAgICByZXR1cm4gISFiYXNlUHRyKGtpbmQpOworfQorCiBBTFdBWVNfSU5MSU5FIHNpemVfdCBt YXNrKEtpbmQpIHsgcmV0dXJuIDA7IH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4K