180187 2017-11-30 03:17:24 -0800 WebDriver: locator strategy should be validated before trying to find elements 2017-11-30 05:50:26 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez webkit-bug-importer oldest_to_newest 1376258 0 cgarcia 2017-11-30 03:17:24 -0800 We currently rely on the js atom to raise an exception in case the locator strategy is not valid, but in case of find element from element, if the element doesn't exist we fail with stale element error instead of invalid argument as expected. So, let's validate the strategies when parsing them, which would also avoid going to the browser in cae of invalid strategy. 1376259 1 327964 cgarcia 2017-11-30 03:19:20 -0800 Created attachment 327964 Patch 1376287 2 cgarcia 2017-11-30 05:48:56 -0800 Committed r225326: <https://trac.webkit.org/changeset/225326> 1376288 3 webkit-bug-importer 2017-11-30 05:50:26 -0800 <rdar://problem/35771142> 327964 2017-11-30 03:19:20 -0800 2017-11-30 03:37:37 -0800 Patch wd-invalid-using.diff text/plain 2394 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggZTY1ZTUzYjgxOTcuLmExMmVjMmQ3MzQwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTExLTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGxvY2F0b3Igc3RyYXRlZ3kg c2hvdWxkIGJlIHZhbGlkYXRlZCBiZWZvcmUgdHJ5aW5nIHRvIGZpbmQgZWxlbWVudHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDE4NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGN1cnJlbnRseSBy ZWx5IG9uIHRoZSBqcyBhdG9tIHRvIHJhaXNlIGFuIGV4Y2VwdGlvbiBpbiBjYXNlIHRoZSBsb2Nh dG9yIHN0cmF0ZWd5IGlzIG5vdCB2YWxpZCwgYnV0IGluIGNhc2Ugb2YKKyAgICAgICAgZmluZCBl bGVtZW50IGZyb20gZWxlbWVudCwgaWYgdGhlIGVsZW1lbnQgZG9lc24ndCBleGlzdCB3ZSBmYWls IHdpdGggc3RhbGUgZWxlbWVudCBlcnJvciBpbnN0ZWFkIG9mIGludmFsaWQKKyAgICAgICAgYXJn dW1lbnQgYXMgZXhwZWN0ZWQuIFNvLCBsZXQncyB2YWxpZGF0ZSB0aGUgc3RyYXRlZ2llcyB3aGVu IHBhcnNpbmcgdGhlbSwgd2hpY2ggd291bGQgYWxzbyBhdm9pZCBnb2luZyB0byB0aGUKKyAgICAg ICAgYnJvd3NlciBpbiBjYWUgb2YgaW52YWxpZCBzdHJhdGVneS4KKworICAgICAgICBGaXhlczog aW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9yZXRyaWV2YWwvZmluZF9lbGVtZW50X2Zyb21f ZWxlbWVudC5weTo6dGVzdF9pbnZhbGlkX3VzaW5nX2FyZ3VtZW50W2FdCisKKyAgICAgICAgKiBX ZWJEcml2ZXJTZXJ2aWNlLmNwcDoKKyAgICAgICAgKFdlYkRyaXZlcjo6aXNWYWxpZFN0cmF0ZWd5 KToKKyAgICAgICAgKFdlYkRyaXZlcjo6ZmluZFN0cmF0ZWd5QW5kU2VsZWN0b3JPckNvbXBsZXRl V2l0aEVycm9yKToKKwogMjAxNy0xMS0zMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViRHJpdmVyOiByZW1vdmUgZWxlbWVudFN1Ym1pdCBj b21tYW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3Bw IGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcAppbmRleCBjN2IxMTYzYmZm ZS4uZTcwMTJjOTdiM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2Vy dmljZS5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcApAQCAt OTkzLDkgKzk5MywyMCBAQCBzdGF0aWMgc3RkOjpvcHRpb25hbDxTdHJpbmc+IGZpbmRFbGVtZW50 T3JDb21wbGV0ZVdpdGhFcnJvcihKU09OOjpPYmplY3QmIHBhcmFtZQogICAgIHJldHVybiBlbGVt ZW50SUQ7CiB9CiAKK3N0YXRpYyBpbmxpbmUgYm9vbCBpc1ZhbGlkU3RyYXRlZ3koY29uc3QgU3Ry aW5nJiBzdHJhdGVneSkKK3sKKyAgICAvLyDCpzEyLjEgTG9jYXRvciBTdHJhdGVnaWVzLgorICAg IC8vIGh0dHBzOi8vdzNjLmdpdGh1Yi5pby93ZWJkcml2ZXIvd2ViZHJpdmVyLXNwZWMuaHRtbCNk Zm4tdGFibGUtb2YtbG9jYXRpb24tc3RyYXRlZ2llcworICAgIHJldHVybiBzdHJhdGVneSA9PSAi Y3NzIHNlbGVjdG9yIgorICAgICAgICB8fCBzdHJhdGVneSA9PSAibGluayB0ZXh0IgorICAgICAg ICB8fCBzdHJhdGVneSA9PSAicGFydGlhbCBsaW5rIHRleHQiCisgICAgICAgIHx8IHN0cmF0ZWd5 ID09ICJ0YWcgbmFtZSIKKyAgICAgICAgfHwgc3RyYXRlZ3kgPT0gInhwYXRoIjsKK30KKwogc3Rh dGljIGJvb2wgZmluZFN0cmF0ZWd5QW5kU2VsZWN0b3JPckNvbXBsZXRlV2l0aEVycm9yKEpTT046 Ok9iamVjdCYgcGFyYW1ldGVycywgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mIGNv bXBsZXRpb25IYW5kbGVyLCBTdHJpbmcmIHN0cmF0ZWd5LCBTdHJpbmcmIHNlbGVjdG9yKQogewot ICAgIGlmICghcGFyYW1ldGVycy5nZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJ1c2luZyIpLCBzdHJh dGVneSkpIHsKKyAgICBpZiAoIXBhcmFtZXRlcnMuZ2V0U3RyaW5nKEFTQ0lJTGl0ZXJhbCgidXNp bmciKSwgc3RyYXRlZ3kpIHx8ICFpc1ZhbGlkU3RyYXRlZ3koc3RyYXRlZ3kpKSB7CiAgICAgICAg IGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJlc3VsdDo6RXJy b3JDb2RlOjpJbnZhbGlkQXJndW1lbnQpKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0K