180186 2017-11-30 02:45:01 -0800 WebDriver: remove elementSubmit command 2017-11-30 05:48:32 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez webkit-bug-importer oldest_to_newest 1376255 0 cgarcia 2017-11-30 02:45:01 -0800 It's not in the spec, we had it only because selenium used it, but now it uses execute_script with custom code to implement submit, so we can just remove it. 1376256 1 327962 cgarcia 2017-11-30 02:46:23 -0800 Created attachment 327962 Patch 1376285 2 cgarcia 2017-11-30 05:47:28 -0800 Committed r225325: <https://trac.webkit.org/changeset/225325> 1376286 3 webkit-bug-importer 2017-11-30 05:48:32 -0800 <rdar://problem/35771129> 327962 2017-11-30 02:46:23 -0800 2017-11-30 03:38:07 -0800 Patch wd-submit-command.diff text/plain 6394 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggY2MzNzcwYzhlYzQuLmU2NWU1M2I4MTk3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTExLTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IHJlbW92ZSBlbGVtZW50U3Vi bWl0IGNvbW1hbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4MDE4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEl0J3Mgbm90IGluIHRoZSBzcGVjLCB3ZSBoYWQgaXQgb25seSBiZWNhdXNlIHNlbGVuaXVt IHVzZWQgaXQsIGJ1dCBub3cgaXQgdXNlcyBleGVjdXRlX3NjcmlwdCB3aXRoIGN1c3RvbSBjb2Rl CisgICAgICAgIHRvIGltcGxlbWVudCBzdWJtaXQsIHNvIHdlIGNhbiBqdXN0IHJlbW92ZSBpdC4K KworICAgICAgICAqIFNlc3Npb24uY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpTZXNzaW9uOjpl bGVtZW50U3VibWl0KTogRGVsZXRlZC4KKyAgICAgICAgKiBTZXNzaW9uLmg6CisgICAgICAgICog V2ViRHJpdmVyU2VydmljZS5jcHA6CisgICAgICAgIChXZWJEcml2ZXI6OldlYkRyaXZlclNlcnZp Y2U6OmVsZW1lbnRTdWJtaXQpOiBEZWxldGVkLgorICAgICAgICAqIFdlYkRyaXZlclNlcnZpY2Uu aDoKKwogMjAxNy0xMS0yOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgV2ViRHJpdmVyOiBpbXBsZW1lbnQgc3RhdHVzIGNvbW1hbmQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nl c3Npb24uY3BwCmluZGV4IDUyMzgyZTQ5NzQ1Li45YTg5MWM1NDYwNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24u Y3BwCkBAIC0xNjI3LDM3ICsxNjI3LDYgQEAgdm9pZCBTZXNzaW9uOjplbGVtZW50U2VuZEtleXMo Y29uc3QgU3RyaW5nJiBlbGVtZW50SUQsIFZlY3RvcjxTdHJpbmc+JiYga2V5cywgRnUKICAgICB9 KTsKIH0KIAotdm9pZCBTZXNzaW9uOjplbGVtZW50U3VibWl0KGNvbnN0IFN0cmluZyYgZWxlbWVu dElELCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiYmIGNvbXBsZXRpb25IYW5kbGVy KQotewotICAgIGlmICghbV90b3BsZXZlbEJyb3dzaW5nQ29udGV4dCkgewotICAgICAgICBjb21w bGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVycm9yQ29k ZTo6Tm9TdWNoV2luZG93KSk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICBoYW5kbGVV c2VyUHJvbXB0cyhbdGhpcywgZWxlbWVudElELCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUo Y29tcGxldGlvbkhhbmRsZXIpXShDb21tYW5kUmVzdWx0JiYgcmVzdWx0KSBtdXRhYmxlIHsKLSAg ICAgICAgaWYgKHJlc3VsdC5pc0Vycm9yKCkpIHsKLSAgICAgICAgICAgIGNvbXBsZXRpb25IYW5k bGVyKFdURk1vdmUocmVzdWx0KSk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLSAg ICAgICAgUmVmUHRyPEpTT046OkFycmF5PiBhcmd1bWVudHMgPSBKU09OOjpBcnJheTo6Y3JlYXRl KCk7Ci0gICAgICAgIGFyZ3VtZW50cy0+cHVzaFN0cmluZyhjcmVhdGVFbGVtZW50KGVsZW1lbnRJ RCktPnRvSlNPTlN0cmluZygpKTsKLQotICAgICAgICBSZWZQdHI8SlNPTjo6T2JqZWN0PiBwYXJh bWV0ZXJzID0gSlNPTjo6T2JqZWN0OjpjcmVhdGUoKTsKLSAgICAgICAgcGFyYW1ldGVycy0+c2V0 U3RyaW5nKEFTQ0lJTGl0ZXJhbCgiYnJvd3NpbmdDb250ZXh0SGFuZGxlIiksIG1fdG9wbGV2ZWxC cm93c2luZ0NvbnRleHQudmFsdWUoKSk7Ci0gICAgICAgIGlmIChtX2N1cnJlbnRCcm93c2luZ0Nv bnRleHQpCi0gICAgICAgICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJm cmFtZUhhbmRsZSIpLCBtX2N1cnJlbnRCcm93c2luZ0NvbnRleHQudmFsdWUoKSk7Ci0gICAgICAg IHBhcmFtZXRlcnMtPnNldFN0cmluZyhBU0NJSUxpdGVyYWwoImZ1bmN0aW9uIiksIEZvcm1TdWJt aXRKYXZhU2NyaXB0KTsKLSAgICAgICAgcGFyYW1ldGVycy0+c2V0QXJyYXkoQVNDSUlMaXRlcmFs KCJhcmd1bWVudHMiKSwgV1RGTW92ZShhcmd1bWVudHMpKTsKLSAgICAgICAgbV9ob3N0LT5zZW5k Q29tbWFuZFRvQmFja2VuZChBU0NJSUxpdGVyYWwoImV2YWx1YXRlSmF2YVNjcmlwdEZ1bmN0aW9u IiksIFdURk1vdmUocGFyYW1ldGVycyksIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigq dGhpcyksIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildKFNl c3Npb25Ib3N0OjpDb21tYW5kUmVzcG9uc2UmJiByZXNwb25zZSkgewotICAgICAgICAgICAgaWYg KHJlc3BvbnNlLmlzRXJyb3IpIHsKLSAgICAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihD b21tYW5kUmVzdWx0OjpmYWlsKFdURk1vdmUocmVzcG9uc2UucmVzcG9uc2VPYmplY3QpKSk7Ci0g ICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgfQotICAgICAgICAgICAgY29tcGxl dGlvbkhhbmRsZXIoQ29tbWFuZFJlc3VsdDo6c3VjY2VzcygpKTsKLSAgICAgICAgfSk7Ci0gICAg fSk7Ci19Ci0KIFJlZlB0cjxKU09OOjpWYWx1ZT4gU2Vzc2lvbjo6aGFuZGxlU2NyaXB0UmVzdWx0 KFJlZlB0cjxKU09OOjpWYWx1ZT4mJiByZXN1bHRWYWx1ZSkKIHsKICAgICBSZWZQdHI8SlNPTjo6 QXJyYXk+IHJlc3VsdEFycmF5OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZlci9TZXNzaW9u LmggYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uaAppbmRleCAxMGNmM2E3ZDYyNC4uYTRkOTQw YzgxMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5oCisrKyBiL1NvdXJj ZS9XZWJEcml2ZXIvU2Vzc2lvbi5oCkBAIC05NSw3ICs5NSw2IEBAIHB1YmxpYzoKICAgICB2b2lk IGVsZW1lbnRDbGljayhjb25zdCBTdHJpbmcmIGVsZW1lbnRJRCwgRnVuY3Rpb248dm9pZCAoQ29t bWFuZFJlc3VsdCYmKT4mJik7CiAgICAgdm9pZCBlbGVtZW50Q2xlYXIoY29uc3QgU3RyaW5nJiBl bGVtZW50SUQsIEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYpOwogICAgIHZvaWQg ZWxlbWVudFNlbmRLZXlzKGNvbnN0IFN0cmluZyYgZWxlbWVudElELCBWZWN0b3I8U3RyaW5nPiYm IGtleXMsIEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYpOwotICAgIHZvaWQgZWxl bWVudFN1Ym1pdChjb25zdCBTdHJpbmcmIGVsZW1lbnRJRCwgRnVuY3Rpb248dm9pZCAoQ29tbWFu ZFJlc3VsdCYmKT4mJik7CiAgICAgdm9pZCBleGVjdXRlU2NyaXB0KGNvbnN0IFN0cmluZyYgc2Ny aXB0LCBSZWZQdHI8SlNPTjo6QXJyYXk+JiYgYXJndW1lbnRzLCBFeGVjdXRlU2NyaXB0TW9kZSwg RnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7CiAgICAgdm9pZCBnZXRBbGxDb29r aWVzKEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYpOwogICAgIHZvaWQgZ2V0TmFt ZWRDb29raWUoY29uc3QgU3RyaW5nJiBuYW1lLCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0 JiYpPiYmKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5j cHAgYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCmluZGV4IDI5MmIyZDc3 MDdhLi5jN2IxMTYzYmZmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJT ZXJ2aWNlLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCkBA IC0xMzYsOSArMTM2LDYgQEAgY29uc3QgV2ViRHJpdmVyU2VydmljZTo6Q29tbWFuZCBXZWJEcml2 ZXJTZXJ2aWNlOjpzX2NvbW1hbmRzW10gPSB7CiAgICAgeyBIVFRQTWV0aG9kOjpQb3N0LCAiL3Nl c3Npb24vJHNlc3Npb25JZC9lbGVtZW50LyRlbGVtZW50SWQvY2xlYXIiLCAmV2ViRHJpdmVyU2Vy dmljZTo6ZWxlbWVudENsZWFyIH0sCiAgICAgeyBIVFRQTWV0aG9kOjpQb3N0LCAiL3Nlc3Npb24v JHNlc3Npb25JZC9lbGVtZW50LyRlbGVtZW50SWQvdmFsdWUiLCAmV2ViRHJpdmVyU2VydmljZTo6 ZWxlbWVudFNlbmRLZXlzIH0sCiAKLSAgICAvLyBGSVhNRTogTm90IGluIHRoZSBzcGVjLCBidXQg c3RpbGwgdXNlZCBieSBTZWxlbml1bS4KLSAgICB7IEhUVFBNZXRob2Q6OlBvc3QsICIvc2Vzc2lv bi8kc2Vzc2lvbklkL2VsZW1lbnQvJGVsZW1lbnRJZC9zdWJtaXQiLCAmV2ViRHJpdmVyU2Vydmlj ZTo6ZWxlbWVudFN1Ym1pdCB9LAotCiAgICAgeyBIVFRQTWV0aG9kOjpQb3N0LCAiL3Nlc3Npb24v JHNlc3Npb25JZC9leGVjdXRlL3N5bmMiLCAmV2ViRHJpdmVyU2VydmljZTo6ZXhlY3V0ZVNjcmlw dCB9LAogICAgIHsgSFRUUE1ldGhvZDo6UG9zdCwgIi9zZXNzaW9uLyRzZXNzaW9uSWQvZXhlY3V0 ZS9hc3luYyIsICZXZWJEcml2ZXJTZXJ2aWNlOjpleGVjdXRlQXN5bmNTY3JpcHQgfSwKIApAQCAt MTI3MiwxOCArMTI2OSw2IEBAIHZvaWQgV2ViRHJpdmVyU2VydmljZTo6ZWxlbWVudFNlbmRLZXlz KFJlZlB0cjxKU09OOjpPYmplY3Q+JiYgcGFyYW1ldGVycywgRnVuY3RpCiAgICAgbV9zZXNzaW9u LT5lbGVtZW50U2VuZEtleXMoZWxlbWVudElELnZhbHVlKCksIFdURk1vdmUodmFsdWUpLCBXVEZN b3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiB9CiAKLXZvaWQgV2ViRHJpdmVyU2VydmljZTo6ZWxl bWVudFN1Ym1pdChSZWZQdHI8SlNPTjo6T2JqZWN0PiYmIHBhcmFtZXRlcnMsIEZ1bmN0aW9uPHZv aWQgKENvbW1hbmRSZXN1bHQmJik+JiYgY29tcGxldGlvbkhhbmRsZXIpCi17Ci0gICAgaWYgKCFm aW5kU2Vzc2lvbk9yQ29tcGxldGVXaXRoRXJyb3IoKnBhcmFtZXRlcnMsIGNvbXBsZXRpb25IYW5k bGVyKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgYXV0byBlbGVtZW50SUQgPSBmaW5kRWxlbWVu dE9yQ29tcGxldGVXaXRoRXJyb3IoKnBhcmFtZXRlcnMsIGNvbXBsZXRpb25IYW5kbGVyKTsKLSAg ICBpZiAoIWVsZW1lbnRJRCkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgbV9zZXNzaW9uLT5lbGVt ZW50U3VibWl0KGVsZW1lbnRJRC52YWx1ZSgpLCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7 Ci19Ci0KIHN0YXRpYyBib29sIGZpbmRTY3JpcHRBbmRBcmd1bWVudHNPckNvbXBsZXRlV2l0aEVy cm9yKEpTT046Ok9iamVjdCYgcGFyYW1ldGVycywgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3Vs dCYmKT4mIGNvbXBsZXRpb25IYW5kbGVyLCBTdHJpbmcmIHNjcmlwdCwgUmVmUHRyPEpTT046OkFy cmF5PiYgYXJndW1lbnRzKQogewogICAgIGlmICghcGFyYW1ldGVycy5nZXRTdHJpbmcoQVNDSUlM aXRlcmFsKCJzY3JpcHQiKSwgc2NyaXB0KSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZl ci9XZWJEcml2ZXJTZXJ2aWNlLmggYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2Uu aAppbmRleCA3ZTg0ZTE3NTE2Mi4uYzNkMDgxMmMxYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJE cml2ZXIvV2ViRHJpdmVyU2VydmljZS5oCisrKyBiL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVy U2VydmljZS5oCkBAIC05Myw3ICs5Myw2IEBAIHByaXZhdGU6CiAgICAgdm9pZCBlbGVtZW50Q2xp Y2soUmVmUHRyPEpTT046Ok9iamVjdD4mJiwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYm KT4mJik7CiAgICAgdm9pZCBlbGVtZW50Q2xlYXIoUmVmUHRyPEpTT046Ok9iamVjdD4mJiwgRnVu Y3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7CiAgICAgdm9pZCBlbGVtZW50U2VuZEtl eXMoUmVmUHRyPEpTT046Ok9iamVjdD4mJiwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYm KT4mJik7Ci0gICAgdm9pZCBlbGVtZW50U3VibWl0KFJlZlB0cjxKU09OOjpPYmplY3Q+JiYsIEZ1 bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQmJik+JiYpOwogICAgIHZvaWQgZXhlY3V0ZVNjcmlw dChSZWZQdHI8SlNPTjo6T2JqZWN0PiYmLCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYp PiYmKTsKICAgICB2b2lkIGV4ZWN1dGVBc3luY1NjcmlwdChSZWZQdHI8SlNPTjo6T2JqZWN0PiYm LCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiYmKTsKICAgICB2b2lkIGdldEFsbENv b2tpZXMoUmVmUHRyPEpTT046Ok9iamVjdD4mJiwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3Vs dCYmKT4mJik7Cg==