180178 2017-11-29 17:34:13 -0800 Missing layer content when animating elements on-screen 2017-11-30 11:00:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser dino sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1376148 0 simon.fraser 2017-11-29 17:34:13 -0800 Missing layer content when animating elements on-screen 1376152 1 327935 simon.fraser 2017-11-29 17:37:17 -0800 Created attachment 327935 Patch 1376154 2 327936 simon.fraser 2017-11-29 17:37:34 -0800 Created attachment 327936 Manual test 1376155 3 simon.fraser 2017-11-29 17:37:49 -0800 rdar://problem/34923438 1376159 4 327935 dino 2017-11-29 17:41:14 -0800 Comment on attachment 327935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327935&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1516 > + bool nowRunningTransformAnimation = wasRunningTransformAnimation; > + if (m_uncommittedChanges & AnimationChanged) > + nowRunningTransformAnimation = isRunningTransformAnimation(); > + > + if (wasRunningTransformAnimation != nowRunningTransformAnimation) > + childCommitState.ancestorStartedOrEndedTransformAnimation = true; I wish all this could be one statement, but I can't think of a better way. 1376165 5 simon.fraser 2017-11-29 17:50:58 -0800 https://trac.webkit.org/r225310 1376403 6 327935 sabouhallawa 2017-11-30 11:00:29 -0800 Comment on attachment 327935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327935&action=review >> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1516 >> + childCommitState.ancestorStartedOrEndedTransformAnimation = true; > > I wish all this could be one statement, but I can't think of a better way. Maybe if ((m_uncommittedChanges & AnimationChanged) && wasRunningTransformAnimation != isRunningTransformAnimation()) 327935 2017-11-29 17:37:17 -0800 2017-11-29 17:41:14 -0800 Patch bug-180178-20171129173716.patch text/plain 3883 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWExOWVmZTRlMWU0Mjhl ZGQ3M2IwZjc5OTM5ZDQ2MjJiMDk0NjliZC4uNDhlMjRiMjExMmE3YTFkMTU3ODBjMGQ3YjkyZTE1 MGE5NTkxOTE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTExLTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1pc3NpbmcgbGF5 ZXIgY29udGVudCB3aGVuIGFuaW1hdGluZyBlbGVtZW50cyBvbi1zY3JlZW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDE3OAorICAgICAgICByZGFy Oi8vcHJvYmxlbS8zNDkyMzQzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIGEgZGVsYXllZCBhbmltYXRpb24gc3RhcnRzLCB0aGF0IGFuaW1hdGVz IGxheWVycyBmcm9tIG9mZnNjcmVlbiwgdGhlbiB3ZSB3b3VsZCBmYWlsCisgICAgICAgIHRvIHJ1 biB0aGUgbG9naWMgdGhhdCBlbnN1cmVzIHRoYXQgdGhvc2UgbGF5ZXJzIGhhdmUgYmFja2luZyBz dG9yZS4KKworICAgICAgICBGaXggYnkgZW5zdXJpbmcgdGhhdCBpZiBhbnkgbGF5ZXIgc3RhcnRz IG9yIGVuZHMgYSB0cmFuc2Zvcm0gYW5pbWF0aW9uLCB3ZSByZS1ldmFsdWF0ZQorICAgICAgICBi YWNraW5nIHN0b3JlIGF0dGFjaG1lbnQgb24gYWxsIGl0cyBkZXNjZW5kYW50cy4KKworICAgICAg ICBJIHRyaWVkIHRvIG1ha2UgYSB0ZXN0LCBidXQgbGF5ZXIgZmx1c2hpbmcgaXMgdGltaW5nLXNl bnNpdGl2ZSBhbmQgdGhlIHRlc3Qgd291bGQgaGF2ZSB0YWtlbgorICAgICAgICA1cywgYW5kIG5v dCBiZWVuIHJlbGlhYmxlLiBUaGVyZSdzIGEgbWFudWFsIHRlc3QgaW4gdGhlIGJ1Zy4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0xheWVyQ0E6OnJlY3Vyc2l2ZUNvbW1pdENoYW5nZXMpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5oOgorCiAyMDE3LTEx LTI5ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3ZlIHRoZSBJbWFnZVNvdXJjZSBmcm9tIHRoZSBjbGFzcyBoaWVyYXJjaHkgdGhhdCBj b25uZWN0cyBCaXRtYXBJbWFnZSB0byBJbWFnZUZyYW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAppbmRleCAzOWE4 NjVmYzZmZWUwZWEzM2NlZjNjNzFiZDhjYTMwZjEyN2I4YmYyLi45YTI3YWYwYWE2ZTY4NzczYTJk YWQ2NWNlMDQ4MGMxYTc5NzRiMzI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKQEAgLTE0NjIsNiArMTQ2Miw5 IEBAIHZvaWQgR3JhcGhpY3NMYXllckNBOjpyZWN1cnNpdmVDb21taXRDaGFuZ2VzKGNvbnN0IENv bW1pdFN0YXRlJiBjb21taXRTdGF0ZSwgY29uCiAgICAgfQogICAgIHNldFZpc2libGVBbmRDb3Zl cmFnZVJlY3RzKHJlY3RzLCBtX2lzVmlld3BvcnRDb25zdHJhaW5lZCB8fCBjb21taXRTdGF0ZS5h bmNlc3RvcklzVmlld3BvcnRDb25zdHJhaW5lZCk7CiAKKyAgICBpZiAoY29tbWl0U3RhdGUuYW5j ZXN0b3JTdGFydGVkT3JFbmRlZFRyYW5zZm9ybUFuaW1hdGlvbikKKyAgICAgICAgYWRkVW5jb21t aXR0ZWRDaGFuZ2VzKENvdmVyYWdlUmVjdENoYW5nZWQpOworCiAjaWZkZWYgVklTSUJMRV9USUxF X1dBU0gKICAgICAvLyBVc2UgaGF2aW5nIGEgdHJhbnNmb3JtIGFzIGEga2V5IHRvIG1ha2luZyB0 aGUgdGlsZSB3YXNoIGxheWVyLiBJZiBldmVyeSBsYXllciBnZXRzIGEgd2FzaCwKICAgICAvLyB0 aGV5IHN0YXJ0IHRvIG9ic2N1cmUgdXNlZnVsIGluZm9ybWF0aW9uLgpAQCAtMTUwMSw5ICsxNTA0 LDE4IEBAIHZvaWQgR3JhcGhpY3NMYXllckNBOjpyZWN1cnNpdmVDb21taXRDaGFuZ2VzKGNvbnN0 IENvbW1pdFN0YXRlJiBjb21taXRTdGF0ZSwgY29uCiAgICAgaWYgKGFmZmVjdGVkQnlQYWdlU2Nh bGUpCiAgICAgICAgIGJhc2VSZWxhdGl2ZVBvc2l0aW9uICs9IG1fcG9zaXRpb247CiAKKyAgICBi b29sIHdhc1J1bm5pbmdUcmFuc2Zvcm1BbmltYXRpb24gPSBpc1J1bm5pbmdUcmFuc2Zvcm1Bbmlt YXRpb24oKTsKKwogICAgIGNvbW1pdExheWVyQ2hhbmdlc0JlZm9yZVN1YmxheWVycyhjaGlsZENv bW1pdFN0YXRlLCBwYWdlU2NhbGVGYWN0b3IsIGJhc2VSZWxhdGl2ZVBvc2l0aW9uKTsKIAotICAg IGlmIChpc1J1bm5pbmdUcmFuc2Zvcm1BbmltYXRpb24oKSkgeworICAgIGJvb2wgbm93UnVubmlu Z1RyYW5zZm9ybUFuaW1hdGlvbiA9IHdhc1J1bm5pbmdUcmFuc2Zvcm1BbmltYXRpb247CisgICAg aWYgKG1fdW5jb21taXR0ZWRDaGFuZ2VzICYgQW5pbWF0aW9uQ2hhbmdlZCkKKyAgICAgICAgbm93 UnVubmluZ1RyYW5zZm9ybUFuaW1hdGlvbiA9IGlzUnVubmluZ1RyYW5zZm9ybUFuaW1hdGlvbigp OworCisgICAgaWYgKHdhc1J1bm5pbmdUcmFuc2Zvcm1BbmltYXRpb24gIT0gbm93UnVubmluZ1Ry YW5zZm9ybUFuaW1hdGlvbikKKyAgICAgICAgY2hpbGRDb21taXRTdGF0ZS5hbmNlc3RvclN0YXJ0 ZWRPckVuZGVkVHJhbnNmb3JtQW5pbWF0aW9uID0gdHJ1ZTsKKworICAgIGlmIChub3dSdW5uaW5n VHJhbnNmb3JtQW5pbWF0aW9uKSB7CiAgICAgICAgIGNoaWxkQ29tbWl0U3RhdGUuYW5jZXN0b3JI YXNUcmFuc2Zvcm1BbmltYXRpb24gPSB0cnVlOwogICAgICAgICBpZiAobV9pbnRlcnNlY3RzQ292 ZXJhZ2VSZWN0KQogICAgICAgICAgICAgY2hpbGRDb21taXRTdGF0ZS5hbmNlc3RvcldpdGhUcmFu c2Zvcm1BbmltYXRpb25JbnRlcnNlY3RzQ292ZXJhZ2VSZWN0ID0gdHJ1ZTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmgKaW5k ZXggYzliNTM2NjJmMWI5NTgxNGY0NjU3ZTIxZDJmNjk3ZDhkYTYwNjczYy4uNjUwMzMyZjM5M2Vh N2Y5MjgyMTlhODA3MjRlOTIxNGU1OWJmZjg3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmgKQEAgLTE1Nyw2ICsxNTcs NyBAQCBwdWJsaWM6CiAgICAgICAgIGludCB0cmVlRGVwdGggeyAwIH07CiAgICAgICAgIGJvb2wg YW5jZXN0b3JIYWRDaGFuZ2VzIHsgZmFsc2UgfTsKICAgICAgICAgYm9vbCBhbmNlc3Rvckhhc1Ry YW5zZm9ybUFuaW1hdGlvbiB7IGZhbHNlIH07CisgICAgICAgIGJvb2wgYW5jZXN0b3JTdGFydGVk T3JFbmRlZFRyYW5zZm9ybUFuaW1hdGlvbiB7IGZhbHNlIH07CiAgICAgICAgIGJvb2wgYW5jZXN0 b3JXaXRoVHJhbnNmb3JtQW5pbWF0aW9uSW50ZXJzZWN0c0NvdmVyYWdlUmVjdCB7IGZhbHNlIH07 CiAgICAgICAgIGJvb2wgYW5jZXN0b3JJc1ZpZXdwb3J0Q29uc3RyYWluZWQgeyBmYWxzZSB9Owog ICAgIH07Cg== 327936 2017-11-29 17:37:34 -0800 2017-11-29 17:37:34 -0800 Manual test index2.html text/html 1234 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CiAgICA8bWV0YSBjaGFyc2V0 PSJVVEYtOCI+CiAgICA8dGl0bGU+WiBpbmRleGluZyB0ZXN0IGNhc2U8L3RpdGxlPgogICAgPHN0 eWxlPgogICAgICAgIGJvZHkgewogICAgICAgICAgICBtYXJnaW46IDA7CiAgICAgICAgfQogICAg ICAgIHAgewogICAgICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgICAgICAgIGNvbG9y OiB3aGl0ZTsKICAgICAgICAgICAgdG9wOiAxZW07CiAgICAgICAgICAgIGxlZnQ6IDFlbTsKICAg ICAgICAgICAgZm9udC1zaXplOiAyZW07CiAgICAgICAgICAgIGZvbnQtZmFtaWx5OiBzYW5zLXNl cmlmOwogICAgICAgICAgICB6LWluZGV4OiAxMDA7CiAgICAgICAgfQogICAgICAgIC53cmFwcGVy IHsKICAgICAgICAgICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgICAgICAgICBhbmltYXRpb246 IHNsaWRlIDNzIDJzIGVhc2UtaW4tb3V0IGluZmluaXRlIGJvdGg7CiAgICAgICAgICAgIGxlZnQ6 IDNlbTsKICAgICAgICAgICAgdG9wOiAxZW07CiAgICAgICAgICAgIHBhZGRpbmc6IDEwcHg7CiAg ICAgICAgICAgIHRyYW5zZm9ybS1vcmlnaW46IHRvcCBsZWZ0OwogICAgICAgICAgICBib3JkZXI6 IDVweCBzb2xpZCBncmVlbjsKICAgICAgICB9CiAgICAgICAgLmJhY2tkcm9wIHsKICAgICAgICAg ICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgICAgICBoZWlnaHQ6IDIwMHB4OwogICAgICAg ICAgICB3aWR0aDogMjAwcHg7CiAgICAgICAgICAgIGJhY2tncm91bmQ6IG9yYW5nZTsKICAgICAg ICAgICAgdG9wOiAyMHB4OwogICAgICAgICAgICBsZWZ0OiAyMHB4OwogICAgICAgICAgICB0cmFu c2Zvcm06IHRyYW5zbGF0ZVooMCk7CiAgICAgICAgfQogICAgICAgIEBrZXlmcmFtZXMgc2xpZGUg ewogICAgICAgICAgICAwJSB7CiAgICAgICAgICAgICAgICB0cmFuc2Zvcm06IHRyYW5zbGF0ZSgt MTAwJSwgMCk7CiAgICAgICAgICAgIH0KICAgICAgICAgICAgNTAlIHsKICAgICAgICAgICAgICAg IHRyYW5zZm9ybTogdHJhbnNsYXRlKDAsIDApOwogICAgICAgICAgICB9CiAgICAgICAgfQogICAg PC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KICAgIDxkaXYgY2xhc3M9IndyYXBwZXIiPgogICAgICAg IFdyYXBwZXIKICAgICAgICA8ZGl2IGNsYXNzPSJiYWNrZHJvcCI+YmQ8L2Rpdj4KICAgICAgICA8 cD50ZXh0PC9wPgogICAgPC9kaXY+CjwvYm9keT4KPC9odG1sPg==