<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>180137</bug_id>
          
          <creation_ts>2017-11-29 05:13:40 -0800</creation_ts>
          <short_desc>Build should fail early if needed Perl modules are not installed</short_desc>
          <delta_ts>2017-12-14 06:09:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=180479</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>180199</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tomas Popela">tpopela</reporter>
          <assigned_to name="Tomas Popela">tpopela</assigned_to>
          <cc>annulen</cc>
    
    <cc>aperez</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>dbates</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>tpopela</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1375780</commentid>
    <comment_count>0</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-11-29 05:13:40 -0800</bug_when>
    <thetext>While compiling latest WebKitGTK+ release (2.19.2) people started to complain, that the build failed because they were missing Perl&apos;s File-Copy-Recursive module (as WebKitGTK+ started to use copy-user-interface-resources.pl recently). The current situation is not optimal as we are not checking for mandatory Perl modules presence during configure so the build will fail after tens of minutes and not immediately.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375783</commentid>
    <comment_count>1</comment_count>
      <attachid>327849</attachid>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-11-29 05:35:47 -0800</bug_when>
    <thetext>Created attachment 327849
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375784</commentid>
    <comment_count>2</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-11-29 05:37:28 -0800</bug_when>
    <thetext>Hmm webkit-patch is broken for me and it didn&apos;t included the ChangeLog..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375787</commentid>
    <comment_count>3</comment_count>
      <attachid>327850</attachid>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-11-29 05:43:30 -0800</bug_when>
    <thetext>Created attachment 327850
Proposed patch

Uploading the patch manually (for the webkit-patch issues I filled bug 180138)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375790</commentid>
    <comment_count>4</comment_count>
      <attachid>327850</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-11-29 06:00:44 -0800</bug_when>
    <thetext>Comment on attachment 327850
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327850&amp;action=review

&gt; ChangeLog:13
&gt; +        made it WebKit style compliant.

Please make it clear where is upstream copy of imported script

Also, I&apos;m not sure it&apos;s a good idea to re-format 3rd party code, it complicates importing new versions from upstreams

&gt; Source/cmake/WebKitCommon.cmake:25
&gt; +    find_package(PerlModules COMPONENTS version REQUIRED)

AFAIU, only File::Copy::Recursive is actually required when you are not using build-webkit and don&apos;t run testing scripts</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375792</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-11-29 06:18:27 -0800</bug_when>
    <thetext>(In reply to Tomas Popela from comment #0)
&gt; While compiling latest WebKitGTK+ release (2.19.2) people started to
&gt; complain, that the build failed because they were missing Perl&apos;s
&gt; File-Copy-Recursive module (as WebKitGTK+ started to use
&gt; copy-user-interface-resources.pl recently). The current situation is not
&gt; optimal as we are not checking for mandatory Perl modules presence during
&gt; configure so the build will fail after tens of minutes and not immediately.

Seems we started to require this after r224566 &lt;https://trac.webkit.org/r224566&gt;
File::Copy::Recursive is required by copy-user-interface-resources.pl

The module is this one: http://search.cpan.org/dist/File-Copy-Recursive/

I wonder if it will be instead a better idea to copy the module in the tree (or reimplement it) rather than adding an extra external dependency for something as simple as &quot;file copy recursive&quot; :\</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375794</commentid>
    <comment_count>6</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-11-29 06:30:18 -0800</bug_when>
    <thetext>I don&apos;t think it makes sense to bundle modules which are easily available

It might make sense to add autoinstall functionality similar to autoinstall which is used by our python code. I once shared this though with Daniel Bates and he agreed that it could be a good idea to do it with CPAN::Shell (core module).

This may be not good for File::Copy::Recursive which is used not in the testing infrastructure, but by build process, and distributions would want to have controlled build dpeendencies. For it we may want to call `cp -a` in the same way as macOS uses `ditto`. It&apos;s probably required to check that cp is from GNU coreutils first.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375812</commentid>
    <comment_count>7</comment_count>
      <attachid>327850</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-11-29 08:05:54 -0800</bug_when>
    <thetext>Comment on attachment 327850
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327850&amp;action=review

&gt;&gt; Source/cmake/WebKitCommon.cmake:25
&gt;&gt; +    find_package(PerlModules COMPONENTS version REQUIRED)
&gt; 
&gt; AFAIU, only File::Copy::Recursive is actually required when you are not using build-webkit and don&apos;t run testing scripts

CMake should only check for Perl modules that are required by the CMake build, yes. The rest probably don&apos;t need to be checked, because we can assume that if you&apos;re using build-webkit, you have run install-dependencies. But they could be checked at the build-webkit level, I suppose....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375813</commentid>
    <comment_count>8</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-11-29 08:09:46 -0800</bug_when>
    <thetext>Respective scripts will fail if used modules are not found, so the only specific handling can be autoinstalling</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375830</commentid>
    <comment_count>9</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-11-29 08:42:16 -0800</bug_when>
    <thetext>I assume you mean from build-webkit. Obviously CMake should not be autoinstalling anything.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375837</commentid>
    <comment_count>10</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-11-29 08:49:26 -0800</bug_when>
    <thetext>&gt;Obviously CMake should not be autoinstalling anything.

Of course.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1376295</commentid>
    <comment_count>11</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-11-30 06:35:26 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #4)
&gt; Also, I&apos;m not sure it&apos;s a good idea to re-format 3rd party code, it
&gt; complicates importing new versions from upstreams

It was a really slight re-format (missing some spaces between cmake keywords and brackets)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1376300</commentid>
    <comment_count>12</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-11-30 06:52:02 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #4)
&gt; AFAIU, only File::Copy::Recursive is actually required when you are not
&gt; using build-webkit and don&apos;t run testing scripts

JSON:PP is needed as well. (Initially I took the requirements from the Fedora package and from install-dependecies scripts).

[  1%] Generating ../../DerivedSources/ForwardingHeaders/JavaScriptCore/Scripts/lazywriter.py
cd /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources &amp;&amp; /usr/bin/cmake -E copy_if_different /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/Scripts/lazywriter.py /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources/ForwardingHeaders/JavaScriptCore/Scripts/lazywriter.py
Can&apos;t locate JSON/PP.pm in @INC (you may need to install the JSON::PP module) (@INC contains: . /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
BEGIN failed--compilation aborted at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
Can&apos;t locate JSON/PP.pm in @INC (you may need to install the JSON::PP module) (@INC contains: . /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
BEGIN failed--compilation aborted at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
Can&apos;t locate JSON/PP.pm in @INC (you may need to install the JSON::PP module) (@INC contains: . /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
BEGIN failed--compilation aborted at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
[  1%] Generating ../../DerivedSources/ForwardingHeaders/JavaScriptCore/Scripts/make-js-file-arrays.py
Can&apos;t locate JSON/PP.pm in @INC (you may need to install the JSON::PP module) (@INC contains: . /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
BEGIN failed--compilation aborted at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
Can&apos;t locate JSON/PP.pm in @INC (you may need to install the JSON::PP module) (@INC contains: . /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
BEGIN failed--compilation aborted at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
cd /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources &amp;&amp; /usr/bin/cmake -E copy_if_different /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/Scripts/make-js-file-arrays.py /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources/ForwardingHeaders/JavaScriptCore/Scripts/make-js-file-arrays.py
Can&apos;t locate JSON/PP.pm in @INC (you may need to install the JSON::PP module) (@INC contains: . /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
BEGIN failed--compilation aborted at /builddir/build/BUILD/webkitgtk-2.19.2/Source/WebCore/bindings/scripts/generate-bindings.pl line 41.
make[2]: Leaving directory &apos;/builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu&apos;
make[2]: *** [Source/WebCore/CMakeFiles/WebCoreBindings.dir/build.make:61: Source/WebCore/CMakeFiles/WebCoreBindings] Error 1
make[1]: *** [CMakeFiles/Makefile2:930: Source/WebCore/CMakeFiles/WebCoreBindings.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1376304</commentid>
    <comment_count>13</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-11-30 07:01:46 -0800</bug_when>
    <thetext>Indeed, I probably looked at wrong branch.

Slightly offtopic here, but I think it would be nice to use JSON::XS instead of JSON::PP if it&apos;s present</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1376314</commentid>
    <comment_count>14</comment_count>
      <attachid>327974</attachid>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-11-30 07:20:55 -0800</bug_when>
    <thetext>Created attachment 327974
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1376321</commentid>
    <comment_count>15</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-11-30 07:42:36 -0800</bug_when>
    <thetext>Hmm I see that it&apos;s failing on win as the build bot is missing File::Copy::Recursive, but I think it&apos;s actually not needed there. I will move the File::Copy::Recursive to OptionsGTK.cmake and OptionsWPE.cmake. But what about other cmake ports? Leaving it in WebKitCommon.cmake, but add there some condition for win port? Any idea for some elegant solution to avoid duplicity?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1376322</commentid>
    <comment_count>16</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-11-30 07:48:06 -0800</bug_when>
    <thetext>&gt;but I think it&apos;s actually not needed there

I see that vcxproj files are calling copy-user-interface-resources.pl, so I guess error is present but not fatal</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1376324</commentid>
    <comment_count>17</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-11-30 07:51:54 -0800</bug_when>
    <thetext>BTW there is another approach: use find_package() without REQUIRED (in dubious cases, not when e.g. Perl itself is missing), and then mark them as required in port-specific files via set_package_properties() of FeatureSummary module.

It may be a good idea to use FeatureSummary more extesively and maybe even ditch our custom configuration summary printing. I remember we discussed with Michael already.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1376330</commentid>
    <comment_count>18</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-11-30 08:12:42 -0800</bug_when>
    <thetext>&gt; It may be a good idea to use FeatureSummary more extesively and maybe even
&gt; ditch our custom configuration summary printing. I remember we discussed
&gt; with Michael already.

I&apos;d probably be fine with that, if you file a bug with an example of what the output would look like.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378634</commentid>
    <comment_count>19</comment_count>
      <attachid>327974</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-06 09:41:44 -0800</bug_when>
    <thetext>Comment on attachment 327974
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327974&amp;action=review

&gt; Source/cmake/WebKitCommon.cmake:21
&gt; +    find_package(PerlModules COMPONENTS File::Copy::Recursive REQUIRED)

But see bug #180479

&gt; Source/cmake/WebKitCommon.cmake:22
&gt; +    find_package(PerlModules COMPONENTS JSON::PP REQUIRED)

This is apparently a core Perl module, so I&apos;m not sure if we need to test for it? Does anyone know?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378635</commentid>
    <comment_count>20</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-06 09:43:26 -0800</bug_when>
    <thetext>&gt;This is apparently a core Perl module

Not it isn&apos;t</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378639</commentid>
    <comment_count>21</comment_count>
      <attachid>327974</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-06 09:48:50 -0800</bug_when>
    <thetext>Comment on attachment 327974
Patch

Emmanuele says:

&quot;Yes, you can always assume they are there if Perl is there

If people go out of their way to install Perl and remove the core modules, aside from breaking everything they can also add them back

It&apos;s not going to be any more complicated than installing a non-core module&quot;

So sorry to trash your work Tom, but we don&apos;t need to test for JSON::PP, and File::Copy::Recursive is a no-go. I think we should just never make the CMake build depend on any non-core Perl modules.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378640</commentid>
    <comment_count>22</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-06 09:49:29 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #20)
&gt; &gt;This is apparently a core Perl module
&gt; 
&gt; Not it isn&apos;t

It&apos;s not? Um</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378641</commentid>
    <comment_count>23</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-06 09:50:16 -0800</bug_when>
    <thetext>OK then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378642</commentid>
    <comment_count>24</comment_count>
      <attachid>327974</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-06 09:50:50 -0800</bug_when>
    <thetext>Comment on attachment 327974
Patch

r+ -&gt; r? -&gt; r+ -&gt; r- -&gt; r+ again, have a nice day. I guess.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378643</commentid>
    <comment_count>25</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-06 09:51:03 -0800</bug_when>
    <thetext>All core modules are documented at http://perldoc.perl.org/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378646</commentid>
    <comment_count>26</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-06 10:02:13 -0800</bug_when>
    <thetext>We&apos;re confused because http://search.cpan.org/~ishigaki/JSON-PP-2.97000/lib/JSON/PP.pm says &quot;JSON::PP has been in the Perl core since Perl 5.14, mainly for CPAN toolchain modules to parse META.json.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378665</commentid>
    <comment_count>27</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-06 10:32:45 -0800</bug_when>
    <thetext>It seems that you are right, vanilla Perl 5.26.1 freshly installed with plenv provides usable JSON::PP out of the box. There is no File::Copy::Recursive though.

Still, two considerations:

* Debian splits Perl into packages &quot;perl-base&quot; and &quot;perl-modules&quot;, the latter is what provides JSON::PP. So it&apos;s still possible to have a system with working perl but no JSON:PP
* We (still) require only Perl 5.10, while JSON::PP document talks about 5.14</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379016</commentid>
    <comment_count>28</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-12-06 21:32:50 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #27)
&gt; It seems that you are right, vanilla Perl 5.26.1 freshly installed with
&gt; plenv provides usable JSON::PP out of the box. There is no
&gt; File::Copy::Recursive though.

F27+ is using 5.26.1 and the build is failing unless I specify to install JSON::PP into it. So I&apos;m confused. So maybe there is something wrong with Fedora packaging.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379026</commentid>
    <comment_count>29</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-06 22:18:17 -0800</bug_when>
    <thetext>Fedora makes a separate rpm from each of core modules: https://src.fedoraproject.org/cgit/rpms/perl.git/tree/perl.spec#n3096</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379029</commentid>
    <comment_count>30</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-12-06 22:20:53 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #29)
&gt; Fedora makes a separate rpm from each of core modules:
&gt; https://src.fedoraproject.org/cgit/rpms/perl.git/tree/perl.spec#n3096

I know, but it really doesn&apos;t matter - what matters is that if it&apos;s supposed to be in core modules - then if should be installed if perl is installed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379033</commentid>
    <comment_count>31</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-12-06 22:26:06 -0800</bug_when>
    <thetext>(In reply to Tomas Popela from comment #30)
&gt; (In reply to Konstantin Tokarev from comment #29)
&gt; &gt; Fedora makes a separate rpm from each of core modules:
&gt; &gt; https://src.fedoraproject.org/cgit/rpms/perl.git/tree/perl.spec#n3096
&gt; 
&gt; I know, but it really doesn&apos;t matter - what matters is that if it&apos;s supposed
&gt; to be in core modules - then if should be installed if perl is installed.

Now I probably see that problem as we are not installing perl, but only a subpackage - that&apos;s the reason why it&apos;s not pulling it in build root. OK, then this patch is not required at all I think..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379034</commentid>
    <comment_count>32</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-06 22:26:17 -0800</bug_when>
    <thetext>This means Fedora, like Debian, doesn&apos;t install all core modules by default. Separate question is if this needs any handling, or we should support only full perl</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379036</commentid>
    <comment_count>33</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-12-06 22:30:09 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #32)
&gt; This means Fedora, like Debian, doesn&apos;t install all core modules by default.
&gt; Separate question is if this needs any handling, or we should support only
&gt; full perl

Yes, that&apos;s the question. But if Debian as well as Fedora are behaving like that then we probably could check for it in the end.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379097</commentid>
    <comment_count>34</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-07 07:37:25 -0800</bug_when>
    <thetext>Yes, let&apos;s check for JSON::PP.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379099</commentid>
    <comment_count>35</comment_count>
      <attachid>328694</attachid>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-12-07 07:44:56 -0800</bug_when>
    <thetext>Created attachment 328694
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379100</commentid>
    <comment_count>36</comment_count>
      <attachid>328694</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-07 07:46:51 -0800</bug_when>
    <thetext>Comment on attachment 328694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328694&amp;action=review

&gt; Source/cmake/WebKitCommon.cmake:21
&gt; +    find_package(PerlModules COMPONENTS JSON::PP REQUIRED)

Where is File::Copy::Recursive?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379101</commentid>
    <comment_count>37</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-12-07 07:51:16 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #36)
&gt; Comment on attachment 328694 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=328694&amp;action=review
&gt; 
&gt; &gt; Source/cmake/WebKitCommon.cmake:21
&gt; &gt; +    find_package(PerlModules COMPONENTS JSON::PP REQUIRED)
&gt; 
&gt; Where is File::Copy::Recursive?

Removed - look at bug 180199.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379107</commentid>
    <comment_count>38</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-07 08:02:55 -0800</bug_when>
    <thetext>I think it should be required in OptionsGTK.cmake</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379108</commentid>
    <comment_count>39</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-07 08:04:26 -0800</bug_when>
    <thetext>Or it can be found in WebKitCommon. but marked as required in GTK and WPE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1379109</commentid>
    <comment_count>40</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-07 08:11:31 -0800</bug_when>
    <thetext>Oops I didn&apos;t intend to close it</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1381109</commentid>
    <comment_count>41</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-13 07:27:48 -0800</bug_when>
    <thetext>I assume JSON::PP is required by all ports... if not, then WebKitCommon.cmake is indeed not the right place for the check.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1381110</commentid>
    <comment_count>42</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-13 07:30:33 -0800</bug_when>
    <thetext>I think it&apos;s OK to check for presence of core module even if it&apos;s not required. This is just a workaround for limitation/feature of Linux distros which make possible to have incomplete perl installation. On Windows and Mac it should always be present</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1381111</commentid>
    <comment_count>43</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-12-13 07:30:54 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #41)
&gt; I assume JSON::PP is required by all ports... if not, then
&gt; WebKitCommon.cmake is indeed not the right place for the check.

Looks like it is.. At least it is installed on all bots (the EWS is green - previously was red on win if File::Copy::Recursive was required and missing)..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1381589</commentid>
    <comment_count>44</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-12-14 05:34:53 -0800</bug_when>
    <thetext>LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1381594</commentid>
    <comment_count>45</comment_count>
      <attachid>328694</attachid>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-12-14 06:08:28 -0800</bug_when>
    <thetext>Comment on attachment 328694
Patch

Clearing flags on attachment: 328694

Committed r225901: &lt;https://trac.webkit.org/changeset/225901&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1381595</commentid>
    <comment_count>46</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2017-12-14 06:08:33 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1381596</commentid>
    <comment_count>47</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-12-14 06:09:46 -0800</bug_when>
    <thetext>&lt;rdar://problem/36046689&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>327849</attachid>
            <date>2017-11-29 05:35:47 -0800</date>
            <delta_ts>2017-11-29 05:43:30 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-180137-20171129143546.patch</filename>
            <type>text/plain</type>
            <size>4379</size>
            <attacher name="Tomas Popela">tpopela</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZFBlcmxNb2R1bGVzLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRQZXJsTW9kdWxlcy5jbWFrZQpu
ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwLi40YjYyZmEwZGI0NDhkNjA2NWQzN2QwMTUzNDIxZDAyOGVhNTI1ZWIxCi0tLSAv
ZGV2L251bGwKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRQZXJsTW9kdWxlcy5jbWFrZQpAQCAtMCww
ICsxLDg0IEBACisjIENoZWNrIHRoYXQgUGVybCBoYXMgY2VydGFpbiBtb2R1bGVzIGF2YWlsYWJs
ZS4KKyMKKyMgSWYgUEVSTF9FWEVDVVRBQkxFIGlzIHNldCwgdXNlcyB0aGF0LCBvdGhlcndpc2Ug
Y2FsbHMgdGhlIFBlcmwgZmluZCBtb2R1bGUuCisjCisjIFRvIHVzZSwgcGFzcyB0aGUgcGVybCBt
b2R1bGUgbmFtZXMgKGluIHRoZSBmb3JtIHlvdSB3b3VsZCB1c2UgaW4gYSBQZXJsCisjIGBgdXNl
YGAgc3RhdGVtZW50KSBhcyBjb21wb25lbnRzLgorIworIyBUaGlzIHdpbGwgZGVmaW5lIHRoZSBm
b2xsb3dpbmcgdmFyaWFibGVzOgorIworIyBgYFBlcmxfPG1vZHVsZT5fRk9VTkRgYAorIyAgICAg
VHJ1ZSBpZiB0aGUgZ2l2ZW4gUGVybCBtb2R1bGUgY291bGQgYmUgbG9hZGVkIGJ5IFBlcmwKKyMK
KyMgd2hlcmUgYGA8bW9kdWxlPmBgIGlzIGVpdGhlciB0aGUgbmFtZSBwYXNzZWQgYXMgYSBjb21w
b25lbnQsIG9yIGEgdmVyc2lvbgorIyB3aXRoIGBgOjpgYCByZXBsYWNlZCBieSBgYF9gYC4KKwor
IyBDb3B5cmlnaHQgMjAxNSBBbGV4IE1lcnJ5IDxhbGV4Lm1lcnJ5QGtkZS5vcmc+CisjCisjIFJl
ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig
d2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg
Zm9sbG93aW5nIGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMgMS4gUmVkaXN0cmlidXRpb25zIG9m
IHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgbm90aWNl
LCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgor
IyAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFi
b3ZlIGNvcHlyaWdodAorIyAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0
aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisjICAgIGRvY3VtZW50YXRpb24gYW5kL29y
IG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisjIDMuIE5l
aXRoZXIgdGhlIG5hbWUgb2YgdGhlIFVuaXZlcnNpdHkgbm9yIHRoZSBuYW1lcyBvZiBpdHMgY29u
dHJpYnV0b3JzCisjICAgIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0
cyBkZXJpdmVkIGZyb20gdGhpcyBzb2Z0d2FyZQorIyAgICB3aXRob3V0IHNwZWNpZmljIHByaW9y
IHdyaXR0ZW4gcGVybWlzc2lvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBU
SEUgUkVHRU5UUyBBTkQgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJyBBTkQKKyMgQU5ZIEVYUFJFU1Mg
T1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhF
CisjIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9S
IEEgUEFSVElDVUxBUiBQVVJQT1NFCisjIEFSRSBESVNDTEFJTUVELiAgSU4gTk8gRVZFTlQgU0hB
TEwgVEhFIFJFR0VOVFMgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRQorIyBGT1IgQU5ZIERJUkVD
VCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVO
VElBTAorIyBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1F
TlQgT0YgU1VCU1RJVFVURSBHT09EUworIyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEs
IE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikKKyMgSE9XRVZFUiBDQVVTRUQg
QU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJ
Q1QKKyMgTElBQklMSVRZLCBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJ
U0UpIEFSSVNJTkcgSU4gQU5ZIFdBWQorIyBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJF
LCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GCisjIFNVQ0ggREFNQUdFLgor
CitpZiAoTk9UIFBFUkxfRVhFQ1VUQUJMRSkKKyAgICBmaW5kX3BhY2thZ2UoUGVybCkKK2VuZGlm
ICgpCisKK2luY2x1ZGUoRmluZFBhY2thZ2VIYW5kbGVTdGFuZGFyZEFyZ3MpCisKK2lmIChQRVJM
X0VYRUNVVEFCTEUpCisgICAgc2V0KFBlcmxNb2R1bGVzX2FsbF9tb2R1bGVzX2ZvdW5kIFRSVUUp
CisgICAgZm9yZWFjaCAoX2NvbXAgJHtQZXJsTW9kdWxlc19GSU5EX0NPTVBPTkVOVFN9KQorICAg
ICAgICBleGVjdXRlX3Byb2Nlc3MoCisgICAgICAgICAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRB
QkxFfSAtZSAidXNlICR7X2NvbXB9IgorICAgICAgICAgICAgUkVTVUxUX1ZBUklBQkxFIF9yZXN1
bHQKKyAgICAgICAgICAgIE9VVFBVVF9RVUlFVAorICAgICAgICAgICAgRVJST1JfUVVJRVQKKyAg
ICAgICAgKQorICAgICAgICBzdHJpbmcoUkVQTEFDRSAiOjoiICJfIiBfY29tcF9zYW5pdGlzZWQg
IiR7X2NvbXB9IikKKyAgICAgICAgaWYgKF9yZXN1bHQgRVFVQUwgMCkKKyAgICAgICAgICAgIHNl
dChQZXJsTW9kdWxlc18ke19jb21wX3Nhbml0aXNlZH1fRk9VTkQgVFJVRSkKKyAgICAgICAgZWxz
ZSAoKQorICAgICAgICAgICAgc2V0KFBlcmxNb2R1bGVzXyR7X2NvbXBfc2FuaXRpc2VkfV9GT1VO
RCBGQUxTRSkKKyAgICAgICAgICAgIHNldChQZXJsTW9kdWxlc19hbGxfbW9kdWxlc19mb3VuZCBG
QUxTRSkKKyAgICAgICAgZW5kaWYgKCkKKyAgICAgICAgZmluZF9wYWNrYWdlX2hhbmRsZV9zdGFu
ZGFyZF9hcmdzKFBlcmxNb2R1bGVzXyR7X2NvbXB9CisgICAgICAgICAgICBGT1VORF9WQVIKKyAg
ICAgICAgICAgICAgICBQZXJsTW9kdWxlc18ke19jb21wfV9GT1VORAorICAgICAgICAgICAgUkVR
VUlSRURfVkFSUworICAgICAgICAgICAgICAgIFBlcmxNb2R1bGVzXyR7X2NvbXBfc2FuaXRpc2Vk
fV9GT1VORAorICAgICAgICAgICAgKQorICAgIGVuZGZvcmVhY2ggKCkKK2VuZGlmICgpCisKK2Zp
bmRfcGFja2FnZV9oYW5kbGVfc3RhbmRhcmRfYXJncyhQZXJsTW9kdWxlcworICAgIEZPVU5EX1ZB
UgorICAgICAgICBQZXJsTW9kdWxlc19GT1VORAorICAgIFJFUVVJUkVEX1ZBUlMKKyAgICAgICAg
UGVybE1vZHVsZXNfYWxsX21vZHVsZXNfZm91bmQKKyAgICBIQU5ETEVfQ09NUE9ORU5UUworKQor
CitpbmNsdWRlKEZlYXR1cmVTdW1tYXJ5KQorc2V0X3BhY2thZ2VfcHJvcGVydGllcyhQZXJsTW9k
dWxlcyBQUk9QRVJUSUVTCisgICAgVVJMICJodHRwOi8vd3d3LmNwYW4ub3JnIgorKQpkaWZmIC0t
Z2l0IGEvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJL
aXRDb21tb24uY21ha2UKaW5kZXggMWFmYmU2ZjQ3MGRiZDBjYjBkOWE2NTE4ZGYzNzIzMzE1NGQ4
ZmIxZS4uNjBiNzEyNTQzYjcxYWE0MTE5MmFkNGE2M2E4M2NhMDI0ZmU2OTNjMyAxMDA2NDQKLS0t
IGEvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2Vi
S2l0Q29tbW9uLmNtYWtlCkBAIC0xOCw2ICsxOCwxMSBAQCBpZiAoTk9UIEhBU19SVU5fV0VCS0lU
X0NPTU1PTikKIAogICAgICMgVE9ETyBFbmZvcmNlIHZlcnNpb24gcmVxdWlyZW1lbnQgZm9yIHBl
cmwKICAgICBmaW5kX3BhY2thZ2UoUGVybCA1LjEwLjAgUkVRVUlSRUQpCisgICAgZmluZF9wYWNr
YWdlKFBlcmxNb2R1bGVzIENPTVBPTkVOVFMgSlNPTjo6UFAgUkVRVUlSRUQpCisgICAgZmluZF9w
YWNrYWdlKFBlcmxNb2R1bGVzIENPTVBPTkVOVFMgRmlsZTo6Q29weTo6UmVjdXJzaXZlIFJFUVVJ
UkVEKQorICAgIGZpbmRfcGFja2FnZShQZXJsTW9kdWxlcyBDT01QT05FTlRTIFN3aXRjaCBSRVFV
SVJFRCkKKyAgICBmaW5kX3BhY2thZ2UoUGVybE1vZHVsZXMgQ09NUE9ORU5UUyBUaW1lOjpIaVJl
cyBSRVFVSVJFRCkKKyAgICBmaW5kX3BhY2thZ2UoUGVybE1vZHVsZXMgQ09NUE9ORU5UUyB2ZXJz
aW9uIFJFUVVJUkVEKQogCiAgICAgZmluZF9wYWNrYWdlKFB5dGhvbkludGVycCAyLjcuMCBSRVFV
SVJFRCkKICAgICBpZiAoUFlUSE9OX1ZFUlNJT05fTUFKT1IgR1JFQVRFUiAyKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>327850</attachid>
            <date>2017-11-29 05:43:30 -0800</date>
            <delta_ts>2017-11-30 07:20:51 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>0001-Build-should-fail-early-is-needed-Perl-modules-are-n.patch</filename>
            <type>text/plain</type>
            <size>5950</size>
            <attacher name="Tomas Popela">tpopela</attacher>
            
              <data encoding="base64">RnJvbSBmMWQyOGQ0ZDQ3NDRjMmZmMzFjNzg2MTFjOTViYTBkYzA2N2ZhMDBiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBQb3BlbGEgPHRwb3BlbGFAcmVkaGF0LmNvbT4KRGF0
ZTogV2VkLCAyOSBOb3YgMjAxNyAxNDoyODoyNCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEJ1aWxk
IHNob3VsZCBmYWlsIGVhcmx5IGlzIG5lZWRlZCBQZXJsIG1vZHVsZXMgYXJlIG5vdAogaW5zdGFs
bGVkIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAxMzcKClJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKRG9uJ3QgZmluaXNoIHRoZSBjb25maWd1cmUgc3VjY2Vz
c2Z1bGx5IGlmIHRoZSByZXF1aXJlZCBQZXJsIG1vZHVsZXMKYXJlIG5vdCBpbnN0YWxsZWQuIFN0
YXJ0IHRvIHJlcXVpcmUgbW9kdWxlcyB0aGF0IGFyZSBuZWVkZWQgZm9yCldQRS9HVEsrIHBvcnRz
LgoKKiBTb3VyY2UvY21ha2UvRmluZFBlcmxNb2R1bGVzLmNtYWtlOiBDb3BpZWQgZnJvbSBLREUg
cmVwb3NpdG9yaWVzIGFuZAptYWRlIGl0IFdlYktpdCBzdHlsZSBjb21wbGlhbnQuCiogU291cmNl
L2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZToKLS0tCiBDaGFuZ2VMb2cgICAgICAgICAgICAgICAg
ICAgICAgICAgIHwgMTUgKysrKysrKwogU291cmNlL2NtYWtlL0ZpbmRQZXJsTW9kdWxlcy5jbWFr
ZSB8IDg0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvY21h
a2UvV2ViS2l0Q29tbW9uLmNtYWtlICAgIHwgIDUgKysrCiAzIGZpbGVzIGNoYW5nZWQsIDEwNCBp
bnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgU291cmNlL2NtYWtlL0ZpbmRQZXJsTW9k
dWxlcy5jbWFrZQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3MzZl
YjFkYTVlZi4uYzE1YmRhZjk4ZWUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VM
b2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNy0xMS0yOSAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUBy
ZWRoYXQuY29tPgorCisgICAgICAgIEJ1aWxkIHNob3VsZCBmYWlsIGVhcmx5IGlzIG5lZWRlZCBQ
ZXJsIG1vZHVsZXMgYXJlIG5vdCBpbnN0YWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDEzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGZpbmlzaCB0aGUgY29uZmlndXJlIHN1Y2Nlc3Nm
dWxseSBpZiB0aGUgcmVxdWlyZWQgUGVybCBtb2R1bGVzCisgICAgICAgIGFyZSBub3QgaW5zdGFs
bGVkLiBTdGFydCB0byByZXF1aXJlIG1vZHVsZXMgdGhhdCBhcmUgbmVlZGVkIGZvcgorICAgICAg
ICBXUEUvR1RLKyBwb3J0cy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kUGVybE1vZHVs
ZXMuY21ha2U6IENvcGllZCBmcm9tIEtERSByZXBvc2l0b3JpZXMgYW5kCisgICAgICAgIG1hZGUg
aXQgV2ViS2l0IHN0eWxlIGNvbXBsaWFudC4KKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0
Q29tbW9uLmNtYWtlOgorCiAyMDE3LTExLTI4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnph
cm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyMjUwOTgpOiBbV1BFXSBTb21l
IGZlYXR1cmVzIGhhdmUgY2hhbmdlZCBvZiB2YWx1ZSAoNzAgbmV3IGZhaWx1cmVzKQpkaWZmIC0t
Z2l0IGEvU291cmNlL2NtYWtlL0ZpbmRQZXJsTW9kdWxlcy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9G
aW5kUGVybE1vZHVsZXMuY21ha2UKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw
MDAuLjRiNjJmYTBkYjQ0Ci0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRQZXJs
TW9kdWxlcy5jbWFrZQpAQCAtMCwwICsxLDg0IEBACisjIENoZWNrIHRoYXQgUGVybCBoYXMgY2Vy
dGFpbiBtb2R1bGVzIGF2YWlsYWJsZS4KKyMKKyMgSWYgUEVSTF9FWEVDVVRBQkxFIGlzIHNldCwg
dXNlcyB0aGF0LCBvdGhlcndpc2UgY2FsbHMgdGhlIFBlcmwgZmluZCBtb2R1bGUuCisjCisjIFRv
IHVzZSwgcGFzcyB0aGUgcGVybCBtb2R1bGUgbmFtZXMgKGluIHRoZSBmb3JtIHlvdSB3b3VsZCB1
c2UgaW4gYSBQZXJsCisjIGBgdXNlYGAgc3RhdGVtZW50KSBhcyBjb21wb25lbnRzLgorIworIyBU
aGlzIHdpbGwgZGVmaW5lIHRoZSBmb2xsb3dpbmcgdmFyaWFibGVzOgorIworIyBgYFBlcmxfPG1v
ZHVsZT5fRk9VTkRgYAorIyAgICAgVHJ1ZSBpZiB0aGUgZ2l2ZW4gUGVybCBtb2R1bGUgY291bGQg
YmUgbG9hZGVkIGJ5IFBlcmwKKyMKKyMgd2hlcmUgYGA8bW9kdWxlPmBgIGlzIGVpdGhlciB0aGUg
bmFtZSBwYXNzZWQgYXMgYSBjb21wb25lbnQsIG9yIGEgdmVyc2lvbgorIyB3aXRoIGBgOjpgYCBy
ZXBsYWNlZCBieSBgYF9gYC4KKworIyBDb3B5cmlnaHQgMjAxNSBBbGV4IE1lcnJ5IDxhbGV4Lm1l
cnJ5QGtkZS5vcmc+CisjCisjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBi
aW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0
ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMg
MS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBj
b3B5cmlnaHQKKyMgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZv
bGxvd2luZyBkaXNjbGFpbWVyLgorIyAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0g
bXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICBub3RpY2UsIHRoaXMgbGlz
dCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisjICAg
IGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBk
aXN0cmlidXRpb24uCisjIDMuIE5laXRoZXIgdGhlIG5hbWUgb2YgdGhlIFVuaXZlcnNpdHkgbm9y
IHRoZSBuYW1lcyBvZiBpdHMgY29udHJpYnV0b3JzCisjICAgIG1heSBiZSB1c2VkIHRvIGVuZG9y
c2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20gdGhpcyBzb2Z0d2FyZQorIyAgICB3
aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyMKKyMgVEhJUyBTT0ZU
V0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgUkVHRU5UUyBBTkQgQ09OVFJJQlVUT1JTIGBgQVMgSVMn
JyBBTkQKKyMgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJV
VCBOT1QgTElNSVRFRCBUTywgVEhFCisjIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFC
SUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFCisjIEFSRSBESVNDTEFJ
TUVELiAgSU4gTk8gRVZFTlQgU0hBTEwgVEhFIFJFR0VOVFMgT1IgQ09OVFJJQlVUT1JTIEJFIExJ
QUJMRQorIyBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVY
RU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTAorIyBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1Qg
TElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUworIyBPUiBTRVJWSUNF
UzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElP
TikKKyMgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVU
SEVSIElOIENPTlRSQUNULCBTVFJJQ1QKKyMgTElBQklMSVRZLCBPUiBUT1JUIChJTkNMVURJTkcg
TkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWQorIyBPVVQgT0YgVEhF
IFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZ
IE9GCisjIFNVQ0ggREFNQUdFLgorCitpZiAoTk9UIFBFUkxfRVhFQ1VUQUJMRSkKKyAgICBmaW5k
X3BhY2thZ2UoUGVybCkKK2VuZGlmICgpCisKK2luY2x1ZGUoRmluZFBhY2thZ2VIYW5kbGVTdGFu
ZGFyZEFyZ3MpCisKK2lmIChQRVJMX0VYRUNVVEFCTEUpCisgICAgc2V0KFBlcmxNb2R1bGVzX2Fs
bF9tb2R1bGVzX2ZvdW5kIFRSVUUpCisgICAgZm9yZWFjaCAoX2NvbXAgJHtQZXJsTW9kdWxlc19G
SU5EX0NPTVBPTkVOVFN9KQorICAgICAgICBleGVjdXRlX3Byb2Nlc3MoCisgICAgICAgICAgICBD
T01NQU5EICR7UEVSTF9FWEVDVVRBQkxFfSAtZSAidXNlICR7X2NvbXB9IgorICAgICAgICAgICAg
UkVTVUxUX1ZBUklBQkxFIF9yZXN1bHQKKyAgICAgICAgICAgIE9VVFBVVF9RVUlFVAorICAgICAg
ICAgICAgRVJST1JfUVVJRVQKKyAgICAgICAgKQorICAgICAgICBzdHJpbmcoUkVQTEFDRSAiOjoi
ICJfIiBfY29tcF9zYW5pdGlzZWQgIiR7X2NvbXB9IikKKyAgICAgICAgaWYgKF9yZXN1bHQgRVFV
QUwgMCkKKyAgICAgICAgICAgIHNldChQZXJsTW9kdWxlc18ke19jb21wX3Nhbml0aXNlZH1fRk9V
TkQgVFJVRSkKKyAgICAgICAgZWxzZSAoKQorICAgICAgICAgICAgc2V0KFBlcmxNb2R1bGVzXyR7
X2NvbXBfc2FuaXRpc2VkfV9GT1VORCBGQUxTRSkKKyAgICAgICAgICAgIHNldChQZXJsTW9kdWxl
c19hbGxfbW9kdWxlc19mb3VuZCBGQUxTRSkKKyAgICAgICAgZW5kaWYgKCkKKyAgICAgICAgZmlu
ZF9wYWNrYWdlX2hhbmRsZV9zdGFuZGFyZF9hcmdzKFBlcmxNb2R1bGVzXyR7X2NvbXB9CisgICAg
ICAgICAgICBGT1VORF9WQVIKKyAgICAgICAgICAgICAgICBQZXJsTW9kdWxlc18ke19jb21wfV9G
T1VORAorICAgICAgICAgICAgUkVRVUlSRURfVkFSUworICAgICAgICAgICAgICAgIFBlcmxNb2R1
bGVzXyR7X2NvbXBfc2FuaXRpc2VkfV9GT1VORAorICAgICAgICAgICAgKQorICAgIGVuZGZvcmVh
Y2ggKCkKK2VuZGlmICgpCisKK2ZpbmRfcGFja2FnZV9oYW5kbGVfc3RhbmRhcmRfYXJncyhQZXJs
TW9kdWxlcworICAgIEZPVU5EX1ZBUgorICAgICAgICBQZXJsTW9kdWxlc19GT1VORAorICAgIFJF
UVVJUkVEX1ZBUlMKKyAgICAgICAgUGVybE1vZHVsZXNfYWxsX21vZHVsZXNfZm91bmQKKyAgICBI
QU5ETEVfQ09NUE9ORU5UUworKQorCitpbmNsdWRlKEZlYXR1cmVTdW1tYXJ5KQorc2V0X3BhY2th
Z2VfcHJvcGVydGllcyhQZXJsTW9kdWxlcyBQUk9QRVJUSUVTCisgICAgVVJMICJodHRwOi8vd3d3
LmNwYW4ub3JnIgorKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFr
ZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKaW5kZXggMWFmYmU2ZjQ3MGQuLjYw
YjcxMjU0M2I3IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tbW9uLmNtYWtlCisr
KyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKQEAgLTE4LDYgKzE4LDExIEBAIGlm
IChOT1QgSEFTX1JVTl9XRUJLSVRfQ09NTU9OKQogCiAgICAgIyBUT0RPIEVuZm9yY2UgdmVyc2lv
biByZXF1aXJlbWVudCBmb3IgcGVybAogICAgIGZpbmRfcGFja2FnZShQZXJsIDUuMTAuMCBSRVFV
SVJFRCkKKyAgICBmaW5kX3BhY2thZ2UoUGVybE1vZHVsZXMgQ09NUE9ORU5UUyBKU09OOjpQUCBS
RVFVSVJFRCkKKyAgICBmaW5kX3BhY2thZ2UoUGVybE1vZHVsZXMgQ09NUE9ORU5UUyBGaWxlOjpD
b3B5OjpSZWN1cnNpdmUgUkVRVUlSRUQpCisgICAgZmluZF9wYWNrYWdlKFBlcmxNb2R1bGVzIENP
TVBPTkVOVFMgU3dpdGNoIFJFUVVJUkVEKQorICAgIGZpbmRfcGFja2FnZShQZXJsTW9kdWxlcyBD
T01QT05FTlRTIFRpbWU6OkhpUmVzIFJFUVVJUkVEKQorICAgIGZpbmRfcGFja2FnZShQZXJsTW9k
dWxlcyBDT01QT05FTlRTIHZlcnNpb24gUkVRVUlSRUQpCiAKICAgICBmaW5kX3BhY2thZ2UoUHl0
aG9uSW50ZXJwIDIuNy4wIFJFUVVJUkVEKQogICAgIGlmIChQWVRIT05fVkVSU0lPTl9NQUpPUiBH
UkVBVEVSIDIpCi0tIAoyLjE0LjMKCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>327974</attachid>
            <date>2017-11-30 07:20:55 -0800</date>
            <delta_ts>2017-12-07 07:44:52 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-180137-20171130162054.patch</filename>
            <type>text/plain</type>
            <size>5153</size>
            <attacher name="Tomas Popela">tpopela</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZFBlcmxNb2R1bGVzLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRQZXJsTW9kdWxlcy5jbWFrZQpu
ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwLi45M2EzMWZlM2UyNDNhYmVjMTMxNjVjYWRmMzU5ZmFjNzc2OWE5MTNhCi0tLSAv
ZGV2L251bGwKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRQZXJsTW9kdWxlcy5jbWFrZQpAQCAtMCww
ICsxLDg4IEBACisjLnJzdDoKKyMgRmluZFBlcmxNb2R1bGVzCisjIC0tLS0tLS0tLS0tLS0tLQor
IworIyBDaGVjayB0aGF0IFBlcmwgaGFzIGNlcnRhaW4gbW9kdWxlcyBhdmFpbGFibGUuCisjCisj
IElmIFBFUkxfRVhFQ1VUQUJMRSBpcyBzZXQsIHVzZXMgdGhhdCwgb3RoZXJ3aXNlIGNhbGxzIHRo
ZSBQZXJsIGZpbmQgbW9kdWxlLgorIworIyBUbyB1c2UsIHBhc3MgdGhlIHBlcmwgbW9kdWxlIG5h
bWVzIChpbiB0aGUgZm9ybSB5b3Ugd291bGQgdXNlIGluIGEgUGVybAorIyBgYHVzZWBgIHN0YXRl
bWVudCkgYXMgY29tcG9uZW50cy4KKyMKKyMgVGhpcyB3aWxsIGRlZmluZSB0aGUgZm9sbG93aW5n
IHZhcmlhYmxlczoKKyMKKyMgYGBQZXJsXzxtb2R1bGU+X0ZPVU5EYGAKKyMgICAgIFRydWUgaWYg
dGhlIGdpdmVuIFBlcmwgbW9kdWxlIGNvdWxkIGJlIGxvYWRlZCBieSBQZXJsCisjCisjIHdoZXJl
IGBgPG1vZHVsZT5gYCBpcyBlaXRoZXIgdGhlIG5hbWUgcGFzc2VkIGFzIGEgY29tcG9uZW50LCBv
ciBhIHZlcnNpb24KKyMgd2l0aCBgYDo6YGAgcmVwbGFjZWQgYnkgYGBfYGAuCisKKyMgQ29weXJp
Z2h0IDIwMTUgQWxleCBNZXJyeSA8YWxleC5tZXJyeUBrZGUub3JnPgorIworIyBSZWRpc3RyaWJ1
dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK
KyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu
ZyBjb25kaXRpb25zCisjIGFyZSBtZXQ6CisjIDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2Ug
Y29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgIG5vdGljZSwgdGhpcyBs
aXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgMi4gUmVk
aXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5
cmlnaHQKKyMgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv
d2luZyBkaXNjbGFpbWVyIGluIHRoZQorIyAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBt
YXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIyAzLiBOZWl0aGVyIHRo
ZSBuYW1lIG9mIHRoZSBVbml2ZXJzaXR5IG5vciB0aGUgbmFtZXMgb2YgaXRzIGNvbnRyaWJ1dG9y
cworIyAgICBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZl
ZCBmcm9tIHRoaXMgc29mdHdhcmUKKyMgICAgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVu
IHBlcm1pc3Npb24uCisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIFJFR0VO
VFMgQU5EIENPTlRSSUJVVE9SUyBgYEFTIElTJycgQU5ECisjIEFOWSBFWFBSRVNTIE9SIElNUExJ
RUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQorIyBJTVBM
SUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJ
Q1VMQVIgUFVSUE9TRQorIyBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBS
RUdFTlRTIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUKKyMgRk9SIEFOWSBESVJFQ1QsIElORElS
RUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwKKyMg
REFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNV
QlNUSVRVVEUgR09PRFMKKyMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9G
SVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pCisjIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB
TlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUCisjIExJ
QUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklT
SU5HIElOIEFOWSBXQVkKKyMgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJ
RiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRgorIyBTVUNIIERBTUFHRS4KKworaWYgKE5P
VCBQRVJMX0VYRUNVVEFCTEUpCisgICAgZmluZF9wYWNrYWdlKFBlcmwpCitlbmRpZiAoKQorCitp
bmNsdWRlKEZpbmRQYWNrYWdlSGFuZGxlU3RhbmRhcmRBcmdzKQorCitpZiAoUEVSTF9FWEVDVVRB
QkxFKQorICAgIHNldChQZXJsTW9kdWxlc19hbGxfbW9kdWxlc19mb3VuZCBUUlVFKQorICAgIGZv
cmVhY2ggKF9jb21wICR7UGVybE1vZHVsZXNfRklORF9DT01QT05FTlRTfSkKKyAgICAgICAgZXhl
Y3V0ZV9wcm9jZXNzKAorICAgICAgICAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gLWUg
InVzZSAke19jb21wfSIKKyAgICAgICAgICAgIFJFU1VMVF9WQVJJQUJMRSBfcmVzdWx0CisgICAg
ICAgICAgICBPVVRQVVRfUVVJRVQKKyAgICAgICAgICAgIEVSUk9SX1FVSUVUCisgICAgICAgICkK
KyAgICAgICAgc3RyaW5nKFJFUExBQ0UgIjo6IiAiXyIgX2NvbXBfc2FuaXRpc2VkICIke19jb21w
fSIpCisgICAgICAgIGlmIChfcmVzdWx0IEVRVUFMIDApCisgICAgICAgICAgICBzZXQoUGVybE1v
ZHVsZXNfJHtfY29tcF9zYW5pdGlzZWR9X0ZPVU5EIFRSVUUpCisgICAgICAgIGVsc2UgKCkKKyAg
ICAgICAgICAgIHNldChQZXJsTW9kdWxlc18ke19jb21wX3Nhbml0aXNlZH1fRk9VTkQgRkFMU0Up
CisgICAgICAgICAgICBzZXQoUGVybE1vZHVsZXNfYWxsX21vZHVsZXNfZm91bmQgRkFMU0UpCisg
ICAgICAgIGVuZGlmICgpCisgICAgICAgIGZpbmRfcGFja2FnZV9oYW5kbGVfc3RhbmRhcmRfYXJn
cyhQZXJsTW9kdWxlc18ke19jb21wfQorICAgICAgICAgICAgRk9VTkRfVkFSCisgICAgICAgICAg
ICAgICAgUGVybE1vZHVsZXNfJHtfY29tcH1fRk9VTkQKKyAgICAgICAgICAgIFJFUVVJUkVEX1ZB
UlMKKyAgICAgICAgICAgICAgICBQZXJsTW9kdWxlc18ke19jb21wX3Nhbml0aXNlZH1fRk9VTkQK
KyAgICAgICAgICAgICkKKyAgICBlbmRmb3JlYWNoICgpCitlbmRpZiAoKQorCitmaW5kX3BhY2th
Z2VfaGFuZGxlX3N0YW5kYXJkX2FyZ3MoUGVybE1vZHVsZXMKKyAgICBGT1VORF9WQVIKKyAgICAg
ICAgUGVybE1vZHVsZXNfRk9VTkQKKyAgICBSRVFVSVJFRF9WQVJTCisgICAgICAgIFBlcmxNb2R1
bGVzX2FsbF9tb2R1bGVzX2ZvdW5kCisgICAgSEFORExFX0NPTVBPTkVOVFMKKykKKworaW5jbHVk
ZShGZWF0dXJlU3VtbWFyeSkKK3NldF9wYWNrYWdlX3Byb3BlcnRpZXMoUGVybE1vZHVsZXMgUFJP
UEVSVElFUworICAgIFVSTCAiaHR0cDovL3d3dy5jcGFuLm9yZyIKKykKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tbW9u
LmNtYWtlCmluZGV4IDFhZmJlNmY0NzBkYmQwY2IwZDlhNjUxOGRmMzcyMzMxNTRkOGZiMWUuLjQ3
ZmI4ZTViMWZkNjAwYjg4N2ZjMDhiZjFlYzgyMzhhZjgzMmZmMTYgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1v
bi5jbWFrZQpAQCAtMTgsNiArMTgsOCBAQCBpZiAoTk9UIEhBU19SVU5fV0VCS0lUX0NPTU1PTikK
IAogICAgICMgVE9ETyBFbmZvcmNlIHZlcnNpb24gcmVxdWlyZW1lbnQgZm9yIHBlcmwKICAgICBm
aW5kX3BhY2thZ2UoUGVybCA1LjEwLjAgUkVRVUlSRUQpCisgICAgZmluZF9wYWNrYWdlKFBlcmxN
b2R1bGVzIENPTVBPTkVOVFMgRmlsZTo6Q29weTo6UmVjdXJzaXZlIFJFUVVJUkVEKQorICAgIGZp
bmRfcGFja2FnZShQZXJsTW9kdWxlcyBDT01QT05FTlRTIEpTT046OlBQIFJFUVVJUkVEKQogCiAg
ICAgZmluZF9wYWNrYWdlKFB5dGhvbkludGVycCAyLjcuMCBSRVFVSVJFRCkKICAgICBpZiAoUFlU
SE9OX1ZFUlNJT05fTUFKT1IgR1JFQVRFUiAyKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh
bmdlTG9nCmluZGV4IDI1ZmE0NzlhNDZjYzNkYzFiYWI1MDdiNGM3NGI1YzE3YWQxNmJjNTcuLjM3
NDFlY2E1NWE2MDg1MjJjNTgxNmI5ZTA1MWFmZmFmNWU0YWExNWUgMTAwNjQ0Ci0tLSBhL0NoYW5n
ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNy0xMS0zMCAgVG9tYXMg
UG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgorCisgICAgICAgIEJ1aWxkIHNob3VsZCBmYWls
IGVhcmx5IGlzIG5lZWRlZCBQZXJsIG1vZHVsZXMgYXJlIG5vdCBpbnN0YWxsZWQKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDEzNworCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGZpbmlzaCB0aGUg
Y29uZmlndXJlIHN1Y2Nlc3NmdWxseSBpZiB0aGUgcmVxdWlyZWQgUGVybCBtb2R1bGVzCisgICAg
ICAgIGFyZSBub3QgaW5zdGFsbGVkLiBTdGFydCB0byByZXF1aXJlIG1vZHVsZXMgdGhhdCBhcmUg
bmVlZGVkIGZvcgorICAgICAgICBXUEUvR1RLKyBwb3J0cy4KKworICAgICAgICAqIFNvdXJjZS9j
bWFrZS9GaW5kUGVybE1vZHVsZXMuY21ha2U6IENvcGllZCBmcm9tCisgICAgICAgIGh0dHBzOi8v
Z2l0aHViLmNvbS9LREUva2RlbGliczRzdXBwb3J0L2Jsb2IvbWFzdGVyL2NtYWtlL0ZpbmRQZXJs
TW9kdWxlcy5jbWFrZQorICAgICAgICBhbmQgbWFkZSBpdCBXZWJLaXQgc3R5bGUgY29tcGxpYW50
LgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2U6CisKIDIwMTctMTEt
MjkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAg
ICBGaXggTWFjIENNYWtlIGJ1aWxkLgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>328694</attachid>
            <date>2017-12-07 07:44:56 -0800</date>
            <delta_ts>2017-12-14 06:08:28 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-180137-20171207164455.patch</filename>
            <type>text/plain</type>
            <size>5101</size>
            <attacher name="Tomas Popela">tpopela</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZFBlcmxNb2R1bGVzLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRQZXJsTW9kdWxlcy5jbWFrZQpu
ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwLi45M2EzMWZlM2UyNDNhYmVjMTMxNjVjYWRmMzU5ZmFjNzc2OWE5MTNhCi0tLSAv
ZGV2L251bGwKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRQZXJsTW9kdWxlcy5jbWFrZQpAQCAtMCww
ICsxLDg4IEBACisjLnJzdDoKKyMgRmluZFBlcmxNb2R1bGVzCisjIC0tLS0tLS0tLS0tLS0tLQor
IworIyBDaGVjayB0aGF0IFBlcmwgaGFzIGNlcnRhaW4gbW9kdWxlcyBhdmFpbGFibGUuCisjCisj
IElmIFBFUkxfRVhFQ1VUQUJMRSBpcyBzZXQsIHVzZXMgdGhhdCwgb3RoZXJ3aXNlIGNhbGxzIHRo
ZSBQZXJsIGZpbmQgbW9kdWxlLgorIworIyBUbyB1c2UsIHBhc3MgdGhlIHBlcmwgbW9kdWxlIG5h
bWVzIChpbiB0aGUgZm9ybSB5b3Ugd291bGQgdXNlIGluIGEgUGVybAorIyBgYHVzZWBgIHN0YXRl
bWVudCkgYXMgY29tcG9uZW50cy4KKyMKKyMgVGhpcyB3aWxsIGRlZmluZSB0aGUgZm9sbG93aW5n
IHZhcmlhYmxlczoKKyMKKyMgYGBQZXJsXzxtb2R1bGU+X0ZPVU5EYGAKKyMgICAgIFRydWUgaWYg
dGhlIGdpdmVuIFBlcmwgbW9kdWxlIGNvdWxkIGJlIGxvYWRlZCBieSBQZXJsCisjCisjIHdoZXJl
IGBgPG1vZHVsZT5gYCBpcyBlaXRoZXIgdGhlIG5hbWUgcGFzc2VkIGFzIGEgY29tcG9uZW50LCBv
ciBhIHZlcnNpb24KKyMgd2l0aCBgYDo6YGAgcmVwbGFjZWQgYnkgYGBfYGAuCisKKyMgQ29weXJp
Z2h0IDIwMTUgQWxleCBNZXJyeSA8YWxleC5tZXJyeUBrZGUub3JnPgorIworIyBSZWRpc3RyaWJ1
dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK
KyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu
ZyBjb25kaXRpb25zCisjIGFyZSBtZXQ6CisjIDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2Ug
Y29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgIG5vdGljZSwgdGhpcyBs
aXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgMi4gUmVk
aXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5
cmlnaHQKKyMgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv
d2luZyBkaXNjbGFpbWVyIGluIHRoZQorIyAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBt
YXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIyAzLiBOZWl0aGVyIHRo
ZSBuYW1lIG9mIHRoZSBVbml2ZXJzaXR5IG5vciB0aGUgbmFtZXMgb2YgaXRzIGNvbnRyaWJ1dG9y
cworIyAgICBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZl
ZCBmcm9tIHRoaXMgc29mdHdhcmUKKyMgICAgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVu
IHBlcm1pc3Npb24uCisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIFJFR0VO
VFMgQU5EIENPTlRSSUJVVE9SUyBgYEFTIElTJycgQU5ECisjIEFOWSBFWFBSRVNTIE9SIElNUExJ
RUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQorIyBJTVBM
SUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJ
Q1VMQVIgUFVSUE9TRQorIyBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBS
RUdFTlRTIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUKKyMgRk9SIEFOWSBESVJFQ1QsIElORElS
RUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwKKyMg
REFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNV
QlNUSVRVVEUgR09PRFMKKyMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9G
SVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pCisjIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB
TlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUCisjIExJ
QUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklT
SU5HIElOIEFOWSBXQVkKKyMgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJ
RiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRgorIyBTVUNIIERBTUFHRS4KKworaWYgKE5P
VCBQRVJMX0VYRUNVVEFCTEUpCisgICAgZmluZF9wYWNrYWdlKFBlcmwpCitlbmRpZiAoKQorCitp
bmNsdWRlKEZpbmRQYWNrYWdlSGFuZGxlU3RhbmRhcmRBcmdzKQorCitpZiAoUEVSTF9FWEVDVVRB
QkxFKQorICAgIHNldChQZXJsTW9kdWxlc19hbGxfbW9kdWxlc19mb3VuZCBUUlVFKQorICAgIGZv
cmVhY2ggKF9jb21wICR7UGVybE1vZHVsZXNfRklORF9DT01QT05FTlRTfSkKKyAgICAgICAgZXhl
Y3V0ZV9wcm9jZXNzKAorICAgICAgICAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gLWUg
InVzZSAke19jb21wfSIKKyAgICAgICAgICAgIFJFU1VMVF9WQVJJQUJMRSBfcmVzdWx0CisgICAg
ICAgICAgICBPVVRQVVRfUVVJRVQKKyAgICAgICAgICAgIEVSUk9SX1FVSUVUCisgICAgICAgICkK
KyAgICAgICAgc3RyaW5nKFJFUExBQ0UgIjo6IiAiXyIgX2NvbXBfc2FuaXRpc2VkICIke19jb21w
fSIpCisgICAgICAgIGlmIChfcmVzdWx0IEVRVUFMIDApCisgICAgICAgICAgICBzZXQoUGVybE1v
ZHVsZXNfJHtfY29tcF9zYW5pdGlzZWR9X0ZPVU5EIFRSVUUpCisgICAgICAgIGVsc2UgKCkKKyAg
ICAgICAgICAgIHNldChQZXJsTW9kdWxlc18ke19jb21wX3Nhbml0aXNlZH1fRk9VTkQgRkFMU0Up
CisgICAgICAgICAgICBzZXQoUGVybE1vZHVsZXNfYWxsX21vZHVsZXNfZm91bmQgRkFMU0UpCisg
ICAgICAgIGVuZGlmICgpCisgICAgICAgIGZpbmRfcGFja2FnZV9oYW5kbGVfc3RhbmRhcmRfYXJn
cyhQZXJsTW9kdWxlc18ke19jb21wfQorICAgICAgICAgICAgRk9VTkRfVkFSCisgICAgICAgICAg
ICAgICAgUGVybE1vZHVsZXNfJHtfY29tcH1fRk9VTkQKKyAgICAgICAgICAgIFJFUVVJUkVEX1ZB
UlMKKyAgICAgICAgICAgICAgICBQZXJsTW9kdWxlc18ke19jb21wX3Nhbml0aXNlZH1fRk9VTkQK
KyAgICAgICAgICAgICkKKyAgICBlbmRmb3JlYWNoICgpCitlbmRpZiAoKQorCitmaW5kX3BhY2th
Z2VfaGFuZGxlX3N0YW5kYXJkX2FyZ3MoUGVybE1vZHVsZXMKKyAgICBGT1VORF9WQVIKKyAgICAg
ICAgUGVybE1vZHVsZXNfRk9VTkQKKyAgICBSRVFVSVJFRF9WQVJTCisgICAgICAgIFBlcmxNb2R1
bGVzX2FsbF9tb2R1bGVzX2ZvdW5kCisgICAgSEFORExFX0NPTVBPTkVOVFMKKykKKworaW5jbHVk
ZShGZWF0dXJlU3VtbWFyeSkKK3NldF9wYWNrYWdlX3Byb3BlcnRpZXMoUGVybE1vZHVsZXMgUFJP
UEVSVElFUworICAgIFVSTCAiaHR0cDovL3d3dy5jcGFuLm9yZyIKKykKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tbW9u
LmNtYWtlCmluZGV4IDFhZmJlNmY0NzBkYmQwY2IwZDlhNjUxOGRmMzcyMzMxNTRkOGZiMWUuLmU3
NjQ0NDFlNDkzMGE5MWI1MjE4MzUxYzY4ZjgxZGRjOWQ0YzEyYWIgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1v
bi5jbWFrZQpAQCAtMTgsNiArMTgsNyBAQCBpZiAoTk9UIEhBU19SVU5fV0VCS0lUX0NPTU1PTikK
IAogICAgICMgVE9ETyBFbmZvcmNlIHZlcnNpb24gcmVxdWlyZW1lbnQgZm9yIHBlcmwKICAgICBm
aW5kX3BhY2thZ2UoUGVybCA1LjEwLjAgUkVRVUlSRUQpCisgICAgZmluZF9wYWNrYWdlKFBlcmxN
b2R1bGVzIENPTVBPTkVOVFMgSlNPTjo6UFAgUkVRVUlSRUQpCiAKICAgICBmaW5kX3BhY2thZ2Uo
UHl0aG9uSW50ZXJwIDIuNy4wIFJFUVVJUkVEKQogICAgIGlmIChQWVRIT05fVkVSU0lPTl9NQUpP
UiBHUkVBVEVSIDIpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjM0
OTMzZjczOGJiYjE3Mjk2OWI4NjYwMWU2NzI4YWVjNDA0ZWVjMC4uOWRjYjcxMzI1NDAyN2EwNjYz
MGNkZjc2YzQ4MDNkNzliZDNlMTlmMCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n
ZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTEyLTA3ICBUb21hcyBQb3BlbGEgIDx0cG9wZWxh
QHJlZGhhdC5jb20+CisKKyAgICAgICAgQnVpbGQgc2hvdWxkIGZhaWwgZWFybHkgaXMgbmVlZGVk
IFBlcmwgbW9kdWxlcyBhcmUgbm90IGluc3RhbGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWlj
aGFlbCBDYXRhbnphcm8uCisKKyAgICAgICAgRG9uJ3QgZmluaXNoIHRoZSBjb25maWd1cmUgc3Vj
Y2Vzc2Z1bGx5IGlmIHRoZSByZXF1aXJlZCBQZXJsIG1vZHVsZXMKKyAgICAgICAgYXJlIG5vdCBp
bnN0YWxsZWQuIFN0YXJ0IHRvIHJlcXVpcmUgbW9kdWxlcyB0aGF0IGFyZSBuZWVkZWQgZm9yCisg
ICAgICAgIFdQRS9HVEsrIHBvcnRzLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRQZXJs
TW9kdWxlcy5jbWFrZTogQ29waWVkIGZyb20KKyAgICAgICAgaHR0cHM6Ly9naXRodWIuY29tL0tE
RS9rZGVsaWJzNHN1cHBvcnQvYmxvYi9tYXN0ZXIvY21ha2UvRmluZFBlcmxNb2R1bGVzLmNtYWtl
CisgICAgICAgIGFuZCBtYWRlIGl0IFdlYktpdCBzdHlsZSBjb21wbGlhbnQuCisgICAgICAgICog
U291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZToKKwogMjAxNy0xMi0wNSAgU3RlcGhhbiBT
emFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CiAKICAgICAgICAgU3dpdGNoIHdpbmRvd3Mg
YnVpbGQgdG8gVmlzdWFsIFN0dWRpbyAyMDE3Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>