180124 2017-11-28 20:15:39 -0800 Web Inspector: Console Tab navigation bar sometimes does not include filter bar, clear console sometimes does not work 2017-11-29 11:07:46 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1375676 0 joepeck 2017-11-28 20:15:39 -0800 Console Tab navigation bar sometimes does not include filter bar Steps to Reproduce: 1. Inspect this page 2. Show Debugger tab 3. Show Split Console drawer 4. Show Console tab => Console doesn't have filter bar, but it should Notes: - There are navigation items that only toggle when in the console tab, but those are sometimes not showing because "isShowingSplitConsole" is still true. 1375678 1 327822 joepeck 2017-11-28 20:19:32 -0800 Created attachment 327822 [PATCH] Proposed Fix 1375679 2 327822 mattbaker 2017-11-28 20:24:16 -0800 Comment on attachment 327822 [PATCH] Proposed Fix Nice fix, r=me 1375680 3 327822 joepeck 2017-11-28 20:28:33 -0800 Comment on attachment 327822 [PATCH] Proposed Fix There are actually a host of issues here. While this is correct I'm going to expand on it all in one patch. 1375681 4 webkit-bug-importer 2017-11-28 20:36:47 -0800 <rdar://problem/35740353> 1375682 5 327823 joepeck 2017-11-28 20:37:38 -0800 Created attachment 327823 [PATCH] Proposed Fix 1375875 6 327823 bburg 2017-11-29 09:41:51 -0800 Comment on attachment 327823 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=327823&action=review r=me > Source/WebInspectorUI/ChangeLog:21 > + It is also now possible, to share a ContentView across ContentBrowsers via Nit: -, 1375924 7 joepeck 2017-11-29 11:07:46 -0800 <https://trac.webkit.org/r225280> 327822 2017-11-28 20:19:32 -0800 2017-11-28 20:28:33 -0800 [PATCH] Proposed Fix console-nav-bar-1.patch text/plain 1533 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDgwZDM0YWE0ZTFiLi4wOGY1MzUwMTBlZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMTEtMjggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBDb25zb2xlIFRhYiBuYXZpZ2F0aW9uIGJhciBzb21ldGltZXMgZG9lcyBub3QgaW5jbHVkZSBm aWx0ZXIgYmFyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODAxMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZVRhYkNvbnRlbnRWaWV3LmpzOgorICAgICAg ICAoV0kuQ29uc29sZVRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5zaG93bik6CisgICAgICAgIFdo ZW4gc2hvd2luZyB0aGUgQ29uc29sZVRhYiBpbW1lZGlhdGVseSBjb2xsYXBzZSB0aGUgc3BsaXQg Y29uc29sZSBzbyB0aGF0IGFueQorICAgICAgICBmb2xsb3dpbmcgY29kZSB0aGF0IGNoZWNrcyBX SS5pc1Nob3dpbmdTcGxpdENvbnNvbGUgd2lsbCBnZXQgdGhlIGV4cGVjdGVkIHZhbHVlLgorCiAy MDE3LTExLTI4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIE5ldHdvcmsgIkNsZWFyIG9uIGxvYWQiIGZyb20gU2V0 dGluZ3MgdGFiIG5vdyB0aGF0IE5ldHdvcmsgdGFiIGhhcyBhIHRvZ2dsZSBmb3IgaXQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVU YWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NvbnNvbGVUYWJDb250ZW50Vmlldy5qcwppbmRleCA4M2QzM2I2Yjk5OC4uZmRhY2U1ZDMx YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0NvbnNvbGVUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9Db25zb2xlVGFiQ29udGVudFZpZXcuanMKQEAgLTUyLDYgKzUyLDgg QEAgV0kuQ29uc29sZVRhYkNvbnRlbnRWaWV3ID0gY2xhc3MgQ29uc29sZVRhYkNvbnRlbnRWaWV3 IGV4dGVuZHMgV0kuQ29udGVudEJyb3dzZXIKICAgICB7CiAgICAgICAgIHN1cGVyLnNob3duKCk7 CiAKKyAgICAgICAgV0kuaGlkZVNwbGl0Q29uc29sZSgpOworCiAgICAgICAgIFdJLmNvbnNvbGVD b250ZW50Vmlldy5wcm9tcHQuZm9jdXMoKTsKIAogICAgICAgICBpZiAodGhpcy5jb250ZW50QnJv d3Nlci5jdXJyZW50Q29udGVudFZpZXcgPT09IFdJLmNvbnNvbGVDb250ZW50VmlldykK 327823 2017-11-28 20:37:38 -0800 2017-11-29 11:04:33 -0800 [PATCH] Proposed Fix console-nav-1.patch text/plain 4534 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDgwZDM0YWE0ZTFiLi5jOGRiNjBhNTBiZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTctMTEtMjggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBDb25zb2xlIFRhYiBuYXZpZ2F0aW9uIGJhciBzb21ldGltZXMgZG9lcyBub3QgaW5jbHVkZSBm aWx0ZXIgYmFyLCBjbGVhciBjb25zb2xlIHNvbWV0aW1lcyBkb2VzIG5vdCB3b3JrCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAxMjQKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM1NzQwMzUzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5q czoKKyAgICAgICAgKFdJLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5jbG9zZWQpOgorICAgICAg ICBBdm9pZCByZW1vdmluZyBldmVudCBsaXN0ZW5lcnMgaWYgdGhpcyBMb2dDb250ZW50VmlldyBz aW5nbGV0b24gaXMgZXZlciBjbG9zZWQuCisgICAgICAgIFRoZSBzaW5nbGV0b24gd2lsbCBhbHdh eXMgYmUgYWxpdmUgc28gd2UgZG9uJ3Qgd2FudCB0byByZW1vdmUgdGhlIGV2ZW50IGxpc3RlbmVy cworICAgICAgICB3aXRob3V0IGEgd2F5IHRvIGFkZCB0aGVtIGJhY2suCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAgKFdJLnNob3dTcGxpdENvbnNvbGUp OgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZVRhYkNvbnRlbnRWaWV3Lmpz OgorICAgICAgICAoV0kuQ29uc29sZVRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5zaG93bik6Cisg ICAgICAgIFdoZW4gc2hvd2luZyB0aGUgQ29uc29sZVRhYiBpbW1lZGlhdGVseSBjb2xsYXBzZSB0 aGUgc3BsaXQgY29uc29sZSBzbyB0aGF0IGFueQorICAgICAgICBmb2xsb3dpbmcgY29kZSB0aGF0 IGNoZWNrcyBXSS5pc1Nob3dpbmdTcGxpdENvbnNvbGUgd2lsbCBnZXQgdGhlIGV4cGVjdGVkIHZh bHVlLgorICAgICAgICBJdCBpcyBhbHNvIG5vdyBwb3NzaWJsZSwgdG8gc2hhcmUgYSBDb250ZW50 VmlldyBhY3Jvc3MgQ29udGVudEJyb3dzZXJzIHZpYQorICAgICAgICB0b21ic3RvbmVzLCBzbyBy ZW1vdmUgdGhlIG9sZCBjb2RlIHRoYXQgd291bGQgZnJlcXVlbnRseSBjbG9zZSB0aGUgTG9nQ29u dGVudFZpZXcuCisKIDIwMTctMTEtMjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgTmV0d29yayAiQ2xlYXIgb24g bG9hZCIgZnJvbSBTZXR0aW5ncyB0YWIgbm93IHRoYXQgTmV0d29yayB0YWIgaGFzIGEgdG9nZ2xl IGZvciBpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9N YWluLmpzCmluZGV4IDI1ODMwOWFkMDVjLi4yYzAxM2UzZTJmZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtODg2LDEwICs4ODYs NiBAQCBXSS5zaG93U3BsaXRDb25zb2xlID0gZnVuY3Rpb24oKQogICAgIGlmICh0aGlzLmNvbnNv bGVEcmF3ZXIuY3VycmVudENvbnRlbnRWaWV3ID09PSB0aGlzLmNvbnNvbGVDb250ZW50VmlldykK ICAgICAgICAgcmV0dXJuOwogCi0gICAgLy8gQmUgc3VyZSB0byBjbG9zZSB0aGUgdmlldyBpbiB0 aGUgdGFiIGNvbnRlbnQgYnJvd3NlciBiZWZvcmUgc2hvd2luZyBpdCBpbiB0aGUKLSAgICAvLyBz cGxpdCBjb250ZW50IGJyb3dzZXIuIFdlIGNhbiBvbmx5IHNob3cgYSBjb250ZW50IHZpZXcgaW4g b25lIGJyb3dzZXIgYXQgYSB0aW1lLgotICAgIGlmICh0aGlzLmNvbnNvbGVDb250ZW50Vmlldy5w YXJlbnRDb250YWluZXIpCi0gICAgICAgIHRoaXMuY29uc29sZUNvbnRlbnRWaWV3LnBhcmVudENv bnRhaW5lci5jbG9zZUNvbnRlbnRWaWV3KHRoaXMuY29uc29sZUNvbnRlbnRWaWV3KTsKICAgICB0 aGlzLmNvbnNvbGVEcmF3ZXIuc2hvd0NvbnRlbnRWaWV3KHRoaXMuY29uc29sZUNvbnRlbnRWaWV3 KTsKIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NvbnNvbGVUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVUYWJDb250ZW50Vmlldy5qcwppbmRleCA4M2QzM2I2 Yjk5OC4uYzg1OTRkOGM3NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlVGFiQ29udGVudFZpZXcuanMK QEAgLTUyLDE3ICs1MiwxMiBAQCBXSS5Db25zb2xlVGFiQ29udGVudFZpZXcgPSBjbGFzcyBDb25z b2xlVGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50QnJvd3NlcgogICAgIHsKICAgICAg ICAgc3VwZXIuc2hvd24oKTsKIAotICAgICAgICBXSS5jb25zb2xlQ29udGVudFZpZXcucHJvbXB0 LmZvY3VzKCk7Ci0KLSAgICAgICAgaWYgKHRoaXMuY29udGVudEJyb3dzZXIuY3VycmVudENvbnRl bnRWaWV3ID09PSBXSS5jb25zb2xlQ29udGVudFZpZXcpCi0gICAgICAgICAgICByZXR1cm47Ci0K LSAgICAgICAgLy8gQmUgc3VyZSB0byBjbG9zZSB0aGUgdmlldyBpbiB0aGUgc3BsaXQgY29udGVu dCBicm93c2VyIGJlZm9yZSBzaG93aW5nIGl0IGluIHRoZQotICAgICAgICAvLyB0YWIgY29udGVu dCBicm93c2VyLiBXZSBjYW4gb25seSBzaG93IGEgY29udGVudCB2aWV3IGluIG9uZSBicm93c2Vy IGF0IGEgdGltZS4KLSAgICAgICAgaWYgKFdJLmNvbnNvbGVDb250ZW50Vmlldy5wYXJlbnRDb250 YWluZXIpCi0gICAgICAgICAgICBXSS5jb25zb2xlQ29udGVudFZpZXcucGFyZW50Q29udGFpbmVy LmNsb3NlQ29udGVudFZpZXcoV0kuY29uc29sZUNvbnRlbnRWaWV3KTsKKyAgICAgICAgV0kuaGlk ZVNwbGl0Q29uc29sZSgpOwogCiAgICAgICAgIHRoaXMuY29udGVudEJyb3dzZXIuc2hvd0NvbnRl bnRWaWV3KFdJLmNvbnNvbGVDb250ZW50Vmlldyk7CisgICAgICAgIFdJLmNvbnNvbGVDb250ZW50 Vmlldy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV0kuQ29udGVudFZpZXcuRXZlbnQuTmF2aWdh dGlvbkl0ZW1zRGlkQ2hhbmdlKTsKKworICAgICAgICBXSS5jb25zb2xlQ29udGVudFZpZXcucHJv bXB0LmZvY3VzKCk7CiAKICAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5jb250ZW50QnJvd3Nl ci5jdXJyZW50Q29udGVudFZpZXcgPT09IFdJLmNvbnNvbGVDb250ZW50Vmlldyk7CiAgICAgfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9n Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Mb2dDb250ZW50Vmlldy5qcwppbmRleCBkYTI2MDNjNjIwYi4uY2FkMWFjMDY1ZGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRl bnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0xvZ0NvbnRlbnRWaWV3LmpzCkBAIC0xNjIsOCArMTYyLDEwIEBAIFdJLkxvZ0NvbnRlbnRWaWV3 ID0gY2xhc3MgTG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogCiAgICAgY2xv c2VkKCkKICAgICB7Ci0gICAgICAgIFdJLmxvZ01hbmFnZXIucmVtb3ZlRXZlbnRMaXN0ZW5lcihu dWxsLCBudWxsLCB0aGlzKTsKLSAgICAgICAgV0kuRnJhbWUucmVtb3ZlRXZlbnRMaXN0ZW5lcihu dWxsLCBudWxsLCB0aGlzKTsKKyAgICAgICAgLy8gV2hpbGUgaXQgbWF5IGJlIHBvc3NpYmxlIHRv IGdldCBoZXJlLCB0aGlzIGlzIGEgc2luZ2xldG9uIENvbnRlbnRWaWV3IGluc3RhbmNlCisgICAg ICAgIC8vIHRoYXQgaXMgb2Z0ZW4gcmUtaW5zZXJ0ZWQgYmFjayBpbnRvIGRpZmZlcmVudCBDb250 ZW50QnJvd3NlcnMsIHNvIHdlIHNob3VsZG4ndAorICAgICAgICAvLyByZW1vdmUgdGhlIGV2ZW50 IGxpc3RlbmVycy4gVGhlIHNpbmdsZXRvbiB3aWxsIG5ldmVyIGdvIGF3YXkgYW55d2F5cy4KKyAg ICAgICAgY29uc29sZS5hc3NlcnQodGhpcyA9PT0gV0kuY29uc29sZUNvbnRlbnRWaWV3KTsKIAog ICAgICAgICBzdXBlci5jbG9zZWQoKTsKICAgICB9Cg==