180120 2017-11-28 17:37:41 -0800 REGRESSION(r218064): [GTK] Broke entering fullscreen mode in debug builds 2017-11-29 09:07:03 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro oldest_to_newest 1375621 0 mcatanzaro 2017-11-28 17:37:41 -0800 r218064 added a bad assert when entering fullscreen mode. It just crashes now (in debug builds). 1375623 1 327809 mcatanzaro 2017-11-28 17:40:07 -0800 Created attachment 327809 Patch 1375624 2 ews-watchlist 2017-11-28 17:41:31 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1375631 3 327811 mcatanzaro 2017-11-28 17:50:40 -0800 Created attachment 327811 Patch 1375728 4 327811 cgarcia 2017-11-28 23:04:10 -0800 Comment on attachment 327811 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327811&action=review > Source/WebKit/ChangeLog:8 > + Remove the bad assertions. Why not fix them instead? > Source/WebKit/ChangeLog:10 > + This should hopefully fix /webkit2/WebKitWebView/fullscreen in debug mode. Hopefully? Could you check it before submitting a new patch? > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:-1308 > - ASSERT(priv->fullScreenModeActive); > - This is only called by the page client when not in fullscreen mode, the intention of the assert was to ensure that was always the case, but for some reason I added the assert checking the opposite. So, the actual fix is changing this assert to ASSERT(!priv->fullScreenModeActive); > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:-1326 > - ASSERT(!priv->fullScreenModeActive); > - Same here, we want to ensure we leave fullscreen while we are in fullscreen so the right assert is: ASSERT(priv->fullScreenModeActive); 1375815 5 mcatanzaro 2017-11-29 08:13:42 -0800 OK, I'll swap the assertions. That works. > > Source/WebKit/ChangeLog:10 > > + This should hopefully fix /webkit2/WebKitWebView/fullscreen in debug mode. > > Hopefully? Could you check it before submitting a new patch? I thought I would need a rebuild to run API tests, but I actually don't. It works. 1375817 6 327853 mcatanzaro 2017-11-29 08:14:59 -0800 Created attachment 327853 Patch 1375844 7 commit-queue 2017-11-29 09:06:35 -0800 The commit-queue encountered the following flaky tests while processing attachment 327853: editing/spelling/spellcheck-async.html bug 160571 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) The commit-queue is continuing to process your patch. 1375846 8 327853 commit-queue 2017-11-29 09:07:01 -0800 Comment on attachment 327853 Patch Clearing flags on attachment: 327853 Committed r225267: <https://trac.webkit.org/changeset/225267> 1375847 9 commit-queue 2017-11-29 09:07:03 -0800 All reviewed patches have been landed. Closing bug. 327809 2017-11-28 17:40:07 -0800 2017-11-28 17:50:38 -0800 Patch bug-180120-20171128194006.patch text/plain 1548 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3YThkMDgxOTdmOTM4MzI3 OGQyZWFiYjZjNjRlNTUxNjBhNWE0ZWQuLmY4MTc2MjhkMWIxYjYwNWVjZWViYzBhY2JiMDBhNzc5 YmZmMDdkOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMTEtMjggIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04o cjIxODA2NCk6IFtHVEtdIEJyb2tlIGVudGVyaW5nIGZ1bGxzY3JlZW4gbW9kZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMTIwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBiYWQgYXNz ZXJ0LgorCisgICAgICAgIFRoaXMgc2hvdWxkIGhvcGVmdWxseSBmaXggL3dlYmtpdDIvV2ViS2l0 V2ViVmlldy9mdWxsc2NyZWVuIGluIGRlYnVnIG1vZGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFz ZUVudGVyRnVsbFNjcmVlbik6CisKIDIwMTctMTEtMjcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBHaXZlIERvY3VtZW50IGEgc3Ryb25nbHkgdHlwZWQgaWRlbnRp ZmllciBpbnN0ZWFkIG9mIGEgdWludDY0X3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKaW5kZXggNDMyZGFjM2MxN2I4MzQ4 NTMzOGZmNjlhZTUwOWRhZDE4MjU3MTFiNi4uMjk5YzQ0YTUyN2NmZDQ5OWMzMjkyYjVlMzMzMjE3 ZDI5N2NmYWY0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTEzMDQsOCArMTMwNCw2IEBAIHZvaWQgd2Via2l0 V2ViVmlld0Jhc2VFbnRlckZ1bGxTY3JlZW4oV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZp ZXdCYXNlKQogewogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICBXZWJLaXRXZWJWaWV3 QmFzZVByaXZhdGUqIHByaXYgPSB3ZWJraXRXZWJWaWV3QmFzZS0+cHJpdjsKLSAgICBBU1NFUlQo cHJpdi0+ZnVsbFNjcmVlbk1vZGVBY3RpdmUpOwotCiAgICAgV2ViRnVsbFNjcmVlbk1hbmFnZXJQ cm94eSogZnVsbFNjcmVlbk1hbmFnZXJQcm94eSA9IHByaXYtPnBhZ2VQcm94eS0+ZnVsbFNjcmVl bk1hbmFnZXIoKTsKICAgICBmdWxsU2NyZWVuTWFuYWdlclByb3h5LT53aWxsRW50ZXJGdWxsU2Ny ZWVuKCk7CiAK 327811 2017-11-28 17:50:40 -0800 2017-11-29 08:14:57 -0800 Patch bug-180120-20171128195039.patch text/plain 2002 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRmMzBmMjQ0YTlmZDllNTcz NjEzYTc1ZWUwZDJjYjI1ZDQxNTBjNmQuLjcxZmU5YTg3ZmY3OTVjYjQ5OWNhMjU4YTYxZDg2YzA3 NDRmMTNmZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMTEtMjggIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04o cjIxODA2NCk6IFtHVEtdIEJyb2tlIGVudGVyaW5nIGZ1bGxzY3JlZW4gbW9kZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMTIwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBiYWQgYXNz ZXJ0aW9ucy4KKworICAgICAgICBUaGlzIHNob3VsZCBob3BlZnVsbHkgZml4IC93ZWJraXQyL1dl YktpdFdlYlZpZXcvZnVsbHNjcmVlbiBpbiBkZWJ1ZyBtb2RlLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2ViVmll d0Jhc2VFbnRlckZ1bGxTY3JlZW4pOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VFeGl0RnVs bFNjcmVlbik6CisKIDIwMTctMTEtMjggIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdh QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ0ddIFBvc3RTY3JpcHQgaW1hZ2VzIHNob3VsZCBiZSBz dXBwb3J0ZWQgaWYgdGhleSBhcmUgc3ViLXJlc291cmNlIGltYWdlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCA0 MzJkYWMzYzE3YjgzNDg1MzM4ZmY2OWFlNTA5ZGFkMTgyNTcxMWI2Li5kNDFkOTFmYzFmMjY0YzIx YWEzZWUwZDRkZDlmYWIyZTBiOTgzY2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMTMwNCw4ICsxMzA0LDYg QEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUVudGVyRnVsbFNjcmVlbihXZWJLaXRXZWJWaWV3QmFz ZSogd2Via2l0V2ViVmlld0Jhc2UpCiB7CiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogICAg IFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZSogcHJpdiA9IHdlYmtpdFdlYlZpZXdCYXNlLT5wcml2 OwotICAgIEFTU0VSVChwcml2LT5mdWxsU2NyZWVuTW9kZUFjdGl2ZSk7Ci0KICAgICBXZWJGdWxs U2NyZWVuTWFuYWdlclByb3h5KiBmdWxsU2NyZWVuTWFuYWdlclByb3h5ID0gcHJpdi0+cGFnZVBy b3h5LT5mdWxsU2NyZWVuTWFuYWdlcigpOwogICAgIGZ1bGxTY3JlZW5NYW5hZ2VyUHJveHktPndp bGxFbnRlckZ1bGxTY3JlZW4oKTsKIApAQCAtMTMyMiw4ICsxMzIwLDYgQEAgdm9pZCB3ZWJraXRX ZWJWaWV3QmFzZUV4aXRGdWxsU2NyZWVuKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWV3 QmFzZSkKIHsKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCiAgICAgV2ViS2l0V2ViVmlld0Jh c2VQcml2YXRlKiBwcml2ID0gd2Via2l0V2ViVmlld0Jhc2UtPnByaXY7Ci0gICAgQVNTRVJUKCFw cml2LT5mdWxsU2NyZWVuTW9kZUFjdGl2ZSk7Ci0KICAgICBXZWJGdWxsU2NyZWVuTWFuYWdlclBy b3h5KiBmdWxsU2NyZWVuTWFuYWdlclByb3h5ID0gcHJpdi0+cGFnZVByb3h5LT5mdWxsU2NyZWVu TWFuYWdlcigpOwogICAgIGZ1bGxTY3JlZW5NYW5hZ2VyUHJveHktPndpbGxFeGl0RnVsbFNjcmVl bigpOwogCg== 327853 2017-11-29 08:14:59 -0800 2017-11-29 09:07:01 -0800 Patch bug-180120-20171129101458.patch text/plain 2076 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRmMzBmMjQ0YTlmZDllNTcz NjEzYTc1ZWUwZDJjYjI1ZDQxNTBjNmQuLmVlMmQ0NzdkZWIxYjNkZDdhNTg2YjA0YzQ4Y2I3NTBj MGQ1MmVlMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMTEtMjkgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04o cjIxODA2NCk6IFtHVEtdIEJyb2tlIGVudGVyaW5nIGZ1bGxzY3JlZW4gbW9kZSBpbiBkZWJ1ZyBi dWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 MDEyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZXNlIGFzc2VydGlvbnMgbmVlZCB0byBiZSBzd2FwcGVkLiBGaXhlcyAvd2Via2l0Mi9XZWJLaXRX ZWJWaWV3L2Z1bGxzY3JlZW4gaW4gZGVidWcgbW9kZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNl RW50ZXJGdWxsU2NyZWVuKToKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlRXhpdEZ1bGxTY3Jl ZW4pOgorCiAyMDE3LTExLTI4ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBs ZS5jb20+CiAKICAgICAgICAgW0NHXSBQb3N0U2NyaXB0IGltYWdlcyBzaG91bGQgYmUgc3VwcG9y dGVkIGlmIHRoZXkgYXJlIHN1Yi1yZXNvdXJjZSBpbWFnZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKaW5kZXggNDMyZGFj M2MxN2I4MzQ4NTMzOGZmNjlhZTUwOWRhZDE4MjU3MTFiNi4uZDI3YWI0MDEzMGE5NWM1ODhjZmQ2 ZjUxYzIxOWViODFmYjczZmRiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTEzMDQsNyArMTMwNCw3IEBAIHZv aWQgd2Via2l0V2ViVmlld0Jhc2VFbnRlckZ1bGxTY3JlZW4oV2ViS2l0V2ViVmlld0Jhc2UqIHdl YmtpdFdlYlZpZXdCYXNlKQogewogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICBXZWJL aXRXZWJWaWV3QmFzZVByaXZhdGUqIHByaXYgPSB3ZWJraXRXZWJWaWV3QmFzZS0+cHJpdjsKLSAg ICBBU1NFUlQocHJpdi0+ZnVsbFNjcmVlbk1vZGVBY3RpdmUpOworICAgIEFTU0VSVCghcHJpdi0+ ZnVsbFNjcmVlbk1vZGVBY3RpdmUpOwogCiAgICAgV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eSog ZnVsbFNjcmVlbk1hbmFnZXJQcm94eSA9IHByaXYtPnBhZ2VQcm94eS0+ZnVsbFNjcmVlbk1hbmFn ZXIoKTsKICAgICBmdWxsU2NyZWVuTWFuYWdlclByb3h5LT53aWxsRW50ZXJGdWxsU2NyZWVuKCk7 CkBAIC0xMzIyLDcgKzEzMjIsNyBAQCB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlRXhpdEZ1bGxTY3Jl ZW4oV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlKQogewogI2lmIEVOQUJMRShG VUxMU0NSRUVOX0FQSSkKICAgICBXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUqIHByaXYgPSB3ZWJr aXRXZWJWaWV3QmFzZS0+cHJpdjsKLSAgICBBU1NFUlQoIXByaXYtPmZ1bGxTY3JlZW5Nb2RlQWN0 aXZlKTsKKyAgICBBU1NFUlQocHJpdi0+ZnVsbFNjcmVlbk1vZGVBY3RpdmUpOwogCiAgICAgV2Vi RnVsbFNjcmVlbk1hbmFnZXJQcm94eSogZnVsbFNjcmVlbk1hbmFnZXJQcm94eSA9IHByaXYtPnBh Z2VQcm94eS0+ZnVsbFNjcmVlbk1hbmFnZXIoKTsKICAgICBmdWxsU2NyZWVuTWFuYWdlclByb3h5 LT53aWxsRXhpdEZ1bGxTY3JlZW4oKTsK